Re: Review Request 17133: Improve test coverage for TaskAssignerImpl.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17133/#review32369 --- Ship it! Looks good! - Suman Karumuri On Jan. 20, 2014, 10:12 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17133/ --- (Updated Jan. 20, 2014, 10:12 p.m.) Review request for Aurora, Kevin Sweeney and Suman Karumuri. Bugs: AURORA-63 https://issues.apache.org/jira/browse/AURORA-63 Repository: aurora Description --- This brings TaskAssignerImpl to 100% coverage. Diffs - src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 339773d71b9f15e767d9f057b921582c0d8814a5 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17133/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17068: Added docs about git setup.
On Jan. 18, 2014, 12:34 a.m., Jonathan Boulle wrote: docs/contributing.md, lines 7-8 https://reviews.apache.org/r/17068/diff/2/?file=429765#file429765line7 s/setup/set up/ s/configured/configure/ Done. On Jan. 18, 2014, 12:34 a.m., Jonathan Boulle wrote: docs/contributing.md, line 16 https://reviews.apache.org/r/17068/diff/2/?file=429765#file429765line16 s/jira/JIRA/ s/reviewboard/ReviewBoard Done. On Jan. 18, 2014, 12:34 a.m., Jonathan Boulle wrote: docs/contributing.md, line 17 https://reviews.apache.org/r/17068/diff/2/?file=429765#file429765line17 s/emails your/emails from your/ Done. - Suman --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17068/#review32236 --- On Jan. 17, 2014, 11:40 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17068/ --- (Updated Jan. 17, 2014, 11:40 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Added docs about git setup. Diffs - docs/contributing.md d337da2be9b182a0c872574c3587d414c566331b Diff: https://reviews.apache.org/r/17068/diff/ Testing --- Thanks, Suman Karumuri
Re: Review Request 17131: Improve test coverage for CronJobManager.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/#review32376 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java https://reviews.apache.org/r/17131/#comment61173 +1 for inlining it. - Maxim Khutornenko On Jan. 20, 2014, 9:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17131/ --- (Updated Jan. 20, 2014, 9:01 p.m.) Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs: AURORA-62 https://issues.apache.org/jira/browse/AURORA-62 Repository: aurora Description --- This raises instruction test coverage from 76% to 95%, and branch coverage from 75% to 96%. There are only two things not currently covered: - Handling when catching InterruptedException (this only logs) - Handling unknown CollisionPolicy (only logs) Diffs - src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java 5a56a701a6a355f9de3f05fbb95013b96b06b171 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java e9886cdb279cc42a961d6c964e2cfae3c4c13f61 Diff: https://reviews.apache.org/r/17131/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 17068: Added docs about git setup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17068/ --- (Updated Jan. 21, 2014, 4:03 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Added docs about git setup. Diffs (updated) - docs/contributing.md d337da2be9b182a0c872574c3587d414c566331b Diff: https://reviews.apache.org/r/17068/diff/ Testing --- Thanks, Suman Karumuri
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32377 --- ping? - Mark Chu-Carroll On Jan. 17, 2014, 3:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 3:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17153: Implement restart command for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21, 2014, 5:03 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- Updated link to jira. Bugs: aurora-54 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Implement restart command for client v2. Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION Diff: https://reviews.apache.org/r/17153/diff/ Testing --- [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 23 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32430 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17051/#comment61257 line 58 of context.py still raises CommandError ?? - Jonathan Boulle On Jan. 17, 2014, 8:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 8:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/ --- (Updated Jan. 21, 2014, 11:18 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Summary (updated) - Update all dependencies coming from twitter commons and upgrade to guava 15 Repository: aurora Description (updated) --- Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict. Diffs - build.gradle 00cabb00b81b320ef2c474da759281b3fda24967 Diff: https://reviews.apache.org/r/17161/diff/ Testing --- ./gradlew build I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts. Thanks, Bill Farner
Re: Review Request 17042: Add a web interface to the zookeeper instance.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/#review32198 --- examples/vagrant/provision-zookeeper.sh https://reviews.apache.org/r/17042/#comment60913 you can get a few seconds of speedup if you collapse into a single apt-get invocation apt-get -y install zookeeper git python-django python-zookeeper examples/vagrant/provision-zookeeper.sh https://reviews.apache.org/r/17042/#comment60914 Can simplify to pushd ~vagrant sudo -H -u vagrant git clone https://github.com/phunt/zookeeper_dashboard popd - Kevin Sweeney On Jan. 17, 2014, 11:21 a.m., Tobias Weingartner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/ --- (Updated Jan. 17, 2014, 11:21 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Add a web interface to the zookeeper instance. Diffs - examples/vagrant/provision-zookeeper.sh b68e801be6a33d83ff0cbf9ad31f4a4af4d84f84 Diff: https://reviews.apache.org/r/17042/diff/ Testing --- $ vagrant up zookeeper # point web browser at 192.168.33.2:8080 Thanks, Tobias Weingartner
Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/#review32457 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/ --- (Updated Jan. 21, 2014, 11:18 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict. Diffs - build.gradle 00cabb00b81b320ef2c474da759281b3fda24967 Diff: https://reviews.apache.org/r/17161/diff/ Testing --- ./gradlew build I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts. Thanks, Bill Farner
Re: Review Request 17153: Implement restart command for client v2.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/#review32454 --- Mark - want to put some time in my calendar tomorrow to sit down together and go through all the outstanding reviews to get them merged? The patches are in a bit of a confusing state, every time I look at a review it seems like it's reverting something inadvertently :-( src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17153/#comment61315 hm. missing merge? src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17153/#comment61316 s/operate/operated/ - Jonathan Boulle On Jan. 21, 2014, 10:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17153/ --- (Updated Jan. 21, 2014, 10:03 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-54 https://issues.apache.org/jira/browse/aurora-54 Repository: aurora Description --- Implement restart command for client v2. Diffs - src/main/python/apache/aurora/client/cli/context.py 78e54a2233b825ab057a1fb2397c91b50ad1aec0 src/main/python/apache/aurora/client/cli/jobs.py f60d7e9fa5367f43829957e3485e43e76c84bf48 src/main/python/apache/aurora/client/cli/options.py 1b7155409505b46451df072edd196dd7e4c88f1c src/test/python/apache/aurora/client/cli/BUILD f9ebe0cf626a040aa67654faea07b8902e558282 src/test/python/apache/aurora/client/cli/test_restart.py PRE-CREATION src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION Diff: https://reviews.apache.org/r/17153/diff/ Testing --- [sun-wukong aurora (restart)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) == test session starts == platform darwin -- Python 2.7.2 -- pytest-2.5.1 collected 23 items src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_restart.py ... === 23 passed in 1.39 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS [sun-wukong aurora (restart)]$ Thanks, Mark Chu-Carroll
Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15
On Jan. 21, 2014, 11:32 p.m., Kevin Sweeney wrote: Thanks for taking care of this Bill. Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment). Bill Farner wrote: reference it on the first line of your commit I didn't realize this was wired up yet, cool! Do you mean to say that the first line of the summary/description? yes, commits with the first line of AURORA-XXX: description will get picked up by jenkins after running the ci build from a scm change and jenkins will comment back the success of that build on the jira ticket. - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/#review32441 --- On Jan. 21, 2014, 11:18 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17161/ --- (Updated Jan. 21, 2014, 11:18 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- Stale twitter-commons dependencies were preventing us from upgrading to the latest guava. This update cleanly moves us forward without dependency conflict. Diffs - build.gradle 00cabb00b81b320ef2c474da759281b3fda24967 Diff: https://reviews.apache.org/r/17161/diff/ Testing --- ./gradlew build I also inspected the output of ./gradlew dependencies to verify that there are no new dependency conflicts. Thanks, Bill Farner
