Re: Review Request 17877: AURORA-200: set_quota should die if given invalid arguments
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/#review34193
---
src/main/python/apache/aurora/client/commands/admin.py
https://reviews.apache.org/r/17877/#comment64205
Die expects a message string, not an exception object. die('Invalid unit
specification') would end up with a better error message.
- Mark Chu-Carroll
On Feb. 10, 2014, 2:17 p.m., Dan Norris wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17877/
---
(Updated Feb. 10, 2014, 2:17 p.m.)
Review request for Aurora, Jonathan Boulle and Mark Chu-Carroll.
Bugs: AURORA-200
https://issues.apache.org/jira/browse/AURORA-200
Repository: aurora
Description
---
AURORA-200: set_quota should die if given invalid arguments
Diffs
-
src/main/python/apache/aurora/client/commands/admin.py
45686aec8d69f0dfa1d649a92a19ca87bd315823
Diff: https://reviews.apache.org/r/17877/diff/
Testing
---
./gradlew clean build ./pants src/test/python:all -vxs along with manual
testing w/ bad arguments.
Thanks,
Dan Norris
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34207 --- Looks good to me... but needs other people's eyes as well. src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17752/#comment64223 What happens to non-running instances? src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17752/#comment64224 Random thought: Is this even used? Other than possibly root, what is the use-case for this? - Tobias Weingartner On Feb. 7, 2014, 8:44 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 7, 2014, 8:44 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs - src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34215 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2014, 10:58 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- (Updated Feb. 11, 2014, 10:58 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- (Updated Feb. 11, 2014, 7:40 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- CR comments. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.
On Feb. 11, 2014, 7:27 p.m., Bill Farner wrote: I don't see a test case that reproduces the bug. Can you add that as confirmation that schedulerActive now succeeds? Added. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34218 --- On Feb. 11, 2014, 6:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/ --- (Updated Feb. 11, 2014, 6:58 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-210 https://issues.apache.org/jira/browse/AURORA-210 Repository: aurora Description --- Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 388926c2c51c381b91ab2dcf7e4af7993d19d111 src/main/java/org/apache/aurora/scheduler/state/CronJobManager.java b5d97af7454e7c4fe4b7428e2adf2c7b9ca0c1dc src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java 24e1bc49a446bab9ec9a8aff62438cbde89e6569 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 0b565abc2187deeba466a63162de80b5e2bb5d47 Diff: https://reviews.apache.org/r/17955/diff/ Testing --- gradle clean build Thanks, Maxim Khutornenko
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34239 --- src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17752/#comment64264 bad merge? this still references context instead of instance_str - Jonathan Boulle On Feb. 7, 2014, 8:44 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 7, 2014, 8:44 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs - src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17752: Add task noun, supporting run and ssh verbs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 11, 2014, 9:16 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Changes --- fix glitched merge. Bugs: aurora-124 https://issues.apache.org/jira/browse/aurora-124 Repository: aurora Description --- Add task noun, supporting run and ssh verbs. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD f5c9ae75d7a26883d90b9bd8ac9c80cd436d03a1 src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/task.py PRE-CREATION src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_task_run.py PRE-CREATION Diff: https://reviews.apache.org/r/17752/diff/ Testing --- [sun-wukong incubator-aurora (tasknoun)]$ ./pants src/test/python/apache/aurora/client/cli:all Build operating on targets: OrderedSet([PythonTestSuite(src/test/python/apache/aurora/client/cli/BUILD:all)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 25 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py . src/test/python/apache/aurora/client/cli/test_restart.py ... src/test/python/apache/aurora/client/cli/test_status.py . src/test/python/apache/aurora/client/cli/test_update.py ... == 25 passed in 1.37 seconds === = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.20 -- pytest-2.5.2 collected 2 items src/test/python/apache/aurora/client/cli/test_task_run.py .. === 2 passed in 0.30 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34259 --- Ship it! lgtm - David Robinson On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 11, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
