Review Request 18523: Remove rogue apostrophes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18523/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Remove rogue apostrophe. Diffs - docs/configurationreference.md 6fb6b201b1748a34f520bd8ebf2365cc6d33328d Diff: https://reviews.apache.org/r/18523/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 18523: Remove rogue apostrophes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18523/#review35537 --- Ship it! Ship It! - Kevin Sweeney On Feb. 26, 2014, 9:43 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18523/ --- (Updated Feb. 26, 2014, 9:43 a.m.) Review request for Aurora and Maxim Khutornenko. Repository: aurora Description --- Remove rogue apostrophe. Diffs - docs/configurationreference.md 6fb6b201b1748a34f520bd8ebf2365cc6d33328d Diff: https://reviews.apache.org/r/18523/diff/ Testing --- Thanks, Bill Farner
Review Request 18526: Add support for slaveHosts set in TaskQuery.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18526/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-232 https://issues.apache.org/jira/browse/AURORA-232 Repository: aurora Description --- The slaveHosts set-based field will eventually replace a string field. All internal queries are converted to use the new field. The old one is still supported for queries coming from the web (until client side is refactored). Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java b9f207c740362fafff0257988f52b6179025d58d src/main/java/org/apache/aurora/scheduler/http/Maintenance.java 7337044bacd052c516e4d78a2993946d472ef91c src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java d1ab503e4edac86afcb8884a074a87b7536de3f7 src/main/thrift/org/apache/aurora/gen/api.thrift cd60f47bf34b4a634004e2ad9eadad37aa1556bb src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 884f589a2cbea918ecbfedf457f42d7cc9254c95 src/test/resources/org/apache/aurora/gen/api.thrift.md5 fafb5100443482e662db453429c5259f2ab80ae5 Diff: https://reviews.apache.org/r/18526/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Maxim Khutornenko
Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review35552 --- Ship it! Ship It! - Kevin Sweeney On Feb. 26, 2014, 11:07 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- (Updated Feb. 26, 2014, 11:07 a.m.) Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review35553 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 26, 2014, 7:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- (Updated Feb. 26, 2014, 7:07 p.m.) Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review3 --- Ship it! Ship It! - Jake Farrell On Feb. 26, 2014, 7:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- (Updated Feb. 26, 2014, 7:07 p.m.) Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review35547 --- Ship it! src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java https://reviews.apache.org/r/18487/#comment66145 How about extracting a private transactionManager field initialized inline? Small price for a big improvement in readability. src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java https://reviews.apache.org/r/18487/#comment66154 Extra space. src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java https://reviews.apache.org/r/18487/#comment66156 Typo. src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java https://reviews.apache.org/r/18487/#comment66155 This seems to be a prevailing pattern: assertWriting() followed by log(). Why not retain the previous approach of asserting inside of a log()? You could still assert earlier when needed with the assertion in log() being a catch-all case. src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java https://reviews.apache.org/r/18487/#comment66157 Mind converting this comment into a message arg? - Maxim Khutornenko On Feb. 26, 2014, 12:12 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/ --- (Updated Feb. 26, 2014, 12:12 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- There are a few nice things falling out of this refactor: - New methods on mutable store interfaces are not implicitly forwarded (ForwardingStore does not implement mutable stores). - Write ahead/behind behavior is more obvious in LogStorage (i found the delegation by calling super tough to catch mistakes.) - Callers with a handle on LogStorage don't have a means to invoke mutate calls outside of a transaction (they only get access to mutable stores in write(), which obviated testMutateRequiresWriteOperation) Diffs - src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 34d39f2e9064b67ca226c13bb7e330f4daa2a2aa src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 1842210c91ee3e153f5d142266bc2696960535af src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java d6624f470eadaf0be658db1d87d5863ea6701d94 Diff: https://reviews.apache.org/r/18487/diff/ Testing --- ./gradlew build Thanks, Bill Farner
Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review35566 --- Ship it! Ship It! - Tom Galloway On Feb. 26, 2014, 7:07 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/ --- (Updated Feb. 26, 2014, 7:07 p.m.) Review request for Aurora, Maxim Khutornenko and Tom Galloway. Repository: aurora Description --- Used this guy to spit out the TOC: http://doctoc.herokuapp.com/ Diffs - docs/configurationreference.md 3c76d594f2564e77912bd07b33a9ae0a6bbf8a11 Diff: https://reviews.apache.org/r/18528/diff/ Testing --- Rendered at https://github.com/wfarner/incubator-aurora/blob/wfarner/doc_cleanup/docs/configurationreference.md Thanks, Bill Farner
Review Request 18537: AURORA-227: Aurora build should check for the Python version
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18537/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-227 https://issues.apache.org/jira/browse/AURORA-227 Repository: aurora Description --- AURORA-227: Aurora build should check for the Python version Diffs - build-support/pex 8a1574c90fc41e8ed609bc93ca8d9be4fdc50b12 build.gradle e5cd831f7e742a7911994c6cbe23122f90aae313 Diff: https://reviews.apache.org/r/18537/diff/ Testing --- Running ./gradlew checkPythonVersion with Python != 2.6 or 2.7 results in: :checkPythonVersion FAILED FAILURE: Build failed with an exception. * Where: Build file '/home/daniel/Projects/incubator-aurora/build.gradle' line: 257 * What went wrong: Execution failed for task ':checkPythonVersion'. Build requires Python 2.6 or Python 2.7 Thanks, Dan Norris
