On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/core.py, line 399
https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
This is deliberate: the kill command doesn't have a force option.
So this ensures that
I think making a reasonable effort to make it harder to accidentally do
this is worthwhile - there's no harm in it, and it might just help.
-Mark
On Thu, Mar 13, 2014 at 10:07 AM, Kevin Sweeney kevi...@apache.org wrote:
This is an automatically generated e-mail. To reply, visit:
What looks odd though is a command that is unusable without the --force
flag. The standard optional semantic of that flag feels violated here.
On Thu, Mar 13, 2014 at 11:10 AM, Maxim Khutornenko ma...@apache.orgwrote:
What looks odd though is a command that is unusable without the --force
But in some sense, this isn't a standard command. This is a dangerous
command, and we want it to be out of the ordinary. We want to be sure that
it's not done accidentally, and making its flag behavior be strange is
arguably good.
-Mark
On Thu, Mar 13, 2014 at 11:14 AM, Maxim Khutornenko
On March 12, 2014, 3:25 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/commands/core.py, line 399
https://reviews.apache.org/r/19159/diff/1/?file=517771#file517771line399
This is deliberate: the kill command doesn't have a force option.
So this ensures that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
---
(Updated March 13, 2014, 3:51 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
---
(Updated March 13, 2014, 4:05 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
---
(Updated March 13, 2014, 7:59 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
---
(Updated March 13, 2014, 8:14 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/
---
(Updated March 13, 2014, 8:14 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37141
---
Ship it!
src/main/python/apache/aurora/client/commands/core.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19159/#review37153
---
Ship it!
Ship It!
- Bill Farner
On March 14, 2014, 12:14 a.m.,
12 matches
Mail list logo