Re: Review Request 19833: Migrated Job page to angular JS

2014-04-01 Thread Suman Karumuri

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19833/
---

(Updated April 1, 2014, 9:57 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Updated the diff to just contain the changes related to replacing the job page. 
Using the --parent option, I have filtered the changes for the role/env page 
and excluded all the 3rd party js libs.


Bugs: AURORA-281
https://issues.apache.org/jira/browse/AURORA-281


Repository: aurora


Description
---

*** Please review Diff 2. Diff 1 is https://reviews.apache.org/r/19565/. Added 
it here so only new code can be reviewed. ***


Migrated job page to AngularJS.
Removed old scheduler job page.
Removed js related to the old scheduler page. Removed data tables.
Added moment.js library for date time manipulation.
Refactored code a bit for reusability.
Stats link should still be added to the new jobs page.

Since the role/env code is not committed, this diff contains that code as well. 
Code changes start from page 4 in diff between version 1 and 2.


Diffs (updated)
-

  build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
eeafc784e915137cacd5f64df1252ccbaf6c0f6c 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
ec56c649116c03ef148bac916bd6691a94685bc3 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
2ccc6f367b9715a0abb3e0673069289ae4860087 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java 
b35aad8db006133ba70692e43db1f083d4950914 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/css/jquery.dataTables.css
 ee6da23c3948a87b0d4df73e82e5c4e2ab2bc803 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_disabled.png
 881de7976ff98955e2a5487dca66e618a0655f3d 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled.png
 c608682b04a6d9b8002602450c8ef7e80ebba099 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled_hover.png
 d300f1064b3beac1d7d5274e294494d3143e53a2 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_disabled.png
 6a6ded7de821619aedc71d1738c0b73463a4452e 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled.png
 a4e6b5384b8454ee7f44a8f7c75b0321b7eeb9b1 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled_hover.png
 fc46c5ebf0524b72a509fe2d7c1bc74995cb8a9d 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc.png
 a88d7975fe9017e4e5f2289a94bd1ed66a5f59dc 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc_disabled.png
 4e144cf0b1f786a9248a2998311e8109998d8a2d 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_both.png
 18670406bc01ab2721781822dd6478917745ff54 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_desc.png
 def071ed5afd264a036f6d9e75856366fd6ad153 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_desc_disabled.png
 7824973cc60fc1841b16f2cb39323cefcdc3f942 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.bootstrap.js
 420e507086f7a2af08f68787f67208546745260d 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.htmlNumberType.js
 885ad347f3076dcf75558ef44806dc25a8171884 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/dataTables.localstorage.js
 3c0b39aefbd5a82adee49f2ac7539b6974576b2f 
  
src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/js/jquery.dataTables.min.js
 02694a4a56eb247baa2398d971927dfbd1ac3e60 
  src/main/resources/org/apache/aurora/scheduler/http/assets/dictionary.js 
92045c41706ee9315f3522c3b5bbff7f6e7d2c64 
  src/main/resources/org/apache/aurora/scheduler/http/assets/util.js 
5dd0d17849c7116d70925275b9c6c0715b441f14 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzjob.st 
28b56671b2e825912a6427e609c2bbe1e7758e26 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html 
PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 
ade850ce624964693e9bd55946464983c4b9f8c2 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 
36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/job.html PRE-CREATION 
  

Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39207
---


Isn't a StorageBackfill what you're after here?  Rewrite tasks in the UNKNOWN 
state to a more appropriate state?

- Bill Farner


On April 1, 2014, 9:52 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19888/
 ---
 
 (Updated April 1, 2014, 9:52 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-261
 https://issues.apache.org/jira/browse/AURORA-261
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
 graceful rollback of that change.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
 003d475a1bd4ecc099d9a641fd239a8189f71cdb 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
 d2becea60e5d7bb59a2e5adb66e10cd50f6b56f3 
   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
 e77063a9c8e40e015ec264b151a7ed76f1c7f00f 
 
 Diff: https://reviews.apache.org/r/19888/diff/
 
 
 Testing
 ---
 
 gradle clean build
 gradle run
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Maxim Khutornenko


 On April 1, 2014, 10:43 p.m., Bill Farner wrote:
  Isn't a StorageBackfill what you're after here?  Rewrite tasks in the 
  UNKNOWN state to a more appropriate state?

The StorageBackfill is a much more invasive approach, which is not really 
required here. Besides, rewriting state would mess up the task events and show 
something like FINISHED - UNKNOWN - FINISHED. Trying to minimize the impact 
here.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39207
---


On April 1, 2014, 9:52 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19888/
 ---
 
 (Updated April 1, 2014, 9:52 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-261
 https://issues.apache.org/jira/browse/AURORA-261
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
 graceful rollback of that change.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
 003d475a1bd4ecc099d9a641fd239a8189f71cdb 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
 d2becea60e5d7bb59a2e5adb66e10cd50f6b56f3 
   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
 e77063a9c8e40e015ec264b151a7ed76f1c7f00f 
 
 Diff: https://reviews.apache.org/r/19888/diff/
 
 
 Testing
 ---
 
 gradle clean build
 gradle run
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 19833: Migrated Job page to angular JS

2014-04-01 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19833/#review39208
---


Looks great overall!  Last request - can you push a branch to origin that 
contains the proposed change?  I'd like to try this out on a local scheduler.


src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
https://reviews.apache.org/r/19833/#comment71570

Can you address this TODO now?  AFAICT there's nothing in the way of that.



src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
https://reviews.apache.org/r/19833/#comment71571

revert



src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html
https://reviews.apache.org/r/19833/#comment71572

Can you put an ng-if on the span and remove the second if?

if environment
  li
  if job
span



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
https://reviews.apache.org/r/19833/#comment71573

Can you wrap these in a more readable way?  e.g.

{label: 'Instances',
 map: 'range',
 isSortable: false,
 formatFunction: function (range) {
 },
}

Ditto in other hashes that span multiple lines.



src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js
https://reviews.apache.org/r/19833/#comment71574

Please be consistent about placing the + for strings that span multiple 
lines.


- Bill Farner


On April 1, 2014, 9:57 p.m., Suman Karumuri wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19833/
 ---
 
 (Updated April 1, 2014, 9:57 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-281
 https://issues.apache.org/jira/browse/AURORA-281
 
 
 Repository: aurora
 
 
 Description
 ---
 
 *** Please review Diff 2. Diff 1 is https://reviews.apache.org/r/19565/. 
 Added it here so only new code can be reviewed. ***
 
 
 Migrated job page to AngularJS.
 Removed old scheduler job page.
 Removed js related to the old scheduler page. Removed data tables.
 Added moment.js library for date time manipulation.
 Refactored code a bit for reusability.
 Stats link should still be added to the new jobs page.
 
 Since the role/env code is not committed, this diff contains that code as 
 well. 
 Code changes start from page 4 in diff between version 1 and 2.
 
 
 Diffs
 -
 
   build.gradle c2a70b0285c6afb20f6db387e50744424c572d3f 
   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
 eeafc784e915137cacd5f64df1252ccbaf6c0f6c 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 ec56c649116c03ef148bac916bd6691a94685bc3 
   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 
 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
   src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java 
 2ccc6f367b9715a0abb3e0673069289ae4860087 
   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java 
 e3ff2571d95effcf72b2047cc5840d56143a180c 
   src/main/java/org/apache/aurora/scheduler/http/UIRedirectFilter.java 
 b35aad8db006133ba70692e43db1f083d4950914 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/css/jquery.dataTables.css
  ee6da23c3948a87b0d4df73e82e5c4e2ab2bc803 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_disabled.png
  881de7976ff98955e2a5487dca66e618a0655f3d 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled.png
  c608682b04a6d9b8002602450c8ef7e80ebba099 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/back_enabled_hover.png
  d300f1064b3beac1d7d5274e294494d3143e53a2 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_disabled.png
  6a6ded7de821619aedc71d1738c0b73463a4452e 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled.png
  a4e6b5384b8454ee7f44a8f7c75b0321b7eeb9b1 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/forward_enabled_hover.png
  fc46c5ebf0524b72a509fe2d7c1bc74995cb8a9d 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc.png
  a88d7975fe9017e4e5f2289a94bd1ed66a5f59dc 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_asc_disabled.png
  4e144cf0b1f786a9248a2998311e8109998d8a2d 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_both.png
  18670406bc01ab2721781822dd6478917745ff54 
   
 src/main/resources/org/apache/aurora/scheduler/http/assets/datatables/images/sort_desc.png
  def071ed5afd264a036f6d9e75856366fd6ad153 
   
 

Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Bill Farner


 On April 1, 2014, 10:43 p.m., Bill Farner wrote:
  Isn't a StorageBackfill what you're after here?  Rewrite tasks in the 
  UNKNOWN state to a more appropriate state?
 
 Maxim Khutornenko wrote:
 The StorageBackfill is a much more invasive approach, which is not really 
 required here. Besides, rewriting state would mess up the task events and 
 show something like FINISHED - UNKNOWN - FINISHED. Trying to minimize the 
 impact here.

I find changing state machine logic more invasive, actually.  This will impact 
other areas of the system.  For example, HistoryPruner will be unable to purge 
these tasks because UNKNOWN is not a TERMINAL_STATE.

However, with a backfill operation, you could flip a task in UNKNOWN back to 
the previous state, and delete the transition event to UNKNOWN (i.e. this 
doesn't need to go through the state machine).


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39207
---


On April 1, 2014, 9:52 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19888/
 ---
 
 (Updated April 1, 2014, 9:52 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-261
 https://issues.apache.org/jira/browse/AURORA-261
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
 graceful rollback of that change.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
 003d475a1bd4ecc099d9a641fd239a8189f71cdb 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
 d2becea60e5d7bb59a2e5adb66e10cd50f6b56f3 
   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
 e77063a9c8e40e015ec264b151a7ed76f1c7f00f 
 
 Diff: https://reviews.apache.org/r/19888/diff/
 
 
 Testing
 ---
 
 gradle clean build
 gradle run
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Maxim Khutornenko


 On April 1, 2014, 10:43 p.m., Bill Farner wrote:
  Isn't a StorageBackfill what you're after here?  Rewrite tasks in the 
  UNKNOWN state to a more appropriate state?
 
 Maxim Khutornenko wrote:
 The StorageBackfill is a much more invasive approach, which is not really 
 required here. Besides, rewriting state would mess up the task events and 
 show something like FINISHED - UNKNOWN - FINISHED. Trying to minimize the 
 impact here.
 
 Bill Farner wrote:
 I find changing state machine logic more invasive, actually.  This will 
 impact other areas of the system.  For example, HistoryPruner will be unable 
 to purge these tasks because UNKNOWN is not a TERMINAL_STATE.
 
 However, with a backfill operation, you could flip a task in UNKNOWN back 
 to the previous state, and delete the transition event to UNKNOWN (i.e. this 
 doesn't need to go through the state machine).

Rewriting the events would result in a broken UI sandbox link until the history 
pruner acts on it, whereas in my case UNKNOWN tasks were not shown in the UI. 
Anyway, I am ok with the backfill approach.


- Maxim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39207
---


On April 1, 2014, 9:52 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19888/
 ---
 
 (Updated April 1, 2014, 9:52 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-261
 https://issues.apache.org/jira/browse/AURORA-261
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
 graceful rollback of that change.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/base/Tasks.java 
 003d475a1bd4ecc099d9a641fd239a8189f71cdb 
   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 
 d2becea60e5d7bb59a2e5adb66e10cd50f6b56f3 
   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
 e77063a9c8e40e015ec264b151a7ed76f1c7f00f 
 
 Diff: https://reviews.apache.org/r/19888/diff/
 
 
 Testing
 ---
 
 gradle clean build
 gradle run
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/
---

(Updated April 2, 2014, 12:05 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

Converting to StorageBackfill approach.


Bugs: AURORA-261
https://issues.apache.org/jira/browse/AURORA-261


Repository: aurora


Description
---

Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
graceful rollback of that change.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
6622216c285eb1c25c7648769a7d7676e8b73bcc 
  src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
PRE-CREATION 

Diff: https://reviews.apache.org/r/19888/diff/


Testing (updated)
---

gradle clean build


Thanks,

Maxim Khutornenko



Re: Review Request 19888: Prepare to store UNKNOWN state.

2014-04-01 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19888/#review39220
---

Ship it!



src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java
https://reviews.apache.org/r/19888/#comment71585

use List#remove(int) here, it returns the removed element.


- Bill Farner


On April 2, 2014, 12:05 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19888/
 ---
 
 (Updated April 2, 2014, 12:05 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-261
 https://issues.apache.org/jira/browse/AURORA-261
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Before we start storing UNKNOWN (SANDBOX_DELETED) state need to prepare for a 
 graceful rollback of that change.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 
 6622216c285eb1c25c7648769a7d7676e8b73bcc 
   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 
 PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/19888/diff/
 
 
 Testing
 ---
 
 gradle clean build
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-04-01 Thread Mark Chu-Carroll


 On March 28, 2014, 1:46 p.m., Maxim Khutornenko wrote:
  src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh, line 43
  https://reviews.apache.org/r/19788/diff/1/?file=539838#file539838line43
 
  Why not pushd once instead?
 
 Mark Chu-Carroll wrote:
 Don't follow the question. What would a pushd accomplish here?
 
 Maxim Khutornenko wrote:
 Sorry, what I meant here ssh, pushd and do everything in a single session.

We get better errors this way. Right now, when the test setup fails, you can 
easily see exactly which step was the problem. When you bundle it into one 
session, it becomes harder. The time-cost of doing it this way is under 2 
seconds, which is pretty much noise in the runtime of this test.


- Mark


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19788/#review38919
---


On March 28, 2014, 1:28 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/19788/
 ---
 
 (Updated March 28, 2014, 1:28 p.m.)
 
 
 Review request for Aurora, Joe Smith and Kevin Sweeney.
 
 
 Bugs: aurora-266
 https://issues.apache.org/jira/browse/aurora-266
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Add a clientv2 version of the e2e test.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/BUILD 
 118c4a080b2aac88f1fb6365787b3bb55a665bea 
   src/main/python/apache/aurora/client/cli/BUILD 
 02e061c7d485cc7f24c48c0db1b5778819961f47 
   src/test/python/apache/aurora/client/cli/BUILD 
 d93a2df0f146e2771de2ce6223438a671d0e92a2 
   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/19788/diff/
 
 
 Testing
 ---
 
 [sun-wukong incubator-aurora (v2_e2e)]$ sh 
 src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh
 + . src/test/sh/org/apache/aurora/e2e/test_common.sh
 ++ exec
 ++ _aurora_built=false
 + RETCODE=1
 + export CLIENT_NAME=aurorav2.pex
 + CLIENT_NAME=aurorav2.pex
 + export EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
 + EXAMPLE_DIR=/vagrant/src/test/sh/org/apache/aurora/e2e/flask
 + TEST_DIR=deploy_test
 + TEST_CLUSTER=example
 + TEST_ROLE=vagrant
 + TEST_ENV=test
 + TEST_JOB=flask_example
 + TEST_SCHEDULER_IP=192.168.33.6
 + TEST_ARGS=($TEST_CLUSTER $TEST_ROLE $TEST_ENV $TEST_JOB $TEST_DIR 
 $TEST_SCHEDULER_IP $EXAMPLE_DIR/flask_example.aurora 
 $EXAMPLE_DIR/flask_example_updated.aurora)
 + trap collect_result EXIT
 + vagrant up
 Bringing machine 'devtools' up with 'virtualbox' provider...
 Bringing machine 'zookeeper' up with 'virtualbox' provider...
 Bringing machine 'mesos-master' up with 'virtualbox' provider...
 Bringing machine 'mesos-slave1' up with 'virtualbox' provider...
 Bringing machine 'mesos-slave2' up with 'virtualbox' provider...
 Bringing machine 'aurora-scheduler' up with 'virtualbox' provider...
 [devtools] VirtualBox VM is already running.
 [zookeeper] VirtualBox VM is already running.
 [mesos-master] VirtualBox VM is already running.
 [mesos-slave1] VirtualBox VM is already running.
 [mesos-slave2] VirtualBox VM is already running.
 [aurora-scheduler] VirtualBox VM is already running.
 + rm -rf deploy_test
 + devtools_setup deploy_test
 + local _testdir=deploy_test
 ++ git branch
 ++ grep '*'
 ++ cut -c 3-
 + branch=v2_e2e
 + run_dev 'if [ ! -d ~/test_dev ]; then git clone /vagrant ~/test_dev; fi'
 + vagrant ssh devtools -c 'if [ ! -d ~/test_dev ]; then git clone /vagrant 
 ~/test_dev; fi'
 + run_dev 'cd ~/test_dev; git reset --hard; git clean -fdx'
 + vagrant ssh devtools -c 'cd ~/test_dev; git reset --hard; git clean -fdx'
 HEAD is now at 29ae4e5 end-to-end for clientv2
 Removing .BUILD.CPython-2.7.3.pyc
 Removing .pants.d/
 Removing 3rdparty/python/.BUILD.CPython-2.7.3.pyc
 Removing build-support/pants-0.0.14-dev2.pex
 Removing build-support/pex.venv/
 Removing build-support/virtualenv-1.10.1.tar.gz
 Removing build-support/virtualenv-1.10.1/
 Removing dist/
 Removing src/main/python/apache/aurora/client/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/client/api/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/client/bin/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/client/cli/.BUILD.CPython-2.7.3.pyc
 Removing 
 src/main/python/apache/aurora/client/commands/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/client/hooks/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/common/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/common/auth/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/config/.BUILD.CPython-2.7.3.pyc
 Removing src/main/python/apache/aurora/config/schema/.BUILD.CPython-2.7.3.pyc
 Removing