Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 71 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line71 How about Multimap, ImmutableMultimap.Builder? Great idea. Done. On April 16,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 9:15 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Bill Farner
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 107 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line107 You probably want to initialize stats with a non-default value, to avoid

Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-17 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20469/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
On April 16, 2014, 11:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 107 https://reviews.apache.org/r/20398/diff/1/?file=560703#file560703line107 You probably want to initialize stats with a non-default value, to avoid

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 11:31 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-17 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 17, 2014, 11:39 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-17 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20469/#review40717 --- Please note the bug in the review field as well. - Bill Farner

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-17 Thread Suman Karumuri
On April 17, 2014, 12:21 a.m., David McLaughlin wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, lines 361-363 https://reviews.apache.org/r/19833/diff/7/?file=560830#file560830line361 Better to move these default values to getTasksForJob (is the

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-17 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/ --- (Updated April 18, 2014, 1:59 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-17 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19833/ --- (Updated April 18, 2014, 2 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-17 Thread David McLaughlin
On April 17, 2014, 12:21 a.m., David McLaughlin wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 365 https://reviews.apache.org/r/19833/diff/7/?file=560830#file560830line365 Why are you passing $scope.role, $scope.environment and $scope.job