Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository:

Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23718/#review48248 --- Ship it! src/main/python/apache/aurora/BUILD

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48068 --- Ship it! Ship It!

Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-593

Re: Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/#review48294 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 1:58 p.m.,

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 21, 2014, 9:39 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Maxim Khutornenko
On July 2, 2014, 11:11 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 414 https://reviews.apache.org/r/23188/diff/2/?file=623177#file623177line414 What's the motivation for including the job key? I would assume that the caller either already

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48298 --- Ping. - Maxim Khutornenko On July 3, 2014, 1:48 a.m., Maxim

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48300 --- Ship it! Still think it's worth keeping but don't want to block

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review48303 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 2:58 p.m.,

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48304 --- Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 3:53 p.m.,

Re: Review Request 23776: Add --stacktrace to gradle build command.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/ --- (Updated July 21, 2014, 10:27 p.m.) Review request for Aurora and Kevin

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko
On July 21, 2014, 10:16 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 721 https://reviews.apache.org/r/23254/diff/1/?file=623290#file623290line721 We should avoid taking advantage of passing nulls where possible, and

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48316 --- Ship it! Ship It! - Bill Farner On July 21, 2014, 11:23 p.m.,

Review Request 23782: Revert Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23782/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/#review48322 --- Do you think this should be obviated by