Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48362 --- src/main/python/apache/aurora/client/commands/core.py

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 4:41 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 23817: Do not rely upon pytest capsys since command line parameters alter outcome.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23817/#review48381 --- Ship it! Ship It! - Kevin Sweeney On July 22, 2014, 9:27 a.m.,

Re: Review Request 23823: Upgrade jersey version.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23823/#review48413 --- Ship it! Ship It! - Maxim Khutornenko On July 22, 2014, 7:42

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48414 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 4:23 p.m.,

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-22 Thread Maxim Khutornenko
On July 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 131 https://reviews.apache.org/r/23244/diff/2/?file=639321#file639321line131 What is this initialization doing? I don't see what it changes - it's reassigned just

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48418 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 22, 2014, 8:40 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/#review48427 --- Ship it! Ship It!

Review Request 23827: Filtering out unknown hosts when starting maintenance.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23827/ --- Review request for Aurora and Mark Chu-Carroll. Bugs: AURORA-443

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48442 --- Overall I think this is great. For my own curiosity - any reason

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
On July 22, 2014, 10:52 p.m., David McLaughlin wrote: Overall I think this is great. For my own curiosity - any reason why you've used gson over the simple JSON protocol that comes with Thrift? Bill Farner wrote: TSimpleJSONProtocol is one-way, so it doesn't solve consumption of

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/#review48448 --- Ship it! Ship It! - Kevin Sweeney On July 1, 2014, 6:33 p.m.,

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48449 --- Ship it! lgtm. - David McLaughlin On July 21, 2014, 4:59 p.m.,

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48450 --- Ship it!

Re: Review Request 23776: Add --stacktrace to gradle build command.

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/#review48451 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 3:27 p.m.,

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review48453 --- Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 11:11 a.m.,

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-22 Thread Bjoern Metzdorf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 4:28 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-22 Thread Bjoern Metzdorf
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/ --- (Updated July 22, 2014, 4:28 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23832: Fix constraint violation caused by slave ID change.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23832/#review48464 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 1:25

Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-94

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/#review48467 --- Ship it!

Re: Review Request 23834: Refactoring SchedulerCore (restartShards)

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23834/ --- (Updated July 23, 2014, 2:36 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48327 --- Ship it!