Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-28 Thread Misho Krastev
On July 22, 2014, 12:54 a.m., Bill Farner wrote: Do you think this should be obviated by https://reviews.apache.org/r/23741/ ? This looks like elegant (declarative) solution to export REST variant of the native thrift interface. I am not familiar with the Aurora scheduler code so I can

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-28 Thread Bill Farner
On July 22, 2014, 12:54 a.m., Bill Farner wrote: Do you think this should be obviated by https://reviews.apache.org/r/23741/ ? Misho Krastev wrote: This looks like elegant (declarative) solution to export REST variant of the native thrift interface. I am not familiar with the

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48897 --- All ship-its have been given, but i'll give you guys until EOD to

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48905 --- build.gradle https://reviews.apache.org/r/23741/#comment85685

Review Request 24017: Make bootstrapThrift quiet.

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24017/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Review Request 24018: Update to RBTools 0.6.2

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24018/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 24017: Make bootstrapThrift quiet.

2014-07-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24017/#review48934 --- Ship it! Ship It! - Bill Farner On July 28, 2014, 11:10 p.m.,

Re: Review Request 24018: Update to RBTools 0.6.2

2014-07-28 Thread Bill Farner
On July 28, 2014, 11:44 p.m., Bill Farner wrote: Thanks for linking to the release notes. Some relevant changes i spotted: It’s no longer necessary to pass -g (or --guess-fields) to rbt post in order to automatically fill in the Summary and Description fields. This is now

Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24019/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-609

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/#review48949 --- Ship it! Ship It! - Kevin Sweeney On July 26, 2014, 11:16 a.m.,

Re: Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko
On July 28, 2014, 11:49 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/admin/admin_util.py, line 144 https://reviews.apache.org/r/24019/diff/1/?file=643988#file643988line144 giving this function a name turns this into a 3-liner but makes a much more readable stack trace

Re: Review Request 24019: Blocking on post drain script call.

2014-07-28 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24019/ --- (Updated July 29, 2014, 1:04 a.m.) Review request for Aurora, Joe Smith and

Review Request 24042: Add test coverage for Mname.

2014-07-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24042/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora