Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 22, 2014, 11:46 p.m.) Review request for Aurora, Joe Smith and Ma

Re: Review Request 24995: Adding support for a pre-update quota check.

2014-08-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/#review51334 --- Ship it! lgtm. - David McLaughlin On Aug. 22, 2014, 8:55 p.m., M

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51331 --- Ship it! Thank you!! - Joe Smith On Aug. 22, 2014, 2:26 p.m., Ma

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51319 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 22, 2014, 5:26 p.m.

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- (Updated Aug. 22, 2014, 9:26 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Maxim Khutornenko
> On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 187 > > > > > > If we're no longer wrapping a full maintenance process (which is fine) > > we shouldn't

Review Request 24995: Adding support for a pre-update quota check.

2014-08-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24995/ --- Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-649

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
> On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 187 > > > > > > If we're no longer wrapping a full maintenance process (which is fine) > > we shouldn'

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Maxim Khutornenko
> On Aug. 22, 2014, 6:39 p.m., Joe Smith wrote: > > src/main/python/apache/aurora/admin/host_maintenance.py, line 187 > > > > > > If we're no longer wrapping a full maintenance process (which is fine) > > we shouldn't

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51306 --- src/main/python/apache/aurora/admin/host_maintenance.py

Re: Review Request 24982: Fixing checkstyle build break.

2014-08-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/#review51294 --- Ship it! Ship It! - David McLaughlin On Aug. 22, 2014, 3:49 p.m.

Re: Review Request 24982: Fixing checkstyle build break.

2014-08-22 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/#review51293 --- Ship it! - Zameer Manji On Aug. 22, 2014, 8:49 a.m., Maxim Khutor

Review Request 24982: Fixing checkstyle build break.

2014-08-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24982/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-311 https://is

Re: Review Request 24852: Add command output tests for "job create", "job killall", "job kill"

2014-08-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/ --- (Updated Aug. 22, 2014, 11:04 a.m.) Review request for Aurora, David McLaughlin