Review Request 26024: Fix extra constructor arg causing build break.

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 26024: Fix extra constructor arg causing build break.

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/ --- (Updated Sept. 25, 2014, 7:09 a.m.) Review request for Aurora and Maxim

Re: Review Request 26024: Fix extra constructor arg causing build break.

2014-09-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26024/#review54545 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 25, 2014, 7:09

Re: Review Request 26015: Skip past irrelevant jobs when running cron show command.

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26015/ --- (Updated Sept. 25, 2014, 4:30 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 23330: replace 143 kB favicon with 318 byte version

2014-09-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54550 --- Ship it! Ship It! - Brian Wickman On July 31, 2014, 12:13 a.m.,

Review Request 26043: Fix checkstyle broken by rb/26015.

2014-09-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 26043: Fix checkstyle broken by rb/26015.

2014-09-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/#review54551 --- Found this when trying to apply r/23330 but commits are being

Re: Review Request 26043: Fix checkstyle broken by rb/26015.

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26043/#review54556 --- Ship it! Ship It! - Bill Farner On Sept. 25, 2014, 5:27 p.m.,

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54557 ---

Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54561 --- Ship it! Ship It! - Brian Wickman On Sept. 25, 2014, 5:54 p.m.,

Re: Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54564 --- build-support/jenkins/build.sh

Re: Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Bill Farner
On Sept. 25, 2014, 6:03 p.m., Kevin Sweeney wrote: build-support/jenkins/build.sh, lines 27-28 https://reviews.apache.org/r/26044/diff/1/?file=705427#file705427line27 Why's this indirection needed, can't you just do ```bash ./build-support/hooks/pre-commit

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Maxim Khutornenko
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Happy to change it.

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:16 p.m.) Review request for Aurora, Mark

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Bill Farner
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Brian Wickman
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko

Re: Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54570 --- Ship it! Ship It! - Joe Smith On Sept. 25, 2014, 11:09 a.m.,

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:26 p.m.) Review request for Aurora, Mark

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Maxim Khutornenko
On Sept. 25, 2014, 5:51 p.m., Brian Wickman wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java, line 91 https://reviews.apache.org/r/25970/diff/2/?file=704572#file704572line91 minor nit I think the proper spelling is RETRIABLE Maxim Khutornenko

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ --- (Updated Sept. 25, 2014, 6:34 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/#review54573 --- src/test/python/apache/aurora/client/api/test_scheduler_client.py

Review Request 26048: Cosmetic UI changes

2014-09-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 26048: Cosmetic UI changes

2014-09-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26048/#review54577 --- Ship it! Ship It! - Bill Farner On Sept. 25, 2014, 6:39 p.m.,

Re: Review Request 26012: Use BufferedOutputStream for deflater

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 2:24 p.m.) Review request for Aurora, David

Re: Review Request 26012: Use BufferedOutputStream for deflater

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 2:24 p.m.) Review request for Aurora, David

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

2014-09-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-25 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 10:02 p.m.) Review request for Aurora, Bill Farner

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54613 --- Ship it! Ship It! - Zameer Manji On Sept. 25, 2014, 3:02 p.m.,

Re: Review Request 26012: Use BufferedOutputStream for deflater

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 3:12 p.m.) Review request for Aurora, David

Re: Review Request 26012: Use BufferedOutputStream for deflater

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ --- (Updated Sept. 25, 2014, 3:21 p.m.) Review request for Aurora, David

Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.

2014-09-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 --- src/main/python/apache/aurora/executor/common/announcer.py