Review Request 26113: Upgrade to gradle 2.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26113/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- www.gradle.org/docs/2.1/release-notes.html www.gradle.org/docs/2.0/release-notes.html Distillation of major features that might help us: 2.1: - Easier use of community plugins - Incremental Java compilation - Use of HTTPS for mavenCentral() and jcenter() dependency repositories - PMD Console Output 2.0: - Support for Java 8 Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 gradle/wrapper/gradle-wrapper.jar 0087cd3b18659b5577cf6ad3ef61f8eb9416ebba gradle/wrapper/gradle-wrapper.properties 72018bc493792fe24592daa606f51dd5fca7897a src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java 212ba122acb539a2934690215bbcce095602d702 src/main/java/org/apache/aurora/scheduler/storage/mem/MemJobStore.java c8f73bb51e2f7d2aabd8e34480811cb8ed617cfa Diff: https://reviews.apache.org/r/26113/diff/ Testing --- git clean -fdx ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26106: Add updater support for disabling rollback and batched update settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26106/ --- (Updated Sept. 27, 2014, 7:36 a.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Changes --- Fixed python test break. Bugs: AURORA-744 and AURORA-747 https://issues.apache.org/jira/browse/AURORA-744 https://issues.apache.org/jira/browse/AURORA-747 Repository: aurora Description --- Add updater support for disabling rollback and batched update settings. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 5dec82aef337f42a402084f2c1a1776bb977ab56 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649 src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml 2794242e71515effdc710cb40e881baca9dc4124 src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 866e6587a2deee39228ccabf89bf276cc5e44881 src/main/thrift/org/apache/aurora/gen/api.thrift cebd2c30dc536debbbe8a7d38d81eb5030978135 src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 7e4184330bdec271ead0d700bc02c8b3470876a9 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9 Diff: https://reviews.apache.org/r/26106/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- Once this is commited, please make tickets for adding tests to these classes. - Zameer Manji On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 4:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54773 --- Ship it! build.gradle https://reviews.apache.org/r/26123/#comment95048 Move thresholds to constants for better visibility? - Maxim Khutornenko On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 11:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54772 --- Love this! build.gradle https://reviews.apache.org/r/26123/#comment95046 extra slash? build.gradle https://reviews.apache.org/r/26123/#comment95047 can we pull these values out to constants so it's easy[1] to bump them up as coverage increases? [1] not that it's hard, but I imagine future diffs are easier if it's just: + MINIMUM_LINE_COVERAGE=0.87 - MINIMUM_LINE_COVERAGE=0.86 build.gradle https://reviews.apache.org/r/26123/#comment95049 This seems like a potentially harsh penalty for good behavior if someone has to go from 0 to $MIN_COVERAGE in one go... I can imagine it encouraging the opposite of the desired behavior for someone adding new code to a legacy class but not adding code coverage because it means writing tests for the entire class as part of their change. - Joshua Cohen On Sept. 27, 2014, 11:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 11:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
