---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/
---
(Updated Oct. 8, 2014, 10:42 a.m.)
Review request for Aurora, David McLaughlin
On Oct. 8, 2014, 1:58 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/cli/__init__.py, line 435
https://reviews.apache.org/r/26328/diff/2/?file=714194#file714194line435
It writes into the current directory where the user is executing the
client.
This is going
On Oct. 7, 2014, 9:39 p.m., Mark Chu-Carroll wrote:
Looks good.
One note on the change description: I'm willing to bet that there is a way
to get that branch active in a test. Every single time that I've ever said
that something couldn't be tested, or that some branch couldn't be
On Oct. 7, 2014, 9:18 p.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/client/cli/test_api_from_cli.py, line 51
https://reviews.apache.org/r/26308/diff/5/?file=713862#file713862line51
Why do these need to be mocks? This would work identically using the
Thrift structures
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/
---
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-804
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55805
---
src/main/python/apache/aurora/common/transport.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55810
---
Ship it!
Ship It!
- Bill Farner
On Oct. 8, 2014, 12:14 a.m.,
On Oct. 8, 2014, 4:28 p.m., Bill Farner wrote:
src/main/python/apache/aurora/common/transport.py, line 28
https://reviews.apache.org/r/26424/diff/2/?file=714839#file714839line28
I find it odd to extract a function for this. If i were a newcomer, i
would immediately inline this
On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote:
src/main/python/apache/aurora/config/schema/base.py, line 69
https://reviews.apache.org/r/26383/diff/1/?file=714259#file714259line69
Do we need to make this path configurable? I'm trying to think of a
reason that someone might want
On Oct. 8, 2014, 1:05 a.m., Maxim Khutornenko wrote:
I see this got committed even though there are still open questions in this RB.
Any chance these can get answered?
- Maxim
---
This is an automatically generated e-mail. To
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote:
docs/configuration-reference.md, lines 359-360
https://reviews.apache.org/r/26383/diff/1/?file=714257#file714257line359
Is there any reason this needs to be configurable? Why not just
hardcode the filename as '.healthchecksnooze'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55818
---
Ship it!
Ship It!
- Bill Farner
On Oct. 8, 2014, 4:54 p.m.,
I'm +1 on removing the time control as well. If you need to extend the
snooze you could always touch -m the snooze file?
On Wed, Oct 8, 2014 at 9:51 AM, Bill Farner wfar...@apache.org wrote:
On Oct. 6, 2014, 10:40 p.m., Brian Wickman wrote:
docs/configuration-reference.md, lines 359-360
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55821
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 3, 2014, 1:59
On Oct. 6, 2014, 4:33 p.m., Joshua Cohen wrote:
*ping* Kevin.
*ping* again. Once this ships the static assets changes from
https://github.com/jcohen/incubator-aurora/commits/jcohen/static-assets
(reviewed at https://reviews.apache.org/r/25835/) should be mergeable.
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26422/
---
(Updated Oct. 8, 2014, 10:27 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/
---
(Updated Oct. 8, 2014, 10:28 a.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55828
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 5:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26422/#review55827
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 5:27
On Oct. 8, 2014, 9:19 a.m., Bill Farner wrote:
While our minds are on deadlock risks, it's a good idea to assess other
potential vulnerabilities.
A quick filter to find other potential sources deserving a glance:
$ grep -Rl synchronized src/main/java | xargs grep -l Storage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55836
---
Ship it!
Ship It!
- Brian Wickman
On Oct. 8, 2014, 5:28 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/
---
(Updated Oct. 8, 2014, 1:40 p.m.)
Review request for Aurora, David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26448/#review55838
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 10:32 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55840
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 8:58 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55839
---
Ship it!
Awesome
- Joe Smith
On Oct. 8, 2014, 10:28 a.m., Kevin
On Oct. 3, 2014, 4:43 p.m., Bill Farner wrote:
Anything left to do here before Kevin commits?
Joshua Cohen wrote:
Nope, he tried to commit but was blocked by checkstyle flagging 3rdparty
python (https://issues.apache.org/jira/browse/AURORA-780). I sent a review
out to address that
On Oct. 8, 2014, 4:19 p.m., Bill Farner wrote:
While our minds are on deadlock risks, it's a good idea to assess other
potential vulnerabilities.
A quick filter to find other potential sources deserving a glance:
$ grep -Rl synchronized src/main/java | xargs grep -l Storage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55846
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 4, 2014, 10:55 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26320/#review55847
---
Apologies for the review delay.
Is there a way we can tell
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55849
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 3:58
On Oct. 8, 2014, 6:02 p.m., Kevin Sweeney wrote:
Apologies for the review delay.
Is there a way we can tell checkstyle to avoid this file at all? I'd rather
not make it a policy to patch each individual bower component we checkin.
Not without patching checkstyle alas.
- Joshua
On Oct. 8, 2014, 9:19 a.m., Bill Farner wrote:
While our minds are on deadlock risks, it's a good idea to assess other
potential vulnerabilities.
A quick filter to find other potential sources deserving a glance:
$ grep -Rl synchronized src/main/java | xargs grep -l Storage
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26422/#review55854
---
Ship it!
Thanks for the extra look!
- Bill Farner
On Oct. 8,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/
---
(Updated Oct. 8, 2014, 11:56 a.m.)
Review request for Aurora, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26428/#review55857
---
Ship it!
Ship It!
- Brian Wickman
On Oct. 8, 2014, 12:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55858
---
Ship it!
Ship It!
- Joe Smith
On Oct. 4, 2014, 10:55 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55859
---
src/test/python/apache/aurora/client/commands/test_maintenance.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55860
---
Ship it!
Inlining inside `__init__` WFM. thanks!
- Joe Smith
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26428/
---
(Updated Oct. 8, 2014, 7:22 p.m.)
Review request for Aurora and Brian Wickman.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55862
---
Patch fails to apply:
% ./rbt patch -c 25835
Patch is being
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25835/#review55864
---
Patch fails to apply:
% ./rbt patch -c 25835
Patch is being
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26425/#review55865
---
I'm underwater on reviews and unable to review this promptly -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review55870
---
src/main/python/apache/aurora/client/config.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/
---
(Updated Oct. 8, 2014, 8:57 p.m.)
Review request for Aurora, Kevin Sweeney and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/
---
Review request for Aurora, Joe Smith and Brian Wickman.
Bugs: AURORA-820
On Oct. 6, 2014, 4:44 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/client/cli/test_update.py, lines 342-353
https://reviews.apache.org/r/26363/diff/1/?file=714123#file714123line342
This sequence of mocks and writing config to a file is repeated in...
many (all?) of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---
(Updated Oct. 8, 2014, 3:29 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/
---
(Updated Oct. 8, 2014, 3:29 p.m.)
Review request for Aurora, Kevin Sweeney,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26430/#review55885
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 8, 2014, 3:29 p.m.,
On Oct. 8, 2014, 5:17 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 90
https://reviews.apache.org/r/26425/diff/1/?file=714851#file714851line90
These methods read strangely to me: check the quota of this task
config, and check the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26425/
---
(Updated Oct. 8, 2014, 10:58 p.m.)
Review request for Aurora and Bill Farner.
On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, lines
157-158
https://reviews.apache.org/r/26383/diff/1/?file=714260#file714260line157
I know you didn't originate this pattern, but it seems odd for these
On Oct. 8, 2014, 5:32 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 81
https://reviews.apache.org/r/26376/diff/1/?file=714219#file714219line81
Seems like we're moving towards identical calculations for prod and
non-prod tasks.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26464/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-819
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26394/
---
(Updated Oct. 8, 2014, 11:39 p.m.)
Review request for Aurora, David
On Oct. 8, 2014, 11:31 p.m., Bill Farner wrote:
Ship It!
This is now on master:
$ git log -1 --abbrev-commit origin/master
commit 18ae905
Author: Zameer Manji zma...@twopensource.com
Date: Wed Oct 8 16:33:42 2014 -0700
Blacklist
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/
---
(Updated Oct. 8, 2014, 11:46 p.m.)
Review request for Aurora, Joe Smith and
On Oct. 8, 2014, 7:08 p.m., Joe Smith wrote:
src/test/python/apache/aurora/client/commands/test_maintenance.py, line 117
https://reviews.apache.org/r/26431/diff/1/?file=715028#file715028line117
can this be a mock that we assert gets called 3 times?
(This test is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26464/#review55900
---
This doesn't actually fail when I run it locally. I'm worried that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/
---
(Updated Oct. 8, 2014, 7:56 p.m.)
Review request for Aurora, David McLaughlin
On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote:
This doesn't actually fail when I run it locally. I'm worried that we're
just fixing a symptom of the problem, and not the problem itself (i.e.
we're going to be adding random classes to the legacy list despite their
actually having
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26394/#review55907
---
Thanks again for leading this - i'm very happy to see momentum on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55899
---
src/main/python/apache/aurora/admin/host_maintenance.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55909
---
src/main/python/apache/aurora/admin/host_maintenance.py
On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote:
This doesn't actually fail when I run it locally. I'm worried that we're
just fixing a symptom of the problem, and not the problem itself (i.e.
we're going to be adding random classes to the legacy list despite their
actually having
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26469/
---
Review request for Aurora, Bill Farner and Zameer Manji.
Repository: aurora
On Oct. 8, 2014, 11:50 p.m., Joshua Cohen wrote:
This doesn't actually fail when I run it locally. I'm worried that we're
just fixing a symptom of the problem, and not the problem itself (i.e.
we're going to be adding random classes to the legacy list despite their
actually having
On Oct. 9, 2014, 12:05 a.m., Bill Farner wrote:
Thanks again for leading this - i'm very happy to see momentum on removing
`Identity`.
Stepping back - i wonder if we should re-evaluate the way we do field
deprecations now that we've established a protocol with JIRA and releases.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26469/#review55916
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 5:15 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 12:43 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 12:46 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55924
---
src/main/python/apache/aurora/executor/common/health_checker.py
On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote:
src/main/python/apache/aurora/executor/common/health_checker.py, line 41
https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41
Why add a default value here?
David Pan wrote:
The reason why
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 9, 2014, 1:56 a.m.)
Review request for Aurora, Joe Smith, Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/
---
Review request for Aurora, David McLaughlin, Bill Farner, and Zameer Manji.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/
---
(Updated Oct. 8, 2014, 7:39 p.m.)
Review request for Aurora, David McLaughlin,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26478/#review55943
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 8, 2014, 7:39 p.m.,
77 matches
Mail list logo