---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26856/#review57139
---
docs/storage_config.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26822/#review57141
---
Ship it!
Thanks! That always bugged me!
- Jay Buffington
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/#review57142
---
docs/client-cluster-configuration.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26845/#review57143
---
Ship it!
Sorry for the late review after it already merged. This
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57144
---
docs/cron-jobs.md
https://reviews.apache.org/r/26836/#comment97615
On Oct. 15, 2014, 6:08 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/admin/host_maintenance.py, line 41
https://reviews.apache.org/r/26458/diff/2/?file=717917#file717917line41
minor nit:
Amount(5, Time.MINUTES)
Done.
- Maxim
On Oct. 15, 2014, 7:04 p.m., Joe Smith wrote:
src/test/python/apache/aurora/client/commands/test_maintenance.py, line 206
https://reviews.apache.org/r/26458/diff/2/?file=717919#file717919line206
mock_wait.assert_called_once_with
Added.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/
---
(Updated Oct. 17, 2014, 3:48 p.m.)
Review request for Aurora, Joe Smith and
On Oct. 15, 2014, 12:41 a.m., Bill Farner wrote:
src/main/python/apache/aurora/executor/gc_executor.py, line 281
https://reviews.apache.org/r/26664/diff/1/?file=719806#file719806line281
More context? It's not clear what you mean here.
Added.
On Oct. 15, 2014, 12:41 a.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26664/
---
(Updated Oct. 17, 2014, 4:15 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review57164
---
Ship it!
Ship It!
- Joe Smith
On Oct. 17, 2014, 8:48 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/#review57160
---
docs/storage_recovery.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 17, 2014, 10:09 a.m.)
Review request for Aurora, Joe Smith,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57163
---
src/main/python/apache/aurora/executor/common/health_checker.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26852/#review57170
---
examples/vagrant/provision-dev-cluster.sh
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review57177
---
Ship it!
Ship It!
- Mark Chu-Carroll
On Oct. 8, 2014, 7:46
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26881/
---
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: aurora-771
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
---
(Updated Oct. 17, 2014, 11:28 a.m.)
Review request for Aurora, Joe Smith,
On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote:
Ship It!
Maxim - can you commit this?
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26841/#review57069
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57197
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 17, 2014, 6:28
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/
---
(Updated Oct. 17, 2014, 8:02 p.m.)
Review request for Aurora, Joe Smith and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26881/#review57206
---
Maybe this is nitpicking, but given the confusion we've already
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26834/
---
(Updated Oct. 17, 2014, 8:23 p.m.)
Review request for Aurora, Maxim
On Oct. 17, 2014, 3:02 p.m., Jay Buffington wrote:
docs/client-cluster-configuration.md, line 63
https://reviews.apache.org/r/26834/diff/3/?file=723872#file723872line63
I this true? It was my understanding that the only use for this field
is to format URLs that are output by
On Oct. 16, 2014, 8:11 p.m., Kevin Sweeney wrote:
Is this still needed? I thought the checkstyle check was updated
Zameer Manji wrote:
I was under this impression as well.
Ok, discarded.
- Joshua
---
This is an automatically
On Oct. 17, 2014, 12:18 p.m., Maxim Khutornenko wrote:
Ship It!
Bill Farner mentioned that once you give a shipit, it is good to go (and that
he is not needed for the review). Is it okay if you commit the change?
Thanks!
- David
On Oct. 17, 2014, 5:07 p.m., Bill Farner wrote:
docs/storage_recovery.md, line 1
https://reviews.apache.org/r/26851/diff/1/?file=723887#file723887line1
How about: Recovering from a scheduler backup
Done.
On Oct. 17, 2014, 5:07 p.m., Bill Farner wrote:
docs/storage_recovery.md,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/
---
(Updated Oct. 17, 2014, 8:45 p.m.)
Review request for Aurora, Kevin Sweeney
On Oct. 17, 2014, 7:30 p.m., David Pan wrote:
Ship It!
This is on master. Thanks!
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review57199
On Oct. 17, 2014, 2:46 p.m., Jay Buffington wrote:
docs/storage_config.md, line 2
https://reviews.apache.org/r/26856/diff/1/?file=723958#file723958line2
A summary here would be good to help give an overview of what the point
of this document is and who the intended audience is.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26856/
---
(Updated Oct. 17, 2014, 9:18 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26851/
---
(Updated Oct. 17, 2014, 9:47 p.m.)
Review request for Aurora, Kevin Sweeney
On Oct. 17, 2014, 9:34 p.m., Kevin Sweeney wrote:
Can you merge docs/scheduler-storage.md with this one? Also, filename nit:
we've used dash instead of underscore elsewhere, mind keeping that
convention here?
Agree, no reason to keep them separate. Merged and discarded this review in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26901/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-868
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26901/#review57247
---
Ship it!
LGTM once terminology is swapped so penalty applies after
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26901/
---
(Updated Oct. 17, 2014, 11:47 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26901/#review57249
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 17, 2014, 4:47 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57252
---
Sorry Jay, I'll address your feedback in a subsequent review.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26901/#review57253
---
Ship it!
Thanks! This is now on master.
$ git log -1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26902/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26902/#review57254
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 17, 2014, 5:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26902/#review57256
---
Thanks, great idea?
On Oct. 18, 2014, 12:50 a.m., Bill Farner wrote:
Thanks, great idea?
Whoops, should have read Thanks, great idea!
:-)
- Bill
---
This is an automatically generated e-mail. To reply, visit:
43 matches
Mail list logo