---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/
---
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-874
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57614
---
Ship it!
Thanks for also using the term instance.
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26985/
---
Review request for Aurora, Joshua Cohen and Bill Farner.
Repository: aurora
On Oct. 15, 2014, 2:24 p.m., Bill Farner wrote:
Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a
separte diff?
Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's
broken by this patch.
I'd prefer to leave that doc - it's a historical
On Oct. 20, 2014, 7:35 p.m., Bill Farner wrote:
src/main/thrift/org/apache/aurora/gen/api.thrift, line 1024
https://reviews.apache.org/r/26531/diff/3/?file=723031#file723031line1024
This method name reads strangely to me, since it's using heartbeat as
a verb. 'Pulse' has a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57622
---
Is there an end to end test for this that needs updated?
- David
On Oct. 20, 2014, 8 p.m., Joshua Cohen wrote:
src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql, line
109
https://reviews.apache.org/r/26531/diff/3/?file=723030#file723030line109
Other instances of delays stored in ms seem to be INT not BIGINT.
Signed BIGINT
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/
---
(Updated Oct. 21, 2014, 5:58 p.m.)
Review request for Aurora, David
On Oct. 21, 2014, 1:57 p.m., David McLaughlin wrote:
Is there an end to end test for this that needs updated?
No. The end-to-end doesn't check the output from the status command.
- Mark
---
This is an automatically generated e-mail.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57626
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 21, 2014, 4:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/
---
(Updated Oct. 21, 2014, 2:05 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26985/#review57630
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 21, 2014, 10:46 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/
---
(Updated Oct. 21, 2014, 2:34 p.m.)
Review request for Aurora, Bill Farner and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26991/
---
Review request for Aurora, David McLaughlin and Mark Chu-Carroll.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/#review57655
---
Ship it!
Ship It!
- Zameer Manji
On Oct. 21, 2014, 1:54 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/#review57657
---
Ship it!
Ship It!
- Joshua Cohen
On Oct. 21, 2014, 8:54 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/#review57659
---
build-support/thrift/Makefile
On Oct. 21, 2014, 2:18 p.m., Maxim Khutornenko wrote:
build-support/thrift/Makefile, line 15
https://reviews.apache.org/r/26995/diff/1/?file=727984#file727984line15
Is there any evidence this mirror is any better SLA-wise that the old
one?
From the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/
---
Review request for Aurora, Joshua Cohen and Kevin Sweeney.
Bugs: AURORA-824
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57662
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 21, 2014, 2:24 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26995/#review57664
---
Ship it!
Ship It!
- Maxim Khutornenko
On Oct. 21, 2014, 8:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26985/
---
(Updated Oct. 21, 2014, 9:33 p.m.)
Review request for Aurora, Joshua Cohen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26998/#review57679
---
This end-to-end test runs against all components (it recently
On Oct. 21, 2014, 10:15 p.m., Kevin Sweeney wrote:
This end-to-end test runs against all components (it recently caught an
executor build break). Any reason not to build them all here?
+1, I'd say build them all by default but maybe add an env switch to skip
building for speedier
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26998/
---
(Updated Oct. 21, 2014, 10:29 p.m.)
Review request for Aurora, Joshua Cohen
On Oct. 21, 2014, 10:15 p.m., Kevin Sweeney wrote:
This end-to-end test runs against all components (it recently caught an
executor build break). Any reason not to build them all here?
Joshua Cohen wrote:
+1, I'd say build them all by default but maybe add an env switch to skip
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27001/
---
Review request for Aurora and Kevin Sweeney.
Repository: aurora
Description
On Oct. 21, 2014, 3:32 p.m., Joshua Cohen wrote:
Thoughts on adding an 'all' component to aurorabuild.sh that builds
everything? We do this in three places now that I know of (these two and
the provision script).
Maxim Khutornenko wrote:
That's exactly what I was hesitating on
On Oct. 21, 2014, 3:15 p.m., Kevin Sweeney wrote:
This end-to-end test runs against all components (it recently caught an
executor build break). Any reason not to build them all here?
Joshua Cohen wrote:
+1, I'd say build them all by default but maybe add an env switch to skip
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27001/#review57699
---
Ship it!
Ship It!
- Kevin Sweeney
On Oct. 21, 2014, 3:38 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26998/#review57714
---
Ship it!
Thanks!
- Joshua Cohen
On Oct. 21, 2014, 11:22 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26997/#review57723
---
Ship it!
On Oct. 21, 2014, 6:40 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java, line
150
https://reviews.apache.org/r/26997/diff/1/?file=728016#file728016line150
Consider sticking to the standard here of using guava's ToStringHelper
On Oct. 15, 2014, 6:24 p.m., Bill Farner wrote:
Should `docs/clientv2.md` be rehashed/removed to wipe traces of v1, or in a
separte diff?
Can you also update `examples/vagrant/test_tutorial.sh`? I suspect it's
broken by this patch.
Mark Chu-Carroll wrote:
I'd prefer to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26991/#review57726
---
Ship it!
Ship It!
- Bill Farner
On Oct. 21, 2014, 7:42 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26991/#review57727
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 21, 2014, 7:42
37 matches
Mail list logo
