Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review63976 --- Ship it! Master (905137f) is green with this patch.

Re: Review Request 28738: Remove unused DefaultServlet subclass.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28738/#review64016 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 4:06

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/ --- (Updated Dec. 5, 2014, 6:32 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 28738: Remove unused DefaultServlet subclass.

2014-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28738/ --- (Updated Dec. 5, 2014, 6:33 p.m.) Review request for Aurora and Maxim

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review64056 --- Ship it! Master (40d2718) is green with this patch.

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review63897 --- build.gradle https://reviews.apache.org/r/28710/#comment106210

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/#review64066 --- Not to bikeshed, but do either of you have a sense for what it

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Maxim Khutornenko
On Dec. 5, 2014, 8:06 p.m., Bill Farner wrote: Not to bikeshed, but do either of you have a sense for what it would take to put the benchmarking code into a gradle subproject? My sense is that would avoid further complicating the root build.gradle, but i'm not familiar enough with

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Bill Farner
On Dec. 5, 2014, 8:06 p.m., Bill Farner wrote: Not to bikeshed, but do either of you have a sense for what it would take to put the benchmarking code into a gradle subproject? My sense is that would avoid further complicating the root build.gradle, but i'm not familiar enough with

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28742/#review64075 --- What would it take to massage the log format? I'd love to drop the

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Zameer Manji
On Dec. 5, 2014, 12:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
On Dec. 5, 2014, 8:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel

Review Request 28771: Don't fall back to old command syntax in the new client.

2014-12-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs:

Re: Review Request 28771: Don't fall back to old command syntax in the new client.

2014-12-05 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64086 --- Ship it! Ship It! - Zameer Manji On Dec. 5, 2014, 1:12 p.m.,

Re: Review Request 28771: Don't fall back to old command syntax in the new client.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64087 --- Master (40d2718) is green with this patch.

Re: Review Request 28771: Don't fall back to old command syntax in the new client.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28771/#review64103 --- Ship it! Ship It! - Maxim Khutornenko On Dec. 5, 2014, 9:12

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/ --- (Updated Dec. 5, 2014, 10:57 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/ --- (Updated Dec. 5, 2014, 11:02 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28617: Implemented offer filtering for tasks with static vetoes.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28617/#review64111 --- Ship it! Master (40d2718) is green with this patch.

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2014-12-05 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28731/#review64112 --- This patch does not apply cleanly on master (40d2718), do you need

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28710/ --- (Updated Dec. 6, 2014, 12:33 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 28710: Adding JMH framework support for scheduler performance analysis.

2014-12-05 Thread Maxim Khutornenko
On Dec. 5, 2014, 7:42 p.m., Kevin Sweeney wrote: build.gradle, line 53 https://reviews.apache.org/r/28710/diff/1/?file=782698#file782698line53 This should be unneeded. Dropped. On Dec. 5, 2014, 7:42 p.m., Kevin Sweeney wrote: build.gradle, line 103

Re: Review Request 28742: Simplify logging in the client.

2014-12-05 Thread Bill Farner
On Dec. 5, 2014, 8:37 p.m., Bill Farner wrote: What would it take to massage the log format? I'd love to drop the `INFO:root:` prefix to every line. Personally, i find it noisy for a command line tool to include the log level on each line of output, though others may feel