Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.

2014-12-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65644 --- src/main/python/apache/aurora/common/transport.py

Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.

2014-12-19 Thread Kevin Sweeney
On Dec. 19, 2014, 10:25 a.m., Brian Wickman wrote: src/main/python/apache/aurora/common/transport.py, lines 44-45 https://reviews.apache.org/r/29165/diff/3/?file=795507#file795507line44 does it make sense to have both session_factory and user_agent as arguments to

Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.

2014-12-19 Thread Joshua Cohen
On Dec. 19, 2014, 6:25 p.m., Brian Wickman wrote: src/main/python/apache/aurora/common/transport.py, lines 44-45 https://reviews.apache.org/r/29165/diff/3/?file=795507#file795507line44 does it make sense to have both session_factory and user_agent as arguments to

Review Request 29267: Remove unused 3rdparty dependencies.

2014-12-19 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.

2014-12-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65664 --- Ship it! Master (9042c56) is green with this patch.

Re: Review Request 29267: Remove unused 3rdparty dependencies.

2014-12-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65667 --- Ship it! Please file an issue to implement the equivalent

Re: Review Request 29267: Remove unused 3rdparty dependencies.

2014-12-19 Thread Kevin Sweeney
On Dec. 19, 2014, 12:17 p.m., Brian Wickman wrote: Please file an issue to implement the equivalent test_executor_builds functionality into CI. Done - filed https://issues.apache.org/jira/browse/AURORA-977 - Kevin --- This is an

Re: Review Request 29267: Remove unused 3rdparty dependencies.

2014-12-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29267/#review65672 --- Ship it! Master (9042c56) is green with this patch.

Re: Review Request 29165: Add custom user agent for Aurora v1, Aurora v2 and Aurora Admin clients.

2014-12-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29165/#review65684 --- Ship it! Ship It! - Brian Wickman On Dec. 19, 2014, 7:39 p.m.,

Review Request 29271: Removing cron schedule support from createJob and killTasks

2014-12-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-454

Review Request 29275: Fixing build break.

2014-12-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29275/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 29275: Fixing build break.

2014-12-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29275/#review65695 --- Ship it! Ship It! - Brian Wickman On Dec. 19, 2014, 10:46 p.m.,

Re: Review Request 29271: Removing cron schedule support from createJob and killTasks

2014-12-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29271/#review65697 --- Ship it! Master (84ad650) is green with this patch.

Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.

2014-12-19 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.

2014-12-19 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/#review65725 --- Ship it! Master (84ad650) is green with this patch.

Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.

2014-12-19 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/#review65729 --- Ship it! Ship It! - Joe Smith On Dec. 19, 2014, 7:05 p.m.,