On Jan. 21, 2015, 6:53 p.m., Zameer Manji wrote:
I talked with Florian offline and the next step for this patch is to add
CLI flags so this legacy behaviour can be enabled. This way we don't break
backwards compatability and users who rely on this behaviour don't get a
nasty surprise
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review68963
---
I talked with Florian offline and the next step for this patch is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review68950
---
Kevin - any chance you're available to take a pass at this soon?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review68962
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68961
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 16, 2015, 9:45 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69047
---
Meta question - how do you envision us using this? When a perf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69051
---
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java
On Jan. 21, 2015, 11:44 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 101
https://reviews.apache.org/r/28731/diff/5/?file=808351#file808351line101
I think we should proceed one of two ways here:
1. whittle this down
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/#review69071
---
This patch does not apply cleanly on master (116ee2d), do you need
On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote:
docs/thrift-deprecation.md, line 31
https://reviews.apache.org/r/29117/diff/2/?file=793344#file793344line31
There should be an item about logging and signaling in API responses
when deprecated fields are used.
Maxim Khutornenko
On Jan. 21, 2015, 10:27 p.m., Bill Farner wrote:
Meta question - how do you envision us using this? When a perf issue is
discovered, should we generally push for a test case to be added here to
validate the perf fix?
Maxim Khutornenko wrote:
I doubt we can build a
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote:
docs/developing-aurora-client.md, line 124
https://reviews.apache.org/r/29117/diff/2/?file=793342#file793342line124
s/thrift/Thrift/
Uppercased everywhere.
On Jan. 9, 2015, 6:44 p.m., Bill Farner wrote:
docs/thrift-deprecation.md,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29117/
---
(Updated Jan. 21, 2015, 10:59 p.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 21, 2015, 10:27 p.m., Bill Farner wrote:
Meta question - how do you envision us using this? When a perf issue is
discovered, should we generally push for a test case to be added here to
validate the perf fix?
I doubt we can build a reliable/automated way to catch regressions
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28920/#review68845
---
Sorry for the delay in reply. I've been thinking a lot about this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/
---
(Updated Jan. 22, 2015, 1:54 a.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 5, 2015, 8:38 p.m., Bill Farner wrote:
src/jmh/java/org/apache/aurora/benchmark/fakes/FakeClusterState.java, line
23
https://reviews.apache.org/r/28731/diff/4/?file=792353#file792353line23
Did you consider using `CachedClusterState` instead? That might cause
some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28731/#review69116
---
Master (116ee2d) is green with this patch.
20 matches
Mail list logo
