Re: Review Request 30858: Upgrade to checkstyle 6.3

2015-02-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30858/#review71913 --- Ship it! Master (64fa0ca) is green with this patch.

Re: Review Request 30859: Remove thrift checksum verification script and resources.

2015-02-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30859/#review71898 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 11, 2015, 1:14

Re: Review Request 30859: Remove thrift checksum verification script and resources.

2015-02-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30859/#review71912 --- Ship it! Master (64fa0ca) is green with this patch.

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71904 --- Ship it! api/src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review71907 --- Master (64fa0ca) is red with this patch.

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review71900 --- Ship it! Ship It! - Bill Farner On Feb. 11, 2015, 1:19 a.m.,

Re: Review Request 30858: Upgrade to checkstyle 6.3

2015-02-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30858/#review71918 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 11, 2015, 1:08

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Maxim Khutornenko
On Feb. 3, 2015, 12:28 a.m., Bill Farner wrote: src/main/python/apache/aurora/client/api/updater_util.py, line 108 https://reviews.apache.org/r/30461/diff/2/?file=842714#file842714line108 Can you investigate whether the python code respects the `isSetX` pattern? My hunch is that

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749/#review71831 --- src/main/python/apache/aurora/executor/bin/BUILD

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71835 ---

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71841 --- Ship it! Ship It! - Joshua Cohen On Feb. 6, 2015, 5:07 p.m.,

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review71840 --- Ship it! (assuming it rebases cleanly without the need for major

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71836 ---

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-10 Thread Joshua Cohen
On Feb. 10, 2015, 7:32 p.m., Joshua Cohen wrote: Ship It! Zameer Manji wrote: Don't forget to commit this. I had missed your earlier ship it. Will merge it now. - Joshua --- This is an automatically generated e-mail. To

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-10 Thread Zameer Manji
On Feb. 10, 2015, 11:32 a.m., Joshua Cohen wrote: Ship It! Don't forget to commit this. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71841

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review71879 --- I like the shape of this, thanks for working through a few

Review Request 30858: Upgrade to checkstyle 6.2.

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30858/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 30858: Upgrade to checkstyle 6.3

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30858/ --- (Updated Feb. 11, 2015, 1:08 a.m.) Review request for Aurora and Maxim

Review Request 30859: Remove thrift checksum verification script and resources.

2015-02-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30859/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Maxim Khutornenko
On Feb. 3, 2015, 3:35 a.m., Joshua Cohen wrote: src/main/python/apache/aurora/client/api/updater.py, line 99 https://reviews.apache.org/r/30461/diff/2/?file=842713#file842713line99 s/in/by the Fixed. On Feb. 3, 2015, 3:35 a.m., Joshua Cohen wrote:

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Feb. 11, 2015, 1:19 a.m.) Review request for Aurora, David