Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74373 --- src/main/python/apache/thermos/monitoring/garbage.py https://reviews.apache.org/r/31491/#comment120938 Optional, but you'd be doing FutureOncallJoe™ a favor by bootstrapping a logger and printing out the rm-s here (maybe in the lower methods instead?0 src/test/python/apache/thermos/monitoring/test_garbage.py https://reviews.apache.org/r/31491/#comment120939 If these are going to run in CI, we shouldn't add 'real' disk unfortunately. This could roll up into an 'integration' test, but I'm not a fan of adding a disk dependency to the tests - Joe Smith On Feb. 26, 2015, noon, Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, noon) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector interface
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 7:46 p.m.) Review request for Aurora, Joe Smith and Zameer Manji. Changes --- Remove tbds Bugs: AURORA-1026 https://issues.apache.org/jira/browse/AURORA-1026 Repository: aurora Description --- This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging. Diffs (updated) - src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2 src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7 src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8 src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138 src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5 src/main/python/apache/thermos/observer/detector.py PRE-CREATION src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381 src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886 src/test/python/apache/thermos/observer/BUILD PRE-CREATION src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION Diff: https://reviews.apache.org/r/31451/diff/ Testing --- Manually launched observer and ran some thermos tasks. + mba=aurora=; ./pants test src/test/python/apache/thermos/observer/:: Thanks, Brian Wickman
Re: Review Request 31451: Port thermos observer to the path detector interface
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74354
---
Master (36af017) is red with this patch.
./build-support/jenkins/build.sh
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.log
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.log-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.process
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.process-0.3.0-py2.7-nspkg.pth
Running setup.py install for gitdb
building 'gitdb._perf' extension
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2
-Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c
gitdb/_fun.c -o build/temp.linux-x86_64-2.7/gitdb/_fun.o
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2
-Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c
gitdb/_delta_apply.c -o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o
x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions
-Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv
-O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector
--param=ssp-buffer-size=4 -Wformat -Werror=format-security
build/temp.linux-x86_64-2.7/gitdb/_fun.o
build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o -o
build/lib.linux-x86_64-2.7/gitdb/_perf.so
Running setup.py install for twitter.common.app
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
Running setup.py install for GitPython
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292:
UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this
may not work as expected with newer versions of setuptools, pip, and PyPI.
Please see PEP 440 for more details.
details. % self.metadata.version
Running setup.py install for pep8
Installing pep8 script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for pyflakes
Installing pyflakes script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for twitter.checkstyle
Skipping installation of
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
(namespace package)
Installing
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
Installing twitterstyle script to
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2
smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0
twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0
twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0
twitter.common.options-0.3.0
Re: Review Request 31451: Port thermos observer to the path detector interface
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74345 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2015, 11:46 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 11:46 a.m.) Review request for Aurora, Joe Smith and Zameer Manji. Bugs: AURORA-1026 https://issues.apache.org/jira/browse/AURORA-1026 Repository: aurora Description --- This creates a new abstraction, the ObserverTaskDetector, which is responsible for managing state transitions for tasks for the observer. Adds some tests and better debug logging. Diffs - src/main/python/apache/aurora/executor/common/resource_manager.py 08e02e41b581f275f070228bb23c4cf2a0489f9a src/main/python/apache/aurora/executor/thermos_task_runner.py 7a28e3255842e3e13a0866d6ad1bfc4cb64781e1 src/main/python/apache/thermos/bin/thermos.py 0853a9892399824385bee9e72db4c108f46fceda src/main/python/apache/thermos/common/path.py 846f507e2e097fc04fe0098a7250b40fefcfc6e2 src/main/python/apache/thermos/monitoring/disk.py 175ed3af6515e6107e297d91d4e30cbb3034faf7 src/main/python/apache/thermos/monitoring/monitor.py 11423bc1764c8380d8de4ad095c1e2748ebb78f8 src/main/python/apache/thermos/monitoring/resource.py b4cb881c87a09bb90a740f369a7a5fc5d75dbf04 src/main/python/apache/thermos/observer/BUILD ee65f3a46e1d339620e76cadae92c6678fc3510f src/main/python/apache/thermos/observer/bin/BUILD 15a03f74f204f58856f0843b9db05e83b89d1138 src/main/python/apache/thermos/observer/bin/thermos_observer.py effa8c19f963bf2792497f4a06049214ae30dfa5 src/main/python/apache/thermos/observer/detector.py PRE-CREATION src/main/python/apache/thermos/observer/http/file_browser.py 87ef9c8a29689c78a5e39a46cc53e4675e36a381 src/main/python/apache/thermos/observer/observed_task.py f33aecbc8f3c0a461ae3dba66fbd4986f544dc04 src/main/python/apache/thermos/observer/task_observer.py cd528dcca3f5a330359cf38005f3a1a0329a4886 src/test/python/apache/thermos/observer/BUILD PRE-CREATION src/test/python/apache/thermos/observer/test_detector.py PRE-CREATION Diff: https://reviews.apache.org/r/31451/diff/ Testing --- Manually launched observer and ran some thermos tasks. + mba=aurora=; ./pants test src/test/python/apache/thermos/observer/:: Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
On Feb. 26, 2015, 7:46 p.m., Joshua Cohen wrote: src/main/python/apache/thermos/monitoring/garbage.py, line 83 https://reviews.apache.org/r/31491/diff/1/?file=878599#file878599line83 What's the purpose of these comments? ugh, keep forgetting to delete these comments On Feb. 26, 2015, 7:46 p.m., Joshua Cohen wrote: src/main/python/apache/thermos/monitoring/garbage.py, lines 44-47 https://reviews.apache.org/r/31491/diff/1/?file=878599#file878599line44 safe_mtime? derp yeah - Brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74343 --- On Feb. 26, 2015, 7:20 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 7:20 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74353 --- Ship it! Master (36af017) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 26, 2015, 8 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 8 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74342 --- Ship it! Master (36af017) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 26, 2015, 7:20 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 7:20 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Review Request 31493: Upgrading JMH plugin and framework versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31493/ --- Review request for Aurora and Bill Farner. Repository: aurora Description --- Updating jmh plugin to 0.2.0: https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt The most notable is the fix to support `jmhVersion` attribute that allowed to bump up jmh version from 1.3.2 to current 1.6.1. JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/ Among multiple improvements and stability fixes there is also https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of: ``` warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' ``` Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed peak usage of 600Mb). Diffs - build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248 Diff: https://reviews.apache.org/r/31493/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko
Re: Review Request 31493: Upgrading JMH plugin and framework versions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31493/#review74361 --- Ship it! Master (36af017) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 26, 2015, 8:33 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31493/ --- (Updated Feb. 26, 2015, 8:33 p.m.) Review request for Aurora and Bill Farner. Repository: aurora Description --- Updating jmh plugin to 0.2.0: https://github.com/melix/jmh-gradle-plugin/blob/master/CHANGELOG.txt The most notable is the fix to support `jmhVersion` attribute that allowed to bump up jmh version from 1.3.2 to current 1.6.1. JMH changelog: http://hg.openjdk.java.net/code-tools/jmh/ Among multiple improvements and stability fixes there is also https://bugs.openjdk.java.net/browse/CODETOOLS-7901127 fix that gets rid of: ``` warning: Supported source version 'RELEASE_6' from annotation processor 'org.openjdk.jmh.generators.BenchmarkProcessor' less than -source '1.7' ``` Also, bumping up max heap size as some of bechmarks OOM occasionally (noticed peak usage of 600Mb). Diffs - build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248 Diff: https://reviews.apache.org/r/31493/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74362 --- Ship it! Ship It! - Joshua Cohen On Feb. 26, 2015, 8 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 8 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74366 --- src/main/python/apache/thermos/monitoring/garbage.py https://reviews.apache.org/r/31491/#comment120932 You have secured all `self._state` accesses with a check that the latter is defined, all except this one. - Stephan Erb On Feb. 26, 2015, 9 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 9 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74367 --- Ship it! Ship It! - Stephan Erb On Feb. 26, 2015, 9 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 9 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74381 --- src/main/python/apache/thermos/monitoring/garbage.py https://reviews.apache.org/r/31491/#comment120949 Thanks for the catch. - Brian Wickman On Feb. 26, 2015, 8 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 8 p.m.) Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155 https://issues.apache.org/jira/browse/AURORA-1155 Repository: aurora Description --- Add basic test coverage to the TaskGarbageCollector. Diffs - src/main/python/apache/thermos/monitoring/garbage.py 53bb0345f963ae168206f34af1d82c67427f41fe src/test/python/apache/thermos/monitoring/BUILD 9c267775080e0bde08ff4e9b01862c6bee187634 src/test/python/apache/thermos/monitoring/test_garbage.py PRE-CREATION Diff: https://reviews.apache.org/r/31491/diff/ Testing --- ./pants test src/test/python/apache/thermos/monitoring:test_garbage Thanks, Brian Wickman
Re: Review Request 31508: Removing redundant scheduling loop in preemptor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/#review74409 --- Ship it! Master (766d1c9) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 27, 2015, 12:04 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/ --- (Updated Feb. 27, 2015, 12:04 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1156 https://issues.apache.org/jira/browse/AURORA-1156 Repository: aurora Description --- This is #1 from the attached ticket. Brings anywhere between 2% and 18% better perf in bechmark scenarios. BEFORE: ``` Benchmark Mode Samples Score Error Units o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100909677.646 ± 10103.466 ns/op o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark avgt 100 1332768.205 ± 16664.386 ns/op o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 69304405.590 ± 1536571.317 ns/op o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark avgt 100870348.707 ± 16815.495 ns/op ``` AFTER: ``` Benchmark Mode Samples Score Error Units o.a.a.b.SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark avgt 100749864.522 ±6568.372 ns/op o.a.a.b.SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark avgt 100 1125995.085 ± 19241.796 ns/op o.a.a.b.SchedulingBenchmarks.PreemptorFallbackForLargeClusterBenchmark.runBenchmark avgt 100 68028627.539 ± 1412569.919 ns/op o.a.a.b.SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark avgt 100766747.584 ± 13310.142 ns/op ``` Diffs - src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImpl.java a4e8dd3b9b58dac2d8507042500b7a479d46ebc0 src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java 44cd8f79493f0f247cd876ef78b30b4f813314c4 Diff: https://reviews.apache.org/r/31508/diff/ Testing --- ./gradlew jmh Thanks, Maxim Khutornenko
Re: Review Request 31496: Set default people for reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74372 --- Ship it! Ship It! - Joshua Cohen On Feb. 26, 2015, 9:57 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/ --- (Updated Feb. 26, 2015, 9:57 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Set default people for reviews so reviews made by new contributors have reviewers. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d Diff: https://reviews.apache.org/r/31496/diff/ Testing --- Made this review. Thanks, Zameer Manji
Re: Review Request 31496: Set default people for reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74377 --- Ship it! Master (36af017) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 26, 2015, 9:57 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/ --- (Updated Feb. 26, 2015, 9:57 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Set default people for reviews so reviews made by new contributors have reviewers. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d Diff: https://reviews.apache.org/r/31496/diff/ Testing --- Made this review. Thanks, Zameer Manji
Re: Review Request 31496: Set default people for reviews.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74397 --- Ship it! Just to be clear, the responsibility assumed here is that of dispatchers. jcohen and i are not gateways to land patches, and should exercise judgement to re-route contributors to committers that can best help. - Bill Farner On Feb. 26, 2015, 9:57 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/ --- (Updated Feb. 26, 2015, 9:57 p.m.) Review request for Aurora, Joshua Cohen and Bill Farner. Repository: aurora Description --- Set default people for reviews so reviews made by new contributors have reviewers. Diffs - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d Diff: https://reviews.apache.org/r/31496/diff/ Testing --- Made this review. Thanks, Zameer Manji
Re: Review Request 31451: Port thermos observer to the path detector interface
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74384 --- Master (db99eb0) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.config.test_loader . SUCCESS src.test.python.apache.aurora.config.test_thrift . SUCCESS src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_detector . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.kill_manager . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS src.test.python.apache.thermos.bin.test_thermos . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.common.test_planner . SUCCESS src.test.python.apache.thermos.common.test_task_planner . SUCCESS src.test.python.apache.thermos.config.test_schema . SUCCESS src.test.python.apache.thermos.core.test_angry . SUCCESS src.test.python.apache.thermos.core.test_ephemerals . SUCCESS src.test.python.apache.thermos.core.test_failing_runner . SUCCESS src.test.python.apache.thermos.core.test_failure_limit . SUCCESS src.test.python.apache.thermos.core.test_finalization . SUCCESS src.test.python.apache.thermos.core.test_helper . SUCCESS src.test.python.apache.thermos.core.test_process . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_detector . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS src.test.python.apache.thermos.monitoring.test_garbage . SUCCESS src.test.python.apache.thermos.monitoring.test_resource . FAILURE FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Feb. 26, 2015, 10:43 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 10:43 p.m.) Review request for Aurora, Joe Smith and Zameer Manji. Bugs:
Review Request 31525: Improving NearestFit reporting accuracy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1148 https://issues.apache.org/jira/browse/AURORA-1148 Repository: aurora Description --- Instead of relying on a fixed MAX_SCORE, vetoes are now graded by their relative weight (severity) with a dedicated constraint mismatch ranked higest and an insufficient resource mismatch - lowest. Together with break early rule in SchedulingFilter, this ensures heavier vetoes are given proper attention in the NearestFit. This simplifies `NearestFit` logic while also improving pending reason reporting accuracy and scheduling performance. Diffs - src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 3313bd2f9ed5a88375d88715dea5da1e9ad8b963 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java a020ce50d578fba7f32b370f448a49eb1c284147 src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java c3097e49c0f6588ea765aa4fab69dd35e3d90e8b src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java b00668423a53a8cf6f4da3456bce3354f1fd2424 src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java 78a236c0f9074692b67ce18e6e03f18fe4529e02 Diff: https://reviews.apache.org/r/31525/diff/ Testing --- ./gradlew -Pq build Thanks, Maxim Khutornenko
