Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated March 2, 2015, 9:03 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
On March 2, 2015, 6:56 p.m., Bill Farner wrote: src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java, line 133 https://reviews.apache.org/r/31338/diff/8/?file=882131#file882131line133 I think you can drop this since it's == `Resources.NONE` (default). Done On March

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74821 --- This patch does not apply cleanly on master (4cca6a6), do you need

Review Request 31652: Returning pending reason for all tasks in a group

2015-03-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Review Request 31659: Clean up end-to-end tests.

2015-03-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository:

Re: Review Request 31653: docs: Add info on granting production quota.

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31653/#review74864 --- Ship it! Master (4cca6a6) is green with this patch.

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- (Updated March 2, 2015, 11:40 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 31652: Returning pending reason for all tasks in a group

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31652/#review74865 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-02 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101/#review74880 --- debian/aurora-executor.thermos.default

Review Request 31646: Moving GroupKey to scheduler.base.

2015-03-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31646/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-911

Re: Review Request 31646: Moving GroupKey to scheduler.base.

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31646/#review74861 --- Ship it! Master (4cca6a6) is green with this patch.

Review Request 31653: docs: Add info on granting production quota.

2015-03-02 Thread Ricardo Cervera-Navarro
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31653/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review74881 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-02 Thread Bill Farner
On March 3, 2015, 3:38 a.m., Aurora ReviewBot wrote: Master (4cca6a6) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.cron . SUCCESS

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
On March 2, 2015, 7:40 p.m., Bill Farner wrote: Can you elaborate on how this change would have addressed this scenario described in AURORA-1148? Seems like the confusion of only seeing 'Insufficient RAM' is not resolved by this change alone. Correct, it's an incremental quality

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74752 --- @ReviewBot retry - Steve Niemitz On March 2, 2015, 4:59 p.m.,

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74751 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Bill Farner
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, lines 215-227 https://reviews.apache.org/r/31338/diff/4/?file=876499#file876499line215 Can this instead be an exact comparison of ListVolume? Presumably

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74793 ---

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74801 --- Can you elaborate on how this change would have addressed this

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74782 --- Ship it! LGTM mod nits.

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Maxim Khutornenko
On March 2, 2015, 7:14 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 64 https://reviews.apache.org/r/31525/diff/2/?file=880724#file880724line64 I don't think the Math.pow approach is necessary - why not make score an