On March 9, 2015, 5:58 p.m., Kevin Sweeney wrote:
LGTM once reviewbot is happy. It might be choking on the binary diff.
Yeah, pretty sure that's the case :-(
- Bill
---
This is an automatically generated e-mail. To reply, visit:
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76094
---
Ship it!
LGTM modulo the outstanding question re: length limit.
-
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76150
---
Ship it!
Master (4ec563f) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
---
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76191
---
Master (f62e0f1) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76193
---
@ReviewBot retry
- Bill Farner
On March 12, 2015, 1:27 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76194
---
Master (f62e0f1) is red with this patch.
On March 12, 2015, 1:38 a.m., Aurora ReviewBot wrote:
Master (f62e0f1) is red with this patch.
./build-support/jenkins/build.sh
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [gen]
01:37:22 00:00 [thrift][32m
11 matches
Mail list logo