Re: Review Request 31828: Upgrade gradle and a few plugins.
On March 9, 2015, 5:58 p.m., Kevin Sweeney wrote: LGTM once reviewbot is happy. It might be choking on the binary diff. Yeah, pretty sure that's the case :-( - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31828/#review75729 --- On March 7, 2015, 5:54 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31828/ --- (Updated March 7, 2015, 5:54 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- Gradle 2.3: http://gradle.org/docs/2.3/release-notes Checkstyle: http://checkstyle.sourceforge.net/releasenotes.html Can't tell what, if anything, changed in the versions plugin: https://github.com/ben-manes/gradle-versions-plugin/releases Diffs - build.gradle b723118e84038a237b368ef4e3fe9549cd4b2854 buildSrc/gradle.properties 73341fa90f20d73edf34fc3c945b686dd14bf941 gradle/wrapper/gradle-wrapper.jar 2322723c7ed5f591adfa4c87b6c51932f591249a gradle/wrapper/gradle-wrapper.properties 531b41ced8b99d418636a18f4f97297722944ea3 Diff: https://reviews.apache.org/r/31828/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long? Since it's optional anyway, I'd expect truncation could be a more resilient way to handle this. David McLaughlin wrote: I think it's better to just give a clear message telling them there is a limit. Truncation could happen in the client if needed. Maxim Khutornenko wrote: I was considering a case when some automated external service would attempt to act on an update and append some arbitrary metadata with pause/resume/abort. While not desirable, does not necessarily warrant a failure. Stopping a misbehaving update should clearly be a higher priority than enforcing a strict audit mode. Bill Farner wrote: Maybe it does warrant a failure, though. IMHO truncation would be a policy decision that the scheduler is making on behalf of the client. If the most important part of the message is after the truncation, we've made a poor choice. Maxim Khutornenko wrote: IDK, this whole length enforcment seems quite arbitrary to me. We don't restrict string size anywhere in thrift API or SQL schema. The only exception is TaskIdGenerator where the ID length is critical for external reasons (MESOS-691). Perhaps we should start doing it everywhere then? If the requirement to restrict message length is not driven by the underlying store, is there any reason to enforce it at all? Could we just let clients truncate messages as appropriate to their use case? Are we concerned with abuse and/or performance impact? - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76008 --- On March 11, 2015, 12:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 12:04 a.m.) Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- Add scheduler API support for audit messages when changing job updates. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift badb8eec51d9034fdfee79061c777927b2ba1314 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c0d48034ad6b6a91f1f58aca54544a5eddea4742 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 58824888a4839b71f4efa832a6d62ff6dd946e40 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7f5e5c2091458192d9310a81314f3c2c42b11f49 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java eebe01b161fbebdc43e62df4836136a02c3d5fb7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e119c494de8e81d7e2dd1f78337f08dcba3cd518 Diff: https://reviews.apache.org/r/31916/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long? Since it's optional anyway, I'd expect truncation could be a more resilient way to handle this. David McLaughlin wrote: I think it's better to just give a clear message telling them there is a limit. Truncation could happen in the client if needed. Maxim Khutornenko wrote: I was considering a case when some automated external service would attempt to act on an update and append some arbitrary metadata with pause/resume/abort. While not desirable, does not necessarily warrant a failure. Stopping a misbehaving update should clearly be a higher priority than enforcing a strict audit mode. Bill Farner wrote: Maybe it does warrant a failure, though. IMHO truncation would be a policy decision that the scheduler is making on behalf of the client. If the most important part of the message is after the truncation, we've made a poor choice. Maxim Khutornenko wrote: IDK, this whole length enforcment seems quite arbitrary to me. We don't restrict string size anywhere in thrift API or SQL schema. The only exception is TaskIdGenerator where the ID length is critical for external reasons (MESOS-691). Perhaps we should start doing it everywhere then? Joshua Cohen wrote: If the requirement to restrict message length is not driven by the underlying store, is there any reason to enforce it at all? Could we just let clients truncate messages as appropriate to their use case? Are we concerned with abuse and/or performance impact? this whole length enforcment seems quite arbitrary to me I find this surprising. To me it seems reasonable to be defensive and protect a critical service from arbitary-length inputs. We don't restrict string size anywhere in thrift API or SQL schema We do in some places, and we used to in more. IMHO ideally we would do this in every place we have arbitrary input. If the requirement to restrict message length is not driven by the underlying store, is there any reason to enforce it at all? IMHO if a user can crash our service, we have failed. (There are obviously tradeoffs here.) In this case, i could cripple Aurora using this input. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76008 --- On March 11, 2015, 12:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 12:04 a.m.) Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- Add scheduler API support for audit messages when changing job updates. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift badb8eec51d9034fdfee79061c777927b2ba1314 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c0d48034ad6b6a91f1f58aca54544a5eddea4742 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 58824888a4839b71f4efa832a6d62ff6dd946e40 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7f5e5c2091458192d9310a81314f3c2c42b11f49 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java eebe01b161fbebdc43e62df4836136a02c3d5fb7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e119c494de8e81d7e2dd1f78337f08dcba3cd518 Diff: https://reviews.apache.org/r/31916/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76094 --- Ship it! LGTM modulo the outstanding question re: length limit. - Joshua Cohen On March 11, 2015, 12:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 12:04 a.m.) Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- Add scheduler API support for audit messages when changing job updates. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift badb8eec51d9034fdfee79061c777927b2ba1314 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c0d48034ad6b6a91f1f58aca54544a5eddea4742 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 58824888a4839b71f4efa832a6d62ff6dd946e40 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7f5e5c2091458192d9310a81314f3c2c42b11f49 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java eebe01b161fbebdc43e62df4836136a02c3d5fb7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e119c494de8e81d7e2dd1f78337f08dcba3cd518 Diff: https://reviews.apache.org/r/31916/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 48 https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48 Do we really want to fail an operation when a message gets too long? Since it's optional anyway, I'd expect truncation could be a more resilient way to handle this. David McLaughlin wrote: I think it's better to just give a clear message telling them there is a limit. Truncation could happen in the client if needed. Maxim Khutornenko wrote: I was considering a case when some automated external service would attempt to act on an update and append some arbitrary metadata with pause/resume/abort. While not desirable, does not necessarily warrant a failure. Stopping a misbehaving update should clearly be a higher priority than enforcing a strict audit mode. Bill Farner wrote: Maybe it does warrant a failure, though. IMHO truncation would be a policy decision that the scheduler is making on behalf of the client. If the most important part of the message is after the truncation, we've made a poor choice. Maxim Khutornenko wrote: IDK, this whole length enforcment seems quite arbitrary to me. We don't restrict string size anywhere in thrift API or SQL schema. The only exception is TaskIdGenerator where the ID length is critical for external reasons (MESOS-691). Perhaps we should start doing it everywhere then? Joshua Cohen wrote: If the requirement to restrict message length is not driven by the underlying store, is there any reason to enforce it at all? Could we just let clients truncate messages as appropriate to their use case? Are we concerned with abuse and/or performance impact? Bill Farner wrote: this whole length enforcment seems quite arbitrary to me I find this surprising. To me it seems reasonable to be defensive and protect a critical service from arbitary-length inputs. We don't restrict string size anywhere in thrift API or SQL schema We do in some places, and we used to in more. IMHO ideally we would do this in every place we have arbitrary input. If the requirement to restrict message length is not driven by the underlying store, is there any reason to enforce it at all? IMHO if a user can crash our service, we have failed. (There are obviously tradeoffs here.) In this case, i could cripple Aurora using this input. Circling back from offline discussion between myself, Maxim, and Joshua - we should aim to constrain these values at the edge of the system (thrift API) to provide useful error messages to users, and do so additionally in the database. I will proceed with this change as-is and follow up with an input validation layer in https://issues.apache.org/jira/browse/AURORA-1188 - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76008 --- On March 11, 2015, 12:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 12:04 a.m.) Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- Add scheduler API support for audit messages when changing job updates. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift badb8eec51d9034fdfee79061c777927b2ba1314 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c0d48034ad6b6a91f1f58aca54544a5eddea4742 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 58824888a4839b71f4efa832a6d62ff6dd946e40 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7f5e5c2091458192d9310a81314f3c2c42b11f49 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java eebe01b161fbebdc43e62df4836136a02c3d5fb7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e119c494de8e81d7e2dd1f78337f08dcba3cd518 Diff: https://reviews.apache.org/r/31916/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/#review76150 --- Ship it! Master (4ec563f) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 11, 2015, 10:22 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 10:22 p.m.) Review request for Aurora, David McLaughlin and Joshua Cohen. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- Add scheduler API support for audit messages when changing job updates. Diffs - api/src/main/thrift/org/apache/aurora/gen/api.thrift badb8eec51d9034fdfee79061c777927b2ba1314 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java c0d48034ad6b6a91f1f58aca54544a5eddea4742 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 78024a8c257f2d370a4b4d1ba79c6eac68d81ac2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 3d9ca4113514628e2ce5cdf9c715d7848bcdae47 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 7f5e5c2091458192d9310a81314f3c2c42b11f49 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java eebe01b161fbebdc43e62df4836136a02c3d5fb7 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 1f1e02eff254ac1b26e603da243c0dfc37049291 Diff: https://reviews.apache.org/r/31916/diff/ Testing --- Thanks, Bill Farner
Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76191
---
Master (f62e0f1) is red with this patch.
./build-support/jenkins/build.sh
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [gen]
01:37:22 00:00 [thrift][32m
Invalidated 4 targets containing 4 payload files.[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/test.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/thermos/thermos_internal.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/storage.thrift
[0m
01:37:22 00:00 [scrooge]
01:37:22 00:00 [protoc]
01:37:22 00:00 [antlr]
01:37:22 00:00 [ragel]
01:37:22 00:00 [jaxb]
01:37:23 00:01 [wire]
01:37:23 00:01 [aapt]
01:37:23 00:01 [resolve]
01:37:23 00:01 [ivy]
01:37:23 00:01 [bootstrap-nailgun-server]
01:37:23 00:01 [compile]
01:37:23 00:01 [compile]
01:37:23 00:01 [jvm]
01:37:23 00:01 [jvm-compilers]
01:37:23 00:01 [resources]
01:37:23 00:01 [prepare][32m
Invalidated 1 target containing 1 payload file.[0m
01:37:23 00:01 [test]
01:37:23 00:01 [run_prep_command]
01:37:23 00:01 [test]
01:37:23 00:01 [pytest]
01:37:25 00:03 [run]
[31m
FAILURE[0m
Exception message: Cannot satisfy requirements:
[Requirement.parse('py=1.4.25')]
I will refresh this build result if you post a review containing @ReviewBot
retry
- Aurora ReviewBot
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
---
(Updated March 12, 2015, 1:27 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
---
More plumbing.
Diffs
-
src/main/python/apache/aurora/client/api/__init__.py
4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py
37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py
60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py
70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py
d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py
370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
---
Thanks,
Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76193 --- @ReviewBot retry - Bill Farner On March 12, 2015, 1:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 12, 2015, 1:27 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-1077 https://issues.apache.org/jira/browse/AURORA-1077 Repository: aurora Description --- More plumbing. Diffs - src/main/python/apache/aurora/client/api/__init__.py 4025781963a61821d111e6347ae02d27459fd8cd src/main/python/apache/aurora/client/cli/update.py 37cc49880eab2ac0879945714634a4938b603aae src/main/python/apache/aurora/client/hooks/hooked_api.py 60a5aad7c3a7388154654673a6669c93be716635 src/test/python/apache/aurora/api_util.py 70599555c8b13073e51adee31662df74afe67edb src/test/python/apache/aurora/client/api/test_api.py d211fb975db01e72a88312c28078e06cb622d83c src/test/python/apache/aurora/client/cli/test_supdate.py 370a46b46d8fe9499468e0792f181e79e8042b61 Diff: https://reviews.apache.org/r/31966/diff/ Testing --- Thanks, Bill Farner
Re: Review Request 31966: Add client support for including messages when changing update state.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/#review76194 --- Master (f62e0f1) is red with this patch. ./build-support/jenkins/build.sh src.test.python.apache.aurora.client.cli.api . SUCCESS src.test.python.apache.aurora.client.cli.client . SUCCESS src.test.python.apache.aurora.client.cli.command_hooks . SUCCESS src.test.python.apache.aurora.client.cli.config . SUCCESS src.test.python.apache.aurora.client.cli.context . SUCCESS src.test.python.apache.aurora.client.cli.cron . SUCCESS src.test.python.apache.aurora.client.cli.inspect . SUCCESS src.test.python.apache.aurora.client.cli.job . SUCCESS src.test.python.apache.aurora.client.cli.plugins . SUCCESS src.test.python.apache.aurora.client.cli.quota . SUCCESS src.test.python.apache.aurora.client.cli.sla . SUCCESS src.test.python.apache.aurora.client.cli.supdate . SUCCESS src.test.python.apache.aurora.client.cli.task . SUCCESS src.test.python.apache.aurora.client.cli.update . SUCCESS src.test.python.apache.aurora.client.cli.version . SUCCESS src.test.python.apache.aurora.client.config . SUCCESS src.test.python.apache.aurora.client.factory . SUCCESS src.test.python.apache.aurora.client.hooks.hooked_api . FAILURE src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS src.test.python.apache.aurora.common.test_aurora_job_key . SUCCESS src.test.python.apache.aurora.common.test_cluster . SUCCESS src.test.python.apache.aurora.common.test_cluster_option . SUCCESS src.test.python.apache.aurora.common.test_clusters . SUCCESS src.test.python.apache.aurora.common.test_http_signaler . SUCCESS src.test.python.apache.aurora.common.test_pex_version . SUCCESS src.test.python.apache.aurora.common.test_shellify . SUCCESS src.test.python.apache.aurora.common.test_transport . SUCCESS src.test.python.apache.aurora.executor.common.path_detector . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.thermos.cli.commands.commands . SUCCESS src.test.python.apache.thermos.cli.common . SUCCESS src.test.python.apache.thermos.cli.main . SUCCESS src.test.python.apache.thermos.common.test_pathspec . SUCCESS src.test.python.apache.thermos.core.test_runner_integration . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS FAILURE [31m FAILURE[0m I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On March 12, 2015, 1:27 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31966/ --- (Updated March 12, 2015, 1:27 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Re: Review Request 31966: Add client support for including messages when changing update state.
On March 12, 2015, 1:38 a.m., Aurora ReviewBot wrote:
Master (f62e0f1) is red with this patch.
./build-support/jenkins/build.sh
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [deferred-sources]
01:37:22 00:00 [gen]
01:37:22 00:00 [thrift][32m
Invalidated 4 targets containing 4 payload
files.[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/test.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/internal_rpc.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/thermos/thermos_internal.thrift
[0m[32m
Generating thrift for
api/src/main/thrift/org/apache/aurora/gen/storage.thrift
[0m
01:37:22 00:00 [scrooge]
01:37:22 00:00 [protoc]
01:37:22 00:00 [antlr]
01:37:22 00:00 [ragel]
01:37:22 00:00 [jaxb]
01:37:23 00:01 [wire]
01:37:23 00:01 [aapt]
01:37:23 00:01 [resolve]
01:37:23 00:01 [ivy]
01:37:23 00:01 [bootstrap-nailgun-server]
01:37:23 00:01 [compile]
01:37:23 00:01 [compile]
01:37:23 00:01 [jvm]
01:37:23 00:01 [jvm-compilers]
01:37:23 00:01 [resources]
01:37:23 00:01 [prepare][32m
Invalidated 1 target containing 1 payload file.[0m
01:37:23 00:01 [test]
01:37:23 00:01 [run_prep_command]
01:37:23 00:01 [test]
01:37:23 00:01 [pytest]
01:37:25 00:03 [run]
[31m
FAILURE[0m
Exception message: Cannot satisfy requirements:
[Requirement.parse('py=1.4.25')]
I will refresh this build result if you post a review containing
@ReviewBot retry
fun
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76191
---
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/
---
(Updated March 12, 2015, 1:27 a.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1077
https://issues.apache.org/jira/browse/AURORA-1077
Repository: aurora
Description
---
More plumbing.
Diffs
-
src/main/python/apache/aurora/client/api/__init__.py
4025781963a61821d111e6347ae02d27459fd8cd
src/main/python/apache/aurora/client/cli/update.py
37cc49880eab2ac0879945714634a4938b603aae
src/main/python/apache/aurora/client/hooks/hooked_api.py
60a5aad7c3a7388154654673a6669c93be716635
src/test/python/apache/aurora/api_util.py
70599555c8b13073e51adee31662df74afe67edb
src/test/python/apache/aurora/client/api/test_api.py
d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py
370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
---
Thanks,
Bill Farner
