Re: Review Request 32329: Extract job key from RPC parameters

2015-03-25 Thread Joshua Cohen
On March 23, 2015, 8:59 p.m., Joshua Cohen wrote: Thanks, this is already much easier to follow. One general question on the overall approach: do you think the DRY benefits of using composed `StructFieldGetter`s to generate the functions that allow walking from the starting type to

Re: Review Request 32373: Add pesos executor build target

2015-03-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32373/ --- (Updated March 26, 2015, 1:06 a.m.) Review request for Aurora, Kevin Sweeney

Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Repository: aurora

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77838 --- Ship it! Please close

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:33 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 32373: Add pesos executor build target

2015-03-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32373/#review77840 --- Ship it! Master (68d2e47) is green with this patch.

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77841 --- Master (68d2e47) is red with this patch.

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77848 --- Master (68d2e47) is red with this patch.

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/ --- (Updated March 26, 2015, 1:55 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 32515: Kill inotify disk collector.

2015-03-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32515/#review77854 --- Master (68d2e47) is red with this patch.