Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43743
---


Could you describe a bit details on what changes submitted with the patch? 
Maybe it makes sense to internal folks at Twitter but not useful for new/ 
external people

- Henry Saputra


On May 22, 2014, 6 p.m., David McLaughlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21132/
 ---
 
 (Updated May 22, 2014, 6 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Bugs: AURORA-335
 https://issues.apache.org/jira/browse/AURORA-335
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Initial attempt at h2/DB storage implementation (LockStore only)
 
 
 Diffs
 -
 
   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
 db1bec4f508c8908f212aa541fb86e041a8c471c 
   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
 4b33fe5dd8223ff04060de0fe16b1c0759ead956 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
 c851eeb412b17097ff42abce2b7a42fc1c249013 
   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
 4d43f47de75a8bef06f106f563cc071df4cdf093 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 
 a6319f65bff07db66197e6476647117df6be5c9d 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 283976ab0554dbe6700bb0d2a1b7702c969227e8 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 53923627c827131ee4bd93e5c4865d042aee501b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 
 PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 
 PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 PRE-CREATION 
   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
 PRE-CREATION 
   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
 34377430268002e8e8e5bc803b409e092bb86720 
   src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 
 a5191500b2958253e14843089a15a1ffd58e6846 
 
 Diff: https://reviews.apache.org/r/21132/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David McLaughlin
 




Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread Henry Saputra


 On May 22, 2014, 6:06 p.m., Henry Saputra wrote:
  Could you describe a bit details on what changes submitted with the patch? 
  Maybe it makes sense to internal folks at Twitter but not useful for new/ 
  external people
 
 Kevin Sweeney wrote:
 This is the byproduct of a mailing list discussion here: 
 https://mail-archives.apache.org/mod_mbox/incubator-aurora-dev/201404.mbox/%3CCAGRA8uPKh81F3eCp%2Bf7fE84%2B2m%2ByzounTEcbhNpTaUFWqFt-Xw%40mail.gmail.com%3E

Thanks Kevin. So it is a byproduct or actual implementation of the discussions? 
It is still useful to add more context of what happening or desired behavior of 
the patch.


- Henry


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21132/#review43743
---


On May 22, 2014, 6 p.m., David McLaughlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21132/
 ---
 
 (Updated May 22, 2014, 6 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Maxim Khutornenko.
 
 
 Bugs: AURORA-335
 https://issues.apache.org/jira/browse/AURORA-335
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Initial attempt at h2/DB storage implementation (LockStore only)
 
 
 Diffs
 -
 
   build.gradle 6c758f690b87eede3ae3a7c54fabac20db543840 
   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
 bf3d7a36a575bb9d64f4dd851c63fbebda1e61b8 
   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java 
 db1bec4f508c8908f212aa541fb86e041a8c471c 
   src/main/java/org/apache/aurora/scheduler/storage/Storage.java 
 4b33fe5dd8223ff04060de0fe16b1c0759ead956 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/LockMapper.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationModule.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java 
 PRE-CREATION 
   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
 c851eeb412b17097ff42abce2b7a42fc1c249013 
   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
 4d43f47de75a8bef06f106f563cc071df4cdf093 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemLockStore.java 
 a6319f65bff07db66197e6476647117df6be5c9d 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 
 283976ab0554dbe6700bb0d2a1b7702c969227e8 
   src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorageModule.java 
 53923627c827131ee4bd93e5c4865d042aee501b 
   src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml 
 PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/LockMapper.xml 
 PRE-CREATION 
   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 
 PRE-CREATION 
   src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java 
 PRE-CREATION 
   src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
 34377430268002e8e8e5bc803b409e092bb86720 
   src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java 
 a5191500b2958253e14843089a15a1ffd58e6846 
 
 Diff: https://reviews.apache.org/r/21132/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 David McLaughlin
 




Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

Review request for Aurora.


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
c9e62f1efac9bee363133ff80e84f653352f42df 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
3dc15aded2743dd39ca307e1ab5589fa2e4507a3 
  

Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

Review request for Aurora.


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
c9e62f1efac9bee363133ff80e84f653352f42df 
  src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
3dc15aded2743dd39ca307e1ab5589fa2e4507a3 
  

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 23, 2014, 11:38 p.m.)


Review request for Aurora.


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
c9e62f1efac9bee363133ff80e84f653352f42df 
  

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 23, 2014, 11:38 p.m.)


Review request for Aurora.


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
c9e62f1efac9bee363133ff80e84f653352f42df 
  

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 23, 2014, 11:39 p.m.)


Review request for Aurora.


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 
c9e62f1efac9bee363133ff80e84f653352f42df 
  

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 23, 2014, 11:52 p.m.)


Review request for Aurora.


Changes
---

Update branch


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 24, 2014, 5:40 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

People += wfarner


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 

Re: Review Request 21882: AURORA-475 Remove the Apache Copyright rulez for style check.

2014-05-23 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21882/
---

(Updated May 24, 2014, 5:44 a.m.)


Review request for Aurora and Bill Farner.


Changes
---

People += wfarner


Bugs: AURORA-475
https://issues.apache.org/jira/browse/AURORA-475


Repository: aurora


Description
---

AURORA-475 Remove the Apache Copyright rulez for style check.


AURORA-475 Remove copyright header check Copyright with different year, like 
2014 and 2013.


AURORA-475 | Remove Copyright info from ASF license source header comment.


Diffs
-

  3rdparty/javascript/thrift.js bd3a488b3c9800e496723c94ecd7b65137845d90 
  3rdparty/python/BUILD fb154cae81fd7c2df991225a68a6097df99a8691 
  BUILD 29af3cdb3397a8b2e27011d0b353b5f48c62fcb1 
  LICENSE 1671a62a9e57d2e8b01b8fe063568601e8b47788 
  Vagrantfile f339368d963e9f25781102157e65f1fe7b6d6161 
  build-support/hooks/pre-commit 21e2b060bc6293d259f8da1d8ac75a214b74ac1a 
  build-support/isort a5378f1e976c043b23cde62ec5c2581757e35d4f 
  build-support/isort-check 4129deb322a1cf7dba32eeec31238cf70648356a 
  build-support/isort-run c528b9a45e0b9281e0e295b55b3cd762b14c8b07 
  build-support/jenkins/build.sh f6f4940a1450cd0d8d8497e651d0e6c7377dfc3f 
  build-support/pex e940e226e4a798fa688038ef8b992cfc83b1b36b 
  build-support/release/changelog 455473772bd93610cb28eefba738f88042aeab8e 
  build-support/release/make-python-sdists 
e3abd99b263dc170d558b0de0649480267434516 
  build-support/release/release 98105a7998322ef938858e923e966fedeb1aa7cd 
  build-support/release/release-candidate 
006f282dc1b69fd3709326408bd098794f418405 
  build-support/release/verify-release-candidate 
6aaed5ddcf2d1990718a905d11c53ad28fd3f09c 
  build-support/thrift/Makefile fa1b6eeff76b699f33d76cbc531c51a980ec6928 
  build-support/tools/list-missing-shipits 
db0dd03406572c0ee5d8d3593b8e9a6569deced7 
  build-support/virtualenv e2c1ec44e3c4613c94c13fa31b373b56ca2f2070 
  build.gradle d22038503a7bf894c335d8a446dbd936abf58516 
  config/checkstyle/apache.header 63212f7eb30dae1d76dcd19fbaacaaad66809ab4 
  config/checkstyle/apache.header.regex 
d100f20ff661d017c43b749aae9fa59cd0d32fa4 
  config/checkstyle/checkstyle.xml 367304ded273a00875e6a14249081085682b3b36 
  examples/scheduler/scheduler-local.sh 
9f77af7365c5f1953166cb50ce3903f0558cb79f 
  examples/vagrant/provision-dev-cluster.sh 
e9066e9b7ce37b3a61126b30fa822efe6fbb244e 
  examples/vagrant/test_tutorial.sh 0aad7060ac1c468c8d1a4047fa2a1a06cf758024 
  examples/vagrant/upstart/aurora-scheduler.conf 
f5ac4c8f4329f31ed2ea40892c5ace851910b1c3 
  examples/vagrant/upstart/aurora-thermos-observer.conf 
04e4cb68fc49c63396ec7410386d267c6ebfb983 
  examples/vagrant/upstart/mesos-master.conf 
fbec196673db3767accb080c74cb480498b10720 
  examples/vagrant/upstart/mesos-slave.conf 
6f766e8e6c91ed2a460c83b6c133c34b90903de1 
  examples/vagrant/upstart/zookeeper.conf 
3c9a0991f155dde623ed9de55c01cd039c4009e8 
  gradlew e9659bf9ee0b087a37328080dfbe26ff0cd6fc3b 
  pants 0cfacae25ee000bc984d1ae15da1649179d99eee 
  pants.ini e63df4f8670ec53203a0e04a1c2740ce5da51806 
  rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 
  src/main/java/org/apache/aurora/GuiceUtils.java 
d44cf6a2c6933f3cd62fe345272305719e2e5b45 
  src/main/java/org/apache/aurora/Protobufs.java 
1e2f078d3546e8686e56e1ad0aeacc1b9296b9b4 
  src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
c1c733d65108476f24beb40923533cc24f812f76 
  src/main/java/org/apache/aurora/auth/SessionValidator.java 
311ec8db808230b4fffecc8638de5bb0479a4a2e 
  src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
8a98400c7d1a3e5871933cdbe7b990e61db8c2ed 
  src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
85003b4065f7c48b7f772d4fbcfabea29b31740f 
  src/main/java/org/apache/aurora/scheduler/Driver.java 
ab5a300122bca6140cb44cbc7c5be5289696bcf4 
  src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
db864a070a6277d699841c047f4c3317e4cda7c6 
  src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
11571635ad87889ba6b49a8a6e2180cb66e60a00 
  src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
bdd8c19add724ba5a4c93b4c7850097431113c48 
  src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
c5a0f287d30ad23cd50b3c3cb64cf89b126a7c6d 
  src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
e7b1058bbc3f2b19d6c9c54fe4a04347920aafa8 
  src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
8d1c13c4ef4f74ac178efce0fe56afa6383467c5 
  src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
c85ad40cf7641eca03dbeb6ac3ee4093406ff0db 
  src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
5ce5453b8a2e9899e804e59efda1930830ed530d 
  src/main/java/org/apache/aurora/scheduler/TaskVars.java 
2ddfa87b7d92fd14ad99c218171d5ce5e81e7915 
  src/main/java/org/apache/aurora/scheduler/UserTaskLauncher.java 

Re: Review Request 21884: Fixup empty line from license headers.

2014-05-24 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21884/#review43893
---

Ship it!


Ship It!

- Henry Saputra


On May 24, 2014, 7:11 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21884/
 ---
 
 (Updated May 24, 2014, 7:11 a.m.)
 
 
 Review request for Aurora and Henry Saputra.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Realized after the fact that a013703 left an empty line in headers.  This 
 fixed them up.
 
 
 Diffs
 -
 
   3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 
   3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 
   BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 
   LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 
   Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 
   build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 
   build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 
   build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 
   build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd 
   build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 
   build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed 
   build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c 
   build-support/release/make-python-sdists 
 e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 
   build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 
   build-support/release/release-candidate 
 4443e48d74f9cefa84b1bf8263266c286c58d6e8 
   build-support/release/verify-release-candidate 
 906657f249f576a7182f90e54cbd675d81e7ab3f 
   build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 
   build-support/tools/list-missing-shipits 
 596dd0abe2d118cb8734e207baa21b09ca060518 
   build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 
   build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b 
   config/checkstyle/apache.header.regex 
 1bfe993a45fb25043d1475352f6c860629ac50d7 
   examples/scheduler/scheduler-local.sh 
 a80ccaec49c2194f9709409a494523e907acd8a6 
   examples/vagrant/provision-dev-cluster.sh 
 69b0d857247e5c57b5dd9df2eb00021d9c65029a 
   examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 
   examples/vagrant/upstart/aurora-scheduler.conf 
 f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc 
   examples/vagrant/upstart/aurora-thermos-observer.conf 
 be8d99e9159aae28e4c3b74857fc210e2ac1f6fc 
   examples/vagrant/upstart/mesos-master.conf 
 f3e98d2ed329d0a30f11fd52fe436d9e3172a740 
   examples/vagrant/upstart/mesos-slave.conf 
 59db0408624ccd15ef0408e6b16e511cf7bce72f 
   examples/vagrant/upstart/zookeeper.conf 
 ebdf29b43d58896be56563fb284a8cb8ce457057 
   gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa 
   pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 
   pants.ini b9b1db9b10684842f6038206fb932696dab0fedd 
   rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 4e873381d61f4d533553c2139a59ccc9807eb3c2 
   src/main/java/org/apache/aurora/Protobufs.java 
 c4527c725a47522e559eab540ecfa148a40fe36e 
   src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
 54099aea97adf0a82c049685d7945d43f8fe50e4 
   src/main/java/org/apache/aurora/auth/SessionValidator.java 
 ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 
   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
 03fdbc3b4c262412d916eb050de9e97daf1db9fd 
   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
 468151762344ce307dd3ec5e29f65fe3afe2a319 
   src/main/java/org/apache/aurora/scheduler/Driver.java 
 e88481b7842c018a8507461dfbb7e1b929a0e999 
   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
 20ee2a83ddbc47426c011ed35d79514d05edf64e 
   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
 2a67cd7f3458db9250b54b38cb6145e3aa9b164a 
   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
 ae751dcde4f39015f80991846e0814540582d325 
   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
 a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 dbe0a715680bbe3bd908efab7b630ba21ca50f2d 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea 
   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
 bc87e544b6d72e921287dc032d77a1c8ca143428 
   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
 c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 
   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
 379ef20dbf677521356525f58e4300c776b49fe3 
   src/main/java/org/apache/aurora/scheduler

Re: Review Request 21884: Fixup empty line from license headers.

2014-05-24 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21884/#review43894
---

Ship it!


+1

Thanks for the update patch, Bill. Need to sharpen my bash script-fu.

- Henry Saputra


On May 24, 2014, 7:11 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21884/
 ---
 
 (Updated May 24, 2014, 7:11 a.m.)
 
 
 Review request for Aurora and Henry Saputra.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Realized after the fact that a013703 left an empty line in headers.  This 
 fixed them up.
 
 
 Diffs
 -
 
   3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 
   3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 
   BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 
   LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 
   Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 
   build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 
   build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 
   build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 
   build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd 
   build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 
   build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed 
   build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c 
   build-support/release/make-python-sdists 
 e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 
   build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 
   build-support/release/release-candidate 
 4443e48d74f9cefa84b1bf8263266c286c58d6e8 
   build-support/release/verify-release-candidate 
 906657f249f576a7182f90e54cbd675d81e7ab3f 
   build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 
   build-support/tools/list-missing-shipits 
 596dd0abe2d118cb8734e207baa21b09ca060518 
   build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 
   build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b 
   config/checkstyle/apache.header.regex 
 1bfe993a45fb25043d1475352f6c860629ac50d7 
   examples/scheduler/scheduler-local.sh 
 a80ccaec49c2194f9709409a494523e907acd8a6 
   examples/vagrant/provision-dev-cluster.sh 
 69b0d857247e5c57b5dd9df2eb00021d9c65029a 
   examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 
   examples/vagrant/upstart/aurora-scheduler.conf 
 f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc 
   examples/vagrant/upstart/aurora-thermos-observer.conf 
 be8d99e9159aae28e4c3b74857fc210e2ac1f6fc 
   examples/vagrant/upstart/mesos-master.conf 
 f3e98d2ed329d0a30f11fd52fe436d9e3172a740 
   examples/vagrant/upstart/mesos-slave.conf 
 59db0408624ccd15ef0408e6b16e511cf7bce72f 
   examples/vagrant/upstart/zookeeper.conf 
 ebdf29b43d58896be56563fb284a8cb8ce457057 
   gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa 
   pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 
   pants.ini b9b1db9b10684842f6038206fb932696dab0fedd 
   rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 4e873381d61f4d533553c2139a59ccc9807eb3c2 
   src/main/java/org/apache/aurora/Protobufs.java 
 c4527c725a47522e559eab540ecfa148a40fe36e 
   src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
 54099aea97adf0a82c049685d7945d43f8fe50e4 
   src/main/java/org/apache/aurora/auth/SessionValidator.java 
 ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 
   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
 03fdbc3b4c262412d916eb050de9e97daf1db9fd 
   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
 468151762344ce307dd3ec5e29f65fe3afe2a319 
   src/main/java/org/apache/aurora/scheduler/Driver.java 
 e88481b7842c018a8507461dfbb7e1b929a0e999 
   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
 20ee2a83ddbc47426c011ed35d79514d05edf64e 
   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
 2a67cd7f3458db9250b54b38cb6145e3aa9b164a 
   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
 ae751dcde4f39015f80991846e0814540582d325 
   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
 a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 dbe0a715680bbe3bd908efab7b630ba21ca50f2d 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea 
   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
 bc87e544b6d72e921287dc032d77a1c8ca143428 
   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
 c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 
   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
 379ef20dbf677521356525f58e4300c776b49fe3

Re: Review Request 21884: Fixup empty line from license headers.

2014-05-24 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21884/#review43895
---

Ship it!


+1

Thanks for the update patch, Bill. Need to sharpen my bash script-fu.

- Henry Saputra


On May 24, 2014, 7:11 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/21884/
 ---
 
 (Updated May 24, 2014, 7:11 a.m.)
 
 
 Review request for Aurora and Henry Saputra.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Realized after the fact that a013703 left an empty line in headers.  This 
 fixed them up.
 
 
 Diffs
 -
 
   3rdparty/javascript/thrift.js 41405a21b7119828384ceb92dfca085091a4f265 
   3rdparty/python/BUILD 6011ec1d8d4240196867035e4024b25a2978ec26 
   BUILD cf1d5b65e7083629f396066cdcf7dc0e28ea1775 
   LICENSE 71b778a369a1b10c8d006fab2b9dc5b556198a04 
   Vagrantfile 57b9613216f549fc7052aaab7b458bf5af07d8d7 
   build-support/hooks/pre-commit 01be0e9ab03bd0496e4dd02a8554125bf47dc426 
   build-support/isort 656248284115c2de389f8d434883cc18e1eba5c1 
   build-support/isort-check 1d90bc0882f2a13e5644a11b9245b827c44df751 
   build-support/isort-run a4725e2ee22f8ae9934651c7cb5502833103dbfd 
   build-support/jenkins/build.sh 2895470b5f578dab19b2851355af3e7f8b727b41 
   build-support/pex 77c99e1c71090f404da3fdd5f0ec3893e1a6d7ed 
   build-support/release/changelog a92aee2e2126ea5b764ed92af41a0bb4ae9c9d0c 
   build-support/release/make-python-sdists 
 e51f937bf74eb6c4c09608f83ee7dc52f9ddff76 
   build-support/release/release 08372cec7faffaa1e37f940b1040d61fad35edb0 
   build-support/release/release-candidate 
 4443e48d74f9cefa84b1bf8263266c286c58d6e8 
   build-support/release/verify-release-candidate 
 906657f249f576a7182f90e54cbd675d81e7ab3f 
   build-support/thrift/Makefile 8d7099c1f9d1545b44277ae3b5b2338e239d8e12 
   build-support/tools/list-missing-shipits 
 596dd0abe2d118cb8734e207baa21b09ca060518 
   build-support/virtualenv 00ef972c050646a7406fd4a78beeafa90e6f0dc6 
   build.gradle 2a2761d73ee7ed2f501b8ca2238a5bf6e038596b 
   config/checkstyle/apache.header.regex 
 1bfe993a45fb25043d1475352f6c860629ac50d7 
   examples/scheduler/scheduler-local.sh 
 a80ccaec49c2194f9709409a494523e907acd8a6 
   examples/vagrant/provision-dev-cluster.sh 
 69b0d857247e5c57b5dd9df2eb00021d9c65029a 
   examples/vagrant/test_tutorial.sh b713e39401dee67fb4e7f4bfeabc3c460ef31031 
   examples/vagrant/upstart/aurora-scheduler.conf 
 f5a2687f4ff1506f4f8eb53c49bf0d4ef8a30dbc 
   examples/vagrant/upstart/aurora-thermos-observer.conf 
 be8d99e9159aae28e4c3b74857fc210e2ac1f6fc 
   examples/vagrant/upstart/mesos-master.conf 
 f3e98d2ed329d0a30f11fd52fe436d9e3172a740 
   examples/vagrant/upstart/mesos-slave.conf 
 59db0408624ccd15ef0408e6b16e511cf7bce72f 
   examples/vagrant/upstart/zookeeper.conf 
 ebdf29b43d58896be56563fb284a8cb8ce457057 
   gradlew da10ba6e08e30cb3cb0a45e2edef03e8143b55aa 
   pants 6873ecc15ed072c6c60a199900d84f12dfc4c6a4 
   pants.ini b9b1db9b10684842f6038206fb932696dab0fedd 
   rbt 41c91c9edcdd6d71581f4eb0b9cae66bd00cb8e4 
   src/main/java/org/apache/aurora/GuiceUtils.java 
 4e873381d61f4d533553c2139a59ccc9807eb3c2 
   src/main/java/org/apache/aurora/Protobufs.java 
 c4527c725a47522e559eab540ecfa148a40fe36e 
   src/main/java/org/apache/aurora/auth/CapabilityValidator.java 
 54099aea97adf0a82c049685d7945d43f8fe50e4 
   src/main/java/org/apache/aurora/auth/SessionValidator.java 
 ac9d2f5ae3ca381927c987044aabc1dd1d9ecaa9 
   src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java 
 03fdbc3b4c262412d916eb050de9e97daf1db9fd 
   src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 
 468151762344ce307dd3ec5e29f65fe3afe2a319 
   src/main/java/org/apache/aurora/scheduler/Driver.java 
 e88481b7842c018a8507461dfbb7e1b929a0e999 
   src/main/java/org/apache/aurora/scheduler/DriverFactory.java 
 20ee2a83ddbc47426c011ed35d79514d05edf64e 
   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java 
 2a67cd7f3458db9250b54b38cb6145e3aa9b164a 
   src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 
 ae751dcde4f39015f80991846e0814540582d325 
   src/main/java/org/apache/aurora/scheduler/ResourceSlot.java 
 a93f8a4834feb926c07ca4cb1a3d8fa25f755d53 
   src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java 
 dbe0a715680bbe3bd908efab7b630ba21ca50f2d 
   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
 4e3ae2968a23bfe2e23d88744ad5fb8542b558ea 
   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
 bc87e544b6d72e921287dc032d77a1c8ca143428 
   src/main/java/org/apache/aurora/scheduler/TaskLauncher.java 
 c70bf74dfeb55e070c1ede7fb0d5bf7a26c20b33 
   src/main/java/org/apache/aurora/scheduler/TaskVars.java 
 379ef20dbf677521356525f58e4300c776b49fe3

Re: Review Request 22032: first draft of a developing client v2 document.

2014-05-29 Thread Henry Saputra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22032/#review44289
---

Ship it!


Small nits but looks good overall. Will also you add remote debugging info for 
the scheduler in the developing-aurora-scheduler.md doc?


docs/developing-aurora-client.md
https://reviews.apache.org/r/22032/#comment78640

I think Kevin said that the gist already published to Pants's website/doc?



docs/developing-aurora-client.md
https://reviews.apache.org/r/22032/#comment78639

Missing space between Client and v2


- Henry Saputra


On May 29, 2014, 7:30 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/22032/
 ---
 
 (Updated May 29, 2014, 7:30 p.m.)
 
 
 Review request for Aurora, David McLaughlin and Henry Saputra.
 
 
 Bugs: aurora-20
 https://issues.apache.org/jira/browse/aurora-20
 
 
 Repository: aurora
 
 
 Description
 ---
 
 first draft of a developing client v2 document.
 
 
 Diffs
 -
 
   docs/developing-aurora-client.md PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/22032/diff/
 
 
 Testing
 ---
 
 n/a
 
 
 Thanks,
 
 Mark Chu-Carroll