Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
! - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68365 --- On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
/29942/diff/ Testing --- Ran/debug client in PyCharm. Previewed markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen

Re: Review Request 29984: Minor clean up to mock usage in resource manager integration tests.

2015-01-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29984/#review68754 --- @ReviewBoy retry - Joshua Cohen On Jan. 16, 2015, 9:45 p.m

Re: Review Request 29984: Minor clean up to mock usage in resource manager integration tests.

2015-01-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29984/#review68828 --- *ping* - Joshua Cohen On Jan. 16, 2015, 9:45 p.m., Joshua Cohen

Re: Review Request 29984: Minor clean up to mock usage in resource manager integration tests.

2015-01-20 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29984/#review68829 --- @ReviewBot retry - Joshua Cohen On Jan. 16, 2015, 9:45 p.m

Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Joshua Cohen
markdown doc changes here: https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md Thanks, Joshua Cohen

Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Joshua Cohen
/resources/org/apache/aurora/scheduler/http/utilization.st 73f86d51e9bb0179b774554718ad49ce00ba5487 Diff: https://reviews.apache.org/r/29971/diff/ Testing --- Verified styles were present when hitting those endpoints in vagrant. Thanks, Joshua Cohen

Re: Review Request 29971: Fix path to stylesheet in slaves and utilization templates.

2015-01-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29971/#review68477 --- @ReviewBot retry - Joshua Cohen On Jan. 16, 2015, 7:08 p.m

Review Request 29984: Minor clean up to mock usage in resource manager integration tests.

2015-01-16 Thread Joshua Cohen
/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a Diff: https://reviews.apache.org/r/29984/diff/ Testing --- ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration Thanks, Joshua Cohen

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Joshua Cohen
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote: I think we should leave the yaml code but drop the PyYAML dependency from the client requirements. (And inject it into the test -- possibly one test with and one test without to make sure the try/except also functions correctly.) I

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Joshua Cohen
/JobUpdateControllerImpl.java https://reviews.apache.org/r/30225/#comment117942 can drop the else? - Joshua Cohen On Feb. 11, 2015, 7:19 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-02-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225/#review72028 --- Ship it! Ship It! - Joshua Cohen On Feb. 11, 2015, 10:01 p.m

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-02-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review72065 --- Ship it! pending clean test run from review bot. - Joshua Cohen

Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

2015-02-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/#review72810 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 9:59 p.m

Review Request 31138: Add ability to pass configurable options to pytest.

2015-02-17 Thread Joshua Cohen
://reviews.apache.org/r/31138/diff/ Testing --- Ran build.sh before/after exporting PANTS_PYTEST_OPTIONS='-v' Thanks, Joshua Cohen

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review72858 --- Ship it! Ship It! - Joshua Cohen On Feb. 18, 2015, 1 a.m

Review Request 30950: Add the option to make a non-hooked API.

2015-02-12 Thread Joshua Cohen
test.pytest --no-fast src/test/python/apache/aurora/client:: Thanks, Joshua Cohen

Re: Review Request 30950: Add the option to make a non-hooked API.

2015-02-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30950/#review72249 --- On Feb. 12, 2015, 9:59 p.m., Joshua Cohen wrote: --- This is an automatically generated

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

2015-02-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72796 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 6 p.m., Bill

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

2015-02-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72801 --- Ship it! Ship It! - Joshua Cohen On Feb. 17, 2015, 9:49 p.m

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-01-28 Thread Joshua Cohen
familiar with the internals of the scheduler driven updates). - Joshua Cohen On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30225

Re: Review Request 30389: Deny attempts to create a job update with a non-service job.

2015-01-29 Thread Joshua Cohen
://reviews.apache.org/r/30389/#comment115321 Should we include the proper way to update a non-service job (kill/create) in this message? - Joshua Cohen On Jan. 29, 2015, 5:13 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
8fc3cb865fbcd467db91f4cb828d381a02ba7595 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- On Jan. 30, 2015, 7:04 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 7:04

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
8fc3cb865fbcd467db91f4cb828d381a02ba7595 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen

Re: Review Request 30249: Add CONTRIBUTING.md so github shows a link to it before opening a PR

2015-01-24 Thread Joshua Cohen
that it says something like, Please see [the contributing guidelines](docs/contributing.md) for details on how to contribute patches to Aurora. - Joshua Cohen On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote

Re: Review Request 30225: Modifying update controller to support heartbeats.

2015-01-27 Thread Joshua Cohen
update store, but I'm not sure how intensive an operation that will be (or the impact of performing it outside of the context of a lock). - Joshua Cohen On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
/30446/#review70393 --- On Jan. 30, 2015, 6:18 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
/scheduler/storage/testing/StorageTestUtil.java d492e176e73cbd2b3c696fc488010db16106b36a Diff: https://reviews.apache.org/r/30446/diff/ Testing --- ./gradlew build -Pq Thanks, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29770/diff/ Testing --- ./pants build src/test/python/apache/aurora/client:: Thanks, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67685 --- @ReviewBot retry - Joshua Cohen On Jan. 12, 2015, 6:56 p.m

Re: Review Request 29731: Service status endpoint.

2015-01-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29731/#review67337 --- Ship it! Ship It! - Joshua Cohen On Jan. 8, 2015, 11:47 p.m

Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
, Joshua Cohen

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
locally, it didn't crash on r28943 Thanks, Joshua Cohen

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing (updated) --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
/client/cli/test_plugins.py cf742a3feb12c6bb8fc6e80f15daaac7c2b2bf55 src/test/python/apache/aurora/client/cli/util.py 1fa1207d9380e57ac77d2aa24725b9ac39c83d4c Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
. This should fix those cases. Diffs - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- No... is there any way for me to test this? Thanks, Joshua Cohen

Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
://reviews.apache.org/r/29770/diff/ Testing --- ./pants build src/test/python/apache/aurora/client:: Thanks, Joshua Cohen

Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Joshua Cohen
: aurora Description --- Add build-support/rbtools to .gitignore Diffs - .gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb Diff: https://reviews.apache.org/r/29772/diff/ Testing --- $ git status Thanks, Joshua Cohen

Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Joshua Cohen
-mail. To reply, visit: https://reviews.apache.org/r/29772/#review67483 --- On Jan. 9, 2015, 6:47 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
/apache/aurora/client/cli/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29770/diff/ Testing --- ./pants build src/test/python/apache/aurora/client:: Thanks, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
/python/apache/aurora/client/cli/test_version.py PRE-CREATION Diff: https://reviews.apache.org/r/29770/diff/ Testing --- ./pants build src/test/python/apache/aurora/client:: Thanks, Joshua Cohen

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Joshua Cohen
://reviews.apache.org/r/29774/#comment111530 webUI here is inconsistent with web-ui on the previous line. Either one works, but it should be consistent. - Joshua Cohen On Jan. 9, 2015, 7:12 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- On Jan. 9, 2015, 7:38 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67514 --- Ship it! Ship It! - Joshua Cohen On Jan. 9, 2015, 8:51 p.m

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-06 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66909 --- *ping* - Joshua Cohen On Jan. 5, 2015, 7:07 p.m., Joshua Cohen

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Joshua Cohen
/thermos_executor_main.py https://reviews.apache.org/r/29828/#comment111832 nit: should this be 2 spaces, not 4? src/main/python/apache/aurora/executor/common/resource_manager.py https://reviews.apache.org/r/29828/#comment111831 Add license header to all these new files. - Joshua Cohen On Jan. 12, 2015, 11

Re: Review Request 29828: Patch ResourceManager into OSS Aurora.

2015-01-12 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29828/#review67749 --- Ship it! Ship It! - Joshua Cohen On Jan. 12, 2015, 11:40 p.m

Re: Review Request 29829: Fixed cleanup in end to end failure after v1 client removal

2015-01-12 Thread Joshua Cohen
: https://reviews.apache.org/r/29770/diff/# - Joshua Cohen On Jan. 12, 2015, 11:44 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29829

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
/29734/#review67336 --- On Jan. 9, 2015, 12:04 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29734

Re: Review Request 29734: Fix reviewbot to skip reviews that have no diffs.

2015-01-08 Thread Joshua Cohen
/) that has no diffs. This should fix those cases. Diffs (updated) - build-support/jenkins/review_feedback.py bd2c9941960645f662ec835c2baa4d1f3dae7d79 Diff: https://reviews.apache.org/r/29734/diff/ Testing --- Ran locally, it didn't crash on r28943 Thanks, Joshua Cohen

Re: Review Request 29770: Add support for --version flag to client.

2015-01-12 Thread Joshua Cohen
/python:all ./gradlew clean build Also ran e2e tests: bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen

Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
Diff: https://reviews.apache.org/r/30818/diff/ Testing --- ./gradlew jshint Verified push state worked in vagrant. Thanks, Joshua Cohen

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
Verified push state worked in vagrant. Thanks, Joshua Cohen

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joshua Cohen
/test_health_checker.py https://reviews.apache.org/r/30647/#comment117703 Why do we need these real timeouts? - Joshua Cohen On Feb. 6, 2015, 11:13 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30681/#review71841 --- Ship it! Ship It! - Joshua Cohen On Feb. 6, 2015, 5:07 p.m

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-10 Thread Joshua Cohen
-libraries.googlecode.com/git/javadoc/com/google/common/base/Optional.html#or(com.google.common.base.Supplier) - Joshua Cohen On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30681: docs: Expand Getting Started document

2015-02-10 Thread Joshua Cohen
On Feb. 10, 2015, 7:32 p.m., Joshua Cohen wrote: Ship It! Zameer Manji wrote: Don't forget to commit this. I had missed your earlier ship it. Will merge it now. - Joshua --- This is an automatically generated e-mail

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Joshua Cohen
change below, then I'll commit this. docs/user-guide.md https://reviews.apache.org/r/30985/#comment118483 the syntax for updating a range of shards in v2 is: aurora job update cluster/role/env/job/0-1 - Joshua Cohen On Feb. 13, 2015, 7:32 p.m., Florian Pfeiffer wrote

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72416 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 12:55 a.m

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/#review72446 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 10:18 p.m

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Joshua Cohen
s/received/are received s/provided/the provided s/gets blocked/will be blocked - Joshua Cohen On Feb. 13, 2015, 11:25 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72459 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 11:27 p.m

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72469 --- Ship it! Ship It! - Joshua Cohen On Feb. 14, 2015, 12:33 a.m

Re: Review Request 30818: Support separate routes for job controller tabs.

2015-02-09 Thread Joshua Cohen
092e7d5df2121f45f99f5a788187d52bebb7e5dd Diff: https://reviews.apache.org/r/30818/diff/ Testing (updated) --- ./gradlew jsHint Verified push state worked in vagrant. Thanks, Joshua Cohen

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/ --- (Updated Feb. 5, 2015, 1:46 a.m.) Review request for Aurora, Joshua Cohen and Bill Farner

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-05 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30647/#review71282 --- @ReviewBot retry - Joshua Cohen On Feb. 5, 2015, 7:17 p.m

Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
://reviews.apache.org/r/29586/diff/ Testing --- ./pants build src/test/python/apache/aurora:all bash src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Joshua Cohen

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
/test_end_to_end.sh Thanks, Joshua Cohen

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
afaict). - Joshua --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29586/#review66685 --- On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote

Re: Review Request 29586: Replace twitter.common.python dependency with a direct pex dependency (at the latest version).

2015-01-05 Thread Joshua Cohen
://reviews.apache.org/r/29586/#review66687 --- On Jan. 5, 2015, 7:07 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Joshua Cohen
to be a factory function that returned the sandbox, now you're passing in the sandbox itself? Why the change? - Joshua Cohen On Jan. 5, 2015, 8:25 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 29698: Simplify client help output to solely use argparse.

2015-01-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29698/#review67238 --- Ship it! Ship It! - Joshua Cohen On Jan. 8, 2015, 3:33 a.m

Review Request 29674: Fix user agent support for DirectSchedulerClient.

2015-01-07 Thread Joshua Cohen
/client/api/test_scheduler_client.py a3a40b728d7fb31c681bb684c4613f3ad20c4538 Diff: https://reviews.apache.org/r/29674/diff/ Testing --- ./pants build src/test/python/apache/aurora/client/api:scheduler_client Thanks, Joshua Cohen

Re: Review Request 29698: Simplify client help output and solely use argparse.

2015-01-08 Thread Joshua Cohen
/29698/#comment111288 The cron commands are implemented now, right? Can we just kill these lines? - Joshua Cohen On Jan. 8, 2015, 8:32 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 29696: Fix bad call to print_out causing 'job inspect --raw' to fail.

2015-01-08 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29696/#review67272 --- Ship it! Ship It! - Joshua Cohen On Jan. 8, 2015, 7:46 p.m

Re: Review Request 32078: Remove the populatedDEPRECATED thrift field.

2015-03-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32078/#review76594 --- Ship it! Ship It! - Joshua Cohen On March 16, 2015, 5:39 p.m

Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager

2015-03-17 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32175/#review76828 --- Ship it! Ship It! - Joshua Cohen On March 17, 2015, 9:59 p.m

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Joshua Cohen
/AnnotatedAuroraAdmin.java https://reviews.apache.org/r/32141/#comment124452 Can you add a corresponding comment to api.thrift that any new methods (or parameters?) added should be added (or updated?) here. - Joshua Cohen On March 17, 2015, 7:41 p.m., Kevin Sweeney wrote

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Joshua Cohen
On March 17, 2015, 7:56 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java, line 39 https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39 Can you add a corresponding comment to api.thrift that any new methods

Re: Review Request 32161: Create a packer definition to build a base vagrant box.

2015-03-17 Thread Joshua Cohen
before this change to 3m16s afterwards. Overall +1 on this, but I definitely think we need to add a README in the packer directory to explain what's going on, how to build/upload a new box, etc. - Joshua Cohen On March 17, 2015, 4:23 p.m., Bill Farner wrote

Re: Review Request 32319: Add a deprecation warning when using the client-side updater.

2015-03-20 Thread Joshua Cohen
, 2015, 10:27 p.m.) Review request for Aurora and Joshua Cohen. Bugs: AURORA-1190 https://issues.apache.org/jira/browse/AURORA-1190 Repository: aurora Description --- See summary. Diffs - src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Joshua Cohen
https://reviews.apache.org/r/32313/#comment125167 Can we assert `self._mock_api.start_job.mock_calls = [call(...)]` instead? - Joshua Cohen On March 20, 2015, 8:23 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 32313: Rename 'update status' to 'update info' and support fetching arbitrary updates.

2015-03-20 Thread Joshua Cohen
https://reviews.apache.org/r/32313/#comment125174 Yes, let us add stuff! Stuff is great and junk! - Joshua Cohen On March 20, 2015, 10:31 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32118/#review76629 --- Ship it! Ship It! - Joshua Cohen On March 16, 2015, 6:54 p.m

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Joshua Cohen
On March 7, 2015, 12:01 a.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 200 https://reviews.apache.org/r/31814/diff/1/?file=888014#file888014line200 The original scope for AURORA-1077 was to allow for passing

Re: Review Request 31862: Fix preformatted text when viewed on github

2015-03-09 Thread Joshua Cohen
Mind adding `shell` to these blocks? - Joshua Cohen On March 9, 2015, 5:47 p.m., Brian Brazil wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31862

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31814/#review75722 --- Ship it! Ship It! - Joshua Cohen On March 7, 2015, 1:06 a.m

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Joshua Cohen
commenting? - Joshua Cohen On March 7, 2015, 12:54 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-12 Thread Joshua Cohen
/#comment123260 Same here, seems unrelated? Does this just need to be rebased? - Joshua Cohen On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-11 Thread Joshua Cohen
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated March 11, 2015, 12:04 a.m.) Review request for Aurora, David McLaughlin and Joshua Cohen

Re: Review Request 31916: Add scheduler API support for audit messages when changing job updates.

2015-03-11 Thread Joshua Cohen
. - Joshua Cohen On March 11, 2015, 12:04 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31916/ --- (Updated

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Joshua Cohen
On March 13, 2015, 7:59 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 95 https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95 I thought it's generally preferable when installing user-supplied

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-25 Thread Joshua Cohen
On March 23, 2015, 8:59 p.m., Joshua Cohen wrote: Thanks, this is already much easier to follow. One general question on the overall approach: do you think the DRY benefits of using composed `StructFieldGetter`s to generate the functions that allow walking from the starting type

Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Joshua Cohen
--- Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews. Diffs - .reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5 Diff: https://reviews.apache.org/r/31546/diff/ Testing --- Posted this review. Thanks, Joshua Cohen

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Joshua Cohen
for doing this! - Joshua Cohen On March 3, 2015, 8:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31248/#review73603 --- Ship it! Ship It! - Joshua Cohen On Feb. 21, 2015, 6:33 p.m

Re: Review Request 31248: Export stats for source and reason for LOST tasks, and status delivery latency.

2015-02-23 Thread Joshua Cohen
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote: Can you fill in testing done? Bill Farner wrote: Honest question - do you find that useful for changes like this? I find it redundant to always type `./gradlew build -Pq`, especially since the build bot will do that anyhow. My

<    1   2   3   4   >