Re: Review Request 25337: Preserve executor HealthCheckerThread name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52318 --- Ship it! Ship It! - Zameer Manji On Sept. 4, 2014, 3:50 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 3:50 a.m.) Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-682 https://issues.apache.org/jira/browse/AURORA-682 Repository: aurora Description --- Preserve executor HealthCheckerThread name Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676 Diff: https://reviews.apache.org/r/25337/diff/ Testing --- [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor/common:health_checker Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/executor/common/BUILD, health_checker)]) test session starts = platform darwin -- Python 2.7.8 -- py-1.4.23 -- pytest-2.6.1 plugins: cov, timeout collected 4 items src/test/python/apache/aurora/executor/common/test_health_checker.py == 4 passed in 1.54 seconds == src.test.python.apache.aurora.executor.common.health_checker . SUCCESS Tests in vagrant image Thanks, Joe Smith
Re: Review Request 25356: Add a factory to produce OneWayUpdate instances based on job state and update settings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25356/#review52361 --- Ship it! Ship It! - Zameer Manji On Sept. 4, 2014, 2:19 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25356/ --- (Updated Sept. 4, 2014, 2:19 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description --- This is the bridge between the top-level updater logic and the OneWayJobUpdater - taking a user request and the direction we've decided to move the job (forward or back), produce the appropriate OneWayJobUpdater. Diffs - src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 85196af38b6615e5aac7de30a4a601350e935c72 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java aa8b5f2ee81d42db003f27e682f79e94b6625d87 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java dca55ef5612105c9dc8fd57e789fdf1df28ba447 src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java d7baaa679289998a9ea80c0934990a49e5c173d7 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactoryImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java e3e50d7d6526e8796dc5cd82b459190b09ceb72f Diff: https://reviews.apache.org/r/25356/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Review Request 25366: Set principal field in FrameworkInfo struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25366/ --- Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-687 https://issues.apache.org/jira/browse/AURORA-687 Repository: aurora Description --- Set principal field in FrameworkInfo struct. Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e Diff: https://reviews.apache.org/r/25366/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25366/ --- (Updated Sept. 4, 2014, 4:36 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Changes --- Use .getProperty Bugs: AURORA-687 https://issues.apache.org/jira/browse/AURORA-687 Repository: aurora Description --- Set principal field in FrameworkInfo struct. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e Diff: https://reviews.apache.org/r/25366/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 25337: Preserve executor HealthCheckerThread name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52387 --- src/test/python/apache/aurora/executor/test_thermos_executor.py https://reviews.apache.org/r/25337/#comment91167 I don't think this is supposed to be here. - Zameer Manji On Sept. 4, 2014, 5:24 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/ --- (Updated Sept. 4, 2014, 5:24 p.m.) Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman. Bugs: AURORA-682 https://issues.apache.org/jira/browse/AURORA-682 Repository: aurora Description --- Preserve executor HealthCheckerThread name Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676 src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54 Diff: https://reviews.apache.org/r/25337/diff/ Testing --- ###STILL RUNNING E2E TESTS [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all src.test.python.apache.aurora.executor.common.announcer . SUCCESS src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS src.test.python.apache.aurora.executor.common.executor_timeout . SUCCESS src.test.python.apache.aurora.executor.common.health_checker . SUCCESS src.test.python.apache.aurora.executor.common.status_checker . SUCCESS src.test.python.apache.aurora.executor.common.task_info . SUCCESS src.test.python.apache.aurora.executor.executor_base . SUCCESS src.test.python.apache.aurora.executor.executor_detector . SUCCESS src.test.python.apache.aurora.executor.executor_vars . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.status_manager . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith
Review Request 25483: Transaction all SQL under MemStorage
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25483/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Summary (updated) - Transaction all SQL under MemStorage Bugs: AURORA-694 https://issues.apache.org/jira/browse/AURORA-694 Repository: aurora Description (updated) --- This commit ensures all delegated tables are accessed via a transaction via MemStorage. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java d7d350ee85510e75804322ebf6a877e35bf8d0d3 src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java a042fa9abe23ad102c54615eebc007964fb053da Diff: https://reviews.apache.org/r/25483/diff/ Testing (updated) --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 25519: Adding get_scheduler admin command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52929 --- Ship it! Thanks for doing this so quickly. - Zameer Manji On Sept. 10, 2014, 12:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/ --- (Updated Sept. 10, 2014, 12:53 p.m.) Review request for Aurora, Mark Chu-Carroll and Zameer Manji. Bugs: AURORA-692 https://issues.apache.org/jira/browse/AURORA-692 Repository: aurora Description --- Adding get_scheduler admin command. Diffs - src/main/python/apache/aurora/client/api/scheduler_client.py 0ba07611b1a367f7157b91a1d4b65b1af176 src/main/python/apache/aurora/client/commands/admin.py bc9a9eee9a187f2c895e70a093871f0b795931c4 src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081 src/test/python/apache/aurora/client/commands/test_admin.py 94e736fb80c3fd7f103437c24f33d7c4451a6969 src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a Diff: https://reviews.apache.org/r/25519/diff/ Testing --- ./pants src/test/python:all Thanks, Maxim Khutornenko
Re: Review Request 25505: Make aurora job status JSON output more friendly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/#review52930 --- Ship it! Ship It! - Zameer Manji On Sept. 10, 2014, 12:34 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25505/ --- (Updated Sept. 10, 2014, 12:34 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: aurora-666 https://issues.apache.org/jira/browse/aurora-666 Repository: aurora Description --- Use string names instead of numeric values for ScheduleStatus fields of records rendered in JSON. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 38b5f6e306c2c8dd9aa8d98e21c6a628028ad899 src/test/python/apache/aurora/client/cli/test_status.py 721d9764190bdc4b1c5b65e416a039803b7c507c Diff: https://reviews.apache.org/r/25505/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25543: Update to pants 0.0.23.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/#review53048 --- Ship it! Ship It! - Zameer Manji On Sept. 11, 2014, 9:13 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/ --- (Updated Sept. 11, 2014, 9:13 a.m.) Review request for Aurora, Joe Smith and Brian Wickman. Bugs: aurora-695 https://issues.apache.org/jira/browse/aurora-695 Repository: aurora Description --- - Update build files for the new syntax, which no longer requires 'pants(...)' around target names. - Remove no-longer-supported timeout from python_tests. Diffs - pants 4f9c351888afa1a779415730240093c3dee25dfb src/main/python/apache/aurora/admin/BUILD 7a100d1a4a74aae034082f34db051c9cc31f8540 src/main/python/apache/aurora/client/BUILD bf196bf86b36db0d72f8e096260c9a900f74d07c src/main/python/apache/aurora/client/api/BUILD 70ad38e34f14c6d54b71c8f4b2138f085658110e src/main/python/apache/aurora/client/bin/BUILD 43d747956df0611b0880f64df9955d5f5806901c src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/commands/BUILD cc16923909a7b26b0f3ac0b47bb37dafdbbf502e src/main/python/apache/aurora/client/hooks/BUILD 9471c4cba5175296030747301e246a65a39aa203 src/main/python/apache/aurora/common/BUILD b879b15127d6691b35880074fd0ceacd866a61ed src/main/python/apache/aurora/common/auth/BUILD 7e96cb2258711b2e2925d18ad9435fa986e86bca src/main/python/apache/aurora/config/BUILD 4f8fad80114ddabac8b25f70bba00119228ec675 src/main/python/apache/aurora/config/schema/BUILD 69d60aebd2a9aa353497406ae578a9997323b07e src/main/python/apache/aurora/executor/BUILD 1ad8f82cdce85cf228c53e088171918e36ed536d src/main/python/apache/aurora/executor/bin/BUILD aeb8aee6f50a0d89714626e933699c0a13b363d9 src/main/python/apache/aurora/executor/common/BUILD 335ebc4809096c5f128846cd846d33910a777968 src/main/python/apache/thermos/BUILD 0dc035f759dd9949997f0c979b3556a350cf8df7 src/main/python/apache/thermos/bin/BUILD 669f9930a3590184dc0f8b5c15c36168e715eb03 src/main/python/apache/thermos/common/BUILD 6015f9e9a23f71bf6dede1f4698fe63dbb4dcfaa src/main/python/apache/thermos/config/BUILD 0531f92ea569ffe36817b645a17fab7a712e5897 src/main/python/apache/thermos/core/BUILD 0d1d339d55ee6a569297614ac734661e5caf7ea4 src/main/python/apache/thermos/monitoring/BUILD 79da0d5cef9436d4a3d83075910decfc93e422a6 src/main/python/apache/thermos/observer/BUILD 49b844ffc1b1d5911fc28d14294d088c3d0b6e4b src/main/python/apache/thermos/observer/bin/BUILD 044ca66b18282daf17a4198ff369d954e14c9b6d src/main/python/apache/thermos/observer/http/BUILD 901ad9c61e4dd1c61f5fbf4467becb8c881a64ed src/main/python/apache/thermos/testing/BUILD dc328a63788381307576b5a43ecdc704bb764473 src/main/thrift/org/apache/aurora/gen/BUILD 947504ec1f9582496952b23e66d7f5f20a168ce7 src/test/python/BUILD f01efff2e4982a475221b5739dfe1e8fd1a41d92 src/test/python/apache/aurora/BUILD 6555b984a713ef786aef5688b206ae9d8017c48d src/test/python/apache/aurora/admin/BUILD 5e170d6c15a95e2511b69e18a255d7364c2e7a4d src/test/python/apache/aurora/client/BUILD 831a72d39b27ca2aca466a38914bbf40ff94 src/test/python/apache/aurora/client/api/BUILD b4f08c6192e6bf6b38665197e98db7235751ae86 src/test/python/apache/aurora/client/cli/BUILD e1f9ebf96774b8f5c75de8570c6ba87d953ab649 src/test/python/apache/aurora/client/commands/BUILD 17933dedfa08c9d12c369087bf801e7c35cdde9b src/test/python/apache/aurora/client/hooks/BUILD f7856a2d5dc7e5d1edc480f64d5db97d88c71b70 src/test/python/apache/aurora/common/BUILD e949ba8859d5567c62623bec9d5ba86a8463fbaa src/test/python/apache/aurora/config/BUILD 37bbd27e13a2a3589faff7285f04e3c44ca57eeb src/test/python/apache/aurora/executor/BUILD 4d43e256ad131223cc1ac36a406d42a979a8a2dd src/test/python/apache/aurora/executor/common/BUILD 7d8934046b56ac2c0c16440cfc571dc370767a14 src/test/python/apache/thermos/BUILD cb93a4622e33ef96855b89a7c138f42033368950 src/test/python/apache/thermos/bin/BUILD 4b59f3879298de9664f168150ea9029e013e7913 src/test/python/apache/thermos/common/BUILD 36fa6a69b5e77a645a65c52fef6ec9343bf541bc src/test/python/apache/thermos/config/BUILD 42445ceccba8dfe8296a22a174aca6123bdfdb52 src/test/python/apache/thermos/core/BUILD 8f5c626c2e89834dbb4938c3c69ef8c79558e12b src/test/python/apache/thermos/monitoring/BUILD ea4005b52be3185e553f7d23fb29b89f68befa50 Diff: https://reviews.apache.org/r/25543/diff
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53073 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java https://reviews.apache.org/r/25481/#comment92464 I'm a little unfamilar with JobUpdateRequest and this RPC but it seems we should update StartJobUpdateResult to have a message field that we can surface to the user? - Zameer Manji On Sept. 9, 2014, 12:46 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 9, 2014, 12:46 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25529: Add a controller for job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53075 --- This matches the logic previously explained to me, but the diff is pretty large. Once my questions are answered I'll take another look before giving a ship it. build.gradle https://reviews.apache.org/r/25529/#comment92465 Is this needed? If so please break it out of this change. src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java https://reviews.apache.org/r/25529/#comment92477 Would it be a bad idea to encapsulate this into a InstanceName class that contains the logic for constructing one from JobKey + instanceId and how to render it to a String? It seems like a bit of overkill but I dislike the + / in the code. src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java https://reviews.apache.org/r/25529/#comment92481 Just to be clear, currently-active updaters are also persisted in storage right? src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java https://reviews.apache.org/r/25529/#comment92483 Shouldn't this just be FAILED? src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java https://reviews.apache.org/r/25529/#comment92484 How are these errors going to be surfaced to the user? - Zameer Manji On Sept. 10, 2014, 9:53 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/ --- (Updated Sept. 10, 2014, 9:53 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Zameer Manji. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description --- There's a lot going on here, i'm happy to break this up if you'd perfer, but the bulk of the change (JobUpdateControllerImpl+Test) would remain. The remaining required piece here is to record JobInstanceUpdateEvents when actions are taken. As you try to follow JobUpdateControllerImplTest, take some care to understand how FakeScheduledExecutor works. Ultimately, it accepts work added to a mock, and executes that work when FakeClock is advanced past the scheduled time. It may not be obvious at first, but be glad it's there - this kind of async test would be a nightmare without it. Diffs - build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java aaa3513ae99c70ffa51fec0a241d67fb815b6d3f src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346 src/main/java/org/apache/aurora/scheduler/base/Query.java d8572bb21a92025e7a51cf18d5bdf00fc1281078 src/main/java/org/apache/aurora/scheduler/base/Tasks.java 1be16374aeebaee59063aec982690ffa1fbdcf0f src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java b894a71348d2d71c077f35bb21a80ba88a6b4c42 src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 599dbd8bb762d051b75aa1a1e4d6a4c90ca6eb87 src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java ec9b37ccaf03651e986aab9b4541f17ff0540008 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java d725bc356178f51464b4d8ea896f1bf76815e1b2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 39bdca02295706714cf720545ffc291f9042702a src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 3f542ce3e45ec4561238736f4ce84b69f7e41219 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 7be792f0bc9c5ec14c7001cb243a17d643f9607f src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 037602d6aabe6dda978cad008075c053e2c042eb src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java d6a1e4b2c916b1c4dbcc73fe79bd672fca9b3189 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java 80baa7f9360cc8b2bf7910c26d119d443d6cbbf9 src/main/java/org/apache/aurora/scheduler/updater/UpdateConfigurationException.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 028cb079316ca48bb93a35913ae25ace78088fb4 src/main/java/org/apache/aurora/scheduler
Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/#review53181 --- Ship it! Ship It! - Zameer Manji On Sept. 12, 2014, 7:34 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/ --- (Updated Sept. 12, 2014, 7:34 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-706 https://issues.apache.org/jira/browse/aurora-706 Repository: aurora Description --- Fix error in client task ssh command when the job isn't found. Diffs - src/main/python/apache/aurora/client/cli/task.py 91175facdc8c9fd59ab66781f86ee8b5940a src/main/python/apache/aurora/client/commands/ssh.py 37a90089b72b86c82466f1819e7881a36bb2f214 src/test/python/apache/aurora/client/cli/test_task_run.py 8d9ef0543c1ab514d6f039ba63a1d417a4a90a1b src/test/python/apache/aurora/client/commands/test_ssh.py 4070b710b005c91fe08dd7906cd93bf3a8cdba9e Diff: https://reviews.apache.org/r/25582/diff/ Testing --- Added new tests to catch this case; Ran all client unit tests, all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25671: Instruct thrift to generate private fields in java.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/#review53435 --- Ship it! Ship It! - Zameer Manji On Sept. 15, 2014, 4:02 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25671/ --- (Updated Sept. 15, 2014, 4:02 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- This more closely matches our encapsulation elsewhere in the codebase, and makes for simpler refactoring in the future. Diffs - build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java bfca1d9776fea1259eb46ae61be08b5c9082d769 src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java e3c20cbafffb6f9f614b42fc2379f1239e182161 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fedba15792ff2ecf55922ce5c38b85ada2a9edf4 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cf9805155f0e17b75db9ef8edd4b805826107868 src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java f100ada567e3a0945af00c78c84f72c86e1bfb99 Diff: https://reviews.apache.org/r/25671/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25529: Add a controller for job updates.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53598 --- I'm tapping out of this review. I don't have enough knowledge to give a ship to this change. - Zameer Manji On Sept. 15, 2014, 5:39 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/ --- (Updated Sept. 15, 2014, 5:39 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Zameer Manji. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description --- There's a lot going on here, i'm happy to break this up if you'd perfer, but the bulk of the change (JobUpdateControllerImpl+Test) would remain. The remaining required piece here is to record JobInstanceUpdateEvents when actions are taken. As you try to follow JobUpdateControllerImplTest, take some care to understand how FakeScheduledExecutor works. Ultimately, it accepts work added to a mock, and executes that work when FakeClock is advanced past the scheduled time. It may not be obvious at first, but be glad it's there - this kind of async test would be a nightmare without it. Diffs - build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3 src/main/java/org/apache/aurora/scheduler/async/RescheduleCalculator.java aaa3513ae99c70ffa51fec0a241d67fb815b6d3f src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/base/Jobs.java 7b10cf876d4424fab06113aa3e2989a6bef4d346 src/main/java/org/apache/aurora/scheduler/base/Query.java d8572bb21a92025e7a51cf18d5bdf00fc1281078 src/main/java/org/apache/aurora/scheduler/base/Tasks.java 1be16374aeebaee59063aec982690ffa1fbdcf0f src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java f9521f9599e2d26cf594d62fc6b6f6ca3d5fb108 src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java 6a97f36a69c7723ec1c3730085d0df70f94dcac8 src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java c520e1378c4b7947bb866011027b79b4ab65547c src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java 87b773ba80784e4af8cd78790c373c08e26e src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java fedba15792ff2ecf55922ce5c38b85ada2a9edf4 src/main/java/org/apache/aurora/scheduler/updater/InstanceAction.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java d725bc356178f51464b4d8ea896f1bf76815e1b2 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 39bdca02295706714cf720545ffc291f9042702a src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 3f542ce3e45ec4561238736f4ce84b69f7e41219 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 7be792f0bc9c5ec14c7001cb243a17d643f9607f src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 037602d6aabe6dda978cad008075c053e2c042eb src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java d6a1e4b2c916b1c4dbcc73fe79bd672fca9b3189 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java 80baa7f9360cc8b2bf7910c26d119d443d6cbbf9 src/main/java/org/apache/aurora/scheduler/updater/UpdateConfigurationException.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/UpdaterModule.java 028cb079316ca48bb93a35913ae25ace78088fb4 src/main/java/org/apache/aurora/scheduler/updater/strategy/ActiveLimitedStrategy.java 8298ea2283298daa71de4d958ca6bb0898d47531 src/main/java/org/apache/aurora/scheduler/updater/strategy/BatchStrategy.java a3e666e85993b833a4765ce0ad5f4825dc9253e8 src/main/java/org/apache/aurora/scheduler/updater/strategy/QueueStrategy.java 0cf36839dbf64ad755383bef829e14fd94a97e30 src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java af644a967983b8da66231390d29839a034697852 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java cf9805155f0e17b75db9ef8edd4b805826107868 src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/EnumsTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/FakeScheduledExecutor.java PRE-CREATION src/test/java/org
Re: Review Request 25815: Improve performance of fetching host attributes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/#review53989 --- Ship it! Ship It! - Zameer Manji On Sept. 19, 2014, 11:42 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25815/ --- (Updated Sept. 19, 2014, 11:42 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-730 https://issues.apache.org/jira/browse/AURORA-730 Repository: aurora Description --- This patch enables the MyBatis 2nd level cache [1] for the AttributeMapper namespace. Based on some ad-hoc local benchmarking, this improves performance by about 50x (when the cache is primed). MyBatis flushes these caches on insert/update, so it's important we don't unnecessarily write to the table. For this reason, I've also suppressed no-op writes. [1] http://mybatis.github.io/mybatis-3/sqlmap-xml.html#cache Diffs - src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 1b18ad5ab8e640d64f5de0aebdc98d0f8dc411c2 src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml 53017c8806d2a5cdd1d181fd156afc9afca2faf7 src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 4a31999559dce4cfe50b22fc97d1500c9528a242 Diff: https://reviews.apache.org/r/25815/diff/ Testing --- ./gradlew build -Pq Lacking a story for performance testing, i failed to come up with a good way to prove that these help. Best answer i have is local testing (creating a store with ~20k attributes and issuing 1M random queries is repeatably ~50x faster), and 100% line/branch test coverage to prove we hit the no-op exit. Thanks, Bill Farner
Re: Review Request 25835: Serve HTTP assets out of a standard classpath root.
/unit/directivesSpec.js 3rdparty/javascript/bower_components/smart-table/test/unit/filtersSpec.js 3rdparty/javascript/bower_components/underscore/.bower.json 3rdparty/javascript/bower_components/underscore/.editorconfig 3rdparty/javascript/bower_components/underscore/.gitignore 3rdparty/javascript/bower_components/underscore/LICENSE 3rdparty/javascript/bower_components/underscore/README.md 3rdparty/javascript/bower_components/underscore/bower.json 3rdparty/javascript/bower_components/underscore/component.json 3rdparty/javascript/bower_components/underscore/package.json 3rdparty/javascript/bower_components/underscore/underscore.js 3rdparty/javascript/thrift.js build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 392b4f7bc9d5352ed536ff83eafb4175e4860aa1 src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora.png src/main/resources/org/apache/aurora/scheduler/http/assets/images/aurora_logo.png src/main/resources/org/apache/aurora/scheduler/http/assets/images/viz.png src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css src/main/resources/org/apache/aurora/scheduler/http/ui/error.html src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html src/main/resources/org/apache/aurora/scheduler/http/ui/home.html src/main/resources/org/apache/aurora/scheduler/http/ui/index.html src/main/resources/org/apache/aurora/scheduler/http/ui/job.html src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js src/main/resources/org/apache/aurora/scheduler/http/ui/role.html src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html src/main/resources/org/apache/aurora/scheduler/http/ui/schedulingDetail.html src/main/resources/org/apache/aurora/scheduler/http/ui/taskLink.html src/main/resources/org/apache/aurora/scheduler/http/ui/taskSandbox.html src/main/resources/org/apache/aurora/scheduler/http/ui/taskStatus.html src/main/resources/scheduler/assets/index.html PRE-CREATION src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java c2679c7f191bdf80ee9025e8cb3e078a4647fa4b Diff: https://reviews.apache.org/r/25835/diff/ Testing --- ./gradlew build -Pq Confirmed everything works in scheduler UI in vagrant image. One thing I've seen locally is lost tasks in vagrant, but I *think* that's just due to my image being somehow misconfigured, and not these changes. I'm going to destroy and rebuild the image to see if that cleans things up. Thanks, Joshua Cohen -- Zameer Manji
Re: Review Request 25914: use javax.inject.Qualifier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/#review54206 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 4:35 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25914/ --- (Updated Sept. 22, 2014, 4:35 p.m.) Review request for Aurora. Repository: aurora Description --- use javax.inject.Qualifier instead of @BindingAnnotation See https://github.com/google/guice/wiki/JSR330 Diffs - src/main/java/org/apache/aurora/GuiceUtils.java a27243c6b93330bf8415a140ad7052e6144a1fef src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java e72961abf6509fbd3ee7e3c73ea61a4c2536bb80 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/RandomJitterReturnDelay.java 1a65a3418c1bf8276f78a2d3aad532b4768a010c src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java fd08be11381255f1aca640db9c6276eaddeb7b91 src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 05417ca29714a18b0f3f8e062ae005d04671051e src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java 085454c63a3023e28ae1d148c64d25cfed99c4f1 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java fc3eaf6ba461dbfc371afc6ccf5afbd34760f2c5 src/main/java/org/apache/aurora/scheduler/storage/Storage.java f83a71a877a317810cd166c74ca468dd17c50d07 src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java 4bfb44d43224e8bb99efcd3051d7f01ee636c2a3 src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java 6f94af50a9992dd5efd9f28c0d39ae808a3f3e87 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java ce42ad20e8839698583e04f1780c59197a9f0be8 src/main/java/org/apache/aurora/scheduler/storage/mem/MemStorage.java 186bc46d74c562603d5e0a724b0fe2ff5b69131d src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 49770e5f87f047502e4f5653b908657a40d8683f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java d07220ae3e83c5dae43dd6280fa65c1f9a94f075 src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java 52ff46447c4b73f2b126ac297f2a74b731373267 Diff: https://reviews.apache.org/r/25914/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 25918: Improve aurora command-line help using metavars.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/#review54239 --- Ship it! Ship It! - Zameer Manji On Sept. 22, 2014, 6:53 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25918/ --- (Updated Sept. 22, 2014, 6:53 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-737 https://issues.apache.org/jira/browse/aurora-737 Repository: aurora Description --- Improve aurora command-line help using metavars. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 383c59143ae87d1f059644fdc3433e4c2075d02e src/main/python/apache/aurora/client/cli/options.py 36f80aa175beaf8f2dc6b6f962394643313d6405 src/main/python/apache/aurora/client/cli/task.py 5b5710ae9005664e17be1053c63b282364ae0300 Diff: https://reviews.apache.org/r/25918/diff/ Testing --- All unit tests pass. Thanks, Mark Chu-Carroll
Review Request 25974: Prevent uncaught exceptions from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent uncaught exceptions from killing the executor when creating the status manager. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26004: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54457 --- Ship it! Ship It! - Zameer Manji On Sept. 24, 2014, 1:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/ --- (Updated Sept. 24, 2014, 1:24 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-742 https://issues.apache.org/jira/browse/aurora-742 Repository: aurora Description --- Add support for commands to query and display active updates being managed by the scheduler. Two commands are added: * aurora update list, which shows all active updates that are being processed by the server. * aurora update status, which shows detailed status information about an update in-progress on the server. Diffs - src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f src/main/python/apache/aurora/client/cli/update.py c6cb98fe6aa42310090167796c971856d3dc177f src/test/python/apache/aurora/client/cli/test_supdate.py 4fb1623e497b9741ae2a350deb20030dd4036506 src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's Feedback Summary (updated) - Prevent initial ZK timeouts from killing the executor. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description (updated) --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25481: Adding JobUpdateRequest validation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review54613 --- Ship it! Ship It! - Zameer Manji On Sept. 25, 2014, 3:02 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/ --- (Updated Sept. 25, 2014, 3:02 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-649 https://issues.apache.org/jira/browse/AURORA-649 Repository: aurora Description --- Adding JobUpdateRequest validation. Diffs - src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 9152c211c49b433c835e2345320e97010cb588e2 src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java f4aefb21a41d41f11cb4a8caf402bbe18eb2d1d5 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java a894a3aca18d3101543c3520ab4d547d63cd6d61 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 5b00d3cf72adc154f130bb067723c3bd6960a314 Diff: https://reviews.apache.org/r/25481/diff/ Testing --- gradle -Pq build Thanks, Maxim Khutornenko
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 26, 2014, 2:24 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Kevin's Feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Sept. 25, 2014, 4:29 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/executor/common/test_announcer.py, line 264 https://reviews.apache.org/r/25974/diff/2/?file=705691#file705691line264 where is this magic number coming from? extract a constant and import that here? This is the default initial health check + (max failures * health check). I'm unsure on the best way to fix this without duplicating the code it is trying to test. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54623 --- On Sept. 25, 2014, 2:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 25, 2014, 2:39 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26123: Fail the build on lack of test coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- Once this is commited, please make tickets for adding tests to these classes. - Zameer Manji On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 4:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 26123: Fail the build on lack of test coverage.
On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote: Once this is commited, please make tickets for adding tests to these classes. Bill Farner wrote: I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is difficult to track. Any bright ideas? I have no ideas. In that case feel free to ignore my request for tickets. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/#review54771 --- On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26123/ --- (Updated Sept. 27, 2014, 4:25 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko. Repository: aurora Description --- This will fail the build if: - global line or branch coverage is below a threshold - a class has no test coverage - a class flagged as known to have no coverage gains coverage Hopefully we can all contribute to whittle the legacy non-covered list down to zero. Diffs - build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 Diff: https://reviews.apache.org/r/26123/diff/ Testing --- ./gradlew build -Pq Thanks, Bill Farner
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54890 --- Pinging Brian and Kevin to this review. - Zameer Manji On Sept. 29, 2014, 2:46 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 2:46 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Bill's Feedback Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 26137: Fix help for new update command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54894 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/ --- (Updated Sept. 29, 2014, 8:05 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-748 https://issues.apache.org/jira/browse/aurora-748 Repository: aurora Description --- Fix help for new update command. Diffs - src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 Diff: https://reviews.apache.org/r/26137/diff/ Testing --- manual testing. Thanks, Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 5:54 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's Feedback except for calling start_async() Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Sept. 29, 2014, 4:43 p.m., Brian Wickman wrote: src/main/python/apache/aurora/executor/common/announcer.py, lines 112-116 https://reviews.apache.org/r/25974/diff/4/?file=708538#file708538line112 this data is available within the mesos_task struct created in from_assigned_task. you should be getting the information from there as it may contain default values not required to be populated in the executorConfig json (in which case you'd be getting KeyErrors from make_serverset.) done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review54916 --- On Sept. 29, 2014, 5:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 29, 2014, 5:54 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 30, 2014, 5:17 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's Feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing (updated) --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 26270: Make the client invocation code actually use the exit codes returned by the client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26270/#review55217 --- Ship it! Ship It! - Zameer Manji On Oct. 2, 2014, 9:07 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26270/ --- (Updated Oct. 2, 2014, 9:07 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-781 https://issues.apache.org/jira/browse/aurora-781 Repository: aurora Description --- Fix multiple errors involving bindings, and fix result codes. - Cause an error to be raised by an unresolved binding in a configuration file. - Fix incorrect structuring of processed bindings. - Add a test to confirm that unbound parameters generate errors. While I'm in the code, also fix a problem where result codes aren't returned correctly to the shell. Diffs - src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9 src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28 src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04 Diff: https://reviews.apache.org/r/26270/diff/ Testing --- Unit tests: - verified that tests fail if the binding code is disabled, but pass with in on. - added a new unit test to check that unresolved bindings generate an error. Thanks, Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Oct. 1, 2014, 4:34 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/executor/common/announcer.py, line 228 https://reviews.apache.org/r/25974/diff/6/?file=709964#file709964line228 push this into `__start`, out of the constructor? At least on the Java side we try to avoid doing any I/O in constructors (as they're more for wiring) but instead delegate to explicit lifecycle methods like `start`. I'd rather not. Keeping it in the constructor means it stays in the from_assigned_task method code path. Moving it to the start method moves it out of that code path and really changes when we do this sort of I/O. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55161 --- On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 30, 2014, 5:17 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
On Oct. 1, 2014, 4:14 p.m., Brian Wickman wrote: src/test/python/apache/aurora/executor/common/test_announcer.py, line 239 https://reviews.apache.org/r/25974/diff/6/?file=709965#file709965line239 out of scope for this review, but there's a new-ish pypi project called 'zake' that allows the kazoo client to be stubbed out with a mock zk tree (while preserving certain operations like create/delete.) i'd love to explore using it here in the future. It looks really nice for this sort of testing. It is definately out of the scope of this review. If we ever need to do more work on the Announcer/Service Discovery we should first migrate to zake. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55158 --- On Sept. 30, 2014, 5:17 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Sept. 30, 2014, 5:17 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Oct. 2, 2014, 4:20 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Oct. 2, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Changes --- Brian's feedback. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs (updated) - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26328: Add aurora update list and aurora update status commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55390 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/26328/#comment95746 I think we should put an ISO formatted date like `datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d %H:%M:%S')`. - Zameer Manji On Oct. 3, 2014, 1:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 3, 2014, 1:47 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26328: Add aurora update list and aurora update status commands.
On Oct. 3, 2014, 1:56 p.m., Zameer Manji wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 434 https://reviews.apache.org/r/26328/diff/1/?file=713687#file713687line434 I think we should put an ISO formatted date like `datetime.datetime.fromtimestamp(time.time()).strftime('%Y-%m-%d %H:%M:%S')`. Kevin pointed out to me we could just use `datetime.datetime.isoformat`: https://docs.python.org/2/library/datetime.html#datetime.datetime.isoformat - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review55390 --- On Oct. 3, 2014, 1:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 3, 2014, 1:47 p.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c src/main/python/apache/aurora/client/cli/options.py 9a81a1d7d04c6648e94ff117429278317a9dbed8 src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69 src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/#review55402 --- Pinging Kevin for final ship it and commit. - Zameer Manji On Oct. 2, 2014, 6:44 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25974/ --- (Updated Oct. 2, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-728 https://issues.apache.org/jira/browse/AURORA-728 Repository: aurora Description --- Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught exceptions from killing the executor. Diffs - src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2 src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602 src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326 Diff: https://reviews.apache.org/r/25974/diff/ Testing --- ./pants src/test/python/apache/aurora/executor:executor-small ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Zameer Manji
Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/#review55520 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 7:57 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26363/ --- (Updated Oct. 6, 2014, 7:57 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-792 https://issues.apache.org/jira/browse/aurora-792 Repository: aurora Description --- Make the large-update check in the client update command consider instance parameters. Diffs - src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 Diff: https://reviews.apache.org/r/26363/diff/ Testing --- New unit tests added, all test pass. Thanks, Mark Chu-Carroll
Re: Review Request 26372: Update as property
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55521 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 9:55 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/ --- (Updated Oct. 6, 2014, 9:55 a.m.) Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Zameer Manji. Bugs: AURORA-748 https://issues.apache.org/jira/browse/AURORA-748 Repository: aurora Description --- Test all the nouns and verbs Diffs - src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9 src/test/python/apache/aurora/client/cli/test_help.py e1602b145a6b100efca8663104a7d44cc119c5a5 Diff: https://reviews.apache.org/r/26372/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants ./src/test/python/apache/aurora/client/cli:help Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) test session starts = platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 6 items src/test/python/apache/aurora/client/cli/test_help.py .. == 6 passed in 0.71 seconds == src.test.python.apache.aurora.client.cli.help . SUCCESS And confirmed via: [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ git diff diff --git a/src/main/python/apache/aurora/client/cli/update.py b/src/main/python/apache/aurora/client/cli/update.py index 41475a7..142ba5e 100644 --- a/src/main/python/apache/aurora/client/cli/update.py +++ b/src/main/python/apache/aurora/client/cli/update.py @@ -42,7 +42,7 @@ class StartUpdate(Verb): INSTANCES_SPEC_ARGUMENT, CONFIG_ARGUMENT ] - @property + #@property def help(self): return textwrap.dedent(\ Start a scheduler-driven rolling upgrade on a running job, using the update [tw-172-25-132-201 aurora (yasumoto/test_update_help)]$ ./pants ./src/test/python/apache/aurora/client/cli:help Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, help)]) test session starts = platform darwin -- Python 2.6.8 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 6 items src/test/python/apache/aurora/client/cli/test_help.py F. == FAILURES == ___ TestHelp.test_all_help ___ self = test_help.TestHelp testMethod=test_all_help def test_all_help(self): for noun in self.cmd.registered_nouns: with patch('apache.aurora.client.cli.client.AuroraCommandLine.print_out', side_effect=self.mock_print): self.cmd.execute(['help', noun]) assert 'Usage for noun %s:' % noun in self.transcript assert self.err_transcript == [] self.transcript = [] for verb in self.cmd.nouns.get(noun).verbs.keys(): self.cmd.execute(['help', noun, verb]) assert 'Usage for verb %s %s:' % (noun, verb) in self.transcript E
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Add a comment Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs (updated) - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/#review3 --- Ship it! Ship It! - Zameer Manji On Oct. 6, 2014, 11:55 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328/ --- (Updated Oct. 6, 2014, 11:55 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Improve handling of unknown errors in the aurora client. Instead of dumping the stack on the user's terminal, or absorbing the error and generating a brief error message, the client now writes detailed information about the error is written into an error log file, and the user is given a clean error message referring them to that file for details. Diffs - src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2 src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064 src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2 src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3 src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26378: Upgrade to pants 0.0.24
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/#review55566 --- Ship it! The big win we are getting from this is the repo wide interpreter enforcement. - Zameer Manji On Oct. 6, 2014, 12:47 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26378/ --- (Updated Oct. 6, 2014, 12:47 p.m.) Review request for Aurora, Joshua Cohen, Brian Wickman, and Zameer Manji. Bugs: AURORA-363 https://issues.apache.org/jira/browse/AURORA-363 Repository: aurora Description --- Upgrade to pants 0.0.24 Diffs - pants 61468a9ea51f3abe7db48f605f8623321005c3a8 pants.ini f6461c2ba2f7506204db66b56b6c858c65286790 Diff: https://reviews.apache.org/r/26378/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith
Review Request 26391: Remove special casing of 'rack' attribute.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26391/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-662 https://issues.apache.org/jira/browse/AURORA-662 Repository: aurora Description --- This patch removes the auto injection of the 'rack' attribute in the constraint of every job. This will allow for jobs without the 'rack' attribute to be scheduled and allow Aurora to schedule jobs on Mesos slaves that don't have the 'rack' attribute. Diffs - src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 9ee4fe2e76d36e17f8de2ab3eb714a6aae52c09c src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 Diff: https://reviews.apache.org/r/26391/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 26417: Change JSON result of job status when job isn't found.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/#review55664 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 10:12 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26417/ --- (Updated Oct. 7, 2014, 10:12 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-803 https://issues.apache.org/jira/browse/aurora-803 Repository: aurora Description --- Instead of just exiting with an error code, return a valid JSON structure when a user calls aurora job status, and no job matching the jobspec is running. Also, remove a bunch of pants labels from build files, which generated warnings while building the tests. Diffs - src/main/python/apache/aurora/client/cli/context.py 0816ac02846c30e0beab5c0339aca38f15c4ae10 src/main/python/apache/aurora/client/cli/jobs.py 103fb53cb5101d3e025d8712e3887bccdfbb6aeb src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8 src/test/python/apache/aurora/client/cli/test_status.py bd30b11022ee0d1fb38da9f6efd4d9c5923b7d13 Diff: https://reviews.apache.org/r/26417/diff/ Testing --- Ran all unit tests; added new test for the empty job list json case. Thanks, Mark Chu-Carroll
Re: Review Request 26422: Drop syncrhonized from JobUpdateEventSubscriber
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/#review55700 --- Ship it! Ship It! - Zameer Manji On Oct. 7, 2014, 12:28 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26422/ --- (Updated Oct. 7, 2014, 12:28 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-801 https://issues.apache.org/jira/browse/AURORA-801 Repository: aurora Description --- Drop syncrhonized from JobUpdateEventSubscriber This fixes a startup deadlock. Diffs - src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java 49d8b7a6c4adc4c58049c439bd09019c9e6885b1 Diff: https://reviews.apache.org/r/26422/diff/ Testing --- ./gradlew -Pq build Manually verified that all delegated calls to the JobUpdateController are already protected by the storage write-lock. Rather than add a potentially-flaky regression test (like the one added in https://reviews.apache.org/r/25556/) I'd prefer to prioritize adding runtime deadlock detection (https://issues.apache.org/jira/browse/AURORA-800). Thanks, Kevin Sweeney
Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1 src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26324: Increase timeout for PyPI HTTP fetches.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/#review55750 --- Ping Kevin. - Zameer Manji On Oct. 6, 2014, 12:02 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26324/ --- (Updated Oct. 6, 2014, 12:02 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- This patch increases the timeout for PyPI HTTP fetches. This was recomended by John Sirois to reduce the flakeyness of Python tests on Apache Jenkins. Diffs - build-support/jenkins/build.sh 1a664e266213cff43e956606407f02737db6f051 Diff: https://reviews.apache.org/r/26324/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26448: Move the error-log seed file to a user specified directory.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26448/#review55838 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 10:32 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26448/ --- (Updated Oct. 8, 2014, 10:32 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-779 https://issues.apache.org/jira/browse/aurora-779 Repository: aurora Description --- Instead of dumping error traces into the users current directory, dump them into a user specified directory, with a benign default. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 5c0688f5ea184e2c0b1f8e1b54a109d8260a12fa src/main/python/apache/aurora/client/cli/standalone_client.py 4fdcf6df493f63aae672e0834214dad208cf4110 src/test/python/apache/aurora/client/cli/test_create.py 8dc0ccb78539f8b0c7829ec2927da93d4afa9ada src/test/python/apache/aurora/client/cli/test_inspect.py fd35fe0185c1850910bd18d6a1e5831cd3effa6f src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128 Diff: https://reviews.apache.org/r/26448/diff/ Testing --- Added new unit test; verified all tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 26445: Fix error in incorrect deprecation warning on v1 ssh command.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26445/#review55840 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 8:58 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26445/ --- (Updated Oct. 8, 2014, 8:58 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-804 https://issues.apache.org/jira/browse/aurora-804 Repository: aurora Description --- The error message incorrectly displayed a list-value for the --tunnels parameter, when in fact it should expand the list into multiple instances of --tunnels. Diffs - src/main/python/apache/aurora/client/commands/ssh.py 9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 Diff: https://reviews.apache.org/r/26445/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll
Re: Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- (Updated Oct. 8, 2014, 3:29 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Changes --- Brian's feedback. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject Diffs (updated) - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- (Updated Oct. 8, 2014, 3:29 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description (updated) --- This removes several long deprecated configuration options from aurora. The features removed are automatically filling out environment, cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject. Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Review Request 26464: Blacklist org/apache/aurora/scheduler/http/api/ApiBeta$2 which has no coverage.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26464/ --- Review request for Aurora, Joshua Cohen and Bill Farner. Bugs: AURORA-819 https://issues.apache.org/jira/browse/AURORA-819 Repository: aurora Description --- The org/apache/aurora/scheduler/http/api/ApiBeta$2 class has no coverage so we blacklist it. Diffs - build.gradle 2e1bf78d7797f17afd51a94a22eff80e00aba464 Diff: https://reviews.apache.org/r/26464/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review55916 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 5:15 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/ --- (Updated Oct. 8, 2014, 5:15 p.m.) Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora Description --- Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly. Diffs - build.gradle 8f7eed0b58a00f8e5e0521512975087d5788b5b6 src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java eaf63382f689a045f837847736ef24fa75dee874 src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 62154045f49c5b23949dc739d735c3e5d3680b89 Diff: https://reviews.apache.org/r/26469/diff/ Testing --- ./gradlew build -Pq $ curl -I http://192.168.33.7:8081/apibeta/help/method/setQuota.html HTTP/1.1 200 OK Content-Type: text/html Vary: Accept-Encoding Content-Length: 0 Server: Jetty(7.6.15.v20140411) Thanks, Joshua Cohen
Re: Review Request 26383: Health Check Disabler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55924 --- src/main/python/apache/aurora/executor/common/health_checker.py https://reviews.apache.org/r/26383/#comment96295 Why add a default value here? src/main/python/apache/aurora/executor/common/health_checker.py https://reviews.apache.org/r/26383/#comment96296 Why add a default value here? src/main/python/apache/aurora/executor/common/health_checker.py https://reviews.apache.org/r/26383/#comment96297 Why add a default here? - Zameer Manji On Oct. 8, 2014, 5:46 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 8, 2014, 5:46 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26383: Health Check Disabler
On Oct. 8, 2014, 6:09 p.m., Zameer Manji wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 41 https://reviews.apache.org/r/26383/diff/2/?file=716291#file716291line41 Why add a default value here? David Pan wrote: The reason why ThreadedHealthChecker has defaults is because some tests for ThreadedHealthChecker don't care about all the parameters to ThreadedHealthChecker. For example, if my test doesn't care about the interval_secs, the defaults allow me to ignore that parameter altogether, and focus on the parameters that I actually care about. It isn't acceptable to alter parameters like that. Please modify your tests to pass in a value instead. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55924 --- On Oct. 8, 2014, 5:46 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 8, 2014, 5:46 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26478: Add a flag to deduplicate storage snapshots
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review55943 --- Ship it! Ship It! - Zameer Manji On Oct. 8, 2014, 7:39 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/ --- (Updated Oct. 8, 2014, 7:39 p.m.) Review request for Aurora, David McLaughlin, Bill Farner, and Zameer Manji. Bugs: AURORA-722 https://issues.apache.org/jira/browse/AURORA-722 Repository: aurora Description --- Add a new format for deduplicated storage snapshots. Microbenchmarks show a 10x deduplication ratio on Twitter's production snapshots. This format is backwards-incompatible, so this patch introduces a flag to control its use (defaulting off). This only changes the format used to write to the replicated log (where time is of the essence since all writes are done holding the global storage lock) - the format of backups written to disk is unchanged, as backups don't hold the lock. Diffs - build.gradle 2e1bf78d7797f17afd51a94a22eff80e00aba464 src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 65e986eaa2c4193431ca048425a1ed3ab60f5882 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java 7239a6a5eb5479e395e16423c83fdf80a77e5a83 src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 4b50e2069407dc263b4fc93f1827d3a8836253bf src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java f806297d1d0700155c976743f936b2b8a3a390fb src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 769348e6b8a5c701734afff391b1c77de35222c6 src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java 22db80eaf34fe736fa5a3a9289836c9ac9e59906 src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java e5cfbf5cf43bf5bbc38c42fe685a7e9f0d03af2a src/main/thrift/org/apache/aurora/gen/storage.thrift 5350ec945fbe028ee4641683815a068ce00b5efc src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 39729b374fe4e383f9b5ada7d016923766df9af7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 7a8c3b882633376a1bf6a78616d55aaa7401d13f src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicatorImplTest.java PRE-CREATION Diff: https://reviews.apache.org/r/26478/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney
Re: Review Request 26383: Health Check Disabler
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the file is there, don't perform health checks. When you want to re-enable health checks, delete the file. Happy to hear what others think about that. Doesn't this mean user error can disable health checks forever? I think we should treat disabling health checking as an exceptional state (since the proceses has opted in to health checking) and therefore require user action (increasing mtime) to continue to stay in this state. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55985 --- On Oct. 8, 2014, 6:56 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 8, 2014, 6:56 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26504: Restore JDK8 compatibility
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56012 --- Ship it! Ship It! - Zameer Manji On Oct. 9, 2014, 9:50 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/ --- (Updated Oct. 9, 2014, 9:50 a.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository: aurora Description --- I misconfigured my IDE and noticed that we'd stopped compiling on JDK8. Diffs - src/main/java/org/apache/aurora/scheduler/sla/SlaUtil.java 7ecb05ae87058e7a25d88959cf629b2da17dc520 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 Diff: https://reviews.apache.org/r/26504/diff/ Testing --- ./gradlew -Pq build With ``` diff --git a/build.gradle b/build.gradle index 8f7eed0..af3d4ba 100644 --- a/build.gradle +++ b/build.gradle @@ -38,8 +38,8 @@ def httpAssetsPath = 'scheduler/assets' def thriftVersion = '0.9.1' compileJava { - sourceCompatibility = 1.7 - targetCompatibility = 1.7 + sourceCompatibility = 1.8 + targetCompatibility = 1.8 } ``` Thanks, Kevin Sweeney
Re: Review Request 26383: Health Check Disabler
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the file is there, don't perform health checks. When you want to re-enable health checks, delete the file. Happy to hear what others think about that. Zameer Manji wrote: Doesn't this mean user error can disable health checks forever? I think we should treat disabling health checking as an exceptional state (since the proceses has opted in to health checking) and therefore require user action (increasing mtime) to continue to stay in this state. Kevin Sweeney wrote: Presumably we can trust the user here - health checking is after all opt-in via {{thermos.ports[health]}}. Making it a simple on/off switch greatly simplifies the code on our end. I'm very worried about introducing a feature which can allow unhealthy instances live forever. Furthermore this information isn't exposed on the Aurora UI or Observer UI so there isn't an easy way to check if an instance has health checking disabled or not. A user can be completely oblivious that health checking of their instance has been disabled. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55985 --- On Oct. 8, 2014, 6:56 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 8, 2014, 6:56 p.m.) Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji. Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.
Applying the patch, cleaning my reports directory and then running `./gradlew clean build` produces no error for me. I can share my xml report if needed. On Thu, Oct 9, 2014 at 10:42 AM, Bill Farner wfar...@apache.org wrote: Can you post your xml report to a ticket? It might help get to the bottom of this flakiness. On Thursday, October 9, 2014, Joshua Cohen jco...@twopensource.com wrote: I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit. On Thu, Oct 9, 2014 at 10:05 AM, Joshua Cohen jco...@twopensource.com wrote: Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2; even after cleaning the reports directory I was *not* getting the failure about it missing coverage even though it actually was. On Thu, Oct 9, 2014 at 8:32 AM, Bill Farner wfar...@apache.org wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/ On October 9th, 2014, 2:32 p.m. UTC, *Bill Farner* wrote: Ship It! Hmm, i'm now getting a different coverage error when preparing to submit this: * What went wrong: Execution failed for task ':jacocoTestReport'. Thanks for adding the first test coverage to: org/apache/aurora/scheduler/async/OfferQueue$OfferQueueImpl$2 please remove it from the legacyClassesWithoutCoverage list. Expression: (coverage == 0). Values: coverage = 6 This remains after cleaning the reports directory. Do you see that one as well? - Bill On October 9th, 2014, 12:15 a.m. UTC, Joshua Cohen wrote: Review request for Aurora, Bill Farner and Zameer Manji. By Joshua Cohen. *Updated Oct. 9, 2014, 12:15 a.m.* *Repository: * aurora Description Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly. Testing ./gradlew build -Pq $ curl -I http://192.168.33.7:8081/apibeta/help/method/setQuota.html HTTP/1.1 200 OK Content-Type: text/html Vary: Accept-Encoding Content-Length: 0 Server: Jetty(7.6.15.v20140411) Diffs - build.gradle (8f7eed0b58a00f8e5e0521512975087d5788b5b6) - src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java (eaf63382f689a045f837847736ef24fa75dee874) - src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java (62154045f49c5b23949dc739d735c3e5d3680b89) View Diff https://reviews.apache.org/r/26469/diff/ -- -=Bill -- Zameer Manji
Re: Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/#review56417 --- Pinging Mark and Wickman to this review. - Zameer Manji On Oct. 8, 2014, 3:29 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- (Updated Oct. 8, 2014, 3:29 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Brian Wickman. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are automatically filling out environment, cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject. Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Review Request 26716: Use JobKey when getting roles to authenticate against.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26716/ --- Review request for Aurora. Repository: aurora Description --- Use JobKey when getting roles to authenticate against. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java d8572bb21a92025e7a51cf18d5bdf00fc1281078 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 3b61ff3c237de3ec5224a239d1756ce8d7093a52 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e Diff: https://reviews.apache.org/r/26716/diff/ Testing --- Thanks, Zameer Manji
Re: Review Request 26716: Use JobKey when getting roles to authenticate against.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26716/ --- (Updated Oct. 14, 2014, 5:23 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-837 https://issues.apache.org/jira/browse/AURORA-837 Repository: aurora Description --- Use JobKey when getting roles to authenticate against. Diffs - src/main/java/org/apache/aurora/scheduler/base/Query.java d8572bb21a92025e7a51cf18d5bdf00fc1281078 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 3b61ff3c237de3ec5224a239d1756ce8d7093a52 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e Diff: https://reviews.apache.org/r/26716/diff/ Testing (updated) --- ./gradlew clean test Thanks, Zameer Manji
Re: Review Request 26688: Fix errors in help rendering:
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56733 --- src/main/python/apache/aurora/client/cli/standalone_client.py https://reviews.apache.org/r/26688/#comment97118 Is this a python standard for log levels? Could the help show all possible values? - Zameer Manji On Oct. 15, 2014, 9:46 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- (Updated Oct. 15, 2014, 9:46 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: aurora-831 https://issues.apache.org/jira/browse/aurora-831 Repository: aurora Description --- - Put plugin-generated options into the correct order. - Include the option-name in the detailed help list. - Add missing metavars. Diffs - src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 src/main/python/apache/aurora/client/cli/options.py dc76c25b90acb9610e40b939e65c3cabf032649f src/main/python/apache/aurora/client/cli/standalone_client.py 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1 src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d Diff: https://reviews.apache.org/r/26688/diff/ Testing --- New help output: {noformat} [sun-wukong incubator-aurora (deprecate)]$ ./dist/aurora2.pex help cron deschedule Usage for verb cron deschedule: deschedule [--verbose-logging] [--logging-level=numeric_level] [--error-log-dir=error-log-dir] [--bind=var=value] CLUSTER/ROLE/ENV/NAME Options: --bind=var=value Bind a pystachio variable name to a value. Multiple flags may be used to specify multiple values. CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format --verbose-logging Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level=numeric_level Set logging to a specific numeric level. --error-log-dir=error-log-dir Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created Remove the cron schedule for a job. {noformat} Thanks, Mark Chu-Carroll
Re: Review Request 26688: Fix errors in help rendering:
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56750 --- Ship it! Ship It! - Zameer Manji On Oct. 15, 2014, 10:57 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/ --- (Updated Oct. 15, 2014, 10:57 a.m.) Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: aurora-831 https://issues.apache.org/jira/browse/aurora-831 Repository: aurora Description --- - Put plugin-generated options into the correct order. - Include the option-name in the detailed help list. - Add missing metavars. Diffs - src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 src/main/python/apache/aurora/client/cli/options.py dc76c25b90acb9610e40b939e65c3cabf032649f src/main/python/apache/aurora/client/cli/standalone_client.py 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1 src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d Diff: https://reviews.apache.org/r/26688/diff/ Testing --- New help output: {noformat} [sun-wukong incubator-aurora (deprecate)]$ ./dist/aurora2.pex help cron deschedule Usage for verb cron deschedule: deschedule [--verbose-logging] [--logging-level=numeric_level] [--error-log-dir=error-log-dir] [--bind=var=value] CLUSTER/ROLE/ENV/NAME Options: --bind=var=value Bind a pystachio variable name to a value. Multiple flags may be used to specify multiple values. CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format --verbose-logging Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level=numeric_level Set logging to a specific numeric level. --error-log-dir=error-log-dir Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created Remove the cron schedule for a job. {noformat} Thanks, Mark Chu-Carroll
Re: Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- (Updated Oct. 16, 2014, 11:21 a.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Changes --- Drop markcc add maxim Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are automatically filling out environment, cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject. Diffs - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26802: Set a default for the error log dir
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26802/#review56983 --- I have no time to review this. Please remove me from review. - Zameer Manji On Oct. 16, 2014, 10:51 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26802/ --- (Updated Oct. 16, 2014, 10:51 a.m.) Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji. Bugs: AURORA-827 https://issues.apache.org/jira/browse/AURORA-827 Repository: aurora Description --- Set a default for the error log dir This has been a weird issue to wrap my head around, it's really using lots of low-level systems (writing tracebacks to files) so I feel like I've done some weird things in the tests. Feedback and critque welcome + appreciated. Diffs - src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8 src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c src/test/python/apache/aurora/client/cli/test_aurora_command_line.py PRE-CREATION Diff: https://reviews.apache.org/r/26802/diff/ Testing --- [tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants src/test/python/apache/aurora/client/cli:aurora_command_line Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD, aurora_command_line)]) test session starts = platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 1 items src/test/python/apache/aurora/client/cli/test_aurora_command_line.py . == 1 passed in 0.63 seconds == src.test.python.apache.aurora.client.cli.aurora_command_line . SUCCESS Thanks, Joe Smith
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 1:59 p.m.) Review request for Aurora and Bill Farner. Changes --- Feedback. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26430: Remove deprecated configuration options.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26430/ --- (Updated Oct. 16, 2014, 2:09 p.m.) Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. Changes --- Rebase on top of master. Bugs: AURORA-333 https://issues.apache.org/jira/browse/AURORA-333 Repository: aurora Description --- This removes several long deprecated configuration options from aurora. The features removed are automatically filling out environment, cron_policy, daemon, health_check_interval_secs, recipes and the PackerObject. Diffs (updated) - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2 src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java d3c90416e48e25d83f28f966b21c018ee2a1ac27 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 src/test/python/apache/aurora/client/api/test_scheduler_client.py 1835843f1795b0530874ec561582df17acfbce65 src/test/python/apache/aurora/client/cli/util.py 967b5dcdab76f0581f6d2a518409c30de0800f27 src/test/python/apache/aurora/client/commands/util.py 663f2f4a16113a36826943b7238cad900ae0dcd2 src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26430/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:15 p.m.) Review request for Aurora and Bill Farner. Changes --- Bill's feedback. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:27 p.m.) Review request for Aurora and Bill Farner. Changes --- Fix checkstyle issues. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/python/apache/aurora/client/binding_helper.py 6d6a06785c6840e4345e304eb4e242682676ac66 src/main/python/apache/aurora/client/config.py e440f587d100ce46b2df85ccc663912c615051ef src/main/python/apache/aurora/config/recipes.py 68b5d252f87a592d4c2f7d52525163829bea2cc9 src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java ee9587582bd7c45a446e8afe28930c18a97d2792 src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 791aa6fed7380999ea9257d92d16b69ed89dcea0 src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e src/test/python/apache/aurora/client/api/test_scheduler_client.py 630f662ad2ffb8d192299d98c612ad4892161081 src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 src/test/python/apache/aurora/client/commands/util.py 21b8830df5a3eccc7d36067369fc16cc5fd9de2a src/test/python/apache/aurora/client/test_config.py 901c3378ed59c44b7e2dea239f186193f1f66355 src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26821/ --- (Updated Oct. 16, 2014, 2:28 p.m.) Review request for Aurora and Bill Farner. Changes --- Rebase. Bugs: AURORA-848 https://issues.apache.org/jira/browse/AURORA-848 Repository: aurora Description --- Handle resourceOffers callback asynchronsly. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646 src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2 Diff: https://reviews.apache.org/r/26821/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 26320: Skip checkstyle on python file in 3rdparty.
On Oct. 16, 2014, 1:11 p.m., Kevin Sweeney wrote: Is this still needed? I thought the checkstyle check was updated I was under this impression as well. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/#review56991 --- On Oct. 3, 2014, 9:51 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26320/ --- (Updated Oct. 3, 2014, 9:51 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: AURORA-780 https://issues.apache.org/jira/browse/AURORA-780 Repository: aurora Description --- Skip checkstyle on python file in 3rdparty. Diffs - 3rdparty/javascript/bower_components/bootstrap/test-infra/s3_cache.py 472963a1e4a6c9ace6044273c7f728812aa8458b Diff: https://reviews.apache.org/r/26320/diff/ Testing --- Committed file w/ precommit hook in place. Thanks, Joshua Cohen
Re: Review Request 26383: Health Check Disabler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review57019 --- Ship it! Ship It! - Zameer Manji On Oct. 16, 2014, 3:04 p.m., David Pan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/ --- (Updated Oct. 16, 2014, 3:04 p.m.) Review request for Aurora, Joe Smith, Maxim Khutornenko, and Zameer Manji. Bugs: AURORA-795 https://issues.apache.org/jira/browse/AURORA-795 Repository: aurora Description --- The health check disabler allows health checks for a job to be snoozed temporarily by touching a snooze file in the job's sandbox. The appropriate unit tests were modified/added. The corresponding JIRA ticket is the following: https://issues.apache.org/jira/browse/AURORA-795 Diffs - docs/user-guide.md e12ee89b043e34d06348ae3ddbbe8363244fca7c src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163 src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653 src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec Diff: https://reviews.apache.org/r/26383/diff/ Testing --- On vagrant in ~/aurora, I ran ./pants src/test/python/apache/aurora/executor:: Thanks, David Pan
Re: Review Request 26852: Use mesos.native egg from ~kevints
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/#review57098 --- Ship it! Ship It! - Zameer Manji On Oct. 16, 2014, 6:50 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26852/ --- (Updated Oct. 16, 2014, 6:50 p.m.) Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Bugs: AURORA-863 https://issues.apache.org/jira/browse/AURORA-863 Repository: aurora Description --- Use mesos.native egg from ~kevints Diffs - examples/vagrant/provision-dev-cluster.sh 740bc212ba604b2c64af92eba1be41e8ed3fdbde Diff: https://reviews.apache.org/r/26852/diff/ Testing --- (Awaiting e2e test results ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) Thanks, Kevin Sweeney
Re: Review Request 26881: Improve error messages in client commands.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57399 --- Ship it! Ship It! - Zameer Manji On Oct. 17, 2014, 10:58 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/ --- (Updated Oct. 17, 2014, 10:58 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: aurora-771 https://issues.apache.org/jira/browse/aurora-771 Repository: aurora Description --- When a client command fails due to an error in an API call, it used to log whatever messages came back in the reply from the server, and then generate a message saying ... see log for details. This change improves that behavior. Now, an error message is generated saying something like Command failed due to error reported by server, followed by a group of indented lines containing the messages from the server. For example, a new error message would look like: Server reported error restarting job west/bozo/test/hello Job 'west/bozo/test/hello' not found. Diffs - src/main/python/apache/aurora/client/cli/context.py 4e94a4e3017f3b2ace38d6d8ce68c3c778c8cd0e src/main/python/apache/aurora/client/cli/cron.py 061b1d4f768f299d6db72c66f6bb75fdb68bc0d7 src/main/python/apache/aurora/client/cli/jobs.py 0277cbed4b7eb927d6e5823b4b41d90b366f81d0 src/main/python/apache/aurora/client/cli/quota.py 137aab1285a9732a3b65aee65948e836df3c7cac src/main/python/apache/aurora/client/cli/update.py 8a02b8a8b0bb531248949213da97cbc1a380bf64 src/test/python/apache/aurora/client/cli/test_create.py 427f7ce4476b48d407b8bd2bf2c54c52e6e63079 src/test/python/apache/aurora/client/cli/test_kill.py bac4485fa105848d96e2505c4a2ea2eee45dc968 src/test/python/apache/aurora/client/cli/test_restart.py a5f94484b30ecb8417116db9ce12c015957357c5 src/test/python/apache/aurora/client/cli/test_supdate.py 6775c389cb1a0b80dd17fe179e8b98d4e9db0332 Diff: https://reviews.apache.org/r/26881/diff/ Testing --- Thanks, Mark Chu-Carroll
Re: Review Request 26982: Make v2 job status look more like v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/#review57614 --- Ship it! Thanks for also using the term instance. - Zameer Manji On Oct. 21, 2014, 9:19 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26982/ --- (Updated Oct. 21, 2014, 9:19 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: AURORA-874 https://issues.apache.org/jira/browse/AURORA-874 Repository: aurora Description --- Adds a header line to each task in a task status line specifying the instance number, host, etc., the way v1 did. (We had originally planned not to display that information in v2, but we also have tests that depend on it being present.) Diffs - src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8 Diff: https://reviews.apache.org/r/26982/diff/ Testing --- $ ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 62 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py src/test/python/apache/aurora/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 26995: Download thrift from archive.a.o.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/#review57655 --- Ship it! Ship It! - Zameer Manji On Oct. 21, 2014, 1:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26995/ --- (Updated Oct. 21, 2014, 1:54 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-877 https://issues.apache.org/jira/browse/AURORA-877 Repository: aurora Description --- The us.apache.org URL 404s and breaks our build. Diffs - build-support/thrift/Makefile 11fac91cb2a2c67927d6f7f6d7de73e8c3336b59 Diff: https://reviews.apache.org/r/26995/diff/ Testing --- ./gradlew bootstrapThrift Thanks, Kevin Sweeney
Review Request 27044: Make executor overhead configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 048740953629a950c136179c9b880b8dce8fa932 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 283f7e1e22decfe1053bd5640e8283b40eeac592 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java c405d4c8b127c2dd7054c9520064da0346690f02 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27009: Use virtualenv to build pants instead of pex.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/#review57837 --- pants https://reviews.apache.org/r/27009/#comment98712 Why do we need to do this? - Zameer Manji On Oct. 22, 2014, 10:31 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/ --- (Updated Oct. 22, 2014, 10:31 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-876 https://issues.apache.org/jira/browse/AURORA-876 Repository: aurora Description --- Use virtualenv to build pants instead of pex. The goal of this change is to reduce CI flakiness by using `pip install` rather than `pex` to bootstrap pants. This still reaches out to external servers (and thus has the potential to be flaky) but is at least configurable (via `--default-timeout`). In a future review we can consider mirroring to svn.apache.org and disabling PyPI lookups. This requires a change to production executor code to use `sys.executable` rather than chmod+x-ing the runner PEX. Failure to do this results in the pants virtualenv's `site-packages` shadowing the dependencies in the `pex` (fairly obviously as there is a test failure related to psutil1/2 conflicts). I'm sure I'm papering over a PEX bug here but IMO this is fine as the only reason to execute the thermos runner PEX under a different python interpreter than the executor is using (based on the hash-bang in the pex) is not a configuration we need to support IMO. Diffs - pants 168419d7d8f5d89a0d87bfc6ac9f06c9e8e3dbc2 src/main/python/apache/aurora/executor/thermos_task_runner.py f17910826c31c5bf754b43eb72500de639652f37 Diff: https://reviews.apache.org/r/27009/diff/ Testing --- git clean -fdx ./pants src/test/python:all Thanks, Kevin Sweeney
Re: Review Request 27047: Improve status command output ordering.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27047/#review57841 --- Ship it! Ship It! - Zameer Manji On Oct. 22, 2014, 10:57 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27047/ --- (Updated Oct. 22, 2014, 10:57 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-879 https://issues.apache.org/jira/browse/aurora-879 Repository: aurora Description --- - Sort tasks by instance number. - Sort events by timestamp. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f src/test/python/apache/aurora/client/cli/test_status.py 4f62cf0c52e5837309cf7ad702df6d907df8f510 Diff: https://reviews.apache.org/r/27047/diff/ Testing --- ./pants src/test/python/apache/aurora/client/cli:job Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD, job)]) = test session starts == platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3 plugins: cov, timeout collected 58 items src/test/python/apache/aurora/client/cli/test_cancel_update.py .. src/test/python/apache/aurora/client/cli/test_create.py ... src/test/python/apache/aurora/client/cli/test_diff.py ... src/test/python/apache/aurora/client/cli/test_kill.py src/test/python/apache/aurora/client/cli/test_open.py . src/test/python/apache/aurora/client/cli/test_restart.py src/test/python/apache/aurora/client/cli/test_status.py . == 58 passed in 3.65 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll
Re: Review Request 27009: Use virtualenv to build pants instead of pex.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/#review57843 --- Ship it! Please file a PEX bug about the behaviour you noticed as well. - Zameer Manji On Oct. 22, 2014, 11:05 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27009/ --- (Updated Oct. 22, 2014, 11:05 a.m.) Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-876 https://issues.apache.org/jira/browse/AURORA-876 Repository: aurora Description --- Use virtualenv to build pants instead of pex. The goal of this change is to reduce CI flakiness by using `pip install` rather than `pex` to bootstrap pants. This still reaches out to external servers (and thus has the potential to be flaky) but is at least configurable (via `--default-timeout`). In a future review we can consider mirroring to svn.apache.org and disabling PyPI lookups. This requires a change to production executor code to use `sys.executable` rather than chmod+x-ing the runner PEX. Failure to do this results in the pants virtualenv's `site-packages` shadowing the dependencies in the `pex` (fairly obviously as there is a test failure related to psutil1/2 conflicts). I'm sure I'm papering over a PEX bug here but IMO this is fine as the only reason to execute the thermos runner PEX under a different python interpreter than the executor is using (based on the hash-bang in the pex) is not a configuration we need to support IMO. Diffs - pants 168419d7d8f5d89a0d87bfc6ac9f06c9e8e3dbc2 src/main/python/apache/aurora/executor/thermos_task_runner.py f17910826c31c5bf754b43eb72500de639652f37 Diff: https://reviews.apache.org/r/27009/diff/ Testing --- git clean -fdx ./pants src/test/python:all Thanks, Kevin Sweeney
Re: Review Request 25366: Set principal field in FrameworkInfo struct.
On Oct. 23, 2014, 12:28 p.m., Kevin Sweeney wrote: Any progress here? Bill Farner wrote: FYI - i believe this may be a dangerous feature until https://issues.apache.org/jira/browse/MESOS-703 is complete. Kevin Sweeney wrote: Yikes, thoughts on linking that as a blocker to AURORA-867 and unassigning for now? Done. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25366/#review58064 --- On Sept. 4, 2014, 4:36 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25366/ --- (Updated Sept. 4, 2014, 4:36 p.m.) Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-687 https://issues.apache.org/jira/browse/AURORA-687 Repository: aurora Description --- Set principal field in FrameworkInfo struct. Diffs - src/main/java/org/apache/aurora/scheduler/DriverFactory.java 9cc04a84a37374ffca418e2ff767992ee23b9f3e Diff: https://reviews.apache.org/r/25366/diff/ Testing --- ./gradlew build -Pq Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
On Oct. 22, 2014, 10:32 a.m., Joshua Cohen wrote: src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java, line 67 https://reviews.apache.org/r/27044/diff/1/?file=728781#file728781line67 Do we actually need to use a ResourceSlotFactory here? The usage seems to be entirely internal to the test. We could just use constants? We need the slot factory to create the task factory in this test. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review57825 --- On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 22, 2014, 9:57 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 048740953629a950c136179c9b880b8dce8fa932 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 283f7e1e22decfe1053bd5640e8283b40eeac592 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java c405d4c8b127c2dd7054c9520064da0346690f02 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
On Oct. 22, 2014, 3:07 p.m., Bill Farner wrote: config/legacy_untested_classes.txt, line 9 https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line9 In the interest of this file being delete only, can you bite the bullet and create a unit test to cover these in a test? That invovles doing this TODO(wfarner): Try to accomplish all this by subclassing SchedulerMain and actually using AppLauncher. in SchedulerIT. I feel that deserves its own RB. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review57917 --- On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 22, 2014, 9:57 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 048740953629a950c136179c9b880b8dce8fa932 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 283f7e1e22decfe1053bd5640e8283b40eeac592 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java c405d4c8b127c2dd7054c9520064da0346690f02 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
On Oct. 22, 2014, 4:02 p.m., Maxim Khutornenko wrote: config/legacy_untested_classes.txt, line 1 https://reviews.apache.org/r/27044/diff/1/?file=728771#file728771line1 This seems to be out of order, revert? This is the output of the unix `sort` command. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review57819 --- On Oct. 22, 2014, 9:57 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 22, 2014, 9:57 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt 542ac31996d76fd4ab4e0583a737496c0e217a50 src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 048740953629a950c136179c9b880b8dce8fa932 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 283f7e1e22decfe1053bd5640e8283b40eeac592 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java c405d4c8b127c2dd7054c9520064da0346690f02 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 23, 2014, 4:06 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Most feedback. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs (updated) - config/legacy_untested_classes.txt PRE-CREATION src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
On Oct. 23, 2014, 3:32 p.m., Kevin Sweeney wrote: Driveby comment: Consider using Guice's FactoryModuleBuilder to minimize the factory boilerplate needed. IMO this should be the default anytime you want a factory that gets some of its dependencies from Guice, as the created objects will be instrumentable by Guice AOP. This is a great idea. I'm looking into it now. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review58146 --- On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 23, 2014, 4:06 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt PRE-CREATION src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
On Oct. 23, 2014, 4:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java, line 52 https://reviews.apache.org/r/27044/diff/2/?file=731618#file731618line52 private? Does not seem to be used outside. Making it private is a PMD violation: Avoid instantiation through private constructors from outside of the constructors class. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/#review58170 --- On Oct. 23, 2014, 4:06 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 23, 2014, 4:06 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs - config/legacy_untested_classes.txt PRE-CREATION src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27044: Make executor overhead configurable
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27044/ --- (Updated Oct. 23, 2014, 5:24 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Maxim's feedback. Bugs: AURORA-830 https://issues.apache.org/jira/browse/AURORA-830 Repository: aurora Description --- This patch changes the scheduler such that the executor overhead can be configured from the commandline. Diffs (updated) - config/legacy_untested_classes.txt PRE-CREATION src/main/java/org/apache/aurora/scheduler/MesosTaskFactory.java 83d0406a8bc7ccc1ae29804d2a4c8e8dfb90072c src/main/java/org/apache/aurora/scheduler/ResourceSlot.java ed60447c798a97daceda4a3bba6ee9bcdcaedd0f src/main/java/org/apache/aurora/scheduler/ResourceSlotFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 40b652c679d8e340f585e28cbed066335d9d760d src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594 src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27044/diff/ Testing --- ./gradlew clean build Thanks, Zameer Manji
Re: Review Request 27100: Cache the host's maintenance status with offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 23, 2014, 6:50 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Rebase to appease the robot. Bugs: AURORA-878 https://issues.apache.org/jira/browse/AURORA-878 Repository: aurora Description --- Cache the host's maintenance status with the offer. By caching the status alongside the offer the scheduler does not need to access the attribute store for every offer it considers for a task. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 92c843830df7a779abace38bb0ce84d4cbeb5af4 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/http/Offers.java b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27100/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 27100: Cache the host's maintenance status with offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 24, 2014, 12:59 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Bill's feedback. Bugs: AURORA-878 https://issues.apache.org/jira/browse/AURORA-878 Repository: aurora Description --- Cache the host's maintenance status with the offer. By caching the status alongside the offer the scheduler does not need to access the attribute store for every offer it considers for a task. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 92c843830df7a779abace38bb0ce84d4cbeb5af4 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/http/Offers.java b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27100/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 27100: Cache the host's maintenance status with offer.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58339 --- src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java https://reviews.apache.org/r/27100/#comment99292 I don't understand what you mean by matches what we do for dedicated host mismatches as well. - Zameer Manji On Oct. 23, 2014, 6:50 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 23, 2014, 6:50 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-878 https://issues.apache.org/jira/browse/AURORA-878 Repository: aurora Description --- Cache the host's maintenance status with the offer. By caching the status alongside the offer the scheduler does not need to access the attribute store for every offer it considers for a task. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 92c843830df7a779abace38bb0ce84d4cbeb5af4 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/http/Offers.java b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27100/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji
Re: Review Request 27058: Add specs to instances of Mock in Python tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/#review58376 --- Ship it! Ship It! - Zameer Manji On Oct. 24, 2014, 1:09 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27058/ --- (Updated Oct. 24, 2014, 1:09 p.m.) Review request for Aurora, Mark Chu-Carroll and Zameer Manji. Bugs: AURORA-248 https://issues.apache.org/jira/browse/AURORA-248 Repository: aurora Description --- Use of Mock() without a specification considered harmful. I went through and updated as many mocks as I could. Any remaining can be classified as: 1) Mocks of classes that cannot be spec'd. Almost all instances of SchedulerProxy, which uses __getattr__ to delegate to the read or write client. 2) Primitives like strings and callback functions or data objects like dicts and pystachio structs. 3) Weird mocks that broke code where they really shouldn't have (off the top of my head - in test_diff.py and commands/test_run.py) - both when they were spec'd and when they were replaced with real thrift structs. The remaining offenders: $ grep -r --include=*.py Mock() src/test/python src/test/python/apache/aurora/admin/test_host_maintenance.py: mock_callback = mock.Mock() src/test/python/apache/aurora/admin/test_host_maintenance.py: mock_callback = mock.Mock() src/test/python/apache/aurora/client/api/test_api.py:mock_proxy = Mock() src/test/python/apache/aurora/client/api/test_api.py:mock_get = Mock() src/test/python/apache/aurora/client/api/test_api.py:mock_task_config = Mock() src/test/python/apache/aurora/client/api/test_job_monitor.py: self._scheduler = Mock() src/test/python/apache/aurora/client/api/test_quota_check.py: self._scheduler = Mock() src/test/python/apache/aurora/client/api/test_scheduler_client.py: client._connect_scheduler = mock.MagicMock() src/test/python/apache/aurora/client/api/test_sla.py:self._scheduler = Mock() src/test/python/apache/aurora/client/api/test_task_util.py:scheduler = Mock() src/test/python/apache/aurora/client/cli/test_diff.py: job = Mock() src/test/python/apache/aurora/client/cli/test_diff.py: job.assignedTask.task.executorConfig.data = Mock() src/test/python/apache/aurora/client/cli/test_diff.py: patch('json.loads', return_value=Mock())) as (_, _, subprocess_patch, _): src/test/python/apache/aurora/client/cli/test_diff.py: patch('json.loads', return_value=Mock())) as ( src/test/python/apache/aurora/client/cli/test_diff.py: patch('json.loads', return_value=Mock())) as ( src/test/python/apache/aurora/client/cli/test_inspect.py:raw_config = Mock() src/test/python/apache/aurora/client/cli/test_inspect.py:mock_task = Mock() src/test/python/apache/aurora/client/cli/test_inspect.py:mock_process = Mock() src/test/python/apache/aurora/client/cli/test_kill.py: mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/cli/test_kill.py: mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/cli/test_kill.py: mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/cli/test_kill.py: mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/cli/util.py:mock_scheduler = Mock() src/test/python/apache/aurora/client/cli/util.py:mock_scheduler_client = Mock() src/test/python/apache/aurora/client/cli/util.py:mock_api_factory = Mock() src/test/python/apache/aurora/client/commands/test_diff.py: job = Mock() src/test/python/apache/aurora/client/commands/test_diff.py: job.assignedTask.task.executorConfig.data = Mock() src/test/python/apache/aurora/client/commands/test_diff.py: patch('json.loads', return_value=Mock())) as ( src/test/python/apache/aurora/client/commands/test_diff.py: patch('json.loads', return_value=Mock())) as ( src/test/python/apache/aurora/client/commands/test_diff.py: patch('json.loads', return_value=Mock())) as ( src/test/python/apache/aurora/client/commands/test_listjobs.py: mock_options = Mock() src/test/python/apache/aurora/client/commands/test_listjobs.py: job = Mock() src/test/python/apache/aurora/client/commands/test_maintenance.py: mock_callback = Mock() src/test/python/apache/aurora/client/commands/test_maintenance.py: mock_wait = Mock() src/test/python/apache/aurora/client/commands/util.py: mock_scheduler_proxy = Mock() src/test/python/apache/aurora/client/commands/util.py:mock_api_factory = Mock
Re: Review Request 27084: Fix error when job create is called with --open-browser.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/#review58377 --- Ship it! Ship It! - Zameer Manji On Oct. 23, 2014, 9:50 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27084/ --- (Updated Oct. 23, 2014, 9:50 a.m.) Review request for Aurora, David McLaughlin and Zameer Manji. Bugs: aurora-886 https://issues.apache.org/jira/browse/aurora-886 Repository: aurora Description --- Fix error when job create is called with --open-browser. Diffs - src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f src/test/python/apache/aurora/client/cli/test_create.py 328297ab1d29efb0adce8f4931a13929a04dcd9c Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 27100: Cache the host's maintenance status with offer.
On Oct. 24, 2014, 2:10 p.m., Maxim Khutornenko wrote: It's not obvious from the diff: where do we gain perf? Can you point to the place where we don't do store calls anymore? If you notice in `SchedulingFilterImplTest.java` many of the tests no longer make calls to the maintenance controller. This is a performance gain because the maintenance controller makes a consistent read from the AttributeStore. Since this read is ommitted from every time we call the scheduling filter we gain performance. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/#review58374 --- On Oct. 24, 2014, 12:59 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27100/ --- (Updated Oct. 24, 2014, 12:59 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-878 https://issues.apache.org/jira/browse/AURORA-878 Repository: aurora Description --- Cache the host's maintenance status with the offer. By caching the status alongside the offer the scheduler does not need to access the attribute store for every offer it considers for a task. Diffs - src/main/java/org/apache/aurora/scheduler/async/OfferQueue.java 92c843830df7a779abace38bb0ce84d4cbeb5af4 src/main/java/org/apache/aurora/scheduler/async/Preemptor.java 4088559c39014befaddb0b29dad45fac9f4545c4 src/main/java/org/apache/aurora/scheduler/async/TaskScheduler.java 882cdfd9b79b262befb81437cbd9a31a6bc1e40f src/main/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilter.java 5cb0b2d15b1cd22de653946f4dfacac4cf3ab2e6 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java 1e3018e8c740ff322e0809ac2995121aa7d9b6d4 src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java da29428adaebcb27b20a10a8c6b7e380662fce4a src/main/java/org/apache/aurora/scheduler/http/Offers.java b7dfedae45bfbce8fb5890cd99fa5bd1879b8a36 src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 4db9be86f2e7db08d12e0182914a7c5130301b13 src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java c4435cb74925c9ed04a37820b22c3ecdfcad49d4 src/test/java/org/apache/aurora/scheduler/async/OfferQueueImplTest.java ddd24c38cc13e0b53dfa6d07d8c42a4d498de1ec src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142 src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87 src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java 4065629e9d488b122aa811b9802def0b51a21294 src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java c48cbae4864127e7799917182439f7670285b0d3 Diff: https://reviews.apache.org/r/27100/diff/ Testing --- ./gradlew clean build -Pq Thanks, Zameer Manji