injection of the
underlying work than to reimplement those behaviors, but i'm interested in what
you think.
- Bill Farner
On March 21, 2015, 2:19 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
https://reviews.apache.org/r/32329/#comment125511
Ditto.
- Bill Farner
On March 23, 2015, 7:14 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/#review77423
---
On March 22, 2015, 6:37 p.m., Bill Farner wrote
/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32377/diff/
Testing
---
Thanks,
Bill Farner
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32329/
---
(Updated March 23, 2015, 7:14 p.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-1187
https
/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32377/diff/
Testing
---
Thanks,
Bill Farner
---
On March 23, 2015, 6:51 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32377/
---
(Updated March 23
/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java
cc9cfd38239f909b8a77bd1a773e31ec30130d41
src/test/java/org/apache/aurora/scheduler/app/ModulesTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32377/diff/
Testing
---
Thanks,
Bill Farner
/TaskAssignerImplTest.java
06a19038f99f88d28c5548055bd82b0aebb461ac
Diff: https://reviews.apache.org/r/32369/diff/
Testing
---
Thanks,
Bill Farner
/
Testing
---
Thanks,
Bill Farner
Description
---
Use more of the built-in facilities provided by `MyBatisModule`.
Diffs
-
src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java
2a75646867a5af246625f7cf3910fd9a1bbf4f03
Diff: https://reviews.apache.org/r/32372/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32353/#review77317
---
Ship it!
Ship It!
- Bill Farner
On March 21, 2015, 12:25 a.m
.
- Bill Farner
On March 19, 2015, 9:36 p.m., Florian Pfeiffer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32231/
---
(Updated
, new patch will
come shortly with doc updates.
- Bill Farner
On March 20, 2015, 5:26 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313
,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77248
---
On March 20, 2015, 5:26 p.m., Bill Farner wrote
`test` and
conditions could silently fail.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32323/#review77261
---
Ship it!
Thanks! Good find!
- Bill Farner
On March 20, 2015, 6
'
non-integration testing, which removed a ton of boilerplate.
I also corrected some holes in the end-to-end tests, wherein `test` and
conditions could silently fail.
Thanks,
Bill Farner
, which removed a ton of boilerplate.
I also corrected some holes in the end-to-end tests, wherein `test` and
conditions could silently fail.
Thanks,
Bill Farner
/python/apache/aurora/client/cli/util.py
864a71428f58ad5ea23beb1d9ae7520c82d2d276
Diff: https://reviews.apache.org/r/32319/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313/#review77284
---
On March 20, 2015, 8:23 p.m., Bill Farner wrote
of boilerplate.
I also corrected some holes in the end-to-end tests, wherein `test` and
conditions could silently fail.
Thanks,
Bill Farner
.
I also corrected some holes in the end-to-end tests, wherein `test` and
conditions could silently fail.
Thanks,
Bill Farner
---
On March 20, 2015, 10:31 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32313
.
I also corrected some holes in the end-to-end tests, wherein `test` and
conditions could silently fail.
Thanks,
Bill Farner
---
On March 19, 2015, 9:09 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
---
(Updated March
/client/cli/update.py
f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py
cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
---
Thanks,
Bill Farner
/client/cli/update.py
f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py
cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
---
Thanks,
Bill Farner
, the last reply seems for a stale diff.
- Bill Farner
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32225/#review77143
---
Ship it!
Ship It!
- Bill Farner
On March 20, 2015, 12:25 a.m
to figure out what test case is
failing...not seeing this locally. I wasn't able to find the previous run in
the bot's build history.
- Bill Farner
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
---
This is an automatically generated e
, 2015, 1:53 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/
---
(Updated March 20, 2015, 1:53 a.m
://reviews.apache.org/r/32276/diff/
Testing
---
Thanks,
Bill Farner
, in
execute
TypeError: unhashable type: 'set'
```
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
2168e99a315dd2916086100589c8345cd3a2c4ff
Diff: https://reviews.apache.org/r/32276/diff/
Testing
---
Thanks,
Bill Farner
/update.py, line 315, in execute
TypeError: unhashable type: 'set'
```
Diffs
-
src/main/python/apache/aurora/client/cli/update.py
2168e99a315dd2916086100589c8345cd3a2c4ff
Diff: https://reviews.apache.org/r/32276/diff/
Testing
---
Thanks,
Bill Farner
---
Thanks,
Bill Farner
-found
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptorModule.java
https://reviews.apache.org/r/32220/#comment125003
Given that you probably want a singleton PreemptionSlotCache, don't forget
to bind that as such here.
- Bill Farner
On March 19, 2015, 12:29 a.m., Maxim
-
src/main/python/apache/aurora/client/cli/update.py
f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py
cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
---
Thanks,
Bill Farner
/client/cli/update.py
f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py
cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/#review77113
---
Ship it!
Ship It!
- Bill Farner
On March 17, 2015, 9:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32208/#review76947
---
Ship it!
Ship It!
- Bill Farner
On March 18, 2015, 6:28 p.m
is
`PENDING` and has been in that state long enough to warrant a preemption search.
- Bill Farner
On March 17, 2015, 5:19 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On March 17, 2015, 6:05 p.m., Bill Farner wrote:
I actually meant this should be outside the preemptor altogether. The
preemptor is being called, and then internally deciding the caller should
have not called in the first place. I claim this is odd behavior.
I think it would make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76845
---
On March 17, 2015, 11:30 p.m., Bill Farner wrote
/aurora/client/cli/update.py
f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py
cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
---
Thanks,
Bill Farner
On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 208
https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208
This reordering will result in pulsing the hostname even when an
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/#review76766
---
Ship it!
Ship It!
- Bill Farner
On March 17, 2015, 5:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31380/#review76736
---
Is this review stale? If so, discard?
- Bill Farner
On Feb. 24
/AnnotatedAuroraAdmin.java
https://reviews.apache.org/r/32141/#comment124356
Maybe s/Annotated/Authorized/? So as to say - implementations of this
interface can be assured authorization has happened. I don't feel strongly
about this.
- Bill Farner
On March 17, 2015, 1:29 a.m., Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30818/#review76737
---
Update or discard?
- Bill Farner
On Feb. 10, 2015, 6:01 a.m
/
Testing (updated)
---
Test suite + end-to-end tests.
Thanks,
Bill Farner
/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java
Bill Farner wrote:
Good point. Steve landed at this line based on my hasty direction.
You're right, though, that JobDiff is the place to move it. Perhaps this
comparison should be done in JobDiff
---
On March 16, 2015, 5:57 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/
---
(Updated March 16, 2015, 5:57
/python/apache/aurora/client/test_base.py
06c0b436b5104c9b3afbf80499d3bfc66e7ef2f4
Diff: https://reviews.apache.org/r/32078/diff/
Testing
---
Thanks,
Bill Farner
89b9ce0a4150a88e8d9099e711659b591dcdd947
src/test/python/apache/aurora/client/cli/test_supdate.py
a237da92229e21253aaca488a89af2979d94ce48
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
f255f2d0a390359da4f442505fc7b8b492dc06bb
Diff: https://reviews.apache.org/r/32077/diff/
Testing
---
Thanks,
Bill
and Bill Farner.
Bugs: AURORA-1200
https://issues.apache.org/jira/browse/AURORA-1200
Repository: aurora
Description
---
Changed the updater to not update an instance if the job owner changes
Diffs
-
src/main/java/org/apache/aurora/scheduler/updater
/
Testing (updated)
---
Running end-to-end tests in an existing vagrant setup, and will repeat with a
fresh one. Will report back before committing.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/#review76613
---
Ship it!
Ship It!
- Bill Farner
On March 16, 2015, 6:54 p.m
/test_end_to_end.sh
5cff81f4d8d220fb6c18005884d2f7a8beabaa37
Diff: https://reviews.apache.org/r/32050/diff/
Testing
---
Ran end-to-end tests, confirmed pause message is present in the job state
transitions table.
Thanks,
Bill Farner
On March 13, 2015, 2:30 a.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java,
line 279
https://reviews.apache.org/r/32014/diff/1/?file=892576#file892576line279
Ditto - this really seems like it should be client-side logging
Total time: 6.14 secs
```
Thanks,
Bill Farner
/api/test_api.py
d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py
370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
---
Thanks,
Bill Farner
to check for discrepancies.
- Bill Farner
On March 13, 2015, 1:23 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32014
,
Bill Farner
-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76243
---
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply
On March 12, 2015, 4:23 p.m., Maxim Khutornenko wrote:
src/main/python/apache/aurora/client/cli/update.py, lines 123-127
https://reviews.apache.org/r/31966/diff/2/?file=891872#file891872line123
Mind sorting them alphabetically?
Bill Farner wrote:
Done.
Spoke too soon here
On March 13, 2015, 1:10 a.m., Brian Wickman wrote:
@ReviewBot retry
If you believe you have discovered a flaky test (which i assume you're asking
the bot to try again), can you please file a ticket?
- Bill
---
This is an
:
https://reviews.apache.org/r/31828/#review75729
---
On March 7, 2015, 5:54 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
enforcing a strict audit mode.
Bill Farner wrote:
Maybe it does warrant a failure, though. IMHO truncation would be a
policy decision that the scheduler is making on behalf of the client. If the
most important part of the message is after the truncation, we've made a poor
choice.
Maxim
enforcing a strict audit mode.
Bill Farner wrote:
Maybe it does warrant a failure, though. IMHO truncation would be a
policy decision that the scheduler is making on behalf of the client. If the
most important part of the message is after the truncation, we've made a poor
choice.
Maxim
d211fb975db01e72a88312c28078e06cb622d83c
src/test/python/apache/aurora/client/cli/test_supdate.py
370a46b46d8fe9499468e0792f181e79e8042b61
Diff: https://reviews.apache.org/r/31966/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76193
---
@ReviewBot retry
- Bill Farner
On March 12, 2015, 1:27 a.m
---
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76008
---
On March 11, 2015, 12:04 a.m., Bill Farner wrote
/
Testing
---
Thanks,
Bill Farner
/TaskStatusStats.java
68214f20dd7f46adec2d8f6d84e9840dc88dc0fb
src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java
4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1
Diff: https://reviews.apache.org/r/31901/diff/
Testing
---
Thanks,
Bill Farner
src/test/java/org/apache/aurora/scheduler/mesos/TaskStatusStatsTest.java
4bbeff957050fb9d8ee81d9fc79520a6a0ac38a1
Diff: https://reviews.apache.org/r/31901/diff/
Testing
---
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820/#review75954
---
Ship it!
Ship It!
- Bill Farner
On March 10, 2015, 7:45 p.m
---
On March 10, 2015, 5:44 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 10, 2015, 5
/
Testing
---
Thanks,
Bill Farner
/
Testing
---
Thanks,
Bill Farner
/master
commit 57b5b15ab55ea4cfe32e8ed0a60a219331df1d75
Author: Brian Brazil brian.bra...@boxever.com
Date: Mon Mar 9 10:52:29 2015 -0700
Fix preformatted text when viewed on github
Reviewed at https://reviews.apache.org/r/31862/
```
- Bill Farner
On March 9, 2015, 5:47 p.m., Brian
?
Bill Farner wrote:
I think the magic user value abuses a field that serves a different
purpose. IMHO an API consumer should be able to programmatically determine
that the scheduler independently performed an action without resorting to
string matching on the magic value of a field
/
---
(Updated March 7, 2015, 12:54 a.m.)
Review request for Aurora, Joshua Cohen and Bill Farner.
Bugs: AURORA-809 and AURORA-811
https://issues.apache.org/jira/browse/AURORA-809
https://issues.apache.org/jira/browse/AURORA-811
Repository: aurora
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75761
---
On March 9, 2015, 8:10 p.m., Bill Farner wrote
---
On March 9, 2015, 8:10 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869
?
Bill Farner wrote:
I think the magic user value abuses a field that serves a different
purpose. IMHO an API consumer should be able to programmatically determine
that the scheduler independently performed an action without resorting to
string matching on the magic value of a field
---
On March 7, 2015, 1:06 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814
b65970a2717a1f36767c61e5e09c980b04895f01
Diff: https://reviews.apache.org/r/31869/diff/
Testing
---
Thanks,
Bill Farner
: https://reviews.apache.org/r/31814/diff/
Testing
---
Thanks,
Bill Farner
, visit:
https://reviews.apache.org/r/31814/#review75832
---
On March 10, 2015, 12:35 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814/#review75831
---
@ReviewBot retry
- Bill Farner
On March 10, 2015, 12:35 a.m
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814/#review75829
---
On March 10, 2015, 12:35 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814/#review75836
---
@ReviewBot retry
- Bill Farner
On March 10, 2015, 12:35 a.m
e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75812
---
On March 9, 2015, 8:39 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply
On March 7, 2015, 5:30 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/async/preemptor/PreemptionSlotFinder.java,
line 326
https://reviews.apache.org/r/31821/diff/1/?file=888148#file888148line326
Not yours, but it seems odd that we would call a function
/diff/
Testing
---
Thanks,
Bill Farner
/apache/aurora/client/cli/test_supdate.py
93a5532dc6f7aee2c40bc86385a630b9a1b6f528
src/test/python/apache/aurora/client/cli/util.py
6d3cc51f50b417405549c254531c854565a54949
Diff: https://reviews.apache.org/r/31779/diff/
Testing
---
Normal test suite + end-to-end tests.
Thanks,
Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review75224
---
Ship it!
Ship It!
- Bill Farner
On Feb. 28, 2015, 1:37 a.m
1 - 100 of 1376 matches
Mail list logo