---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32372/#review77501
---
Ship it!
Ship It!
- David McLaughlin
On March 21, 2015, 9:16
: https://reviews.apache.org/r/27848/diff/#
- David McLaughlin
On March 17, 2015, 11:54 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32050/#review76394
---
Ship it!
Ship It!
- David McLaughlin
On March 13, 2015, 4:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/#review76004
---
Ship it!
Ship It!
- David McLaughlin
On March 11, 2015, 12:04
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/
---
(Updated March 11, 2015, 12:04 a.m.)
Review request for Aurora, David McLaughlin and Joshua Cohen.
Bugs: AURORA-1077
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review75797
---
Ship it!
Ship It!
- David McLaughlin
On Feb. 28, 2015, 1:37 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31029/#review72795
---
Ship it!
Ship It!
- David McLaughlin
On Feb. 14, 2015, 12:33
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30942/#review72248
---
Ship it!
Ship It!
- David McLaughlin
On Feb. 12, 2015, 6:40 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72265
---
Ship it!
Ship It!
- David McLaughlin
On Feb. 12, 2015, 9:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30913/#review72275
---
Ship it!
Ship It!
- David McLaughlin
On Feb. 12, 2015, 2:47 a.m
/#comment118378
Sorry I missed this first review, but AFAIK this isn't true for dynamic
languages (incl. our own scheduler UI)?
- David McLaughlin
On Feb. 13, 2015, 12:35 a.m., Maxim Khutornenko wrote:
---
This is an automatically
, 2015, 6:01 a.m.)
Review request for Aurora and David McLaughlin.
Bugs: AURORA-696
https://issues.apache.org/jira/browse/AURORA-696
Repository: aurora
Description
---
Previously navigating between the active/completed/all tabs on the
job controller page did not alter
On Feb. 11, 2015, 6:58 p.m., David McLaughlin wrote:
src/main/resources/scheduler/assets/js/controllers.js, line 338
https://reviews.apache.org/r/30818/diff/2/?file=859882#file859882line338
You should never have to do this with routes in Angular. I think this
is a code smell from
time should be enforced
in scheduler rather than here.
- David McLaughlin
On Feb. 11, 2015, 1:19 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review71729
---
Ship it!
Pulse logic LGTM.
- David McLaughlin
On Feb. 7, 2015
/JobUpdateControllerImpl.java
https://reviews.apache.org/r/30225/#comment116725
I think we still want to update the last pulse time even if it's paused?
- David McLaughlin
On Feb. 4, 2015, 5:24 p.m., Maxim Khutornenko wrote
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/
---
(Updated Feb. 4, 2015, 5:24 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Bugs: AURORA
concerned about adding support for hooks in an
environment where we can't support post-hooks.
- David McLaughlin
On Feb. 4, 2015, 12:24 a.m., George Sirois wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126
https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126
Have we considered adding a batch interface, to avoid having to make
multiple RPCs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70383
---
Ship it!
Ship It!
- David McLaughlin
On Jan. 30, 2015, 5:23 p.m
This is consistent with the message above, but we should just say 'a
positive integer' here.
- David McLaughlin
On Jan. 30, 2015, 5:23 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
lines 259-263
https://reviews.apache.org/r/30225/diff/1/?file=832014#file832014line259
I am unsure why this is being called inside pulse. Once
On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
lines 259-263
https://reviews.apache.org/r/30225/diff/1/?file=832014#file832014line259
I am unsure why this is being called inside pulse. Once
On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
lines 259-263
https://reviews.apache.org/r/30225/diff/1/?file=832014#file832014line259
I am unsure why this is being called inside pulse. Once
On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
lines 259-263
https://reviews.apache.org/r/30225/diff/1/?file=832014#file832014line259
I am unsure why this is being called inside pulse. Once
On Jan. 28, 2015, 7:41 p.m., David McLaughlin wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
lines 259-263
https://reviews.apache.org/r/30225/diff/1/?file=832014#file832014line259
I am unsure why this is being called inside pulse. Once
.
David McLaughlin wrote:
AFAICT the worst race condition is sending a heartbeat for a job that is
already complete. Are there other race conditions we are protecting against?
Also, I don't see the value in persisting the heartbeats. What is the
rationale for this?
Maxim
. 23, 2015, 8:37 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Bugs: AURORA-1010
https://issues.apache.org/jira/browse/AURORA-1010
Repository: aurora
Description
---
Added pulsing support into the JobUpdateController. The qualified
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30285/#review69682
---
Ship it!
Ship It!
- David McLaughlin
On Jan. 26, 2015, 9:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68457
---
Ship it!
Ship It!
- David McLaughlin
On Jan. 16, 2015, 7:08 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29058/#review65131
---
Ship it!
Ship It!
- David McLaughlin
On Dec. 15, 2014, 9:52 p.m
. 15, 2014, 9:52 p.m.)
Review request for Aurora, David McLaughlin, Kevin Sweeney, and Zameer Manji.
Repository: aurora
Description
---
Extract mechanism for determining pex version so it can be used for cases
other than client version.
I'm going to use this for the soon
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28623/#review63783
---
Ship it!
Ship It!
- David McLaughlin
On Dec. 3, 2014, 2:13 a.m
://reviews.apache.org/r/28398/#comment104981
s/existing //
- David McLaughlin
On Nov. 24, 2014, 7:19 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28398
that validate chunking
is performing in the intended way.
- David McLaughlin
On Nov. 21, 2014, 1:53 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28272/#review62607
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 21, 2014, 1:29 a.m
On Nov. 21, 2014, 7:34 p.m., David McLaughlin wrote:
Does this code have test coverage? I can't see any tests that validate
chunking is performing in the intended way.
Kevin Sweeney wrote:
Existing test coverage in LogManagerTest validates the on-disk chunked
format is the same
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28306/#review62639
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 21, 2014, 1:53 a.m
and the creation of a temporary file if you do.
- David McLaughlin
On Nov. 21, 2014, 11:14 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28350/#review62693
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 22, 2014, 12:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28250/#review62247
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 19, 2014, 8:44 p.m
/scheduler/storage/log/SnapshotDeduplicator.java
https://reviews.apache.org/r/28272/#comment104342
Can you add a comment explaining why we're doing this?
- David McLaughlin
On Nov. 20, 2014, 1:08 a.m., Kevin Sweeney wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28140/#review62091
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 18, 2014, 12:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28103/#review61816
---
@ReviewBot retry
- David McLaughlin
On Nov. 16, 2014, 10:29 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28103/#review61815
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 16, 2014, 10:29
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28026/#review61506
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 14, 2014, 1:30 a.m
,
David McLaughlin
./build-support/python/checkstyle-check
Thanks,
David McLaughlin
---
On Nov. 13, 2014, 7:32 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/
---
(Updated Nov. 13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review61304
---
@ReviewBot retry
- David McLaughlin
On Nov. 13, 2014, 7:32 p.m
,
David McLaughlin
---
On Nov. 7, 2014, 9:17 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27698/
---
(Updated Nov. 7, 2014, 9
---
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/checkstyle-check src/
./build-support/python/isort-check src/
Thanks,
David McLaughlin
/
Testing
---
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/checkstyle-check src/
./build-support/python/isort-check src/
Thanks,
David McLaughlin
/isort-check
./build-support/python/checkstyle-check
Thanks,
David McLaughlin
---
On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848
-support/python/checkstyle-check
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27747/#review60843
---
Ship it!
Ship It!
- David McLaughlin
On Nov. 8, 2014, 12:28 a.m
inline.
- David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review60892
---
On Nov. 11, 2014, 12:58 a.m., David McLaughlin wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27770/#review60650
---
Ship it!
Awesome.
- David McLaughlin
On Nov. 8, 2014, 4:24 a.m
/
Testing
---
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/isort-check
./build-support/python/checkstyle-check
Thanks,
David McLaughlin
/cli/util.py
154fb3a7170ae81548fcbc9f3cdd6dcf9bf1942d
Diff: https://reviews.apache.org/r/27848/diff/
Testing
---
./pants src/test/python/apache/aurora/client/cli/:all
./build-support/python/isort-check
./build-support/python/checkstyle-check
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27848/#review60723
---
On Nov. 11, 2014, 12:29 a.m., David McLaughlin wrote:
---
This is an automatically
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
David McLaughlin
src.test.python.apache.aurora.client.config
. SUCCESS
David McLaughlin wrote:
Cannot reproduce this locally?
nm, I can. It's just intermittent. The joys.
- David
src.test.python.apache.aurora.client.config
. SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api
. SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api
. SUCCESS
Thanks,
David
-support/python/checkstyle-check src/test/
$ build-support/python/isort-check
Thanks,
David McLaughlin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27084/#review58387
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 23, 2014, 4:50 p.m
/27058/diff/
Testing
---
$ ./pants src/test/python/apache/aurora/:all
$ build-support/python/checkstyle-check src/test/
$ build-support/python/isort-check
Thanks,
David McLaughlin
/
Testing
---
$ ./pants src/test/python/apache/aurora/:all
$ build-support/python/checkstyle-check src/test/
$ build-support/python/isort-check
Thanks,
David McLaughlin
:
AttributeError: Mock object has no attribute 'executorConfig'
David McLaughlin wrote:
This is the behavior I observed as well. For example, see where I had to
update failure_count to failureCount because I added the spec.
I'd really prefer a separate ticket for swapping out mocks
:
AttributeError: Mock object has no attribute 'executorConfig'
David McLaughlin wrote:
This is the behavior I observed as well. For example, see where I had to
update failure_count to failureCount because I added the spec.
I'd really prefer a separate ticket for swapping out mocks
07cbe53109e8bcdd09dcac47f6353b10e095717d
Diff: https://reviews.apache.org/r/27058/diff/
Testing
---
$ ./pants src/test/python/apache/aurora/:all
$ build-support/python/checkstyle-check src/test/
$ build-support/python/isort-check
Thanks,
David McLaughlin
:
AttributeError: Mock object has no attribute 'executorConfig'
David McLaughlin wrote:
This is the behavior I observed as well. For example, see where I had to
update failure_count to failureCount because I added the spec.
I'd really prefer a separate ticket for swapping out mocks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27057/#review57920
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 22, 2014, 10:48
Oct. 21, 2014, 4:19 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-874
https://issues.apache.org/jira/browse/AURORA-874
Repository: aurora
Description
---
Adds a header line to each task in a task status line specifying
the instance
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57626
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 21, 2014, 4:19 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26991/#review57727
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 21, 2014, 7:42 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26363/#review57418
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 11:56 p.m
/20/d89be4fc-7fae-4746-841a-ccaf66e2439e__Screen_Shot_2014-10-20_at_3.55.15_PM.png
Thanks,
David McLaughlin
---
On Oct. 20, 2014, 10:55 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26956/
---
(Updated
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
screenshot.
File Attachments
screenshot
https://reviews.apache.org/media/uploaded/files/2014/10/20/d89be4fc-7fae-4746-841a-ccaf66e2439e__Screen_Shot_2014-10-20_at_3.55.15_PM.png
Thanks,
David McLaughlin
LOCAL - PENDING mean?). Am I being crazy? Would it make sense
to change it to something like (local time), or even better, instead of
hardcoding LOCAL maybe just display their actual time zone identifier
(or, since that's a minor hassle from JS, maybe just the offset)?
David McLaughlin wrote
at 5.38.50 PM.png
https://reviews.apache.org/media/uploaded/files/2014/10/21/56dd8080-7682-4b1e-adab-d7db37e22ed3__Screen_Shot_2014-10-20_at_5.38.50_PM.png
Thanks,
David McLaughlin
remembers?
- David McLaughlin
On Oct. 9, 2014, 11:02 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26531/#review56083
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 9, 2014, 11:23 p.m
, 2014, 2:42 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: aurora-779
https://issues.apache.org/jira/browse/aurora-779
Repository: aurora
Description
---
Improve handling of unknown errors in the aurora client.
Instead of dumping the stack
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55821
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 3, 2014, 1:59 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55828
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 5:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26422/#review55827
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 5:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26445/#review55849
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 8, 2014, 3:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26417/#review55663
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 7, 2014, 5:12 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55749
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 6:55 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55540
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 4:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26372/#review55542
---
Ship it!
Ship It!
- David McLaughlin
On Oct. 6, 2014, 4:58 p.m
1 - 100 of 331 matches
Mail list logo