Re: Review Request 31101: Native Debian packaging for Aurora

2015-03-02 Thread Jake Farrell
, but then would have to deal with symlinking and juggling to make it work (we did this in thrift before moving to the top level for ease). Would be good to wrap creation into a task that executed dch and dpkg commands all in one call - Jake Farrell On Feb. 17, 2015, 12:20 a.m., Benjamin Staffin

Review Request 30600: AURORA-1099: 0.7.0 missing license headers

2015-02-03 Thread Jake Farrell
://reviews.apache.org/r/30600/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 28449: Fix some URLs and text in release emails to include -incubating where appropriate.

2014-12-02 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28449/#review63560 --- Ship it! Ship It! - Jake Farrell On Nov. 25, 2014, 9 p.m., Bill

Re: Review Request 28447: Disambiguate tag push from branch push in release script.

2014-11-25 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28447/#review63037 --- Ship it! Ship It! - Jake Farrell On Nov. 25, 2014, 8:36 p.m

Re: Review Request 28198: Add an example on how to build with Docker.

2014-11-21 Thread Jake Farrell
- Jake Farrell On Nov. 19, 2014, 6:02 p.m., Tony Dong wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28198/ --- (Updated

Review Request 28170: AURORA-933 - python missing license headers

2014-11-18 Thread Jake Farrell
/api_util.py 6e12154fcd6609b763935b9fb7458946efd7d3d6 Diff: https://reviews.apache.org/r/28170/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 27830: Undo 0.6.0 .auroraversion and CHANGELOG changes to prepare for 0.6.0-RC1

2014-11-10 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27830/#review60680 --- Ship it! Ship It! - Jake Farrell On Nov. 10, 2014, 9:11 p.m

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711 https://issues.apache.org/jira

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59111 --- Ship it! Ship It! - Jake Farrell On Oct. 29, 2014, 11:38 p.m

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27253/#review58750 --- why is this not being handled via the release scripts? - Jake

Re: Review Request 27253: Raise .auroraversion to 0.6.0-SNAPSHOT

2014-10-27 Thread Jake Farrell
On Oct. 28, 2014, 1:48 a.m., Jake Farrell wrote: why is this not being handled via the release scripts? ignore, know the reasoning (minor vs major updated during last 0.5.0rc) - Jake --- This is an automatically generated e-mail

Re: Review Request 26852: Use mesos.native egg from ~kevints

2014-10-17 Thread Jake Farrell
://reviews.apache.org/r/26852/#comment97672 What about putting it in svn rather that on people.a.o, perhaps in http://svn.apache.org/repos/asf/incubator/aurora/3rdparty/ - Jake Farrell On Oct. 17, 2014, 1:50 a.m., Kevin Sweeney wrote

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-23 Thread Jake Farrell
as well go with the latest version https://github.com/giampaolo/psutil/blob/master/HISTORY.rst - Jake Farrell On Sept. 9, 2014, 6:38 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24173: AURORA-607:release script is broken

2014-09-22 Thread Jake Farrell
with this script: * git checkout 0.5.0-rc2 * apply this patch * comment out dirty tree exit condition, line 89 of ./build-support/release/release * test with: ./build-support/release/release -r 2 * rm -rf dist * publish with: ./build-support/release/release -r 2 -p Thanks, Jake Farrell

Review Request 25898: AURORA-736 - Update committer docs with steps for adding a gpg key

2014-09-22 Thread Jake Farrell
/ Testing --- Thanks, Jake Farrell

Review Request 24173: AURORA-607:release script is broken

2014-07-31 Thread Jake Farrell
this patch * comment out dirty tree exit condition, line 89 of ./build-support/release/release * test with: ./build-support/release/release -r 2 * rm -rf dist * publish with: ./build-support/release/release -r 2 -p Thanks, Jake Farrell

Re: Review Request 23329: remove embedded jquery

2014-07-30 Thread Jake Farrell
* should be removed in favor of using 3rdparty bower components (these are the last deps in the src tree that are not in 3rdparty currently) - Jake Farrell On July 9, 2014, 9:50 p.m., David Robinson wrote: --- This is an automatically

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Jake Farrell
overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? - Jake Farrell On July 29, 2014, 7:14 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 23931: AURORA-600:RC2 License and NOTICE updates

2014-07-25 Thread Jake Farrell
86fbd708d9806db4d92fa76fdea17666193e5518 Diff: https://reviews.apache.org/r/23931/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 23931: AURORA-600:RC2 License and NOTICE updates

2014-07-25 Thread Jake Farrell
8510f4899325c3da52b66cfad3ed2378167c6b94 NOTICE 86fbd708d9806db4d92fa76fdea17666193e5518 Diff: https://reviews.apache.org/r/23931/diff/ Testing --- Thanks, Jake Farrell

Review Request 23876: AURORA-599 - Reset changelog and version for 0.5.0 rc2

2014-07-23 Thread Jake Farrell
recent resolved tickets since 0.5.0-rc1 was cut that did not get tagged correctly. Diffs - .auroraversion 0034eec93d9d40c8039735f01192121bd2edebea CHANGELOG 017b54652c3d16017f908829d98d3d842e51dbbe Diff: https://reviews.apache.org/r/23876/diff/ Testing --- Thanks, Jake

Review Request 23688: AURORA-590: Release scripts branch and CHANGELOG urls are wrong in generated email template

2014-07-18 Thread Jake Farrell
=CHANGELOGhb=0.5.0-rc1 The branch used to create the release candidate is: https://git-wip-us.apache.org/repos/asf?p=incubator-aurora.githb=0.5.0-rc1 Thanks, Jake Farrell

Re: Review Request 23595: Add the gradle shadow plugin (for fat jar support)

2014-07-17 Thread Jake Farrell
On July 17, 2014, 5:33 p.m., Bill Farner wrote: 'Fat jars' are inherently problematic. Some libraries expect resources at well-known locations, which would be candidate for brittleness when there are collisions. Jar signing is also broken by this approach. Unless there's a

Review Request 23317: AURORA-565:update top level README with instructions on bootstrapping and running initial test

2014-07-07 Thread Jake Farrell
/jfarrell/incubator-aurora/tree/AURORA-565 Diffs - README.md 82096f60c5eed8d34a1c180e975052405329d39a Diff: https://reviews.apache.org/r/23317/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 23238: Move license header to inner node in angular fragments.

2014-07-02 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23238/#review47230 --- Ship it! Ship It! - Jake Farrell On July 2, 2014, 6:56 p.m

Re: Review Request 22983: AURORA-278 - Remove binaries from source RC

2014-06-28 Thread Jake Farrell
generated e-mail. To reply, visit: https://reviews.apache.org/r/22983/#review46884 --- On June 25, 2014, 8:18 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail

Re: Review Request 21402: Add python checkstyle hooks.

2014-06-25 Thread Jake Farrell
output so it is not forgotten about - Jake Farrell On May 13, 2014, 8:04 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-06-25 Thread Jake Farrell
automation around reviewboard. This seems to turn github into a back door of sorts for changes to not receive the same level of scrutiny. What are your thoughts? Jake Farrell wrote: Github makes it easier for some to contribute patches, but we should require the same criteria as we

Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Jake Farrell
/sh/org/apache/aurora/e2e/http/http_example.aurora 80871273fc4d47558253e6b09c92724e8693bc11 src/test/sh/org/apache/aurora/e2e/http/http_example_updated.aurora fc723cf232ddbc10458fc394e37358c8523118c2 Diff: https://reviews.apache.org/r/22976/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 22976: AURORA-552: License headers missing

2014-06-25 Thread Jake Farrell
/diff/ Testing --- Thanks, Jake Farrell

Review Request 22983: AURORA-278 - Remove binaries from source RC

2014-06-25 Thread Jake Farrell
/ Testing --- ./builds-support/release/release-candidate -r 1 -l m verified gig sig, md5, sha, untared release and looked for binary artifacts. Additional review opened to address missing headers Thanks, Jake Farrell

Re: Review Request 22956: AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output

2014-06-25 Thread Jake Farrell
://reviews.apache.org/r/22956/diff/ Testing --- ./gradlew -Pq clean build Thanks, Jake Farrell

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

2014-06-25 Thread Jake Farrell
/19796/diff/ Testing --- Was initially waiting on AURORA-132 for this. ran build-support/jenkins/build.sh and created dists with no issues. Thanks, Jake Farrell

Re: Review Request 21402: Add python checkstyle hooks.

2014-05-19 Thread Jake Farrell
file rather than /dev/null and prompting to re-run on error? - Jake Farrell On May 13, 2014, 8:04 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21402

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-05-16 Thread Jake Farrell
generated e-mail. To reply, visit: https://reviews.apache.org/r/20407/#review41435 --- On April 17, 2014, 4 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail

Re: Review Request 21386: Add support for custom project to list-missing-shipits

2014-05-16 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21386/#review43080 --- please create a jira issue for this and then +1 - Jake Farrell

Review Request 21253: AURORA-392: Add apache- to source distribution name

2014-05-15 Thread Jake Farrell
-incubating.tar.gz.asc apache-aurora-0.5.1-rc0-incubating.tar.gz.sha Thanks, Jake Farrell

Review Request 21111: AURORA-388 - Update changelog to only pickup fixed issues

2014-05-06 Thread Jake Farrell
6bd8ee9e6136c13e223bc166a06c8d80dce2468a Diff: https://reviews.apache.org/r/2/diff/ Testing --- Removed CHANGELOG file and switched .auroraversion to 0.5.0 and re-ran script, came back with 160 issues vs the 183 currently listed. Thanks, Jake Farrell

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-05-03 Thread Jake Farrell
/test_thermos_executor.py https://reviews.apache.org/r/21055/#comment75843 Nice catch - Jake Farrell On May 4, 2014, 12:02 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 21055: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-05-03 Thread Jake Farrell
at the review group than the actual patch iteself. Thanks for picking this up and finishing the work on it - Jake Farrell On May 4, 2014, 12:02 a.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

2014-04-30 Thread Jake Farrell
, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs. Thanks, Jake Farrell

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

2014-04-30 Thread Jake Farrell
-candidate and docs. Thanks, Jake Farrell

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-29 Thread Jake Farrell
On April 28, 2014, 11 p.m., Maxim Khutornenko wrote: FWIW, I found gradle run incredibly valuable when working on a fix for AURORA-366. Doing the same in Vagrant would take order of magnitude more time. I vote in favor of keeping the isolated mode as a quick dev/debug iteration way.

Re: Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers

2014-04-29 Thread Jake Farrell
?(Apache Software Foundation) } Thanks, Jake Farrell

Review Request 20782: AURORA-278:Review Incubator release check list

2014-04-28 Thread Jake Farrell
/ Testing --- Thanks, Jake Farrell

Re: Review Request 20782: AURORA-278:Review Incubator release check list

2014-04-28 Thread Jake Farrell
720805eff74008a71bb5febd6d13996b341f23cd Diff: https://reviews.apache.org/r/20782/diff/ Testing --- Thanks, Jake Farrell

Review Request 20824: AURORA-278: Review Incubator release check list - missing license headers

2014-04-28 Thread Jake Farrell
| content = File.open(f).read(); next if content.empty? ; puts f unless File.open(f).read().include?(Apache Software Foundation) } Thanks, Jake Farrell

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

2014-04-27 Thread Jake Farrell
434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 19710: AURORA-78: automate and enforce release workflow

2014-04-27 Thread Jake Farrell
these in dry-run mode, getting to the point where I can not test the release script as it requires things to be published to the dev dist. Have some changes in release script that are pending, but wanted to get feedback on the release-candidate and docs. Thanks, Jake Farrell

Re: Review Request 20735: Upgrade aurora repo to twitter.common.python 0.5.4

2014-04-25 Thread Jake Farrell
On April 25, 2014, 9:08 p.m., Kevin Sweeney wrote: Is there a changelog? What's coming in here? Is there a ticket open for this? - Jake --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Jake Farrell
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? +1 with dist added - Jake --- This is an

Re: Review Request 19627: Updates documentation files for markdown consistency

2014-04-24 Thread Jake Farrell
- Jake Farrell On April 24, 2014, 12:43 a.m., Dave Lester wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19627

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Jake Farrell
for development, do we want to pull 2.6 out of that check list if we are seeing these errors from stdlib caused in that version? - Jake Farrell On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/#review41345 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 1:33 a.m

Re: Review Request 20650: Exclude reports directory from idea project.

2014-04-24 Thread Jake Farrell
On April 24, 2014, 6:36 a.m., Suman Karumuri wrote: build.gradle, line 338 https://reviews.apache.org/r/20650/diff/1/?file=566717#file566717line338 Can we add dist/ to this list? Jake Farrell wrote: +1 with dist added Bill Farner wrote: You cannot exclude dist

Re: Review Request 20678: Remove unused mootools dependency

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/#review41365 --- Ship it! Ship It! - Jake Farrell On April 24, 2014, 6:46 p.m

Re: Review Request 20027: AURORA-234: Replace HTML tables in docs with markdown

2014-04-24 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20027/#review41436 --- Ship it! Ship It! - Jake Farrell On April 9, 2014, 2:31 a.m

Re: Review Request 20571: Replace sed command with linux and OSX-friendly perl expression.

2014-04-22 Thread Jake Farrell
- Jake Farrell On April 22, 2014, 7:55 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20571/ --- (Updated

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-21 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40990 --- Ship it! Ship It! - Jake Farrell On April 21, 2014, 7:47 p.m

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-19 Thread Jake Farrell
No longer need the flag based on bootstrapThrift changes in trunk - Jake Farrell On April 10, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-19 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20238/#review40853 --- +1 with changes mentioned - Jake Farrell On April 10, 2014, 10

Re: Review Request 20246: AURORA-299: use system thrift if available

2014-04-18 Thread Jake Farrell
Thrift installed Thanks, Jake Farrell

Re: Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-04-16 Thread Jake Farrell
) - .reviewboardrc a66e6fd0da9102f760381401b56b41b29c8d6f4d rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell

Re: Review Request 20377: Use git-describe to generate version number.

2014-04-15 Thread Jake Farrell
, 2014, 9:23 p.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-320 https://issues.apache.org/jira/browse/AURORA-320 Repository: aurora Description --- Use git-describe to generate version number instead of .auroraversion. Diffs

Review Request 20407: AURORA-323:Add ability to merge in github pull requests similar to rbt

2014-04-15 Thread Jake Farrell
-CREATION build-support/rbt/rbt-github/setup.py PRE-CREATION rbt b03c87f9df129a03cced6ec088aa5ed3e16edfe0 Diff: https://reviews.apache.org/r/20407/diff/ Testing --- Preview a pull request patch ./rbt github -p 7 Commit a pull request ./rbt github -c 7 Thanks, Jake Farrell

Re: Review Request 20188: Update end-to-end test for single-node cluster

2014-04-10 Thread Jake Farrell
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20188/ --- (Updated April 10, 2014, 1:29 a.m.) Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA

Review Request 20246: AURORA-299: use system thrift if available

2014-04-10 Thread Jake Farrell
cdcc0158079bc91b5c10fad4e7c80d2f98da227f Diff: https://reviews.apache.org/r/20246/diff/ Testing --- ran build with and without Thrift installed Thanks, Jake Farrell

Re: Review Request 20238: Optionally use system-installed thrift in build.gradle, use this in vagrant devcluster.

2014-04-10 Thread Jake Farrell
, have a slightly different patch for build.gradle which automates the check and building of Thrift, will throw it up for review - Jake Farrell On April 10, 2014, 10:44 p.m., Bill Farner wrote: --- This is an automatically generated e-mail

Re: Review Request 19955: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-04-02 Thread Jake Farrell
On April 2, 2014, 8:18 p.m., Jake Farrell wrote: build-support/jenkins/build_mesos.sh, line 25 https://reviews.apache.org/r/19955/diff/1/?file=546083#file546083line25 Should be downloaded from Apache url http://www.us.apache.org/dist/thrift/$MESOS_VERSION/ ha, sorry

Review Request 19796: AURORA-145:Test dependencies leak into distribution

2014-03-28 Thread Jake Farrell
and created dists with no issues. Thanks, Jake Farrell

Re: Review Request 19462: [AURORA-282] add gradle target distDeb

2014-03-28 Thread Jake Farrell
/ --- (Updated March 27, 2014, 1:23 p.m.) Review request for Aurora and Jake Farrell. Bugs: AURORA-282 https://issues.apache.org/jira/browse/AURORA-282 Repository: aurora Description --- Add a gradle target distDeb producing a deb package using fpm gradle

Review Request 19710: AURORA-78: automate and enforce release workflow

2014-03-26 Thread Jake Farrell
-CREATION build-support/release/tag-release abfe505fb3531b137a090ea50f4d703f98e4f18b docs/committers.md PRE-CREATION docs/contributing.md 434116378711f40877f6f7af15af8545b5335ec0 Diff: https://reviews.apache.org/r/19710/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.

2014-03-25 Thread Jake Farrell
Can remove all of these yaml headers in the markdown documentation and just use the following in config.rb to map the layout page /documentation/*, :layout = documentation - Jake Farrell On March 25, 2014, 7:57 p.m., Dave Lester wrote

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-03-21 Thread Jake Farrell
- Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote

Re: Review Request 19462: [AURORA-282] add gradle target distDeb

2014-03-20 Thread Jake Farrell
. At quick glance looks like some spacing is off and there are some extra comments. Thanks again for the work on this - Jake Farrell On March 20, 2014, 3:43 p.m., Damien Hardy wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

2014-03-10 Thread Jake Farrell
changed to version 2.5.0 BUILD SUCCESSFUL Thanks, Jake Farrell

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

2014-03-10 Thread Jake Farrell
the following modules: - com.google.protobuf:protobuf-java:2.4.1 - com.google.protobuf:protobuf-java:2.5.0 changed to version 2.5.0 BUILD SUCCESSFUL Thanks, Jake Farrell

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

2014-02-27 Thread Jake Farrell
On Feb. 27, 2014, 2:54 a.m., Maxim Khutornenko wrote: This change needs to be split into at least 3 checkins to ensure proper upgrade story: - thrift changes along with scheduler changes: dual write in storage.thrift and StorageBackfill to ensure smooth deploy rollback - client

Re: Review Request 18580: Upgrade mesos to 0.16.0

2014-02-27 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35685 --- Ship it! Ship It! - Jake Farrell On Feb. 27, 2014, 6:53 p.m

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-02-27 Thread Jake Farrell
On Feb. 27, 2014, 11:04 p.m., Kevin Sweeney wrote: build.gradle, lines 251-260 https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to

Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.

2014-02-26 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review3 --- Ship it! Ship It! - Jake Farrell On Feb. 26, 2014, 7:07 p.m

Re: Review Request 18294: Update gradle wrapper to 1.11

2014-02-20 Thread Jake Farrell
and if this comes up as an issue we can either automate adding a license header at that time with the gradle-license-plugin or remove gradlew and add a bootstrap script to generate it (and adding gradle* to the gitignore) - Jake Farrell On Feb. 20, 2014, 5:50 p.m., Bill Farner wrote

Re: Review Request 17771: AURORA-193: Fix license plugin

2014-02-20 Thread Jake Farrell
On Feb. 6, 2014, 5:23 a.m., Jake Farrell wrote: The new patch does not modify the gradle-license-plugin sourceSet as intended, it ends up using the default of sourceSet.all in the plugin which grabs all resources, dist, and 3rdparty dirs. Digging into the code the license plugin

Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.

2014-02-19 Thread Jake Farrell
On Feb. 20, 2014, 2:05 a.m., Maxim Khutornenko wrote: dist/generated-src/gen-java/.empty, line 1 https://reviews.apache.org/r/18297/diff/1/?file=498504#file498504line1 Any chance these could be replaced by a something like createPath task that the idea task would dependOn? More:

Re: Review Request 18294: Update gradle wrapper to 1.11

2014-02-19 Thread Jake Farrell
We should add the version of gradle in use as a task to make sure that if the wrapper is regenerated it always uses the same set version ( http://www.apache.org/dev/release.html#what) task wrapper(type: Wrapper) { gradleVersion = '1.11' } - Jake Farrell On Feb

Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Jake Farrell
/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell

Review Request 17768: AURORA-193: License header cleanup

2014-02-05 Thread Jake Farrell
SUCCESSFUL Thanks, Jake Farrell

Review Request 17717: License header cleanup introduced in a584410c.

2014-02-04 Thread Jake Farrell
/RescheduleCalculatorImplTest.java c450276dfaf1f676f63ce55ec37e1d256c993164 src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 940dac4e47bd19e48e8226def245a53ad6f19710 Diff: https://reviews.apache.org/r/17717/diff/ Testing --- Thanks, Jake Farrell

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-28 Thread Jake Farrell
://reviews.apache.org/r/17457/#comment62126 requirements moved to global location in AURORA-30 to 3rdparty/python/BUILD - Jake Farrell On Jan. 28, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Jake Farrell
tests for java and python locally Thanks, Jake Farrell

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-21 Thread Jake Farrell
On Jan. 21, 2014, 11:32 p.m., Kevin Sweeney wrote: Thanks for taking care of this Bill. Aside: this seems to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment). Bill Farner wrote: reference it on the first line of your commit

Review Request 17106: AURORA-60:Commit e1aee67 re-creates src/main/python/twitter after namespace change occurring

2014-01-19 Thread Jake Farrell
, Jake Farrell

Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)

2014-01-19 Thread Jake Farrell
. SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell

Re: Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)

2014-01-19 Thread Jake Farrell
. SUCCESS src.test.python.apache.thermos.core.test_staged_kill . SUCCESS src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell

Re: Review Request 17110: AURORA-3:Adding license header to missing files (py, bash, thrift, ...)

2014-01-19 Thread Jake Farrell
src.test.python.apache.thermos.monitoring.test_disk . SUCCESS Thanks, Jake Farrell

Re: Review Request 17057: Deploying Aurora documentation improvements

2014-01-17 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17057/#review32204 --- Ship it! Ship It! - Jake Farrell On Jan. 17, 2014, 6:47 p.m

Re: Review Request 16868: Fix build break caused by a584410.

2014-01-14 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16868/#review31805 --- Ship it! Ship It! - Jake Farrell On Jan. 14, 2014, 8:53 p.m