On March 20, 2015, 3:52 p.m., Joe Smith wrote:
It seems like the `self.quitquitquit` is the important part (on line 340 of the
runner)- doesn't decreasing the timeout not give `quitquitquit` the time it
needs?
- Joe
On March 20, 2015, 3:52 p.m., Joe Smith wrote:
Joe Smith wrote:
It seems like the `self.quitquitquit` is the important part (on line 340
of the runner)- doesn't decreasing the timeout not give `quitquitquit` the
time it needs?
In `src/main/python/apache/aurora/executor
https://reviews.apache.org/r/32221/#comment125192
Maybe also decrease
```
366poll_interval=Amount(500, Time.MILLISECONDS),
```
?
- Joe Smith
On March 18, 2015, 6:20 p.m., Brian Wickman wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76782
---
Ship it!
- Joe Smith
On March 13, 2015, 12:38 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32013/#review76794
---
Ship it!
Ship It!
- Joe Smith
On March 17, 2015, 1:24 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32131/#review76713
---
Ship it!
Ship It!
- Joe Smith
On March 16, 2015, 3:18 p.m
://reviews.apache.org/r/31913/#comment123828
what does this line do?
- Joe Smith
On March 10, 2015, 7:53 p.m., David Robinson wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review76305
---
Ship it!
+10 :)
- Joe Smith
On March 12, 2015, 4:13 p.m., David
,
Joe Smith
/31774/
---
(Updated March 5, 2015, 12:31 p.m.)
Review request for Aurora, Joe Smith and Zameer Manji.
Bugs: AURORA-1133
https://issues.apache.org/jira/browse/AURORA-1133
Repository: aurora
Description
---
Just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559/#review75210
---
Ship it!
Ship It!
- Joe Smith
On March 4, 2015, 10:52 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review75074
---
Ship it!
Ship It!
- Joe Smith
On March 3, 2015, 2:58 p.m
On March 1, 2015, 12:47 p.m., Joe Smith wrote:
src/test/python/apache/thermos/observer/test_detector.py, line 76
https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76
I think it's worthy to make this (and others) explicitly:
assert on_active.mock_calls
()` right?
src/test/python/apache/thermos/observer/test_detector.py
https://reviews.apache.org/r/31451/#comment121378
I think it's worthy to make this (and others) explicitly:
assert on_active.mock_calls == [mock.call(TASK1[0], TASK1[1]]
- Joe Smith
On Feb. 27, 2015, 3:36 p.m., Brian
/#comment120939
If these are going to run in CI, we shouldn't add 'real' disk
unfortunately. This could roll up into an 'integration' test, but I'm not a fan
of adding a disk dependency to the tests
- Joe Smith
On Feb. 26, 2015, noon, Brian Wickman wrote
for me... thank you!!
:)
- Joe Smith
On Feb. 24, 2015, 2:12 p.m., Stephan Erb wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31350
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31380/#review73938
---
Ship it!
Ship It!
- Joe Smith
On Feb. 24, 2015, 1:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73658
---
Ship it!
Ship It!
- Joe Smith
On Feb. 23, 2015, 12:23 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31137/#review72809
---
Ship it!
Ship It!
- Joe Smith
On Feb. 17, 2015, 1:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31135/#review72799
---
Ship it!
Ship It!
- Joe Smith
On Feb. 17, 2015, 1:15 p.m
) but if you don't mind adding docs here
that'd be ~alright.
- Joe Smith
On Feb. 9, 2015, 3:16 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749
/test_health_checker.py
https://reviews.apache.org/r/30647/#comment117704
I have a hard time believing this is going to be un-flaky, but not based on
quantitative analysis.
- Joe Smith
On Feb. 6, 2015, 3:13 p.m., Brian Wickman wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71520
---
On Feb. 6, 2015, 2 p.m., Joe Smith wrote
:04 00:08 [junit]
21:16:04 00:08 [specs]
SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30752/#review71527
---
Ship it!
Ship It!
- Joe Smith
On Feb. 6, 2015, 3:52 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/#review71510
---
On Feb. 6, 2015, 2 p.m., Joe Smith wrote
:04 00:08 [junit]
21:16:04 00:08 [specs]
SUCCESS
Thanks,
Joe Smith
21:16:04 00:08 [junit]
21:16:04 00:08 [specs]
SUCCESS
Thanks,
Joe Smith
seconds
21:16:04 00:08 [junit]
21:16:04 00:08 [specs]
SUCCESS
Thanks,
Joe Smith
refactoring
Joe Smith wrote:
Not quite- if this were for a different test then I'd agree, but since
we're actually testing TaskResourceMonitor, we'll want to mock out that
behavior (and test it separately) to ensure this method is using it right.
(At some point
/#review71284
---
On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649
/30649/diff/
Testing
---
Reviewed the diff [for
twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194)
and
```
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```
Thanks,
Joe Smith
---
```sh
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```
Thanks,
Joe Smith
, visit:
https://reviews.apache.org/r/30649/#review71148
---
On Feb. 4, 2015, 8:07 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29171/#review70692
---
/nudge
- Joe Smith
On Dec. 17, 2014, 12:31 p.m., Brian Wickman
/#comment112102
good idea
- Joe Smith
On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29423/#review66166
---
Ship it!
Ship It!
- Joe Smith
On Dec. 25, 2014, 10:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29426/#review66167
---
Ship it!
Ship It!
- Joe Smith
On Dec. 25, 2014, 11:28 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29286/#review65729
---
Ship it!
Ship It!
- Joe Smith
On Dec. 19, 2014, 7:05 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29132/#review65430
---
Ship it!
Ship It!
- Joe Smith
On Dec. 16, 2014, 4:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29171/#review65431
---
Ship it!
Ship It!
- Joe Smith
On Dec. 17, 2014, 12:31 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27710/#review60454
---
Ship it!
Ship It!
- Joe Smith
On Nov. 6, 2014, 3:40 p.m
---
On Oct. 24, 2014, 5:12 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27182/
---
(Updated Oct. 24
==
src.test.python.apache.thermos.monitoring.test_resource
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27188/#review58480
---
Ship it!
Ship It!
- Joe Smith
On Oct. 24, 2014, 8:17 p.m., Bill
Thanks,
Joe Smith
Thanks,
Joe Smith
=
src.test.python.apache.aurora.admin.admin_util
. SUCCESS
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
Thanks,
Joe
On Oct. 22, 2014, 4:24 p.m., Mark Chu-Carroll wrote:
src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252
https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252
I don't think this needs to be a mock at all - I'm pretty sure that you
can just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review57164
---
Ship it!
Ship It!
- Joe Smith
On Oct. 17, 2014, 8:48 a.m
==
src.test.python.apache.aurora.client.cli.aurora_command_line
. SUCCESS
Thanks,
Joe Smith
---
On Oct. 15, 2014, 11:02 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/
---
(Updated Oct
==
src.test.python.apache.aurora.client.cli.status
. SUCCESS
Thanks,
Joe Smith
p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26828/
---
(Updated Oct. 16, 2014, 2:40 p.m.)
Review
, 2014, 6:50 p.m.)
Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji.
Bugs: AURORA-863
https://issues.apache.org/jira/browse/AURORA-863
Repository: aurora
Description
---
Use mesos.native egg from ~kevints
Diffs
-
examples/vagrant
https://reviews.apache.org/r/26458/#comment97177
mock_wait.assert_called_once_with
- Joe Smith
On Oct. 10, 2014, 3 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26432/#review55839
---
Ship it!
Awesome
- Joe Smith
On Oct. 8, 2014, 10:28 a.m., Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26308/#review55858
---
Ship it!
Ship It!
- Joe Smith
On Oct. 4, 2014, 10:55 a.m., Bill
https://reviews.apache.org/r/26431/#comment96235
can this be a mock that we assert gets called 3 times?
(This test is a little bit of an integration test since it goes in and is
also testing perform_maintenace, but a full refactor of this test may be too
much for now)
- Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55860
---
Ship it!
Inlining inside `__init__` WFM. thanks!
- Joe Smith
assert on how many times this was called?
- Joe Smith
On Oct. 8, 2014, 2:40 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458
the before/after.
- Joe Smith
On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55727
---
Ship it!
Aha, here we go. Thanks!!
- Joe Smith
On Oct. 7, 2014
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions
=
src.test.python.apache.aurora.client.cli.help
. FAILURE
Thanks,
Joe Smith
=
src.test.python.apache.aurora.client.cli.help
. FAILURE
Thanks,
Joe Smith
/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$
./build-support/jenkins/build.sh
Thanks,
Joe Smith
-132-201 aurora (yasumoto/pants_0.0.24)]$
./build-support/jenkins/build.sh
Thanks,
Joe Smith
/test_helper.py
https://reviews.apache.org/r/25972/#comment95731
from psutil._common import puids
- Joe Smith
On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
https://reviews.apache.org/r/26308/#comment95761
Can you also assert that this was called?
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
https://reviews.apache.org/r/26308/#comment95762
can you instead .assert_called_once_with(args) ?
- Joe Smith
On Oct. 2, 2014, 9:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/#review55410
---
Ship it!
Ship It!
- Joe Smith
On Oct. 3, 2014, 3:16 p.m., Brian
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions
https://reviews.apache.org/r/26308/#comment95691
you need to set a spec here
Mock(SchedulerClient)
- Joe Smith
On Oct. 2, 2014, 7:38 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55091
---
Ship it!
Wow.
- Joe Smith
On Oct. 1, 2014, 10:27 a.m., Bill
://reviews.apache.org/r/26137/#comment95276
Could you update a test case to catch accessing these as properties to
catch accidental regressions?
- Joe Smith
On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26089/#review54704
---
Ship it!
Ship It!
- Joe Smith
On Sept. 26, 2014, 10:53 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54570
---
Ship it!
Ship It!
- Joe Smith
On Sept. 25, 2014, 11:09 a.m
https://reviews.apache.org/r/25970/#comment94757
Isn't this not needed if you're specifying a side_effect?
- Joe Smith
On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review53367
---
Ship it!
Ship It!
- Joe Smith
On Sept. 15, 2014, 11:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25667/#review53419
---
Ship it!
Ship It!
- Joe Smith
On Sept. 15, 2014, 3:04 p.m
://reviews.apache.org/r/25582/#comment92646
test_ssh_job_not_found
src/test/python/apache/aurora/client/cli/test_task_run.py
https://reviews.apache.org/r/25582/#comment92647
Test the ssh command for proper behavior when no tasks are found within a
job or something, I think
- Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53189
---
Ship it!
Ship It!
- Joe Smith
On Sept. 12, 2014, 10:17 a.m
On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote:
src/test/python/apache/aurora/client/cli/test_task_run.py, line 228
https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228
Test the ssh command for proper behavior when no tasks are found
within a job or something
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25543/#review53242
---
Ship it!
awesome- thanks!
- Joe Smith
On Sept. 11, 2014, 9:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
---
can you also add e2e test coverage?
- Joe Smith
On Sept. 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52968
---
Ship it!
Ship It!
- Joe Smith
On Sept. 10, 2014, 3:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52674
---
Ship it!
awesome
- Joe Smith
On Sept. 8, 2014, 7:13 p.m., Brian
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25346/#review52334
---
Ship it!
thanks!
- Joe Smith
On Sept. 4, 2014, 11:48 a.m., Bill
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
---
On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
---
On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
---
On Sept. 4, 2014, 8 p.m., Joe Smith wrote:
---
This is an automatically
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
aurora job run?
Joe Smith wrote:
Kevin and Toby, can you two take a look at this ASAP? I'd like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52198
---
On Sept. 2, 2014, 9:06 p.m., Joe Smith wrote
src.test.python.apache.aurora.executor.thermos_executor
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
://reviews.apache.org/r/25208/#review52049
---
On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
1 - 100 of 161 matches
Mail list logo