Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? - Joe

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
On March 20, 2015, 3:52 p.m., Joe Smith wrote: Joe Smith wrote: It seems like the `self.quitquitquit` is the important part (on line 340 of the runner)- doesn't decreasing the timeout not give `quitquitquit` the time it needs? In `src/main/python/apache/aurora/executor

Re: Review Request 32221: Remove excessively low timeout in SIGTERM swallowing test.

2015-03-20 Thread Joe Smith
https://reviews.apache.org/r/32221/#comment125192 Maybe also decrease ``` 366poll_interval=Amount(500, Time.MILLISECONDS), ``` ? - Joe Smith On March 18, 2015, 6:20 p.m., Brian Wickman wrote

Re: Review Request 32012: Improve TaskDetector performance by memoizing regular expressions

2015-03-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32012/#review76782 --- Ship it! - Joe Smith On March 13, 2015, 12:38 p.m., Brian

Re: Review Request 32013: Cache TaskDetectors for reuse.

2015-03-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32013/#review76794 --- Ship it! Ship It! - Joe Smith On March 17, 2015, 1:24 p.m

Re: Review Request 32131: Get CI to build python sdists.

2015-03-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32131/#review76713 --- Ship it! Ship It! - Joe Smith On March 16, 2015, 3:18 p.m

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Joe Smith
://reviews.apache.org/r/31913/#comment123828 what does this line do? - Joe Smith On March 10, 2015, 7:53 p.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31913/#review76305 --- Ship it! +10 :) - Joe Smith On March 12, 2015, 4:13 p.m., David

Review Request 31918: Improve response logging in TRequestsTransport

2015-03-10 Thread Joe Smith
, Joe Smith

Re: Review Request 31774: Add aurora-specific entry point for thermos observer and fix /vars

2015-03-09 Thread Joe Smith
/31774/ --- (Updated March 5, 2015, 12:31 p.m.) Review request for Aurora, Joe Smith and Zameer Manji. Bugs: AURORA-1133 https://issues.apache.org/jira/browse/AURORA-1133 Repository: aurora Description --- Just

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-03-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review75210 --- Ship it! Ship It! - Joe Smith On March 4, 2015, 10:52 a.m

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review75074 --- Ship it! Ship It! - Joe Smith On March 3, 2015, 2:58 p.m

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-03 Thread Joe Smith
On March 1, 2015, 12:47 p.m., Joe Smith wrote: src/test/python/apache/thermos/observer/test_detector.py, line 76 https://reviews.apache.org/r/31451/diff/6/?file=881004#file881004line76 I think it's worthy to make this (and others) explicitly: assert on_active.mock_calls

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-03-01 Thread Joe Smith
()` right? src/test/python/apache/thermos/observer/test_detector.py https://reviews.apache.org/r/31451/#comment121378 I think it's worthy to make this (and others) explicitly: assert on_active.mock_calls == [mock.call(TASK1[0], TASK1[1]] - Joe Smith On Feb. 27, 2015, 3:36 p.m., Brian

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Joe Smith
/#comment120939 If these are going to run in CI, we shouldn't add 'real' disk unfortunately. This could roll up into an 'integration' test, but I'm not a fan of adding a disk dependency to the tests - Joe Smith On Feb. 26, 2015, noon, Brian Wickman wrote

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Joe Smith
for me... thank you!! :) - Joe Smith On Feb. 24, 2015, 2:12 p.m., Stephan Erb wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31350

Re: Review Request 31380: Now that we've identified not calling .converge as a source of flakiness, remove epsilon from health checker tests.

2015-02-24 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31380/#review73938 --- Ship it! Ship It! - Joe Smith On Feb. 24, 2015, 1:27 p.m

Re: Review Request 31251: Fix swallowed exceptions in health check test.

2015-02-23 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31251/#review73658 --- Ship it! Ship It! - Joe Smith On Feb. 23, 2015, 12:23 p.m

Re: Review Request 31137: Update aurora to commons 0.3.3, unflake tests using ThreadedClock

2015-02-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31137/#review72809 --- Ship it! Ship It! - Joe Smith On Feb. 17, 2015, 1:59 p.m

Re: Review Request 31135: Pin protobuf dependency to 2.6.1

2015-02-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/#review72799 --- Ship it! Ship It! - Joe Smith On Feb. 17, 2015, 1:15 p.m

Re: Review Request 30749: Port GC executor to PathDetector interface

2015-02-10 Thread Joe Smith
) but if you don't mind adding docs here that'd be ~alright. - Joe Smith On Feb. 9, 2015, 3:16 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30749

Re: Review Request 30647: Instrument the HealthChecker to export stats.

2015-02-10 Thread Joe Smith
/test_health_checker.py https://reviews.apache.org/r/30647/#comment117704 I have a hard time believing this is going to be un-flaky, but not based on quantitative analysis. - Joe Smith On Feb. 6, 2015, 3:13 p.m., Brian Wickman wrote

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review71520 --- On Feb. 6, 2015, 2 p.m., Joe Smith wrote

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-08 Thread Joe Smith
:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith

Re: Review Request 30752: Fix executor builds.

2015-02-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30752/#review71527 --- Ship it! Ship It! - Joe Smith On Feb. 6, 2015, 3:52 p.m., Brian

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/#review71510 --- On Feb. 6, 2015, 2 p.m., Joe Smith wrote

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
seconds 21:16:04 00:08 [junit] 21:16:04 00:08 [specs] SUCCESS Thanks, Joe Smith

Re: Review Request 27182: Add a test for the thermos resource module

2015-02-05 Thread Joe Smith
refactoring Joe Smith wrote: Not quite- if this were for a different test then I'd agree, but since we're actually testing TaskResourceMonitor, we'll want to mock out that behavior (and test it separately) to ensure this method is using it right. (At some point

Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-05 Thread Joe Smith
/#review71284 --- On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30649

Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Joe Smith
/30649/diff/ Testing --- Reviewed the diff [for twitter/commons](https://github.com/twitter/commons/commit/574d79891d74a3a142e1db6b085b4c7e13c67659#diff-570e3786705ee6965f4f2f72c715382bR194) and ``` $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all ``` Thanks, Joe Smith

Review Request 30650: Upgrade virtualenv to 12.0.7

2015-02-04 Thread Joe Smith
--- ```sh $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all ``` Thanks, Joe Smith

Re: Review Request 30649: Upgrade pants to 0.0.28

2015-02-04 Thread Joe Smith
, visit: https://reviews.apache.org/r/30649/#review71148 --- On Feb. 4, 2015, 8:07 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.

2015-02-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29171/#review70692 --- /nudge - Joe Smith On Dec. 17, 2014, 12:31 p.m., Brian Wickman

Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-13 Thread Joe Smith
/#comment112102 good idea - Joe Smith On Jan. 13, 2015, 4:15 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866

Re: Review Request 29423: Fixes typo in Developing Aurora Client documentation.

2014-12-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29423/#review66166 --- Ship it! Ship It! - Joe Smith On Dec. 25, 2014, 10:16 p.m

Re: Review Request 29426: Fixes markdown formatting in Vagrant documentation.

2014-12-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29426/#review66167 --- Ship it! Ship It! - Joe Smith On Dec. 25, 2014, 11:28 p.m

Re: Review Request 29286: Fix BUILD files in apache.aurora.admin and apache.aurora.client.api.

2014-12-19 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29286/#review65729 --- Ship it! Ship It! - Joe Smith On Dec. 19, 2014, 7:05 p.m

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65430 --- Ship it! Ship It! - Joe Smith On Dec. 16, 2014, 4:57 p.m

Re: Review Request 29171: Fix test_executor_vars so that it doesn't attempt to get a real PEX-INFO.

2014-12-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29171/#review65431 --- Ship it! Ship It! - Joe Smith On Dec. 17, 2014, 12:31 p.m

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60454 --- Ship it! Ship It! - Joe Smith On Nov. 6, 2014, 3:40 p.m

Re: Review Request 27182: Add a test for the thermos resource module

2014-10-27 Thread Joe Smith
--- On Oct. 24, 2014, 5:12 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27182/ --- (Updated Oct. 24

Review Request 27182: Add a test for the thermos resource module

2014-10-24 Thread Joe Smith
== src.test.python.apache.thermos.monitoring.test_resource . SUCCESS Thanks, Joe Smith

Re: Review Request 27188: Use ship-it instead of +/-1.

2014-10-24 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27188/#review58480 --- Ship it! Ship It! - Joe Smith On Oct. 24, 2014, 8:17 p.m., Bill

Review Request 27114: Move from github to bintray for pants support binaries.

2014-10-23 Thread Joe Smith
Thanks, Joe Smith

Review Request 27129: Upgrade psutil to 2.1.3

2014-10-23 Thread Joe Smith
Thanks, Joe Smith

Review Request 27066: Follow the pantsbuild pants_support_baseurls for OS X Yosemite support.

2014-10-22 Thread Joe Smith
= src.test.python.apache.aurora.admin.admin_util . SUCCESS src.test.python.apache.aurora.admin.host_maintenance . SUCCESS Thanks, Joe

Re: Review Request 27058: Add specs to instances of Mock in Python tests.

2014-10-22 Thread Joe Smith
On Oct. 22, 2014, 4:24 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_command_hooks.py, line 252 https://reviews.apache.org/r/27058/diff/1/?file=729290#file729290line252 I don't think this needs to be a mock at all - I'm pretty sure that you can just

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458/#review57164 --- Ship it! Ship It! - Joe Smith On Oct. 17, 2014, 8:48 a.m

Review Request 26802: Set a default for the error log dir

2014-10-16 Thread Joe Smith
== src.test.python.apache.aurora.client.cli.aurora_command_line . SUCCESS Thanks, Joe Smith

Re: Review Request 26802: Set a default for the error log dir

2014-10-16 Thread Joe Smith
--- On Oct. 15, 2014, 11:02 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26802/ --- (Updated Oct

Review Request 26828: Remove info logging when users request json output

2014-10-16 Thread Joe Smith
== src.test.python.apache.aurora.client.cli.status . SUCCESS Thanks, Joe Smith

Re: Review Request 26828: Remove info logging when users request json output

2014-10-16 Thread Joe Smith
p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26828/ --- (Updated Oct. 16, 2014, 2:40 p.m.) Review

Re: Review Request 26852: Use mesos.native egg from ~kevints

2014-10-16 Thread Joe Smith
, 2014, 6:50 p.m.) Review request for Aurora, Joe Smith, Bill Farner, and Zameer Manji. Bugs: AURORA-863 https://issues.apache.org/jira/browse/AURORA-863 Repository: aurora Description --- Use mesos.native egg from ~kevints Diffs - examples/vagrant

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-15 Thread Joe Smith
https://reviews.apache.org/r/26458/#comment97177 mock_wait.assert_called_once_with - Joe Smith On Oct. 10, 2014, 3 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 26432: Reject new GC tasks when shutting down

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26432/#review55839 --- Ship it! Awesome - Joe Smith On Oct. 8, 2014, 10:28 a.m., Kevin

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55858 --- Ship it! Ship It! - Joe Smith On Oct. 4, 2014, 10:55 a.m., Bill

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-08 Thread Joe Smith
https://reviews.apache.org/r/26431/#comment96235 can this be a mock that we assert gets called 3 times? (This test is a little bit of an integration test since it goes in and is also testing perform_maintenace, but a full refactor of this test may be too much for now) - Joe Smith

Re: Review Request 26424: Disable requests http connection logging.

2014-10-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55860 --- Ship it! Inlining inside `__init__` WFM. thanks! - Joe Smith

Re: Review Request 26458: Adding wait loop into host_drain status monitoring.

2014-10-08 Thread Joe Smith
assert on how many times this was called? - Joe Smith On Oct. 8, 2014, 2:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26458

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
the before/after. - Joe Smith On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424

Re: Review Request 26424: Disable requests http connection logging.

2014-10-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26424/#review55727 --- Ship it! Aha, here we go. Thanks!! - Joe Smith On Oct. 7, 2014

Re: Review Request 26137: Fix help for new update command.

2014-10-06 Thread Joe Smith
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: src/main/python/apache/aurora/client/cli/update.py, line 45 https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45 Could you update a test case to catch accessing these as properties to catch accidental regressions

Review Request 26372: Update as property

2014-10-06 Thread Joe Smith
= src.test.python.apache.aurora.client.cli.help . FAILURE Thanks, Joe Smith

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread Joe Smith
= src.test.python.apache.aurora.client.cli.help . FAILURE Thanks, Joe Smith

Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joe Smith
/ Testing --- [tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith

Re: Review Request 26378: Upgrade to pants 0.0.24

2014-10-06 Thread Joe Smith
-132-201 aurora (yasumoto/pants_0.0.24)]$ ./build-support/jenkins/build.sh Thanks, Joe Smith

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
/test_helper.py https://reviews.apache.org/r/25972/#comment95731 from psutil._common import puids - Joe Smith On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-03 Thread Joe Smith
https://reviews.apache.org/r/26308/#comment95761 Can you also assert that this was called? src/test/python/apache/aurora/client/cli/test_api_from_cli.py https://reviews.apache.org/r/26308/#comment95762 can you instead .assert_called_once_with(args) ? - Joe Smith On Oct. 2, 2014, 9:52

Re: Review Request 25972: Make thermos more cognizant of user deletions

2014-10-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25972/#review55410 --- Ship it! Ship It! - Joe Smith On Oct. 3, 2014, 3:16 p.m., Brian

Re: Review Request 26137: Fix help for new update command.

2014-10-02 Thread Joe Smith
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote: src/main/python/apache/aurora/client/cli/update.py, line 45 https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45 Could you update a test case to catch accessing these as properties to catch accidental regressions

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-02 Thread Joe Smith
https://reviews.apache.org/r/26308/#comment95691 you need to set a spec here Mock(SchedulerClient) - Joe Smith On Oct. 2, 2014, 7:38 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 26233: Add a monitoring guide.

2014-10-01 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26233/#review55091 --- Ship it! Wow. - Joe Smith On Oct. 1, 2014, 10:27 a.m., Bill

Re: Review Request 26137: Fix help for new update command.

2014-09-30 Thread Joe Smith
://reviews.apache.org/r/26137/#comment95276 Could you update a test case to catch accessing these as properties to catch accidental regressions? - Joe Smith On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote: --- This is an automatically

Re: Review Request 26089: Renaming update to beta-update in client v2

2014-09-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26089/#review54704 --- Ship it! Ship It! - Joe Smith On Sept. 26, 2014, 10:53 a.m

Re: Review Request 26044: Run python style checks in jenkins.

2014-09-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26044/#review54570 --- Ship it! Ship It! - Joe Smith On Sept. 25, 2014, 11:09 a.m

Re: Review Request 25970: Adding support for retryable storage errors.

2014-09-25 Thread Joe Smith
https://reviews.apache.org/r/25970/#comment94757 Isn't this not needed if you're specifying a side_effect? - Joe Smith On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-09-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review53367 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 11:08 a.m

Re: Review Request 25667: Removing host_drain delay.

2014-09-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25667/#review53419 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 3:04 p.m

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
://reviews.apache.org/r/25582/#comment92646 test_ssh_job_not_found src/test/python/apache/aurora/client/cli/test_task_run.py https://reviews.apache.org/r/25582/#comment92647 Test the ssh command for proper behavior when no tasks are found within a job or something, I think - Joe Smith

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/#review53189 --- Ship it! Ship It! - Joe Smith On Sept. 12, 2014, 10:17 a.m

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote: src/test/python/apache/aurora/client/cli/test_task_run.py, line 228 https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228 Test the ssh command for proper behavior when no tasks are found within a job or something

Re: Review Request 25543: Update to pants 0.0.23.

2014-09-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/#review53242 --- Ship it! awesome- thanks! - Joe Smith On Sept. 11, 2014, 9:13

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52945 --- can you also add e2e test coverage? - Joe Smith On Sept. 10

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52968 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2014, 3:43 p.m

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25466/#review52674 --- Ship it! awesome - Joe Smith On Sept. 8, 2014, 7:13 p.m., Brian

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-05 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25346: Specify required vagrant version in Vagrantfile.

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25346/#review52334 --- Ship it! thanks! - Joe Smith On Sept. 4, 2014, 11:48 a.m., Bill

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52387 --- On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52389 --- On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52395 --- On Sept. 4, 2014, 8 p.m., Joe Smith wrote: --- This is an automatically

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52198 --- On Sept. 2, 2014, 9:06 p.m., Joe Smith wrote

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
://reviews.apache.org/r/25208/#review52049 --- On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

  1   2   >