On March 23, 2015, 8:59 p.m., Joshua Cohen wrote:
Thanks, this is already much easier to follow.
One general question on the overall approach: do you think the DRY benefits
of using composed `StructFieldGetter`s to generate the functions that allow
walking from the starting type
/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
https://reviews.apache.org/r/32329/#comment125541
undo?
- Joshua Cohen
On March 23, 2015, 7:14 p.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77
https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77
This method also appears to be used here:
https://github.com/apache/incubator-aurora/blob
On March 23, 2015, 5:43 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/app/Modules.java, line 77
https://reviews.apache.org/r/32377/diff/1/?file=902301#file902301line77
This method also appears to be used here:
https://github.com/apache/incubator-aurora/blob
://reviews.apache.org/r/32377/#comment125484
This method also appears to be used here:
https://github.com/apache/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/thrift/auth/ThriftAuthModule.java#L81
- Joshua Cohen
On March 22, 2015, 6:37 p.m., Bill Farner wrote
, 2015, 10:27 p.m.)
Review request for Aurora and Joshua Cohen.
Bugs: AURORA-1190
https://issues.apache.org/jira/browse/AURORA-1190
Repository: aurora
Description
---
See summary.
Diffs
-
src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/32313/#comment125167
Can we assert `self._mock_api.start_job.mock_calls = [call(...)]` instead?
- Joshua Cohen
On March 20, 2015, 8:23 p.m., Bill Farner wrote:
---
This is an automatically generated e
https://reviews.apache.org/r/32313/#comment125174
Yes, let us add stuff! Stuff is great and junk!
- Joshua Cohen
On March 20, 2015, 10:31 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32175/#review76828
---
Ship it!
Ship It!
- Joshua Cohen
On March 17, 2015, 9:59 p.m
/AnnotatedAuroraAdmin.java
https://reviews.apache.org/r/32141/#comment124452
Can you add a corresponding comment to api.thrift that any new methods (or
parameters?) added should be added (or updated?) here.
- Joshua Cohen
On March 17, 2015, 7:41 p.m., Kevin Sweeney wrote
On March 17, 2015, 7:56 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java,
line 39
https://reviews.apache.org/r/32141/diff/5/?file=898006#file898006line39
Can you add a corresponding comment to api.thrift that any new methods
before this
change to 3m16s afterwards.
Overall +1 on this, but I definitely think we need to add a README in the
packer directory to explain what's going on, how to build/upload a new box, etc.
- Joshua Cohen
On March 17, 2015, 4:23 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32078/#review76594
---
Ship it!
Ship It!
- Joshua Cohen
On March 16, 2015, 5:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32118/#review76629
---
Ship it!
Ship It!
- Joshua Cohen
On March 16, 2015, 6:54 p.m
On March 13, 2015, 7:59 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java,
line 95
https://reviews.apache.org/r/32055/diff/1/?file=894545#file894545line95
I thought it's generally preferable when installing user-supplied
/#comment123260
Same here, seems unrelated? Does this just need to be rebased?
- Joshua Cohen
On March 10, 2015, 1:18 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/
---
(Updated March 11, 2015, 12:04 a.m.)
Review request for Aurora, David McLaughlin and Joshua Cohen
.
- Joshua Cohen
On March 11, 2015, 12:04 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31916/
---
(Updated
On March 7, 2015, 12:01 a.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 200
https://reviews.apache.org/r/31814/diff/1/?file=888014#file888014line200
The original scope for AURORA-1077 was to allow for passing
Mind adding `shell` to these blocks?
- Joshua Cohen
On March 9, 2015, 5:47 p.m., Brian Brazil wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31862
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31814/#review75722
---
Ship it!
Ship It!
- Joshua Cohen
On March 7, 2015, 1:06 a.m
commenting?
- Joshua Cohen
On March 7, 2015, 12:54 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31820
for doing this!
- Joshua Cohen
On March 3, 2015, 8:55 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659
---
Revert TARGET_PEOPLE change, this was applying to updates as well as new
reviews.
Diffs
-
.reviewboardrc 415e2455660a14681f6fedde30f339f9f211e7f5
Diff: https://reviews.apache.org/r/31546/diff/
Testing
---
Posted this review.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31491/#review74362
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 26, 2015, 8 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31496/#review74372
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 26, 2015, 9:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31389/#review74061
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 25, 2015, 12:01 a.m
the global mount will be the
second mount in the list? It'd be slightly more robust to iterate the mounts
and ensure the mount we expect is *somewhere* in the list?
- Joshua Cohen
On Feb. 25, 2015, 7:15 p.m., Steve Niemitz wrote
On Feb. 24, 2015, 6:01 a.m., Joshua Cohen wrote:
Steve Niemitz wrote:
I'm not a big fan of how the parsing works here either. I was thinking
about this last night, I think I have a better plan here. Lemme know what
you think.
I already want to add volume support per
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31248/#review73603
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 21, 2015, 6:33 p.m
On Feb. 21, 2015, 12:53 a.m., Joshua Cohen wrote:
Can you fill in testing done?
Bill Farner wrote:
Honest question - do you find that useful for changes like this? I find
it redundant to always type `./gradlew build -Pq`, especially since the build
bot will do that anyhow.
My
?
- Joshua Cohen
On Feb. 19, 2015, 11:58 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31137/#review72810
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 17, 2015, 9:59 p.m
://reviews.apache.org/r/31138/diff/
Testing
---
Ran build.sh before/after exporting PANTS_PYTEST_OPTIONS='-v'
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review72858
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 18, 2015, 1 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31123/#review72796
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 17, 2015, 6 p.m., Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31123/#review72801
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 17, 2015, 9:49 p.m
change below, then I'll commit this.
docs/user-guide.md
https://reviews.apache.org/r/30985/#comment118483
the syntax for updating a range of shards in v2 is:
aurora job update cluster/role/env/job/0-1
- Joshua Cohen
On Feb. 13, 2015, 7:32 p.m., Florian Pfeiffer wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30957/#review72416
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 13, 2015, 12:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30985/#review72446
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 13, 2015, 10:18 p.m
s/received/are received
s/provided/the provided
s/gets blocked/will be blocked
- Joshua Cohen
On Feb. 13, 2015, 11:25 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31022/#review72459
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 13, 2015, 11:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31029/#review72469
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 14, 2015, 12:33 a.m
test.pytest --no-fast src/test/python/apache/aurora/client::
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72249
---
On Feb. 12, 2015, 9:59 p.m., Joshua Cohen wrote:
---
This is an automatically generated
/JobUpdateControllerImpl.java
https://reviews.apache.org/r/30225/#comment117942
can drop the else?
- Joshua Cohen
On Feb. 11, 2015, 7:19 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225/#review72028
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 11, 2015, 10:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review72065
---
Ship it!
pending clean test run from review bot.
- Joshua Cohen
/test_health_checker.py
https://reviews.apache.org/r/30647/#comment117703
Why do we need these real timeouts?
- Joshua Cohen
On Feb. 6, 2015, 11:13 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30681/#review71841
---
Ship it!
Ship It!
- Joshua Cohen
On Feb. 6, 2015, 5:07 p.m
-libraries.googlecode.com/git/javadoc/com/google/common/base/Optional.html#or(com.google.common.base.Supplier)
- Joshua Cohen
On Feb. 10, 2015, 12:53 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
On Feb. 10, 2015, 7:32 p.m., Joshua Cohen wrote:
Ship It!
Zameer Manji wrote:
Don't forget to commit this.
I had missed your earlier ship it. Will merge it now.
- Joshua
---
This is an automatically generated e-mail
Diff: https://reviews.apache.org/r/30818/diff/
Testing
---
./gradlew jshint
Verified push state worked in vagrant.
Thanks,
Joshua Cohen
Verified push state worked in vagrant.
Thanks,
Joshua Cohen
092e7d5df2121f45f99f5a788187d52bebb7e5dd
Diff: https://reviews.apache.org/r/30818/diff/
Testing (updated)
---
./gradlew jsHint
Verified push state worked in vagrant.
Thanks,
Joshua Cohen
?
(same for the test below as well)
src/test/python/apache/thermos/monitoring/test_detector.py
https://reviews.apache.org/r/30741/#comment117259
pull this out to a separate test?
(also, same for the test below, could be 3 separate tests)
- Joshua Cohen
On Feb. 6, 2015, 7
it?
- Joshua Cohen
On Feb. 5, 2015, 9:38 p.m., Ricardo Cervera-Navarro wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30681
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/
---
(Updated Feb. 5, 2015, 1:46 a.m.)
Review request for Aurora, Joshua Cohen and Bill Farner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30647/#review71282
---
@ReviewBot retry
- Joshua Cohen
On Feb. 5, 2015, 7:17 p.m
/main -name *.py |xargs grep context.options.jobspec |wc -l
43
- Joshua Cohen
On Feb. 3, 2015, 11:20 p.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586
On Feb. 3, 2015, 11:34 p.m., Joshua Cohen wrote:
Is this indicative of a more wide spread problem?
$ find src/main -name *.py |xargs grep context.options.jobspec |wc -l
43
Nevermind, read the fix backwards ;).
- Joshua
/
---
(Updated Jan. 30, 2015, 10:31 p.m.)
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
Bugs: AURORA-1071
https://issues.apache.org/jira/browse/AURORA-1071
Repository: aurora
Description
://reviews.apache.org/r/30461/#comment116052
s/in/by the
src/test/python/apache/aurora/client/api/test_updater_util.py
https://reviews.apache.org/r/30461/#comment116054
instead of hard coding to 10 here, set it to something like
`UpdateConfig.DEFAULT_PULSE_INTERVAL_SECS - 1`?
- Joshua Cohen
8fc3cb865fbcd467db91f4cb828d381a02ba7595
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
d492e176e73cbd2b3c696fc488010db16106b36a
Diff: https://reviews.apache.org/r/30446/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
---
On Jan. 30, 2015, 7:04 a.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 7:04
8fc3cb865fbcd467db91f4cb828d381a02ba7595
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
d492e176e73cbd2b3c696fc488010db16106b36a
Diff: https://reviews.apache.org/r/30446/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
/30446/#review70393
---
On Jan. 30, 2015, 6:18 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446
/scheduler/storage/testing/StorageTestUtil.java
d492e176e73cbd2b3c696fc488010db16106b36a
Diff: https://reviews.apache.org/r/30446/diff/
Testing
---
./gradlew build -Pq
Thanks,
Joshua Cohen
://reviews.apache.org/r/30389/#comment115321
Should we include the proper way to update a non-service job (kill/create)
in this message?
- Joshua Cohen
On Jan. 29, 2015, 5:13 p.m., Bill Farner wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389/#review70274
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 29, 2015, 7:31 p.m
build -Pq
Thanks,
Joshua Cohen
familiar with the internals
of the scheduler driven updates).
- Joshua Cohen
On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30225
update store, but I'm not sure how intensive an operation that will be (or the
impact of performing it outside of the context of a lock).
- Joshua Cohen
On Jan. 23, 2015, 8:37 p.m., Maxim Khutornenko wrote
that it says something
like, Please see [the contributing guidelines](docs/contributing.md) for
details on how to contribute patches to Aurora.
- Joshua Cohen
On Jan. 24, 2015, 9:53 p.m., Jeffrey Schroeder wrote
On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
I think we should leave the yaml code but drop the PyYAML dependency from
the client requirements. (And inject it into the test -- possibly one test
with and one test without to make sure the try/except also functions
correctly.) I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68754
---
@ReviewBoy retry
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68828
---
*ping*
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68829
---
@ReviewBot retry
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m
/resources/org/apache/aurora/scheduler/http/utilization.st
73f86d51e9bb0179b774554718ad49ce00ba5487
Diff: https://reviews.apache.org/r/29971/diff/
Testing
---
Verified styles were present when hitting those endpoints in vagrant.
Thanks,
Joshua Cohen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29971/#review68477
---
@ReviewBot retry
- Joshua Cohen
On Jan. 16, 2015, 7:08 p.m
/apache/aurora/executor/common/test_resource_manager_integration.py
bb3045700c2870329e175db44873dcb990226c7a
Diff: https://reviews.apache.org/r/29984/diff/
Testing
---
./pants build
src/test/python/apache/aurora/executor/common:resource_manager_integration
Thanks,
Joshua Cohen
by 2 minutes? (i.e. it
says last diff was at 20:18, but looking at the review it was actually at
20:20?)
- Joshua Cohen
On Jan. 15, 2015, 6:38 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
!
- Joshua
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29942/#review68365
---
On Jan. 15, 2015, 11:58 p.m., Joshua Cohen wrote
/29942/diff/
Testing
---
Ran/debug client in PyCharm.
Previewed markdown doc changes here:
https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md
Thanks,
Joshua Cohen
markdown doc changes here:
https://github.com/jcohen/incubator-aurora/blob/jcohen/client/run-in-pycharm/docs/developing-aurora-client.md
Thanks,
Joshua Cohen
On Jan. 14, 2015, 12:49 a.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py,
line 21
https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21
same, this doesn't appear to be related to a pants upgrade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29862/#review67937
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 13, 2015, 7:45 p.m
by
this and by update-pants-requirements rather than having to keep the version in
sync between the two?
- Joshua Cohen
On Jan. 13, 2015, 9:51 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29866/#review67977
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 13, 2015, 11:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29770/#review67685
---
@ReviewBot retry
- Joshua Cohen
On Jan. 12, 2015, 6:56 p.m
/thermos_executor_main.py
https://reviews.apache.org/r/29828/#comment111832
nit: should this be 2 spaces, not 4?
src/main/python/apache/aurora/executor/common/resource_manager.py
https://reviews.apache.org/r/29828/#comment111831
Add license header to all these new files.
- Joshua Cohen
On Jan. 12, 2015, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29828/#review67749
---
Ship it!
Ship It!
- Joshua Cohen
On Jan. 12, 2015, 11:40 p.m
:
https://reviews.apache.org/r/29770/diff/#
- Joshua Cohen
On Jan. 12, 2015, 11:44 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29829
/python:all
./gradlew clean build
Also ran e2e tests:
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Joshua Cohen
,
Joshua Cohen
/test_common.sh
31646425233470b5f87ab50ef4504264f235f48a
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
578662ccd1735ebf500d066b3cc17b30f635c15f
Diff: https://reviews.apache.org/r/29770/diff/
Testing
---
./pants build src/test/python/apache/aurora/client::
Thanks,
Joshua Cohen
,
Joshua Cohen
://reviews.apache.org/r/29770/diff/
Testing
---
./pants build src/test/python/apache/aurora/client::
Thanks,
Joshua Cohen
: aurora
Description
---
Add build-support/rbtools to .gitignore
Diffs
-
.gitignore 86840972c53ea52a793968d3d00df6763a7d6ffb
Diff: https://reviews.apache.org/r/29772/diff/
Testing
---
$ git status
Thanks,
Joshua Cohen
-mail. To reply, visit:
https://reviews.apache.org/r/29772/#review67483
---
On Jan. 9, 2015, 6:47 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply
1 - 100 of 315 matches
Mail list logo