Re: Review Request 32329: Extract job key from RPC parameters

2015-03-23 Thread Kevin Sweeney
1f24e7d47e1f777ffef19a73d01171fcacd31cdb src/test/java/org/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d20c9da3c4944ec8c50fe8d48b7e459ff1c7082b Diff: https://reviews.apache.org/r/32329/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
On March 23, 2015, 10:43 a.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/api/security/ApiSecurityModule.java, line 61 https://reviews.apache.org/r/32377/diff/1/?file=902302#file902302line61 Can you push the lazy instantiation logic to ModuleParser

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
this back to ArgSetModule? - Kevin Sweeney On March 22, 2015, 11:37 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32377

Re: Review Request 32377: Add a mechanism to lazily instantiate module classes.

2015-03-23 Thread Kevin Sweeney
/Modules.java https://reviews.apache.org/r/32377/#comment125503 consider adding a Class? extends Module... overload. - Kevin Sweeney On March 23, 2015, 11:51 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 32323: DRY up PMD configuration.

2015-03-20 Thread Kevin Sweeney
and after: ``` % diff -u (sort -u old-rules.txt) (sort -u new-rules.txt) % ``` Thanks, Kevin Sweeney

Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
/apache/aurora/scheduler/thrift/aop/AopModuleTest.java d20c9da3c4944ec8c50fe8d48b7e459ff1c7082b Diff: https://reviews.apache.org/r/32329/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 32329: Extract job key from RPC parameters

2015-03-20 Thread Kevin Sweeney
, Kevin Sweeney

Re: Review Request 32276: Fix error listing active updates.

2015-03-19 Thread Kevin Sweeney
://reviews.apache.org/r/32276/#comment125032 You can use frozenset here as well. It's a shame thrift sets are mutable by default (which causes them to be unhashable). - Kevin Sweeney On March 19, 2015, 6:53 p.m., Bill Farner wrote

Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager

2015-03-17 Thread Kevin Sweeney
/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
://reviews.apache.org/r/32141/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32175: Add a test to ensure annotations exist for AuroraSchedulerManager

2015-03-17 Thread Kevin Sweeney
(updated) - src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32175/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
aae5cd7709abe3896c2ae06c218a0c90ca11c576 Diff: https://reviews.apache.org/r/32141/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
, visit: https://reviews.apache.org/r/32141/#review76787 --- On March 17, 2015, 1:03 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-17 Thread Kevin Sweeney
/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Review Request 32141: Introduce AnnotatedAuroraAdmin superclass for annotations.

2015-03-16 Thread Kevin Sweeney
7e20aaa6836bd205261afe5b1244fb6af8a56356 src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java aae5cd7709abe3896c2ae06c218a0c90ca11c576 Diff: https://reviews.apache.org/r/32141/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Review Request 32118: Move creation of auth_module into ThriftAuthModule.

2015-03-16 Thread Kevin Sweeney
bb19fc72cafc1640f6331c5eaa3761da1a4af7c0 Diff: https://reviews.apache.org/r/32118/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 32051: Detect an invalid .auroraversion expansion and provide a helpful error message.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32051/#review76388 --- Ship it! Ship It! - Kevin Sweeney On March 13, 2015, 9:41 a.m

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32055/#review76410 --- On March 13, 2015, 12:38 p.m., Kevin Sweeney wrote

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
/scheduler/http/api/security/ApiSecurityIT.java 2876b1f0595fc05fe76718a69ae280b4ce7d7178 src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32055/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
/scheduler/http/api/security/ApiSecurityIT.java 2876b1f0595fc05fe76718a69ae280b4ce7d7178 src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32055/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
/scheduler/http/api/security/ApiSecurityIT.java 2876b1f0595fc05fe76718a69ae280b4ce7d7178 src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32055/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Review Request 32055: Add a flag to configure Shiro at runtime.

2015-03-13 Thread Kevin Sweeney
src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java PRE-CREATION Diff: https://reviews.apache.org/r/32055/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney
/apache/aurora/scheduler/http/api/security/shiro-malformed-missing-sections.ini PRE-CREATION Diff: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-10 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75926 --- On March 10, 2015, 12:45 p.m., Kevin Sweeney wrote

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
print instead. Perhaps you and him should come to a consensus. src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/31869/#comment123346 revert to use self so that subclass delegation will work. - Kevin Sweeney On March 10, 2015, 10:44 a.m., Bill Farner wrote

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
names. - Kevin Sweeney On March 10, 2015, 5:17 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31869

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-10 Thread Kevin Sweeney
On March 10, 2015, 5:08 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 282 https://reviews.apache.org/r/31869/diff/3/?file=890382#file890382line282 My understanding was that zmanji was attempting to remove AuroraCommandContext and patch

Re: Review Request 31828: Upgrade gradle and a few plugins.

2015-03-09 Thread Kevin Sweeney
on the binary diff. - Kevin Sweeney On March 7, 2015, 9:54 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31828

Re: Review Request 31814: Include messages with internal job updater state transitions.

2015-03-09 Thread Kevin Sweeney
On March 9, 2015, 10:50 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 291 https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291 What's the motivation behind dropping the Aurora Updater here?

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-09 Thread Kevin Sweeney
/client/cli/jobs.py https://reviews.apache.org/r/31869/#comment123024 Rather than pass this have it use the instance field or make it a classmethod. - Kevin Sweeney On March 9, 2015, 1:10 p.m., Bill Farner wrote

Re: Review Request 31869: Catch only known Exception types in the client.

2015-03-09 Thread Kevin Sweeney
actually need to use the pytest API for this - since we're on python 2.7 and you have already subclassed `TestCase` you can use [self.assertRaises](https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertRaises). - Kevin Sweeney On March 9, 2015, 1:39 p.m., Bill Farner wrote

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Kevin Sweeney
: https://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Kevin Sweeney
-mail. To reply, visit: https://reviews.apache.org/r/31820/#review75736 --- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Kevin Sweeney
--- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31820

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Kevin Sweeney
. To reply, visit: https://reviews.apache.org/r/31820/#review75723 --- On March 6, 2015, 4:54 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 31820: Support HTTP Basic auth and shiro.ini configuration

2015-03-09 Thread Kevin Sweeney
://reviews.apache.org/r/31820/diff/ Testing --- ./gradlew -Pq build Local testing in the UI and with cURL. Updates to e2e test and Vagrant environment to follow. Thanks, Kevin Sweeney

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-05 Thread Kevin Sweeney
--- On March 4, 2015, 5:55 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754/ --- (Updated March 4

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-03-04 Thread Kevin Sweeney
, author.email)]) File /Users/ksweeney/workspace/aurora/build-support/rbt.venv/lib/python2.7/site-packages/rbtools/api/resource.py, line 299, in __getattr__ raise AttributeError AttributeError ``` - Kevin Sweeney On Feb. 24, 2015, 2:12 p.m., Stephan Erb wrote

Review Request 31754: Break out API servlet configuration into its own module.

2015-03-04 Thread Kevin Sweeney
47d54e3c3bb1ba5e0fb26379792f515f25316480 src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 5019094333f9807c64a49c29569ade191ee61824 src/test/java/org/apache/aurora/scheduler/http/api/ApiTServletTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31754/diff/ Testing --- Thanks, Kevin

Re: Review Request 31754: Break out API servlet configuration into its own module.

2015-03-04 Thread Kevin Sweeney
styleguide - updated diff to follow. - Kevin Sweeney On March 4, 2015, 5:55 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31754

Re: Review Request 31659: Clean up end-to-end tests.

2015-03-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31659/#review75090 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2015, 12:55 p.m

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-03-02 Thread Kevin Sweeney
and more type-safe. - Kevin Sweeney On Feb. 27, 2015, 1:05 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-24 Thread Kevin Sweeney
://reviews.apache.org/r/30891/#comment120290 It would be good form to reset the level in the tearDown here. - Kevin Sweeney On Feb. 23, 2015, 12:36 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/#review73887 --- Ship it! Ship It! - Kevin Sweeney On Feb. 23, 2015, 2:47 p.m

Re: Review Request 31235: Refactoring CronJobManager interface.

2015-02-24 Thread Kevin Sweeney
/scheduler/cron/quartz/CronLifecycle.java https://reviews.apache.org/r/31235/#comment120099 This TODO wasn't addressed - put it back? - Kevin Sweeney On Feb. 23, 2015, 5:23 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 29943: Uptime-driven scheduler job updates

2015-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29943/#review73877 --- Is this ready for review now? - Kevin Sweeney On Jan. 20, 2015

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Kevin Sweeney
On Feb. 24, 2015, 11:12 a.m., Kevin Sweeney wrote: This is awesome! If this fixes the full suite, can you also remove `--no-fast` from `build-support/jenkins/build.sh`? Stephan Erb wrote: I doubt that this patch is sufficient to warrant the change of the build script. There may

Re: Review Request 31350: Fix clusters.patch contextmanager cleanup

2015-02-24 Thread Kevin Sweeney
https://reviews.apache.org/r/31350/#comment120356 I'm not sure this test case is valuable since it will run in a non-deterministic order. - Kevin Sweeney On Feb. 24, 2015, 2:12 p.m., Stephan Erb wrote: --- This is an automatically

Re: Review Request 31394: Renaming storage.thrift job store structs.

2015-02-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31394/#review73953 --- Ship it! Ship It! - Kevin Sweeney On Feb. 24, 2015, 5:06 p.m

Re: Review Request 31042: Added document describing how to build Aurora for CentOS

2015-02-23 Thread Kevin Sweeney
On Feb. 18, 2015, 11:42 a.m., Kevin Sweeney wrote: Hi Craig, thanks for the contribution. I'm wondering if this document might be better suited as a gist or blog post given that it's dated (0.7.1) and we don't have automated test coverage to ensure it doesn't diverge from the rest

Re: Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-23 Thread Kevin Sweeney
/LoggingInterceptorTest.java PRE-CREATION Diff: https://reviews.apache.org/r/31176/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 30895: Offer filtering for static vetoes. Part 4 of 4: Benchmarks.

2015-02-23 Thread Kevin Sweeney
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30895/ --- (Updated Feb. 23, 2015, 1:03 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 31176: Split out ReadOnlySchedulerImplTest.

2015-02-18 Thread Kevin Sweeney
-CREATION Diff: https://reviews.apache.org/r/31176/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-17 Thread Kevin Sweeney
, visit: https://reviews.apache.org/r/30891/ --- (Updated Feb. 12, 2015, 6:27 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-909 https://issues.apache.org/jira/browse/AURORA-909 Repository

Re: Review Request 31136: Uniquely identify job updates in the database by JobUpdateKey.

2015-02-17 Thread Kevin Sweeney
), UNIQUE(job_key_id, update_id), ? - Kevin Sweeney On Feb. 17, 2015, 2:01 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31136

Re: Review Request 31123: Enable checkstyle indentation check, fix violations.

2015-02-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31123/#review72787 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 10 a.m

Re: Review Request 31101: Native Debian packaging for Aurora

2015-02-17 Thread Kevin Sweeney
build script or share this snippet of code between them some way? - Kevin Sweeney On Feb. 16, 2015, 4:20 p.m., Benjamin Staffin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31101

Re: Review Request 31135: Pin protobuf dependency to 2.6.1

2015-02-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31135/#review72792 --- Ship it! Ship It! - Kevin Sweeney On Feb. 17, 2015, 1:15 p.m

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72420 --- @ReviewBot retry - Kevin Sweeney On Feb. 12, 2015, 4:55 p.m

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72438 --- @ReviewBot retry - Kevin Sweeney On Feb. 12, 2015, 4:55 p.m

Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-12 Thread Kevin Sweeney
/thrift/SchedulerThriftInterfaceTest.java 03d1fba76c23570c2c4102a48daf5ce035ecaaa3 Diff: https://reviews.apache.org/r/30957/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 30890: Offer filtering for static vetoes. Part 2 of 4: Veto groups.

2015-02-12 Thread Kevin Sweeney
/30890/#comment118385 Can you use != here since this is an enum? src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java https://reviews.apache.org/r/30890/#comment118386 (Consider moving this test to compile-time with the above approach) - Kevin Sweeney On Feb. 12, 2015, 4:58 p.m

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-12 Thread Kevin Sweeney
5e6577d64b1037c69c3a952008240dcafe3b9f94 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 491aa34d76a6f3fe91188bbc73a2cc7464f3644b Diff: https://reviews.apache.org/r/30957/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 30888: Offer filtering for static vetoes. Part 1 of 4: TaskAssigner.

2015-02-12 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30888/#review72269 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2015, 2:52 p.m

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-12 Thread Kevin Sweeney
5e6577d64b1037c69c3a952008240dcafe3b9f94 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 491aa34d76a6f3fe91188bbc73a2cc7464f3644b Diff: https://reviews.apache.org/r/30957/diff/ Testing --- ./gradlew -Pq build Thanks, Kevin Sweeney

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-03 Thread Kevin Sweeney
update ID). We could probably get away with both updateId and jobKey in the API to avoid ambiguity, or perhpas just updateId and role? I am open to suggestions. Kevin Sweeney wrote: In Shiro this will look something like subject.checkPermission(update:resume:mesos:prod:labrat

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-02-03 Thread Kevin Sweeney
, 5:42 p.m.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1080 https://issues.apache.org/jira/browse/AURORA-1080 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-02-02 Thread Kevin Sweeney
On Feb. 2, 2015, 4:16 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1535 https://reviews.apache.org/r/30325/diff/3/?file=841928#file841928line1535 This is too restrictive. It means that _only_ the update coordinator

Re: Review Request 30535: Remove shard uniqueness check from scheduler recovery phase.

2015-02-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30535/#review70671 --- Ship it! Ship It! - Kevin Sweeney On Feb. 2, 2015, 4:42 p.m

Re: Review Request 30535: Remove shard uniqueness check from scheduler recovery phase.

2015-02-02 Thread Kevin Sweeney
/ --- (Updated Feb. 3, 2015, 12:42 a.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Maxim Khutornenko. Bugs: AURORA-1090 https://issues.apache.org/jira/browse/AURORA-1090 Repository: aurora Description --- Remove

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-02-02 Thread Kevin Sweeney
. - Kevin Sweeney On Feb. 2, 2015, 10:10 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Feb

Re: Review Request 30480: Use checkstyle 6.2.

2015-02-02 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30480/#review70590 --- Ship it! Ship It! - Kevin Sweeney On Jan. 31, 2015, 12:31 p.m

Re: Review Request 30479: Upgrade to gradle 2.2.1.

2015-01-31 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30479/#review70515 --- Ship it! Ship It! - Kevin Sweeney On Jan. 31, 2015, 11:32 a.m

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70403 --- Ship it! Ship It! - Kevin Sweeney On Jan. 30, 2015, 10:53 a.m

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Kevin Sweeney
.) Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028 https://issues.apache.org/jira/browse/AURORA-1028 Repository: aurora Description --- This is needed to take advantage of the task reconciliation API and new status update fields. Diffs

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Kevin Sweeney
/CommandUtilTest.java https://reviews.apache.org/r/30471/#comment115649 Consider [TextFormat.shortDebugString](https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/TextFormat.html#shortDebugString(com.google.protobuf.MessageOrBuilder)) here instead. - Kevin Sweeney On Jan

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Kevin Sweeney
/CommandUtilTest.java https://reviews.apache.org/r/30471/#comment115628 If we're going to maintain this test there should be a reference to an upstream issue. Theoretically the semantics of an unset optional field with a default and a set field should be the same. - Kevin Sweeney On Jan. 30, 2015, 3

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-29 Thread Kevin Sweeney
.) Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora Description --- Added baseline benchmarks for a few static veto cases. Diffs - build.gradle f9f71a84493b782e9f6072e44e89a2c017cf2a09 src/jmh/java/org/apache/aurora/benchmark/Hosts.java

Re: Review Request 30302: Updating release publishing script to work with linked .auroraversion

2015-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30302/#review69888 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2015, 6:32 p.m

Re: Review Request 30331: Fixed python tests hanging

2015-01-27 Thread Kevin Sweeney
elaborate in the description? - Kevin Sweeney On Jan. 27, 2015, 2:28 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331

Re: Review Request 30341: Reverting .auroraversion and CHANGELOG changes

2015-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30341/#review69924 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2015, 4:33 p.m

Re: Review Request 30204: Upgrade to rbt=0.7.0.

2015-01-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30204/#review69653 --- Ship it! Ship It! - Kevin Sweeney On Jan. 22, 2015, 6:11 p.m

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney
://reviews.apache.org/r/30187/#comment114397 For the purposes of sheparding this review along would you consider moving this to another change? - Kevin Sweeney On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney
On Jan. 26, 2015, 12:16 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/common/clusters.py, line 42 https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42 For the purposes of sheparding this review along would you consider moving this to another change

Re: Review Request 30293: Updating release script to work with linked .auroraversion

2015-01-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30293/#review69705 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2015, 4:03 p.m

Review Request 30224: Stream backups directly to file.

2015-01-23 Thread Kevin Sweeney
/30224/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69512 --- Ship it! Ship It! - Kevin Sweeney On Jan. 23, 2015, 4 p.m

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Kevin Sweeney
On Jan. 21, 2015, 6:35 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-cluster.sh, line 17 https://reviews.apache.org/r/28920/diff/18/?file=823204#file823204line17 nit: sh -c indirection is unnecessary here. Steve Niemitz wrote: Eh, this is just copied from

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/#review69306 --- Ship it! Ship It! - Kevin Sweeney On Jan. 8, 2015, 9:25 a.m

Re: Review Request 30178: Avoid performing RPC authentication while holding the write lock.

2015-01-22 Thread Kevin Sweeney
the authentication code to a decorator class and delegating the behavior-once-authenticated. - Kevin Sweeney On Jan. 22, 2015, 11:25 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 30178: Avoid performing RPC authentication while holding the write lock.

2015-01-22 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30178/#review69243 --- Ship it! Ship It! - Kevin Sweeney On Jan. 22, 2015, 11:25 a.m

Re: Review Request 30178: Avoid performing RPC authentication while holding the write lock.

2015-01-22 Thread Kevin Sweeney
On Jan. 22, 2015, 11:43 a.m., Kevin Sweeney wrote: We've explored this in the past, but how about moving the authentication code to a decorator class and delegating the behavior-once-authenticated. Maxim Khutornenko wrote: We have a TODO tracking this: ``` // TODO(Sathya

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-21 Thread Kevin Sweeney
://reviews.apache.org/r/28920/#comment113733 Naive question: since we have this block here can we drop the preamble from the scheduler? - Kevin Sweeney On Jan. 15, 2015, 4:08 p.m., Steve Niemitz wrote: --- This is an automatically generated e

Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-16 Thread Kevin Sweeney
@ about the change - Kevin Sweeney On Jan. 16, 2015, 11:16 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29866

Re: Review Request 29901: De-flakify resource_manager_integration test

2015-01-15 Thread Kevin Sweeney
)? A common issue with the client tests is the configuration of mocks that were later found to be unused. - Kevin Sweeney On Jan. 15, 2015, 4:11 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 29942: Updates so client will run in PyCharm.

2015-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29942/#review68307 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2015, 11:56 a.m

Re: Review Request 29866: Upgrade pants to 0.0.27

2015-01-14 Thread Kevin Sweeney
On Jan. 13, 2015, 4:49 p.m., Kevin Sweeney wrote: src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py, line 21 https://reviews.apache.org/r/29866/diff/3/?file=820203#file820203line21 same, this doesn't appear to be related to a pants upgrade

  1   2   3   4   5   6   7   8   >