Re: Review Request 27084: Fix error when job create is called with --open-browser.

2014-10-27 Thread Mark Chu-Carroll
625cb80a33ae565b403fc71bb9795e4700e1aeb7 src/test/python/apache/aurora/client/cli/test_create.py 8a5aef8d866f69e124951dd43bf98396f0bd1ef1 Diff: https://reviews.apache.org/r/27084/diff/ Testing --- Added new test; all unit tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Mark Chu-Carroll
. To reply, visit: https://reviews.apache.org/r/22457/#review58280 --- On Oct. 24, 2014, 10:50 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 22457: Improve aurora job diff command.

2014-10-27 Thread Mark Chu-Carroll
to inflate a task config list according to the local instance count. Mark Chu-Carroll wrote: So you changed the semantics of the API call without changing its type signature to reflect that? Really? Maxim Khutornenko wrote: We can't change type signatures without breaking

Re: Review Request 27047: Improve status command output ordering.

2014-10-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27047/#review57851 --- On Oct. 22, 2014, 1:57 p.m., Mark Chu-Carroll wrote

Review Request 26982: Make v2 job status look more like v1.

2014-10-21 Thread Mark Chu-Carroll
/client/cli/test_update.py . == 62 passed in 6.42 seconds === src.test.python.apache.aurora.client.cli.job . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
--- On Oct. 15, 2014, 12:20 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26753

Re: Review Request 26982: Make v2 job status look more like v1.

2014-10-21 Thread Mark Chu-Carroll
. To reply, visit: https://reviews.apache.org/r/26982/#review57622 --- On Oct. 21, 2014, 12:19 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
that they fail in exactly the same way as before this change. Thanks, Mark Chu-Carroll

Re: Review Request 26753: Start removing clientv1.

2014-10-21 Thread Mark Chu-Carroll
they continue to pass. - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and verified that they fail in exactly the same way as before this change. Thanks, Mark Chu-Carroll

Re: Review Request 26881: Improve error messages in client commands.

2014-10-20 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26881/#review57361 --- On Oct. 17, 2014, 1:58 p.m., Mark Chu-Carroll wrote

Re: Review Request 26881: Improve error messages in client commands.

2014-10-20 Thread Mark Chu-Carroll
.sh 8f4d2b01c9fa5a6ec9e8885a2d4fa0e9c3abb8a1 Diff: https://reviews.apache.org/r/26881/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-17 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review57177 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 8, 2014, 7:46 p.m

Review Request 26881: Improve error messages in client commands.

2014-10-17 Thread Mark Chu-Carroll
/client/cli/test_supdate.py 6775c389cb1a0b80dd17fe179e8b98d4e9db0332 Diff: https://reviews.apache.org/r/26881/diff/ Testing --- Thanks, Mark Chu-Carroll

Review Request 26753: Start removing clientv1.

2014-10-15 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d Diff: https://reviews.apache.org/r/26688/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
=error-log-dir Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created Remove the cron schedule for a job. {noformat} Thanks, Mark Chu-Carroll

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688/#review56541 --- On Oct. 15, 2014, 12:41 p.m., Mark Chu-Carroll wrote

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
as defined by python standard logging? - Mark Chu-Carroll On Oct. 15, 2014, 12:46 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688

Re: Review Request 26688: Fix errors in help rendering:

2014-10-15 Thread Mark Chu-Carroll
Set logging to a specific numeric level. --error-log-dir=error-log-dir Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created Remove the cron schedule for a job. {noformat} Thanks, Mark Chu-Carroll

Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d Diff: https://reviews.apache.org/r/26688/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
you anything meaningful about what's expected. - Mark Chu-Carroll On Oct. 14, 2014, 11:07 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26688

Re: Review Request 26688: Fix errors in help rendering:

2014-10-14 Thread Mark Chu-Carroll
On Oct. 14, 2014, 1 p.m., Mark Chu-Carroll wrote: src/test/python/apache/aurora/client/cli/test_help.py, line 75 https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75 Yes, they are guaranteed to be unique. The argparse framework that this is built on checks

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-08 Thread Mark Chu-Carroll
/test_create.py 6e55188bdfc576506848605debb391288e696fe3 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll

Review Request 26445: Fix error in incorrect deprecation warning on v1 ssh command.

2014-10-08 Thread Mark Chu-Carroll
/aurora/client/commands/ssh.py 9ee94a0bdfd8bbc030ae978e2ac3fe39571b4ce2 src/test/python/apache/aurora/client/commands/test_ssh.py c5ca66e378bfc97c40a406a758ae4dfaef8ab2c8 Diff: https://reviews.apache.org/r/26445/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Mark Chu-Carroll
/aurora/client/cli/test_update.py 85b1db19d89967a741bfba7964eeb368426f0b61 Diff: https://reviews.apache.org/r/26363/diff/ Testing --- New unit tests added, all test pass. Thanks, Mark Chu-Carroll

Re: Review Request 26363: Make the large-update check in the client update command consider instance parameters.

2014-10-08 Thread Mark Chu-Carroll
/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41 Diff: https://reviews.apache.org/r/26363/diff/ Testing --- New unit tests added, all test pass. Thanks, Mark Chu-Carroll

Re: Review Request 26288: Fixing log_response in context.py

2014-10-07 Thread Mark Chu-Carroll
update the review title, just so that when we look at reviews, we know what this one actually changed? - Mark Chu-Carroll On Oct. 6, 2014, 7:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 26417: Change JSON result of job status when job isn't found.

2014-10-07 Thread Mark Chu-Carroll
. Thanks, Mark Chu-Carroll

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-07 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26308/#review55717 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 4, 2014, 1:55 p.m

Re: Review Request 26308: Fix exit condition for RPC loop, fix test_status_api_failure test.

2014-10-07 Thread Mark Chu-Carroll
that there is a way to get that branch active in a test. Every single time that I've ever said that something couldn't be tested, or that some branch couldn't be exercised in a test, I've always been wrong. There's a way. - Mark Chu-Carroll On Oct. 4, 2014, 1:55 p.m., Bill Farner wrote

Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
that. - Mark Chu-Carroll On Oct. 3, 2014, 4:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26328

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
where the scheduler is sending things via the deprecated field but not via the details list, then that should be changed. - Mark Chu-Carroll On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e

Re: Review Request 26372: Test all the nouns and verbs within the Aurora Command Line for help output

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26372/#review55527 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 6, 2014, 12:58 p.m

Re: Review Request 26288: Fixing log_response in context.py

2014-10-06 Thread Mark Chu-Carroll
://reviews.apache.org/r/26288/#comment95906 If the client-side API is using a deprecated field of this structure, then that should be fixed. We shouldn't be patching this to prevent the need to remove deprecations from the client-side API. - Mark Chu-Carroll On Oct. 2, 2014, 6:28 p.m., Maxim

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-06 Thread Mark Chu-Carroll
/test/python/apache/aurora/client/cli/test_supdate.py 2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll

Re: Review Request 26328: Improve handling of unknown errors in the aurora client.

2014-10-06 Thread Mark Chu-Carroll
://reviews.apache.org/r/26328/diff/ Testing --- New unit test. Thanks, Mark Chu-Carroll

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
command. I can certainly add the updateID to the list command, and add a command (or alternative parameter) for checking on a job by update-ID, but I don't think that making it the normal parameter to status is a good design for the command-line. Mark Chu-Carroll wrote: ping

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-06 Thread Mark Chu-Carroll
2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 26388: Build break fix.

2014-10-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26388/#review55602 --- Ship it! Ship It! - Mark Chu-Carroll On Oct. 6, 2014, 6:01 p.m

Re: Review Request 26328: Add aurora update list and aurora update status commands.

2014-10-03 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Review Request 26270: Make the client invocation code actually use the exit codes returned by the client.

2014-10-02 Thread Mark Chu-Carroll
is disabled, but pass with in on. - added a new unit test to check that unresolved bindings generate an error. Thanks, Mark Chu-Carroll

Re: Review Request 26270: Fix multiple errors involving bindings, and fix result codes.

2014-10-02 Thread Mark Chu-Carroll
a50b83c571390374975accf75e31f392dbdaaa04 Diff: https://reviews.apache.org/r/26270/diff/ Testing --- Unit tests: - verified that tests fail if the binding code is disabled, but pass with in on. - added a new unit test to check that unresolved bindings generate an error. Thanks, Mark Chu-Carroll

Re: Review Request 26137: Fix help for new update command.

2014-10-02 Thread Mark Chu-Carroll
generated e-mail. To reply, visit: https://reviews.apache.org/r/26137/#review54953 --- On Sept. 29, 2014, 11:05 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-02 Thread Mark Chu-Carroll
2782fee2867c6ef79349240299de082f07f7967a src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-10-01 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54466 --- On Sept. 24, 2014, 4:24 p.m., Mark Chu-Carroll wrote

Re: Review Request 26004: Add aurora update list and aurora update status commands.

2014-09-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26004/#review54466 --- On Sept. 24, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically

Review Request 26137: Fix help for new update command.

2014-09-29 Thread Mark Chu-Carroll
--- manual testing. Thanks, Mark Chu-Carroll

Review Request 26004: Add aurora update list and aurora update status commands.

2014-09-24 Thread Mark Chu-Carroll
a50b83c571390374975accf75e31f392dbdaaa04 Diff: https://reviews.apache.org/r/26004/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll

Review Request 26014: Quick fix for cron error.

2014-09-24 Thread Mark Chu-Carroll
://reviews.apache.org/r/26014/diff/ Testing --- Quick fix: no additional test. I'll add a regression test when rosh hashanah is over. Thanks, Mark Chu-Carroll

Re: Review Request 25255: Implement server-driven update commands.

2014-09-17 Thread Mark Chu-Carroll
Chu-Carroll

Re: Review Request 25255: Implement server-driven update commands.

2014-09-17 Thread Mark Chu-Carroll
command; all unit tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 25543: Update to pants 0.0.23.

2014-09-15 Thread Mark Chu-Carroll
/#review53239 --- On Sept. 11, 2014, 12:13 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543

Re: Review Request 25255: Implement server-driven update commands.

2014-09-15 Thread Mark Chu-Carroll
. To reply, visit: https://reviews.apache.org/r/25255/#review53347 --- On Sept. 11, 2014, 10:55 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 25255: Implement server-driven update commands.

2014-09-15 Thread Mark Chu-Carroll
think update start is less natural than job update. -=Bill On Mon, Sep 15, 2014 at 10:25 AM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: On Sept. 15, 2014, 12:04 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/standalone_client.py, line 121 https

Re: Review Request 25255: Implement server-driven update commands.

2014-09-15 Thread Mark Chu-Carroll
originally proposed: aurora job update --start|--pause|--resume|--abort. If you don't like the option syntax, would it be too much work to support double verb (or rather double noun) syntax, like aurora job update start? On Mon, Sep 15, 2014 at 2:07 PM, Mark Chu-Carroll mchucarr...@apache.org wrote

Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Mark Chu-Carroll
://reviews.apache.org/r/25582/diff/ Testing --- Added new tests to catch this case; Ran all client unit tests, all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Mark Chu-Carroll
/client/commands/test_ssh.py 4070b710b005c91fe08dd7906cd93bf3a8cdba9e Diff: https://reviews.apache.org/r/25582/diff/ Testing --- Added new tests to catch this case; Ran all client unit tests, all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 25255: Implement server-driven update commands.

2014-09-11 Thread Mark Chu-Carroll
) and (3). - Mark --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review52220 --- On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote

Re: Review Request 25255: Implement server-driven update commands.

2014-09-11 Thread Mark Chu-Carroll
to the comments never got sent - guessing chrome timed out, and I didn't notice. Please don't re-review this yet - I'm reworking some of the code; I'll send an update when it's ready. - Mark Chu-Carroll On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote

Review Request 25543: Update to pants 0.0.23.

2014-09-11 Thread Mark Chu-Carroll
://reviews.apache.org/r/25543/diff/ Testing --- - Ran all unit tests: several fail, but they also fail under the previous version of pants. - Built all python_binary targets in src/main/python/apache/aurora. - Verified that resulting pexes executed correctly. Thanks, Mark Chu-Carroll

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review53071 --- Ship it! Ship It! - Mark Chu-Carroll On Sept. 10, 2014, 6:43

Re: Review Request 25505: Make aurora job status JSON output more friendly.

2014-09-10 Thread Mark Chu-Carroll
/diff/ Testing --- Added new unit tests; all tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 22457: Improve aurora job diff command.

2014-09-09 Thread Mark Chu-Carroll
Diff: https://reviews.apache.org/r/22457/diff/ Testing --- New unit tests of the JSON tree diff code, plus a bunch of new job diff tests of the new functionality. All tests pass. Thanks, Mark Chu-Carroll

Re: Review Request 25450: Fix broken large update warning.

2014-09-09 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25450/#review52624 --- On Sept. 8, 2014, 2:37 p.m., Mark Chu-Carroll wrote

Re: Review Request 25450: Fix broken large update warning.

2014-09-09 Thread Mark Chu-Carroll
(info): Killed: 8 log(info): Instance 0 has been up and healthy for at least 45 seconds log(info): Instance 1 has been up and healthy for at least 45 seconds log(info): Update successful log(info): Command terminated successfully Mark Chu-Carroll wrote: Current output

Re: Review Request 25450: Fix broken large update warning.

2014-09-09 Thread Mark Chu-Carroll
://reviews.apache.org/r/25450/diff/ Testing --- Added new unit tests. Thanks, Mark Chu-Carroll

Review Request 25450: Fix broken large update warning.

2014-09-08 Thread Mark Chu-Carroll
/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 Diff: https://reviews.apache.org/r/25450/diff/ Testing --- Added new unit tests. Thanks, Mark Chu-Carroll

Re: Review Request 25309: Fix output formatting error in job status.

2014-09-04 Thread Mark Chu-Carroll
/ Testing --- Ran unit tests; added new test cases. Thanks, Mark Chu-Carroll

Re: Review Request 25309: Fix output formatting error in job status.

2014-09-04 Thread Mark Chu-Carroll
--- On Sept. 4, 2014, 9:24 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25309

Review Request 25350: Fix build problem.

2014-09-04 Thread Mark Chu-Carroll
in the timestamps, so that it doesn't matter where the test is run. Diffs - src/test/python/apache/aurora/client/cli/test_status.py 2af24fbaa4971819636898df752fa886553d75a3 Diff: https://reviews.apache.org/r/25350/diff/ Testing --- Thanks, Mark Chu-Carroll

Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
/test_end_to_end_v2.sh 14a0b62c1b06179211d79f35a9c6df162c9a5999 Diff: https://reviews.apache.org/r/25297/diff/ Testing --- - Ran all unit tests successfully. - Ran end-to-end tests successfully. - Thanks, Mark Chu-Carroll

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
successfully. - Thanks, Mark Chu-Carroll

Re: Review Request 25297: Make config-file an optional parameter for job restart.

2014-09-03 Thread Mark Chu-Carroll
successfully. - Ran end-to-end tests successfully. - Thanks, Mark Chu-Carroll

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Mark Chu-Carroll
wrote: Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, and Tobias Weingartner. By Joshua Cohen. *Updated Aug. 29, 2014, 4:17 p.m.* *Bugs: * AURORA-676 https://issues.apache.org/jira/browse/AURORA-676 *Repository: * aurora Description Fix aurora run in end to end tests

Review Request 25309: Fix output formatting error in job status.

2014-09-03 Thread Mark Chu-Carroll
/test_status.py 311fac02af32e0ed687489a2352164effb4dba96 Diff: https://reviews.apache.org/r/25309/diff/ Testing --- Ran unit tests; added new test cases. Thanks, Mark Chu-Carroll

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
On Sept. 2, 2014, 3:35 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/__init__.py, line 176 https://reviews.apache.org/r/25204/diff/1/?file=672539#file672539line176 Nit - but why are you changing the parameter comment syntax? We don't use the double-dash

Re: Review Request 25204: Adding get job update client APIs.

2014-09-03 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25204/#review52214 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 6:28 p.m

Re: Review Request 25255: Implement server-driven update commands.

2014-09-03 Thread Mark Chu-Carroll
, visit: https://reviews.apache.org/r/25255/#review52043 --- On Sept. 2, 2014, 12:36 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 25255: Implement server-driven update commands.

2014-09-02 Thread Mark Chu-Carroll
/apache/aurora/client/cli/test_supdate.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 95a2123e127c9811fd2305e71cfc5c7c4376f904 Diff: https://reviews.apache.org/r/25255/diff/ Testing --- New suite of tests for the new command; all unit tests pass. Thanks, Mark Chu

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52065 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 29, 2014, 7:17 p.m

Re: Review Request 25159: Adding pause/resume/abort client APIs.

2014-08-28 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25159/#review51807 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 28, 2014, 2:16 p.m

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-22 Thread Mark Chu-Carroll
test suite. Thanks, Mark Chu-Carroll

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51319 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 22, 2014, 5:26 p.m

Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Re: Review Request 24953: Fix bug in handling of pystachio bindings.

2014-08-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24953/#review51218 --- On Aug. 21, 2014, 4:44 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
--- On Aug. 19, 2014, 11:22 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
... Mark Chu-Carroll wrote: No, this is a new test. It's almost identical to an existing test, except that instead of checking API calls, it's checking output. Maxim Khutornenko wrote: Please, drop the TODO in that case. No need in multiplying them. But don't we want to mark this as a spot

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Mark Chu-Carroll
. To me, it seems like expecting someone to have a lockid for a pause or a resume call is a good idea. It allows someone to pass responsibility for an ongoing update to another person, without having to allow anyone at all to interrupt/resume it. - Mark Chu-Carroll On Aug. 18, 2014, 4:10 p.m

Re: Review Request 24702: Implementing client job lock and start update APIs.

2014-08-14 Thread Mark Chu-Carroll
will both check that it works, and provide demonstrations for readers to see how it works. (I know you've already got some tests of this, but they're indirect, htrough the surrounding method; for clarity, it would be better to be able to test get_ranges directly.) - Mark Chu-Carroll On Aug

Re: Review Request 24702: Implementing client job lock and start update APIs.

2014-08-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24702/#review50619 --- Ship it! Ship It! - Mark Chu-Carroll On Aug. 14, 2014, 2:26 p.m

Review Request 24651: Fix bug in deprecation warning for cancel-update.

2014-08-13 Thread Mark Chu-Carroll
. Testing for this will be included in the testing coverage changes that I'm working on. Diffs - src/main/python/apache/aurora/client/commands/core.py da9d9a0a2206c83a225071de570bc0fe406b29f4 Diff: https://reviews.apache.org/r/24651/diff/ Testing --- Thanks, Mark Chu-Carroll

Review Request 24573: Fix bug in aurora job inspect.

2014-08-11 Thread Mark Chu-Carroll
3cb39b232648d69615bbdfedc4d81eaf7ece7938 Diff: https://reviews.apache.org/r/24573/diff/ Testing --- Thanks, Mark Chu-Carroll

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24019/#review49260 --- Ship it! Ship It! - Mark Chu-Carroll On July 28, 2014, 9:04 p.m

Review Request 24160: Add deprecation warnings for aurora client v1 command.

2014-07-31 Thread Mark Chu-Carroll
, Mark Chu-Carroll

Re: Review Request 24116: Defining stubs for the Update APIs.

2014-07-31 Thread Mark Chu-Carroll
://reviews.apache.org/r/24116/#comment86205 Definitely support the idea of the more general queries. If we're going to the trouble of supporting an API like this, we should make the extra effort to make it flexible. - Mark Chu-Carroll On July 31, 2014, 2:37 p.m., Maxim Khutornenko wrote

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-31 Thread Mark Chu-Carroll
) This is side-effecting the queues, but the name of it suggests that it's just a predicate. - Mark Chu-Carroll On July 31, 2014, 12:38 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll
Ping, again? David, Joe? This is a really easy one! -Mark On Mon, Jul 28, 2014 at 2:07 PM, Mark Chu-Carroll mchucarr...@apache.org wrote: ping? On Fri, Jul 25, 2014 at 4:50 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated e-mail

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll
src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, Mark Chu-Carroll

Re: Review Request 22457: Improve aurora job diff command.

2014-07-29 Thread Mark Chu-Carroll
/#review49046 --- On July 17, 2014, 10:09 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457

  1   2   3   4   >