---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32371/#review77667
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 21, 2015, 7:42
---
On March 21, 2015, 2:19 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77348
---
On March 21, 2015, 2:19 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32369/#review77417
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 21, 2015, 5:49
://reviews.apache.org/r/32359/#review77436
---
On March 23, 2015, 6:10 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java
ebe551739fb6b7132ce666ad9b3c5a86e90a5363
Diff: https://reviews.apache.org/r/32359/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
.
- Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32359/#review77337
---
On March 21, 2015, 2:22 a.m., Maxim Khutornenko wrote
/scheduler/async/preemptor/PreemptorSlotFinderTest.java
b80e558f18b817814e4768b13ff94aa816d28543
Diff: https://reviews.apache.org/r/32353/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
ebe551739fb6b7132ce666ad9b3c5a86e90a5363
Diff: https://reviews.apache.org/r/32359/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
: https://reviews.apache.org/r/32352/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32220/#review77106
---
On March 19, 2015, 12:29 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32220/#review77112
---
On March 19, 2015, 12:29 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32276/#review77152
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 20, 2015, 1:46
c9d10e4cec44045806ec2d75d8c158dc40d7de98
Diff: https://reviews.apache.org/r/32225/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim Khutornenko
https://reviews.apache.org/r/32171/#comment124999
While it's converted to set by thrift anyway, I'd still recommend using a
set() here to explicitly assert no duplicates are ever accepted.
- Maxim Khutornenko
On March 19, 2015, 9:09 p.m., Bill Farner wrote
://reviews.apache.org/r/32220/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32208/#review76919
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 18, 2015, 6:28
-Pq build
Thanks,
Maxim Khutornenko
/AnnotatedAuroraAdmin.java
https://reviews.apache.org/r/32141/#comment12
You probably want @Nullable here as well.
src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
https://reviews.apache.org/r/32141/#comment124445
same here
- Maxim Khutornenko
On March
On March 17, 2015, 11:12 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java,
line 208
https://reviews.apache.org/r/32181/diff/1/?file=898407#file898407line208
This reordering will result in pulsing the hostname even when
On March 18, 2015, 12:04 a.m., Kevin Sweeney wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, lines 404-406
https://reviews.apache.org/r/32171/diff/3/?file=898440#file898440line404
How would you feel about including all of the currently available data
with a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32164/#review76753
---
On March 17, 2015, 5:19 p.m., Maxim Khutornenko wrote
with @Nullable.
- Maxim Khutornenko
On March 17, 2015, 1:29 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32141
working set, which does not reflect the NOOP nature of this action.
[1] -
https://github.com/apache/incubator-aurora/blob/master/src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java
- Maxim Khutornenko
On March 16, 2015, 3:13 p.m., Steve Niemitz wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32078/#review76632
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 16, 2015, 5:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76636
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 16, 2015, 5:57
instead?
Maxim Khutornenko wrote:
Client already has logs but that's not enough to reconstruct the behavior
when maintenance stalls. We need to see both sides of the story to properly
troubleshoot host draining issues.
Bill Farner wrote:
This one i still don't follow - AFAICT
/MaintenanceController.java
b6f642e319b790544bc538098e7cb78b1bb49997
src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
bd031a5e0b7d2923e36ca5958c5074f40dc64848
Diff: https://reviews.apache.org/r/32014/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim
bd031a5e0b7d2923e36ca5958c5074f40dc64848
src/test/python/apache/aurora/admin/test_host_maintenance.py
bb586700814a96b3e83d11728b462a7765e81bc1
Diff: https://reviews.apache.org/r/32014/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
bd031a5e0b7d2923e36ca5958c5074f40dc64848
src/test/python/apache/aurora/admin/test_host_maintenance.py
bb586700814a96b3e83d11728b462a7765e81bc1
Diff: https://reviews.apache.org/r/32014/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
instead?
Maxim Khutornenko wrote:
Client already has logs but that's not enough to reconstruct the behavior
when maintenance stalls. We need to see both sides of the story to properly
troubleshoot host draining issues.
Bill Farner wrote:
This one i still don't follow - AFAICT
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32048/#review76375
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 13, 2015, 3:45
/scheduler/async/preemptor/PreemptorSlotFinderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/31821/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
alphabetically?
- Maxim Khutornenko
On March 12, 2015, 1:27 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966
://reviews.apache.org/r/31913/#comment123803
Mind adding a host maintenance test instead? I am concerned this may drift
over time and will no longer represent how the grouping is actually used.
- Maxim Khutornenko
On March 11, 2015, 2:53 a.m., David Robinson wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review76304
---
Ship it!
Thanks!
- Maxim Khutornenko
On March 12, 2015, 11:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31913/#review76307
---
Thanks, it's now on master.
- Maxim Khutornenko
On March 12
/state/MaintenanceControllerImplTest.java
bd031a5e0b7d2923e36ca5958c5074f40dc64848
Diff: https://reviews.apache.org/r/32014/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long
and
internally suppress its behavior based on configuration. Seems like the
caller should avoid the call if the behavior is not desired. If you agree,
please TODO.
Maxim Khutornenko wrote:
Not sure I share your concern. This is a predicate intended to answer a
simple question, which
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31901/#review75994
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 10, 2015, 6 p.m
, in module
File stdin, line 1, in lambda
TypeError: 'NoneType' object has no attribute '__getitem__'
```
Please, add a typed default grouping (e.g. ALL) and a correspondent test
in test_host_maintenance.py.
- Maxim Khutornenko
On March 10, 2015, 10:44 p.m., David Robinson
/JobUpdateController.java
https://reviews.apache.org/r/31916/#comment123392
Do we really want to fail an operation when a message gets too long? Since
it's optional anyway, I'd expect truncation could be a more resilient way to
handle this.
- Maxim Khutornenko
On March 11, 2015, 12:04 a.m., Bill Farner
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
On March 11, 2015, 12:19 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java,
line 48
https://reviews.apache.org/r/31916/diff/1/?file=890852#file890852line48
Do we really want to fail an operation when a message gets too long
/JobUpdateControllerImpl.java
https://reviews.apache.org/r/31814/#comment122955
What's the motivation behind dropping the Aurora Updater here?
- Maxim Khutornenko
On March 7, 2015, 1:06 a.m., Bill Farner wrote:
---
This is an automatically
e0f9d8b4c3d80b70faa10612b82a034e3dae9112
Diff: https://reviews.apache.org/r/31525/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 291
https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291
What's the motivation behind dropping the Aurora Updater here
://reviews.apache.org/r/31869/#comment123014
why not just context?
- Maxim Khutornenko
On March 9, 2015, 8:10 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
On March 9, 2015, 5:50 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 291
https://reviews.apache.org/r/31814/diff/2/?file=888120#file888120line291
What's the motivation behind dropping the Aurora Updater here
/aurora/scheduler/async/preemptor/PreemptorSlotFinderTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/31821/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75637
---
On March 7, 2015, 1:36 a.m., Maxim Khutornenko wrote
://reviews.apache.org/r/31821/#review75743
---
On March 7, 2015, 1:36 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31821/#review75816
---
@ReviewBot retry
- Maxim Khutornenko
On March 9, 2015, 11:34 p.m
://reviews.apache.org/r/31821/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
ce5a62650cebab9a53743460f5a5119f62efec1c
Diff: https://reviews.apache.org/r/31652/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75096
---
On March 3, 2015, 12:58 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31646/#review75093
---
On March 3, 2015, 12:07 a.m., Maxim Khutornenko wrote
/scheduler/async/TaskSchedulerTest.java
87bc531d2a72f21c36ddd0c1bd3b2367826cc422
Diff: https://reviews.apache.org/r/31739/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
/TaskSchedulerTest.java
87bc531d2a72f21c36ddd0c1bd3b2367826cc422
Diff: https://reviews.apache.org/r/31739/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
/test_end_to_end.sh
216849145fe681d05ed54ac7fbf385bb31d8cdea
Diff: https://reviews.apache.org/r/31751/diff/
Testing
---
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31751/#review75272
---
On March 5, 2015, 12:48 a.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31739/#review75247
---
On March 4, 2015, 7:30 p.m., Maxim Khutornenko wrote
On March 4, 2015, 8:17 p.m., Bill Farner wrote:
Is there a reason you did not opt to implement this behind the `Preemptor`
interface? Seems like if you went with that approach, `TaskScheduler` can
be oblivious to the background operations.
Maxim Khutornenko wrote:
Trying
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31659/#review75045
---
Ship it!
Ship It!
- Maxim Khutornenko
On March 3, 2015, 8:53
://reviews.apache.org/r/31710/#comment122025
You may want to extract an internal method to do this, e.g.:
```
def timestamp(time_msec):
return time.ctime(time_msec / 1000)
```
- Maxim Khutornenko
On March 3, 2015, 11:44 p.m., Bill Farner wrote
/31652/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
78a236c0f9074692b67ce18e6e03f18fe4529e02
Diff: https://reviews.apache.org/r/31525/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
4ee13c8e5d46ba863f4d9871884c7d494d07758d
src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java
87bc531d2a72f21c36ddd0c1bd3b2367826cc422
Diff: https://reviews.apache.org/r/31646/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/#review74801
---
On Feb. 27, 2015, 9:05 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e
., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/
---
(Updated Feb. 27, 2015, 9:05 p.m.)
Review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31570/#review74649
---
@ReviewBot retry
- Maxim Khutornenko
On Feb. 28, 2015, 1:37 a.m
acdade3dca807a221b4da975d0310c91884ee752
src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java
e24d6bde5f3479a75522e825cce4ec6c30c117aa
Diff: https://reviews.apache.org/r/31570/diff/
Testing
---
./gradlew -Pq build
Manual testing in vagrant.
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31388/#review74508
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 27, 2015, 4:49
833a3e0b088780e21f5f16434327c96447a25115
src/test/java/org/apache/aurora/scheduler/async/preemptor/PreemptorImplTest.java
2845b3f72fca5c329a8b81ce796370ad95d94f02
Diff: https://reviews.apache.org/r/31508/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74566
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 27, 2015, 6:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31525/#review74554
---
On Feb. 27, 2015, 3:19 a.m., Maxim Khutornenko wrote
, bumping up max heap size as some of bechmarks OOM occasionally (noticed
peak usage of 600Mb).
Diffs
-
build.gradle 158d47ac273e75deb8cb1460281c84e85db4f248
Diff: https://reviews.apache.org/r/31493/diff/
Testing
---
./gradlew jmh
Thanks,
Maxim Khutornenko
/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31421/#review74055
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 25, 2015, 6:48
/
---
(Updated Feb. 24, 2015, 8:12 p.m.)
Review request for Aurora, Maxim Khutornenko and Zameer Manji.
Bugs: AURORA-1093
https://issues.apache.org/jira/browse/AURORA-1093
Repository: aurora
Description
---
There are 3 ways a JobUpdateSummary lands in storage:
- starting
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891/#review73703
---
On Feb. 23, 2015, 8:36 p.m., Maxim Khutornenko wrote
://reviews.apache.org/r/30891/#review72448
---
On Feb. 23, 2015, 8:36 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30891
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29943/#review73877
---
On Jan. 20, 2015, 9:12 p.m., Maxim Khutornenko wrote:
---
This is an automatically
/Updates.java
https://reviews.apache.org/r/31376/#comment120333
Would it make sense to accept/return `JobUpdateSummary`? The
mutable/immutable dance is rather confusing at call sites.
- Maxim Khutornenko
On Feb. 24, 2015, 8:12 p.m., Bill Farner wrote
/aurora/common/test_clusters.py
https://reviews.apache.org/r/31350/#comment120237
Please, assert the entire contents here, e.g. `assert clusters ==
[Cluster(...)]`
- Maxim Khutornenko
On Feb. 24, 2015, 2:18 p.m., Stephan Erb wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31389/#review73954
---
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 25, 2015, 12:01
/30895/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
---
On Feb. 20, 2015, 10:48 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31171
/30895/#review73642
---
On Feb. 23, 2015, 7:34 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895
On Feb. 21, 2015, 12:43 a.m., Bill Farner wrote:
src/test/java/org/apache/aurora/scheduler/async/OfferManagerImplTest.java,
line 80
https://reviews.apache.org/r/30891/diff/5-6/?file=867194#file867194line80
This is kinda weird, what's the motivation here?
Maxim Khutornenko
Thanks,
Maxim Khutornenko
---
On Feb. 23, 2015, 9:03 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30895
/30895/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
06c8faa9de4d0ac8389dbf07d4e81934b503761b
Diff: https://reviews.apache.org/r/31334/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
/Updates.java
https://reviews.apache.org/r/31170/#comment119639
JobKeys.assertValid(summary.getJobKey()) should be better here.
Also, you may want to inline these checks with the JobUpdateKey
construction statement.
- Maxim Khutornenko
On Feb. 19, 2015, 8:30 p.m., Bill Farner wrote
: https://reviews.apache.org/r/31241/diff/
Testing
---
./gradlew -Pq build
Thanks,
Maxim Khutornenko
,
Maxim Khutornenko
1 - 100 of 1221 matches
Mail list logo