-916 when this lands.
- Zameer Manji
On March 25, 2015, 6:19 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32515
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32352/#review77425
---
Ship it!
Ship It!
- Zameer Manji
On March 20, 2015, 7:19 p.m
() is a pystachio object but I strongly suggest investigating it.
This way if we try to access other attributes the test will fail.
- Zameer Manji
On March 20, 2015, 10:26 a.m., Bill Farner wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77101
---
Ship it!
Ship It!
- Zameer Manji
On March 19, 2015, 1:22 p.m
/preemptor/PreemptionSlotFinder.java
https://reviews.apache.org/r/32220/#comment125005
This is a bit confusing to see .getSlaveId and then construct an instance
of SlaveID. Perhaps preemptionSlot should return a SlaveID instance?
- Zameer Manji
On March 18, 2015, 5:29 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76844
---
Ship it!
Ship It!
- Zameer Manji
On March 17, 2015, 1:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32077/#review76599
---
Ship it!
Pending e2e test results.
- Zameer Manji
On March 16
/python/apache/thermos/bin/BUILD
669f9930a3590184dc0f8b5c15c36168e715eb03
Diff: https://reviews.apache.org/r/32131/diff/
Testing
---
./build-support/jenkins/build.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32012/#review76409
---
Ship it!
Ship It!
- Zameer Manji
On March 13, 2015, 12:38 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31966/#review76257
---
Ship it!
Ship It!
- Zameer Manji
On March 11, 2015, 6:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31918/#review76002
---
Ship it!
Ship It!
- Zameer Manji
On March 10, 2015, 5:05 p.m
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/
---
(Updated March 10, 2015, 10:44 a.m.)
Review request for Aurora, Kevin Sweeney and Zameer Manji
:
https://reviews.apache.org/r/31821/
---
(Updated March 6, 2015, 5:36 p.m.)
Review request for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1158
https://issues.apache.org/jira/browse/AURORA-1158
Repository: aurora
/preemptor/PreemptionSlotFinder.java
https://reviews.apache.org/r/31821/#comment122986
To keep the implementation package private, could you move it to another
file?
- Zameer Manji
On March 6, 2015, 5:36 p.m., Maxim Khutornenko wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31869/#review75765
---
Ship it!
Ship It!
- Zameer Manji
On March 9, 2015, 1:10 p.m
for Aurora, Bill Farner and Zameer Manji.
Bugs: AURORA-1158
https://issues.apache.org/jira/browse/AURORA-1158
Repository: aurora
Description
---
Extracting PreemptorSlotFinder to be reused for slot validation in later
stages. The changes are very minimal and mostly around
://reviews.apache.org/r/31869/#comment123011
Use pytest.raises for tests where you expect an exception to be raised:
http://pytest.org/latest/assert.html
src/test/python/apache/aurora/client/cli/util.py
https://reviews.apache.org/r/31869/#comment123013
+100
- Zameer Manji
On March 9
the reason for the delay? We already wait for a task to be
pending for 10 minutes before we do preemption, I don't see the reason for
another delay until we look for a victim.
- Zameer Manji
On March 4, 2015, 11:30 a.m., Maxim Khutornenko wrote
On March 3, 2015, 3:21 p.m., Zameer Manji wrote:
src/test/python/apache/aurora/client/cli/test_supdate.py, line 211
https://reviews.apache.org/r/31710/diff/1/?file=883801#file883801line211
For the calls like this you can do
`mock_api.pause_job_update.assert_called_once_with
://reviews.apache.org/r/31559/#comment121996
shouldn't closing the checkpoint and killing the task runner be in a
finally clause?
- Zameer Manji
On March 3, 2015, 2:14 p.m., Brian Wickman wrote:
---
This is an automatically generated e
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review75082
---
Ship it!
Ship It!
- Zameer Manji
On March 3, 2015, 2:58 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31714/#review75123
---
Ship it!
Ship It!
- Zameer Manji
On March 3, 2015, 4:59 p.m
://reviews.apache.org/r/31710/#comment122016
For the calls like this you can do
`mock_api.pause_job_update.assert_called_once_with(self.TEST_JOBKEY)` instead
of comparing against an array of call objects.
- Zameer Manji
On March 3, 2015, 3:16 p.m., Bill Farner wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31652/#review75099
---
Ship it!
Ship It!
- Zameer Manji
On March 2, 2015, 4:58 p.m
command? If you do that then you can create a Mock with a
spec_set.
- Zameer Manji
On Feb. 27, 2015, 12:58 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31559
On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19
https://reviews.apache.org/r/31559/diff/1/?file=880712#file880712line19
Instead of creating a Mock like this here, could you grab the options
from the simplerun
On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote:
src/main/python/apache/thermos/cli/common.py, line 40
https://reviews.apache.org/r/31559/diff/1/?file=880707#file880707line40
Unrelated to your change, why have the strict option at al? Shouldn't
the default behaviour validate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31451/#review74345
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 26, 2015, 11:46 a.m
before shutting down the
task.
- Zameer Manji
On Feb. 25, 2015, 1:22 p.m., Steve Niemitz wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31423
.)
Review request for Aurora, Joe Smith and Zameer Manji.
Bugs: AURORA-1026
https://issues.apache.org/jira/browse/AURORA-1026
Repository: aurora
Description
---
This creates a new abstraction, the ObserverTaskDetector, which is
responsible for managing state transitions
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31453/#review74197
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 25, 2015, 5:41 p.m
/JobUpdateDetailsMapper.xml
https://reviews.apache.org/r/31376/#comment120339
Have you filed an upstream bug about this behaviour?
- Zameer Manji
On Feb. 24, 2015, 12:12 p.m., Bill Farner wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31251/#review73650
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 23, 2015, 11:50 a.m
/test/python/apache/aurora/client/cli/util.py
95a2123e127c9811fd2305e71cfc5c7c4376f904
Diff: https://reviews.apache.org/r/31240/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/client::
Thanks,
Zameer Manji
On Feb. 19, 2015, 1:11 p.m., Zameer Manji wrote:
Ship it, modulo my concern over uncessarily creating an IJobUpdateKey from
PruneVictim.
Bill clarified the creating IJobUpdateKey from PruneVictim offline. PruneVictim
needs to have the mutable types so it can be populated from storage
On Feb. 18, 2015, 5:17 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStore.java,
line 166
https://reviews.apache.org/r/31170/diff/1/?file=868472#file868472line166
Shouldn't PruneVictim have the IJobUpdateKey as the parameter?
Bill
an IJobUpdateKey from
PruneVictim.
- Zameer Manji
On Feb. 19, 2015, 12:30 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31170
On Feb. 14, 2015, 11:39 a.m., Florian Pfeiffer wrote:
docs/build-for-centos.md, line 40
https://reviews.apache.org/r/31042/diff/1/?file=864093#file864093line40
Installing gradle is probably not needed, since the gradle wrapper is
included in the aurora project?
Zameer Manji
) and Kevin
Sweeny (kevints) to the People line of the review?
- Zameer Manji
On Feb. 16, 2015, 11:21 a.m., Craig Wickesser wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31042
/JobUpdateStore.java
https://reviews.apache.org/r/31170/#comment119201
s/t/it
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
https://reviews.apache.org/r/31170/#comment119203
I think you can remove the TODO here.
- Zameer Manji
On Feb. 18, 2015, 4:19 p.m., Bill Farner
in the
UpdateConfig are timeouts until a task enters the RUNNING state?
- Zameer Manji
On Feb. 16, 2015, 10:22 p.m., Moses Nakamura wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31104
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31123/#review72739
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 17, 2015, 10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31124/#review72740
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 17, 2015, 10:09 a.m
-py2.7.egg
$ ./pants test.pytest --no-fast src/test/python::
Thanks,
Zameer Manji
://reviews.apache.org/r/31022/#comment118499
Shouldn't 'test' be self.TEST_CLUSTER or similar?
- Zameer Manji
On Feb. 13, 2015, 1:54 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31022/#review72445
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 13, 2015, 2:15 p.m
://reviews.apache.org/r/30950/#comment118308
Why don't you just use the imported values instead of declaring them here
again?
- Zameer Manji
On Feb. 12, 2015, 1:59 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30950/#review72251
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 12, 2015, 1:59 p.m
/
---
(Updated Feb. 6, 2015, 9:07 a.m.)
Review request for Aurora, Chris Aniszczyk, Dave Lester, Joshua Cohen, Marko
Gargenta, and Zameer Manji.
Repository: aurora
Description
---
docs: Expand Getting Started document
Diffs
-
docs/vagrant.md
On Feb. 9, 2015, 4:56 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java,
line 117
https://reviews.apache.org/r/30710/diff/2/?file=852094#file852094line117
I don't think we can safely do this right now. I know
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749/#review71741
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 9, 2015, 3:16 p.m
. To reply, visit:
https://reviews.apache.org/r/30768/#review71589
---
On Feb. 9, 2015, 10:47 a.m., Zameer Manji wrote:
---
This is an automatically generated e-mail. To reply, visit
but this change LGTM.
- Zameer Manji
On Feb. 9, 2015, 10:56 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30749
/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
as changed
when we start setting a previously unset field to a default value.
See https://issues.apache.org/jira/browse/MESOS-2309 for details.
Currently as this stands, I think this will cause existing Aurora instances
to be rejected by the Master.
- Zameer Manji
On Feb. 9
/30768/diff/
Testing
---
./pants test src/test/python/apache/thermos::
./pants test src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
://reviews.apache.org/r/30749/#comment117329
Shouldn't this log messsage be inside the collector implementation?
- Zameer Manji
On Feb. 6, 2015, 6:27 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit
::
./pants test src/test/python/apache/aurora/executor::
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30741/#review71487
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 6, 2015, 11:30 a.m
://reviews.apache.org/r/30704/diff/
Testing
---
./pants test src/test/python/apache/thermos::
Thanks,
Zameer Manji
Feb. 5, 2015, 10:46 a.m.)
Review request for Aurora, Chris Aniszczyk, Marko Gargenta, and Zameer Manji.
Repository: aurora
Description
---
docs: Expand Getting Started document
Diffs
-
docs/vagrant.md 67f042627bd08632cd237a550153b280e87e324d
Diff: https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30681/#review71303
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 5, 2015, 10:46 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/#review71014
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 3, 2015, 4:24 p.m
sort of
summary that explains what is new.
- Zameer Manji
On Feb. 4, 2015, 6:46 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649
3416c8e1932056725880f2007b60d77112759428
src/test/python/apache/aurora/client/cli/test_cron.py
f488432cd68cc68fab8fce968e8605625ea3f56a
Diff: https://reviews.apache.org/r/30586/diff/
Testing
---
./pants goal test src/test/python/apache/aurora/client/cli:cron
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review71128
---
Maxim, can you review the changes to the tests?
- Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71171
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 4, 2015, 8:13 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30649/#review71172
---
Ship it!
Ship It!
- Zameer Manji
On Feb. 4, 2015, 8:13 p.m
://reviews.apache.org/r/30586/#comment116782
The config object in the argument is very complex and difficult to create.
With our current set of test fixtures.
- Zameer Manji
On Feb. 4, 2015, 6:08 p.m., Zameer Manji wrote
3416c8e1932056725880f2007b60d77112759428
src/test/python/apache/aurora/client/cli/test_cron.py
f488432cd68cc68fab8fce968e8605625ea3f56a
Diff: https://reviews.apache.org/r/30586/diff/
Testing
---
./pants goal test src/test/python/apache/aurora/client/cli:cron
Thanks,
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30586/#review70900
---
@ReviewBot retry
- Zameer Manji
On Feb. 3, 2015, 5:14 p.m
f488432cd68cc68fab8fce968e8605625ea3f56a
Diff: https://reviews.apache.org/r/30586/diff/
Testing
---
./pants goal test src/test/python/apache/aurora/client/cli:cron
Thanks,
Zameer Manji
:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30585/
---
(Updated Feb. 3, 2015, 3:58 p.m.)
Review request for Aurora and Zameer Manji.
Repository: aurora
3416c8e1932056725880f2007b60d77112759428
src/test/python/apache/aurora/client/cli/test_cron.py
f488432cd68cc68fab8fce968e8605625ea3f56a
Diff: https://reviews.apache.org/r/30586/diff/
Testing
---
./pants goal test src/test/python/apache/aurora/client/cli:cron
Thanks,
Zameer Manji
/
Testing
---
Thanks,
Bill Farner
--
Zameer Manji
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review70407
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 30, 2015, 11:18 a.m
/CommandUtilTest.java
876e173ccbac04e4a06a245648c7c6af15eaaa92
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30471/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
/aurora/scheduler/base/CommandUtilTest.java
876e173ccbac04e4a06a245648c7c6af15eaaa92
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30471/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
/aurora/scheduler/base/CommandUtilTest.java
876e173ccbac04e4a06a245648c7c6af15eaaa92
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30471/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
/aurora/scheduler/base/CommandUtilTest.java
876e173ccbac04e4a06a245648c7c6af15eaaa92
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/30471/diff/
Testing
---
./gradlew build -Pq
Thanks,
Zameer Manji
?
- Zameer Manji
On Jan. 26, 2015, 5:08 p.m., Florian Pfeiffer wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010
should avoid it. Would you mind moving this test up to the
TestJobUpdateCommand suite at the top of this file?
This test could then be modified to have minimal patching.
- Zameer Manji
On Jan. 29, 2015, 9:13 a.m., Bill Farner wrote
into this pattern.
- Zameer Manji
On Jan. 29, 2015, 11:31 a.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30389
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30383/#review70106
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 28, 2015, 3:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/#review70043
---
Bill, can I get a ship it here?
- Zameer Manji
On Jan. 22, 2015
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30346/#review69931
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 27, 2015, 5:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30224/#review69444
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 23, 2015, 11:19 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30224/#review69445
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 23, 2015, 11:25 a.m
On Jan. 23, 2015, 12:47 p.m., Maxim Khutornenko wrote:
I am not convinced there is enough value in this diff to risk possible
regression. Besides, the majority of what this diff touches will die out
along with the client updater.
Zameer Manji wrote:
Is there an ETA
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30204/#review69473
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 22, 2015, 6:11 p.m
updater?
- Zameer
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30207/#review69458
---
On Jan. 22, 2015, 7:32 p.m., Zameer Manji wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30203/#review69487
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 23, 2015, 1:48 p.m
/scheduler/configuration/ConfigurationManagerTest.java
https://reviews.apache.org/r/30010/#comment114209
Can you actually add a test for the false case here?
- Zameer Manji
On Jan. 23, 2015, 1:20 a.m., Florian Pfeiffer wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69268
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 22, 2015, 1:09 p.m
/
---
(Updated Jan. 22, 2015, 1:09 p.m.)
Review request for Aurora, Brian Wickman and Zameer Manji.
Bugs: AURORA-1029
https://issues.apache.org/jira/browse/AURORA-1029
Repository: aurora
Description
---
Remove support for cluster
/cli/test_supdate.py PRE-CREATION
src/test/python/apache/aurora/client/cli/test_update.py
8b7d11202b35deb09a248cfe0a96458fb70c
Diff: https://reviews.apache.org/r/30207/diff/
Testing
---
./pants test.pytest --no-fast src/test/python/apache/aurora/client::
Thanks,
Zameer Manji
is to add CLI
flags so this legacy behaviour can be enabled. This way we don't break
backwards compatability and users who rely on this behaviour don't get a nasty
surprise when they update to the next release.
- Zameer Manji
On Jan. 20, 2015, 1:46 p.m., Florian Pfeiffer wrote
.
src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
https://reviews.apache.org/r/30010/#comment113512
This test is not necessary either. We don't need to add tests to ensure we
are not doing the old behaviour.
- Zameer Manji
On Jan. 20, 2015, 1:46 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30102/#review68822
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 20, 2015, 4:31 p.m
5bf283062c9d119ff91ed45da8b236e36d0fc9aa
src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/3/diff/
Testing
---
./gradlew clean test
Thanks,
Zameer Manji
1 - 100 of 356 matches
Mail list logo