---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review33054
---
Kevin — ping? Presumably you can review while i fix up Maxim's
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32551
---
Ship it!
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 42
https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line42
Missing comments for public methods in this class?
We typically don't bother
On Jan. 28, 2014, 9:50 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java,
lines 543-546
https://reviews.apache.org/r/16873/diff/1/?file=423022#file423022line543
This seems like a big enough gotcha to warrant filing a ticket.
On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 77
https://reviews.apache.org/r/16873/diff/1/?file=423020#file423020line77
Should these be javadoc comments instead?
Good call, done.
- Bill
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/
---
(Updated Jan. 29, 2014, 12:09 a.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16873/#review32502
---
Ping
- Bill Farner
On Jan. 14, 2014, 11:27 p.m., Bill Farner
