Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45820 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-16 Thread Maxim Khutornenko
On June 16, 2014, 8:44 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 117 https://reviews.apache.org/r/22483/diff/2/?file=609564#file609564line117 sort Ah, did not realize it's sorted. Fixed. On June 16, 2014, 8:44 p.m., Kevin

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 16, 2014, 8:53 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45824 --- Ship it! Ship It! - Kevin Sweeney On June 16, 2014, 1:53 p.m.,

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45826 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45645 --- +1 to exposing this via thrift if possible- can we just start with

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Maxim Khutornenko
On June 13, 2014, 7:44 p.m., Joe Smith wrote: +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're doing

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Joe Smith
On June 13, 2014, 12:44 p.m., Joe Smith wrote: +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 13, 2014, 8:17 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45447 --- Curious why you didn't make this part of the Thrift API? - David

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-11 Thread Maxim Khutornenko
On June 12, 2014, 12:15 a.m., David McLaughlin wrote: Curious why you didn't make this part of the Thrift API? I don't see a use case for it on the client. This data is rarely needed and for debugging purposes only. Is there something specific you have in mind? - Maxim