---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63025
---
Ship it!
Ship It!
- Joshua Cohen
On Nov. 25, 2014, 6:37 a.m.,
On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
build-support/thrift/thriftw, line 1
https://reviews.apache.org/r/28361/diff/1/?file=772952#file772952line1
License header?
Fixed.
On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
build-support/thrift/thriftw, line 2
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63029
---
Ship it!
Ship It!
- Maxim Khutornenko
On Nov. 25, 2014, 7:39
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63030
---
Ship it!
Ship It!
- Bill Farner
On Nov. 25, 2014, 7:39 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
---
(Updated Nov. 25, 2014, 12:22 p.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review63058
---
Master (5e80581) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62827
---
build.gradle
https://reviews.apache.org/r/28361/#comment104954
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62825
---
./gradlew run fails with these changes. Here's the output:
On Nov. 24, 2014, 7:25 p.m., Joshua Cohen wrote:
build.gradle, line 182
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182
LocalSchedulerMain seems broken in general, but I recall that we needed
to mark these directories as source directories so that running
On Nov. 24, 2014, 7:25 p.m., Joshua Cohen wrote:
build.gradle, line 182
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182
LocalSchedulerMain seems broken in general, but I recall that we needed
to mark these directories as source directories so that running
On Nov. 24, 2014, 11:25 a.m., Joshua Cohen wrote:
build.gradle, line 182
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line182
LocalSchedulerMain seems broken in general, but I recall that we needed
to mark these directories as source directories so that
On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
build.gradle, line 315
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line315
Can we avoid declaring the version of libthrift twice? I see it here
and in ThriftPluginExtension.
Fixed.
On Nov. 24, 2014, 10:31
On Nov. 24, 2014, 10:31 a.m., Zameer Manji wrote:
build.gradle, line 577
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line577
+1
fixed.
- Kevin
---
This is an automatically generated e-mail. To reply,
On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
build.gradle, line 115
https://reviews.apache.org/r/28361/diff/1/?file=772953#file772953line115
whitespaces?
fixed.
On Nov. 21, 2014, 6:16 p.m., Maxim Khutornenko wrote:
build.gradle, line 577
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/
---
(Updated Nov. 24, 2014, 10:37 p.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62941
---
Master (9514a63) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62942
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62716
---
This patch does not apply cleanly on master (a431b1d), do you need
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28361/#review62718
---
build-support/thrift/thriftw
19 matches
Mail list logo
