Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-30 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70419
---

Ship it!


Ship It!

- Brian Wickman


On Jan. 28, 2015, 8:26 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 28, 2015, 8:26 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-29 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70281
---


Brian - ping?

- Bill Farner


On Jan. 28, 2015, 8:26 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 28, 2015, 8:26 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-28 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70079
---

Ship it!


Master (5902574) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 28, 2015, 8:26 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 28, 2015, 8:26 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-28 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/
---

(Updated Jan. 28, 2015, 8:26 p.m.)


Review request for Aurora, Brian Wickman and Zameer Manji.


Bugs: AURORA-1029
https://issues.apache.org/jira/browse/AURORA-1029


Repository: aurora


Description
---

Remove support for cluster metadata in YAML format.


Diffs (updated)
-

  src/main/python/apache/aurora/common/clusters.py 
e55aa774b4b868f696a7de51bb016f950871dd1e 
  src/test/python/apache/aurora/common/BUILD 
14165b96be99b8de418f4bb8def9f27eaf29e67d 
  src/test/python/apache/aurora/common/test_clusters.py 
45250e609cca1149dc296b2aaf645ff2f58f8288 

Diff: https://reviews.apache.org/r/30187/diff/


Testing
---

./build-support/jenkins/build.sh

test_end_to_end.sh is currently broken on master, i will address that and 
ensure it passes before committing this.


Thanks,

Bill Farner



Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-28 Thread Bill Farner


 On Jan. 26, 2015, 8:16 p.m., Kevin Sweeney wrote:
  src/main/python/apache/aurora/common/clusters.py, line 42
  https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
 
  For the purposes of sheparding this review along would you consider 
  moving this to another change?
 
 Bill Farner wrote:
 Can you give more detail on the reasoning?  While i generally agree with 
 keeping logically-different changes separate, i don't think we should be 
 strictly opposed to cleaning up code in the immediate vicinity of a patch.
 
 Kevin Sweeney wrote:
 The patch that removes the style-checker annotations around this set of 
 files will need to be accompanied by a change to the checkstyle tool to 
 ignore or detect these violations. IMO that's big enough for a separate patch.

Thanks.  I had convinced myself that i ran checkstyle and it did not complain.  
Reverting, as it is indeed necessary.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69663
---


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-28 Thread Bill Farner


 On Jan. 26, 2015, 8:40 p.m., Brian Wickman wrote:
  src/main/python/apache/aurora/common/clusters.py, line 42
  https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
 
  wait -- the # noqa is necessary, otherwise checkstyle will fail.

Reverted


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69668
---


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69663
---



src/main/python/apache/aurora/common/clusters.py
https://reviews.apache.org/r/30187/#comment114397

For the purposes of sheparding this review along would you consider moving 
this to another change?


- Kevin Sweeney


On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 1:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Bill Farner


 On Jan. 26, 2015, 8:16 p.m., Kevin Sweeney wrote:
  src/main/python/apache/aurora/common/clusters.py, line 42
  https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
 
  For the purposes of sheparding this review along would you consider 
  moving this to another change?

Can you give more detail on the reasoning?  While i generally agree with 
keeping logically-different changes separate, i don't think we should be 
strictly opposed to cleaning up code in the immediate vicinity of a patch.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69663
---


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69668
---



src/main/python/apache/aurora/common/clusters.py
https://reviews.apache.org/r/30187/#comment114399

wait -- the # noqa is necessary, otherwise checkstyle will fail.


- Brian Wickman


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-26 Thread Kevin Sweeney


 On Jan. 26, 2015, 12:16 p.m., Kevin Sweeney wrote:
  src/main/python/apache/aurora/common/clusters.py, line 42
  https://reviews.apache.org/r/30187/diff/1/?file=830286#file830286line42
 
  For the purposes of sheparding this review along would you consider 
  moving this to another change?
 
 Bill Farner wrote:
 Can you give more detail on the reasoning?  While i generally agree with 
 keeping logically-different changes separate, i don't think we should be 
 strictly opposed to cleaning up code in the immediate vicinity of a patch.

The patch that removes the style-checker annotations around this set of files 
will need to be accompanied by a change to the checkstyle tool to ignore or 
detect these violations. IMO that's big enough for a separate patch.


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69663
---


On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 1:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-23 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69469
---


@ReviewBot retry

- Bill Farner


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-23 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69478
---


Master (e3b8905) is red with this patch.
  ./build-support/jenkins/build.sh

  Running setup.py install for twitter.common.collections
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
  Running setup.py install for smmap

  Running setup.py install for twitter.common.string
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.string-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.options
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.options-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.dirutil
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.dirutil-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.contextutil
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.contextutil-0.3.0-py2.7-nspkg.pth
  Running setup.py install for twitter.common.lang
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py
 (namespace package)
Skipping installation of 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py
 (namespace package)

Installing 
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.lang-0.3.0-py2.7-nspkg.pth
Successfully installed twitter.checkstyle pyflakes pep8 GitPython 
twitter.common.app gitdb twitter.common.process twitter.common.log 
twitter.common.util twitter.common.collections smmap twitter.common.string 
twitter.common.options twitter.common.dirutil twitter.common.contextutil 
twitter.common.lang
Cleaning up...
T001:ERROR   src/main/python/apache/aurora/common/clusters.py:034 Class globals 
must be UPPER_SNAKE_CASED
 |  name = Required(String)

F401:ERROR   src/test/python/apache/aurora/common/test_clusters.py:021 'Parser' 
imported but unused
 |from apache.aurora.common.clusters import Clusters, Parser



I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Brian Wickman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---


I think we should leave the yaml code but drop the PyYAML dependency from the 
client requirements.  (And inject it into the test -- possibly one test with 
and one test without to make sure the try/except also functions correctly.)  I 
feel that .yml is actually a much more natural way of defining the cluster list 
than json, because YAML supports basic templating in order to reduce 
redundancy, similar to pystachio.

The way the code is currently structured, YAML will still work fine if it's 
available in the environmenet of your Aurora client, and gracefully fall back 
if not.

Thoughts?

- Brian Wickman


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Zameer Manji

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69268
---

Ship it!


Ship It!

- Zameer Manji


On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 1:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Bill Farner


 On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
  I think we should leave the yaml code but drop the PyYAML dependency from 
  the client requirements.  (And inject it into the test -- possibly one test 
  with and one test without to make sure the try/except also functions 
  correctly.)  I feel that .yml is actually a much more natural way of 
  defining the cluster list than json, because YAML supports basic templating 
  in order to reduce redundancy, similar to pystachio.
  
  The way the code is currently structured, YAML will still work fine if it's 
  available in the environmenet of your Aurora client, and gracefully fall 
  back if not.
  
  Thoughts?
 
 Zameer Manji wrote:
 If we are going to drop the PyYAML dependency then I think we should drop 
 all of the YAML related code. I agree that YAML is a much nicer format 
 because of the templating functionality it has but as it stands I think the 
 cost of supporting YAML (native code, extra compelxity in loading) is greater 
 than the benefits of a simpler config file.
 
 Joshua Cohen wrote:
 I'm not sure the added complexity is worth the minor benefits provided by 
 YAML. Is cluster configuration really so complex that it requires templating 
 (and if so, could we rely on cluster administrators to work out their own 
 mechanism for templatizing config, puppet/chef/etc.)

I agree with Zameer and Joshua - we should avoid complexity that only benefits 
partially-supported features.


- Bill


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Zameer Manji


 On Jan. 22, 2015, 1:30 p.m., Brian Wickman wrote:
  I think we should leave the yaml code but drop the PyYAML dependency from 
  the client requirements.  (And inject it into the test -- possibly one test 
  with and one test without to make sure the try/except also functions 
  correctly.)  I feel that .yml is actually a much more natural way of 
  defining the cluster list than json, because YAML supports basic templating 
  in order to reduce redundancy, similar to pystachio.
  
  The way the code is currently structured, YAML will still work fine if it's 
  available in the environmenet of your Aurora client, and gracefully fall 
  back if not.
  
  Thoughts?

If we are going to drop the PyYAML dependency then I think we should drop all 
of the YAML related code. I agree that YAML is a much nicer format because of 
the templating functionality it has but as it stands I think the cost of 
supporting YAML (native code, extra compelxity in loading) is greater than the 
benefits of a simpler config file.


- Zameer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---


On Jan. 22, 2015, 1:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 1:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-22 Thread Joshua Cohen


 On Jan. 22, 2015, 9:30 p.m., Brian Wickman wrote:
  I think we should leave the yaml code but drop the PyYAML dependency from 
  the client requirements.  (And inject it into the test -- possibly one test 
  with and one test without to make sure the try/except also functions 
  correctly.)  I feel that .yml is actually a much more natural way of 
  defining the cluster list than json, because YAML supports basic templating 
  in order to reduce redundancy, similar to pystachio.
  
  The way the code is currently structured, YAML will still work fine if it's 
  available in the environmenet of your Aurora client, and gracefully fall 
  back if not.
  
  Thoughts?
 
 Zameer Manji wrote:
 If we are going to drop the PyYAML dependency then I think we should drop 
 all of the YAML related code. I agree that YAML is a much nicer format 
 because of the templating functionality it has but as it stands I think the 
 cost of supporting YAML (native code, extra compelxity in loading) is greater 
 than the benefits of a simpler config file.

I'm not sure the added complexity is worth the minor benefits provided by YAML. 
Is cluster configuration really so complex that it requires templating (and if 
so, could we rely on cluster administrators to work out their own mechanism for 
templatizing config, puppet/chef/etc.)


- Joshua


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review69269
---


On Jan. 22, 2015, 9:09 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/30187/
 ---
 
 (Updated Jan. 22, 2015, 9:09 p.m.)
 
 
 Review request for Aurora, Brian Wickman and Zameer Manji.
 
 
 Bugs: AURORA-1029
 https://issues.apache.org/jira/browse/AURORA-1029
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Remove support for cluster metadata in YAML format.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/common/clusters.py 
 e55aa774b4b868f696a7de51bb016f950871dd1e 
   src/test/python/apache/aurora/common/BUILD 
 14165b96be99b8de418f4bb8def9f27eaf29e67d 
   src/test/python/apache/aurora/common/test_clusters.py 
 45250e609cca1149dc296b2aaf645ff2f58f8288 
 
 Diff: https://reviews.apache.org/r/30187/diff/
 
 
 Testing
 ---
 
 ./build-support/jenkins/build.sh
 
 test_end_to_end.sh is currently broken on master, i will address that and 
 ensure it passes before committing this.
 
 
 Thanks,
 
 Bill Farner