Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45820 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java https://reviews.apache.org/r/22483/#comment80810 sort src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java https://reviews.apache.org/r/22483/#comment80811 Is the token field intended to be made public here? - Kevin Sweeney On June 13, 2014, 1:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 13, 2014, 1:17 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
On June 16, 2014, 8:44 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 117 https://reviews.apache.org/r/22483/diff/2/?file=609564#file609564line117 sort Ah, did not realize it's sorted. Fixed. On June 16, 2014, 8:44 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java, line 130 https://reviews.apache.org/r/22483/diff/2/?file=609566#file609566line130 Is the token field intended to be made public here? Right, the token is a UUID that uniquely identifies the lock session and is intended to be public. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45820 --- On June 13, 2014, 8:17 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 13, 2014, 8:17 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 16, 2014, 8:53 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Changes --- CR comments. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 485b5e628a7b5f50b3f845932f1d27d0f58f2840 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift 8865d8ffe33906d1b2cd748aee83b2f6525a9272 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1742171db9a6eeefdbd5caeb26b4d34eaed9e283 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45824 --- Ship it! Ship It! - Kevin Sweeney On June 16, 2014, 1:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 16, 2014, 1:53 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 485b5e628a7b5f50b3f845932f1d27d0f58f2840 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift 8865d8ffe33906d1b2cd748aee83b2f6525a9272 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1742171db9a6eeefdbd5caeb26b4d34eaed9e283 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45826 --- src/main/thrift/org/apache/aurora/gen/api.thrift https://reviews.apache.org/r/22483/#comment80816 Make sure FlagSchemaChanges still passes - Kevin Sweeney On June 16, 2014, 1:53 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 16, 2014, 1:53 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 485b5e628a7b5f50b3f845932f1d27d0f58f2840 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift 8865d8ffe33906d1b2cd748aee83b2f6525a9272 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 1742171db9a6eeefdbd5caeb26b4d34eaed9e283 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45645 --- +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're doing that anyway) src/main/java/org/apache/aurora/scheduler/http/Quotas.java https://reviews.apache.org/r/22483/#comment80541 naive question- should there be a matching change somewhere else here? (at least in a test maybe?) - Joe Smith On June 11, 2014, 4:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 11, 2014, 4:32 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
On June 13, 2014, 7:44 p.m., Joe Smith wrote: +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're doing that anyway) I am working on a getLocks rpc used in admin client. I am not ready to commit to getLocksForRole as that would not make sense long term. Locks are not specific to role and are identified by a LockKey union. JobKey is just one of the possible values in that union and is the only one for now. That may change in future when we have a hierarchical storage. Having an rpc that would allow wide range queries (similar to TaskQuery) would make more sense then. On June 13, 2014, 7:44 p.m., Joe Smith wrote: src/main/java/org/apache/aurora/scheduler/http/Quotas.java, line 58 https://reviews.apache.org/r/22483/diff/1/?file=607807#file607807line58 naive question- should there be a matching change somewhere else here? (at least in a test maybe?) The name of the method is irrelevant to the endpoint. - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45645 --- On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 11, 2014, 11:32 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
On June 13, 2014, 12:44 p.m., Joe Smith wrote: +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're doing that anyway) Maxim Khutornenko wrote: I am working on a getLocks rpc used in admin client. I am not ready to commit to getLocksForRole as that would not make sense long term. Locks are not specific to role and are identified by a LockKey union. JobKey is just one of the possible values in that union and is the only one for now. That may change in future when we have a hierarchical storage. Having an rpc that would allow wide range queries (similar to TaskQuery) would make more sense then. agreed, good points. thanks! On June 13, 2014, 12:44 p.m., Joe Smith wrote: src/main/java/org/apache/aurora/scheduler/http/Quotas.java, line 58 https://reviews.apache.org/r/22483/diff/1/?file=607807#file607807line58 naive question- should there be a matching change somewhere else here? (at least in a test maybe?) Maxim Khutornenko wrote: The name of the method is irrelevant to the endpoint. kk, thanks! :) - Joe --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45645 --- On June 11, 2014, 4:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 11, 2014, 4:32 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 13, 2014, 8:17 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Changes --- Added an RPC to be used with aurora_admin command. Split out the python side into a separate RB due to broken python build on master. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs (updated) - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/main/java/org/apache/aurora/scheduler/state/LockManager.java 8b3b174eadbb0024323b643f10a205e0f86b5004 src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 0568529343916bb939d1ecb3cba0e406f9b4d09c src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java d9c3a1eecec4995b0539429b1079ff63118fb9e5 src/main/python/apache/aurora/client/cli/client.py 2a06cdd2ea15247f492550727f1dca69f5f387ef src/main/thrift/org/apache/aurora/gen/api.thrift e72bcfb57d288d585307549be5d74067ab08c42b src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java dd36027d6f92a8e2996814c13ac06bf21812ad8d src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 299679618f135f29bbf4e6372585ae46a1224a27 src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java cfe45d1137ca3dec56b0cc4f8612faeedbf44acf Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45447 --- Curious why you didn't make this part of the Thrift API? - David McLaughlin On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 11, 2014, 11:32 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
Re: Review Request 22483: Adding /locks endpoint to expose update locks.
On June 12, 2014, 12:15 a.m., David McLaughlin wrote: Curious why you didn't make this part of the Thrift API? I don't see a use case for it on the client. This data is rarely needed and for debugging purposes only. Is there something specific you have in mind? - Maxim --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/#review45447 --- On June 11, 2014, 11:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22483/ --- (Updated June 11, 2014, 11:32 p.m.) Review request for Aurora, David McLaughlin and Kevin Sweeney. Bugs: AURORA-346 https://issues.apache.org/jira/browse/AURORA-346 Repository: aurora Description --- Needed to get all locks from the scheduler and apparently there is already a ticket for that. Adding /locks endpoint. Diffs - src/main/java/org/apache/aurora/scheduler/http/Locks.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/http/Quotas.java 438d127cc71e29006aad50d386b7d9b7d3263c3c src/main/java/org/apache/aurora/scheduler/http/ServletModule.java d104eab0674b2d9b59a187abe306c45ee5013b38 src/test/java/org/apache/aurora/scheduler/http/LocksTest.java PRE-CREATION Diff: https://reviews.apache.org/r/22483/diff/ Testing --- gradle -Pq build File Attachments locks https://reviews.apache.org/media/uploaded/files/2014/06/11/df79d764-1850-40fe-8a78-5163e81d082a__locks.png Thanks, Maxim Khutornenko
