Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34714 --- src/main/python/apache/aurora/client/cli/sla.py https://reviews.apache.org/r/17948/#comment64931 Yeah, but that'll add a leading CR. I think it's better to just leave it as is. - Mark Chu-Carroll On Feb. 18, 2014, 10:06 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 18, 2014, 10:06 a.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py 3c07c948a74bb9facb7c58e788624e1a404175d2 src/main/python/apache/aurora/client/cli/context.py 4d1de48abd571e809221fcf2487761227b212129 src/main/python/apache/aurora/client/cli/jobs.py 632c539083ba50c3115a2bddc92e4bed6bcdc782 src/main/python/apache/aurora/client/cli/options.py 017f141a605eb6b522fcd7c4fe827eefdc626fca src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/test/python/apache/aurora/client/cli/BUILD 636f407d10e85b1ffc58b72a419d81d854a40ffd src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 18, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Changes --- Rebase. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs (updated) - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py 604eb444b5f7e8679731b01bc9cef471143e092d src/main/python/apache/aurora/client/cli/context.py 4d1de48abd571e809221fcf2487761227b212129 src/main/python/apache/aurora/client/cli/jobs.py 199d27f6d320c9d834a140bf5eb64740f41da48f src/main/python/apache/aurora/client/cli/options.py 37f416d563b526cccf3c9cab69a5df15873db250 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/main/python/apache/aurora/client/cli/sla.py a3973df870567052083b1d5a524438191eb6d812 src/main/python/apache/aurora/client/cli/task.py d7bf5cd34018f4e3678fa9df6a6a48f640e23e81 src/test/python/apache/aurora/client/cli/BUILD 13a3d09a7e98dcec697346f6496d09efd603f947 src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34509 --- src/main/python/apache/aurora/client/cli/__init__.py https://reviews.apache.org/r/17948/#comment64606 minor nit -- we usually prefer never to shadow builtins even though in this case it's harmless. i'd s/str/msg/ just to be consistent with our practices elsewhere. src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17948/#comment64609 I'm not sure how I feel about the help property returning manually split doc lines. It probably makes more sense to just return a docstring style string -- which you can then always do .splitlines() on. (Alternately, you can do isinstance(str) elif isinstance(list) I suppose.) At the end of the day, if you end up on smaller or larger terminals, you'll probably end up using the textwrap module to change the line breaks here programmatically anyway. - Brian Wickman On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 11, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
Re: Review Request 17948: Implement help message generation for the noun/verb framework.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34259 --- Ship it! lgtm - David Robinson On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 11, 2014, 3:31 p.m.) Review request for Aurora, David Robinson and Brian Wickman. Bugs: aurora-202 https://issues.apache.org/jira/browse/aurora-202 Repository: aurora Description --- Implement help message generation for the noun/verb framework. Diffs - src/main/python/apache/aurora/client/cli/__init__.py 9eb5c52097f0e75567977ba2d4fe10932d227a4b src/main/python/apache/aurora/client/cli/client.py e416d3879cc5943ec5ab3931a8b1aedb85a379a9 src/main/python/apache/aurora/client/cli/jobs.py caff6d824d9f43cc9eb0c738ea6bb489321d4669 src/main/python/apache/aurora/client/cli/options.py 5d6eba2abc55954fddb0c8bc1fe4de4f6d089962 src/main/python/apache/aurora/client/cli/quota.py a7bcfbe0100fe8e400abda3710519e3e5029c477 src/test/python/apache/aurora/client/cli/BUILD c106b97a0902da5cd791b18117da3198bfb43b8c src/test/python/apache/aurora/client/cli/test_help.py PRE-CREATION Diff: https://reviews.apache.org/r/17948/diff/ Testing --- Added unit tests of new functions; verified that all client tests pass. Thanks, Mark Chu-Carroll
