Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.
On Feb. 20, 2014, 2:05 a.m., Maxim Khutornenko wrote: dist/generated-src/gen-java/.empty, line 1 https://reviews.apache.org/r/18297/diff/1/?file=498504#file498504line1 Any chance these could be replaced by a something like createPath task that the idea task would dependOn? More: http://www.gradle.org/docs/current/userguide/more_about_tasks.html Kevin Sweeney wrote: +1, the current approach is giving me some gentoo-related flashbacks Jake Farrell wrote: Agree, dist dir should not be included in the src, having a task to check and add these would be a better approach Thanks for pushing, guys. I added a comment describing the 'gotcha' that led me down this path and cleaned it up. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review34965 --- On Feb. 20, 2014, 1:43 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/ --- (Updated Feb. 20, 2014, 1:43 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d dist/generated-src/gen-java/.empty PRE-CREATION dist/generated-src/gen-js/.empty PRE-CREATION Diff: https://reviews.apache.org/r/18297/diff/ Testing --- Several orderings of invoking: rm aurora.iml git clean -fdx ./gradlew idea Thanks, Bill Farner
Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35038 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 10:41 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/ --- (Updated Feb. 20, 2014, 10:41 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d Diff: https://reviews.apache.org/r/18297/diff/ Testing --- Several orderings of invoking: rm aurora.iml git clean -fdx ./gradlew idea Thanks, Bill Farner
Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35046 --- Ship it! Ship It! - Suman Karumuri On Feb. 20, 2014, 6:41 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/ --- (Updated Feb. 20, 2014, 6:41 p.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d Diff: https://reviews.apache.org/r/18297/diff/ Testing --- Several orderings of invoking: rm aurora.iml git clean -fdx ./gradlew idea Thanks, Bill Farner
Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.
On Feb. 20, 2014, 2:05 a.m., Maxim Khutornenko wrote: dist/generated-src/gen-java/.empty, line 1 https://reviews.apache.org/r/18297/diff/1/?file=498504#file498504line1 Any chance these could be replaced by a something like createPath task that the idea task would dependOn? More: http://www.gradle.org/docs/current/userguide/more_about_tasks.html Kevin Sweeney wrote: +1, the current approach is giving me some gentoo-related flashbacks Agree, dist dir should not be included in the src, having a task to check and add these would be a better approach - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review34965 --- On Feb. 20, 2014, 1:43 a.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/ --- (Updated Feb. 20, 2014, 1:43 a.m.) Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aurora Description --- I tried to put relevant context in a comment in build.gradle, so please read that for background on this change. I've also added placeholder files for the gen-java and gen-js directories. This is because the idea plugin will not include source directories that do not exist. Diffs - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d dist/generated-src/gen-java/.empty PRE-CREATION dist/generated-src/gen-js/.empty PRE-CREATION Diff: https://reviews.apache.org/r/18297/diff/ Testing --- Several orderings of invoking: rm aurora.iml git clean -fdx ./gradlew idea Thanks, Bill Farner
