---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated July 23, 2014, 5:05 p.m.)
Review request for Aurora, Mark Chu-Carroll
On June 25, 2014, 10:44 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/instance_watcher.py, line 48
https://reviews.apache.org/r/21440/diff/7-9/?file=604778#file604778line48
this should be terminating_event=None
and self._terminating =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated June 27, 2014, 6:36 p.m.)
Review request for Aurora, Mark Chu-Carroll
On June 25, 2014, 10:44 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/instance_watcher.py, line 48
https://reviews.apache.org/r/21440/diff/7-9/?file=604778#file604778line48
this should be terminating_event=None
and self._terminating =
On June 25, 2014, 10:44 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/instance_watcher.py, line 48
https://reviews.apache.org/r/21440/diff/7-9/?file=604778#file604778line48
this should be terminating_event=None
and self._terminating =
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review46692
---
src/main/python/apache/aurora/client/api/instance_watcher.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated June 24, 2014, 11:28 p.m.)
Review request for Aurora, Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review44989
---
Ship it!
Ship It!
- Brian Wickman
On June 6, 2014, 5:55 p.m.,
On May 27, 2014, 6:38 p.m., Brian Wickman wrote:
src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19
https://reviews.apache.org/r/21440/diff/4/?file=588632#file588632line19
I don't think we can rely upon patching or subclassing _Event (an
internal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated May 30, 2014, 10:08 p.m.)
Review request for Aurora, Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43979
---
Ping Brian, Mark.
- Maxim Khutornenko
On May 23, 2014, 1:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43982
---
Ship it!
Ship It!
- Mark Chu-Carroll
On May 22, 2014, 9:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review44016
---
src/main/python/apache/aurora/client/api/updater.py
On May 27, 2014, 6:38 p.m., Brian Wickman wrote:
src/test/python/apache/aurora/client/api/test_instance_watcher.py, line 19
https://reviews.apache.org/r/21440/diff/4/?file=588632#file588632line19
I don't think we can rely upon patching or subclassing _Event (an
internal
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated May 28, 2014, 12:20 a.m.)
Review request for Aurora, Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated May 23, 2014, 1:19 a.m.)
Review request for Aurora, Mark Chu-Carroll
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
(Updated May 21, 2014, 4:58 p.m.)
Review request for Aurora, Mark Chu-Carroll
On May 20, 2014, 8:04 p.m., Mark Chu-Carroll wrote:
src/main/python/apache/aurora/client/api/updater.py, line 58
https://reviews.apache.org/r/21440/diff/2/?file=582780#file582780line58
This could be clearer with a bit of rephrasing in the comment:
A thread that than
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43523
---
src/main/python/apache/aurora/client/api/updater.py
On May 14, 2014, 10:57 p.m., Brian Wickman wrote:
src/main/python/apache/aurora/client/api/updater.py, line 237
https://reviews.apache.org/r/21440/diff/1/?file=581729#file581729line237
it surprises me that this is necessary. will signal.signal() even work
outside of the
On May 14, 2014, 7:20 p.m., Mark Chu-Carroll wrote:
src/test/python/apache/aurora/client/api/test_updater.py, line 126
https://reviews.apache.org/r/21440/diff/1/?file=581731#file581731line126
Doesn't this mean that the test will be running with just one thread?
That will
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43046
---
a few high level comments. still need to wade through the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/
---
Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21440/#review43004
---
src/main/python/apache/aurora/client/api/instance_watcher.py
24 matches
Mail list logo
