Review Request 21945: Add big job to local test fixture
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-481 https://issues.apache.org/jira/browse/AURORA-481 Repository: aurora Description --- Add big job to local test fixture Diffs - src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java 80f3cac4c310f8ca051add7ae4ed4ab029b5d201 Diff: https://reviews.apache.org/r/21945/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 21945: Add big job to local test fixture
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21945/#review44066
---
Ship it!
Note: you may want to start iterating in vagrant more, i'll be looking to
remove this class soon.
src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java
https://reviews.apache.org/r/21945/#comment78393
pull first param to the next line:
private JobConfiguration createJob(
String jobName,
...) {
- Bill Farner
On May 27, 2014, 11:45 p.m., David McLaughlin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21945/
---
(Updated May 27, 2014, 11:45 p.m.)
Review request for Aurora, Maxim Khutornenko and Bill Farner.
Bugs: AURORA-481
https://issues.apache.org/jira/browse/AURORA-481
Repository: aurora
Description
---
Add big job to local test fixture
Diffs
-
src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java
80f3cac4c310f8ca051add7ae4ed4ab029b5d201
Diff: https://reviews.apache.org/r/21945/diff/
Testing
---
Thanks,
David McLaughlin
Re: Review Request 21945: Add big job to local test fixture
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- (Updated May 28, 2014, 12:22 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes --- Review feedback. Bugs: AURORA-481 https://issues.apache.org/jira/browse/AURORA-481 Repository: aurora Description --- Add big job to local test fixture Diffs (updated) - src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java e9d9bc47d8e0c9590f14dad298b731ded741 Diff: https://reviews.apache.org/r/21945/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 21945: Add big job to local test fixture
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/#review44085 --- Ship it! Ship It! - Maxim Khutornenko On May 28, 2014, 12:22 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- (Updated May 28, 2014, 12:22 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-481 https://issues.apache.org/jira/browse/AURORA-481 Repository: aurora Description --- Add big job to local test fixture Diffs - src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java e9d9bc47d8e0c9590f14dad298b731ded741 Diff: https://reviews.apache.org/r/21945/diff/ Testing --- Thanks, David McLaughlin
Re: Review Request 21945: Add big job to local test fixture
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/#review44086 --- This is on master now. - Maxim Khutornenko On May 28, 2014, 12:22 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21945/ --- (Updated May 28, 2014, 12:22 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-481 https://issues.apache.org/jira/browse/AURORA-481 Repository: aurora Description --- Add big job to local test fixture Diffs - src/main/java/org/apache/aurora/scheduler/local/IsolatedSchedulerModule.java e9d9bc47d8e0c9590f14dad298b731ded741 Diff: https://reviews.apache.org/r/21945/diff/ Testing --- Thanks, David McLaughlin
