---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23247/
---
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-94
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23247/#review47238
---
How would you feel about doing this more piecemeal? This is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23247/#review47243
---
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
On July 2, 2014, 11:08 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, lines
79-89
https://reviews.apache.org/r/23247/diff/1/?file=623081#file623081line79
requireBinding is a DRY violation IMO - any @Inject-annotated
constructor
On July 2, 2014, 10:01 p.m., Bill Farner wrote:
How would you feel about doing this more piecemeal? This is changing a lot
of important code, making it more likely that we'll miss something and
introduce bugs (this is made more likely since tests are changing a lot
too). Would it
On July 2, 2014, 11:08 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, lines
79-89
https://reviews.apache.org/r/23247/diff/1/?file=623081#file623081line79
requireBinding is a DRY violation IMO - any @Inject-annotated
constructor