---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53581
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53598
---
I'm tapping out of this review. I don't have enough knowledge to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/
---
(Updated Sept. 16, 2014, 9:27 p.m.)
Review request for Aurora, Joshua Cohen,
On Sept. 11, 2014, 11:41 p.m., Maxim Khutornenko wrote:
Maxim Khutornenko wrote:
Non-blocking but I was still waiting on my comments/questions addressed.
Wow, sorry about that - i truly thought Kevin was the only remaining ship-it
needed :-( Now that we have a straw-man put
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53425
---
Ship it!
Looks good to me, just a few minor questions/nits:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53389
---
On Sept. 15, 2014, 11:01 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1368
https://reviews.apache.org/r/25529/diff/3/?file=689752#file689752line1368
Is this a leftover from some intermediate work?
Not sure how
On Sept. 15, 2014, 11:13 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
line 1368
https://reviews.apache.org/r/25529/diff/3/?file=689752#file689752line1368
If I'm reading correctly there's no need to make this final
On Sept. 15, 2014, 11:13 p.m., Kevin Sweeney wrote:
src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java,
line 61
https://reviews.apache.org/r/25529/diff/3/?file=689761#file689761line61
TODO to use AssistedInject to generate this factory here?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/
---
(Updated Sept. 16, 2014, 12:39 a.m.)
Review request for Aurora, Joshua Cohen,
On Sept. 11, 2014, 6:51 p.m., Zameer Manji wrote:
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java,
line 109
https://reviews.apache.org/r/25529/diff/1/?file=685011#file685011line109
Would it be a bad idea to encapsulate this into a InstanceName class
On Sept. 11, 2014, 10:13 p.m., Joshua Cohen wrote:
src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java,
line 111
https://reviews.apache.org/r/25529/diff/1/?file=685011#file685011line111
Instead of embedding the logic into a switch here, would it make
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/
---
(Updated Sept. 12, 2014, 10:54 p.m.)
Review request for Aurora, Joshua Cohen,
On Sept. 11, 2014, 11:41 p.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 398
https://reviews.apache.org/r/25529/diff/1/?file=685014#file685014line398
Spent quite a bit of time reading this method. Would
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53075
---
This matches the logic previously explained to me, but the diff is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53101
---
Some of these questions are probably non-sensical due to my limited
On Sept. 11, 2014, 6:51 p.m., Zameer Manji wrote:
build.gradle, line 262
https://reviews.apache.org/r/25529/diff/1/?file=685001#file685001line262
Is this needed? If so please break it out of this change.
Context: this has code coverage run without adding -Pq
Happy to pull this out
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/#review53051
---
src/main/java/org/apache/aurora/scheduler/base/Query.java
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25529/
---
Review request for Aurora, Joshua Cohen, Kevin Sweeney, Maxim Khutornenko, and
19 matches
Mail list logo
