Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review60005 --- Ship it! Thanks! This is now on master $ git log -1 origin/master commit 98a4f42d5d2d6ab2ff3b54b68862e9d1e2b1e217 Author: Zameer Manji zma...@twopensource.com Date: Wed Nov 5 11:25:32 2014 -0800 Remove --bind-var for cron deschedule. Bugs closed: AURORA-854 Reviewed at https://reviews.apache.org/r/27591/ - Bill Farner On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 5, 2014, 2:52 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59851 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 9:39 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59869 --- Can you re-post your diff to prove a green response from the build bot? Stinks that we still have to do this, but it's good to shoot for a green reply. - Bill Farner On Nov. 4, 2014, 9:39 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 9:39 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 6:52 p.m.) Review request for Aurora and Bill Farner. Changes --- Reposting to appease the robot. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs (updated) - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59923 --- Master (9847b7b) is red with this patch. ./build-support/jenkins/build.sh pants build (options) [spec] (build args) pants build (options) [spec]... -- (build args) Options: --version show program's version number and exit --no-pantsrc Specifies that pantsrc files should be ignored. --log-exitLog an exit message on success or failure. -t CONN_TIMEOUT, --timeout=CONN_TIMEOUT Number of seconds to wait for http connections. -i INTERPRETERS, --interpreter=INTERPRETERS Constrain what Python interpreters to use. Uses Requirement format from pkg_resources, e.g. 'CPython=2.6,3' or 'PyPy'. By default, no constraints are used. Multiple constraints may be added. They will be ORed together. -v, --verbose Show verbose output. -f, --fastRun tests in a single chroot. Builds the specified Python target(s). Use ./pants goal for JVM and other targets. - Aurora ReviewBot On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 5, 2014, 2:52 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59924 --- Bill, what should I do now? - Zameer Manji On Nov. 4, 2014, 6:52 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 4, 2014, 6:52 p.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
Re: Review Request 27591: Remove --bind-var for cron deschedule.
On Nov. 5, 2014, 3:12 a.m., Zameer Manji wrote: Bill, what should I do now? I'll run it locally to confirm the patch. - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/#review59924 --- On Nov. 5, 2014, 2:52 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27591/ --- (Updated Nov. 5, 2014, 2:52 a.m.) Review request for Aurora and Bill Farner. Bugs: AURORA-854 https://issues.apache.org/jira/browse/AURORA-854 Repository: aurora Description --- Remove --bind-var for cron deschedule. Diffs - src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 Diff: https://reviews.apache.org/r/27591/diff/ Testing --- [tw-mbp-zmanji aurora (fix-cron-help)]$ ./pants ./src/main/python/apache/aurora/client/cli:aurora2 Build operating on top level addresses: set([BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)]) Building PythonBinary PythonBinary(BuildFileAddress(/Users/zmanji/workspace/aurora/src/main/python/apache/aurora/client/cli/BUILD, aurora2)): Wrote /Users/zmanji/workspace/aurora/dist/aurora2.pex [tw-mbp-zmanji aurora (fix-cron-help)]$ ./dist/aurora2.pex cron deschedule --help usage: aurora2.pex cron deschedule [-h] [--verbose-logging] [--logging-level numeric_level] [--error-log-dir ERROR_LOG_DIR] [--skip-hooks hook,hook,...] CLUSTER/ROLE/ENV/NAME positional arguments: CLUSTER/ROLE/ENV/NAME Fully specified job key, in CLUSTER/ROLE/ENV/NAME format optional arguments: -h, --helpshow this help message and exit --verbose-logging, -v Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20) --logging-level numeric_level Set logging to a specific numeric level, using the standard python log-levels. --error-log-dir ERROR_LOG_DIR Directory location where error files containing stack traces should be written. If the directory doesn't exist, it will be created --skip-hooks hook,hook,... A comma-separated list of command hook names that should be skipped. If the hooks cannot be skipped, then the command will be aborted Thanks, Zameer Manji
