Review Request 28692: Simplify logging in the Aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch removes a custom log level and adds a --verbose flag to the output. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28692/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28692: Simplify logging in the Aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63869 --- Can you paste a few examples from vagrant (preferrably job update) before and after your change? That would help reviewing. src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/28692/#comment106184 Why is this jumping from TRANSCRIPT to INFO? Will every invocation now log the entire config? src/main/python/apache/aurora/client/cli/context.py https://reviews.apache.org/r/28692/#comment106185 same question here - Maxim Khutornenko On Dec. 4, 2014, 6:27 a.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- (Updated Dec. 4, 2014, 6:27 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch removes a custom log level and adds a --verbose flag to the output. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28692/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28692: Simplify logging in the Aurora client.
On Dec. 4, 2014, 10:21 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/context.py, line 94 https://reviews.apache.org/r/28692/diff/1/?file=782492#file782492line94 Why is this jumping from TRANSCRIPT to INFO? Will every invocation now log the entire config? Good catch. - Zameer --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63869 --- On Dec. 3, 2014, 10:27 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- (Updated Dec. 3, 2014, 10:27 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch removes a custom log level and adds a --verbose flag to the output. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28692/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28692: Simplify logging in the Aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- (Updated Dec. 4, 2014, 11:54 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch removes a custom log level and adds a --verbose flag to the output. Diffs (updated) - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28692/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
Re: Review Request 28692: Simplify logging in the Aurora client.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/#review63894 --- Ship it! Master (11da34c) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing @ReviewBot retry - Aurora ReviewBot On Dec. 4, 2014, 7:54 p.m., Zameer Manji wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28692/ --- (Updated Dec. 4, 2014, 7:54 p.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-919 https://issues.apache.org/jira/browse/AURORA-919 Repository: aurora Description --- This patch removes a custom log level and adds a --verbose flag to the output. Diffs - src/main/python/apache/aurora/client/cli/BUILD ebe681a0d1735b7cc695dc3b7a14c4292d87ae32 src/main/python/apache/aurora/client/cli/__init__.py 6e553d8af459e575b2d62282a3bc0d1e266203d8 src/main/python/apache/aurora/client/cli/context.py 51c7d24dca664e476e62f1864d095416dfab70e4 src/main/python/apache/aurora/client/cli/logsetup.py 55d99c42f643910db0bf3c24022596383e160276 src/main/python/apache/aurora/client/cli/standalone_client.py b7c8de66d6e4664b536911f826e36a984e8d0fef src/test/python/apache/aurora/client/cli/test_plugins.py 7a0a31818cbc57de952d7817f8e7c8fa1e84b25a Diff: https://reviews.apache.org/r/28692/diff/ Testing --- ./pants src/test/python/apache/aurora/client:: Thanks, Zameer Manji
