Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Bill Farner

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/
---

Review request for Aurora and Kevin Sweeney.


Repository: aurora


Description
---

This storage.write was already within a storage.write.


Diffs
-

  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 

Diff: https://reviews.apache.org/r/28725/diff/


Testing
---


Thanks,

Bill Farner



Re: Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/#review63936
---

Ship it!


Ship It!

- Kevin Sweeney


On Dec. 4, 2014, 4:20 p.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28725/
 ---
 
 (Updated Dec. 4, 2014, 4:20 p.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This storage.write was already within a storage.write.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 
 
 Diff: https://reviews.apache.org/r/28725/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner
 




Re: Review Request 28725: Remove redundant storage.write.

2014-12-04 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28725/#review63937
---


Master (d26a30e) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing @ReviewBot 
retry

- Aurora ReviewBot


On Dec. 5, 2014, 12:20 a.m., Bill Farner wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/28725/
 ---
 
 (Updated Dec. 5, 2014, 12:20 a.m.)
 
 
 Review request for Aurora and Kevin Sweeney.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 This storage.write was already within a storage.write.
 
 
 Diffs
 -
 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  f0d910dc1eb6c84791a9b70b6478b4632c5a34d5 
 
 Diff: https://reviews.apache.org/r/28725/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Bill Farner